github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity
30,460 Commits 412 Branches 3,604 Tags
main
Commit Graph

93 Commits

Author SHA1 Message Date
Samuel Attard
2c94aac330 build: add oxfmt for JS/TS formatting and import sorting (#50692) 
* build: add oxfmt for code formatting and import sorting

Adds oxfmt as a devDependency alongside oxlint and wires it into the
lint pipeline. The .oxfmtrc.json config matches Electron's current JS
style (single quotes, semicolons, 2-space indent, trailing commas off,
printWidth 100) and configures sortImports with custom groups that
mirror the import/order pathGroups previously enforced by ESLint:
@electron/internal, @electron/*, and {electron,electron/**} each get
their own ordered group ahead of external modules.

- `yarn lint:fmt` runs `oxfmt --check` over JS/TS sources and is
  chained into `yarn lint` so CI enforces it automatically.
- `yarn format` runs `oxfmt --write` for local fix-up.
- lint-staged invokes `oxfmt --write` on staged .js/.ts/.mjs/.cjs
  files before oxlint, so formatting is applied at commit time.

The next commit applies the formatter to the existing codebase so the
check actually passes.

* chore: apply oxfmt formatting to JS and TS sources

Runs `yarn format` across lib/, spec/, script/, build/, default_app/,
and npm/ to bring the codebase in line with the .oxfmtrc.json settings
added in the previous commit. This is a pure formatting pass: import
statements are sorted into the groups defined by the config, method
chains longer than printWidth are broken, single-quoted strings
containing apostrophes are switched to double quotes, and a handful of
single-statement `if` bodies are re-wrapped and get braces added by
`oxlint --fix` to satisfy the `curly: multi-line` rule.

No behavior changes.
 2026-04-12 02:03:04 -07:00
Samuel Attard
a8acb96608 build: replace npx with lockfile-pinned binaries (#50598) 
* build: replace npx with lockfile-pinned binaries

- nan-spec-runner: reorder yarn install first, invoke nan node-gyp bin directly
- publish-to-npm: use host npm with E404 try/catch (closes existing TODO)
- upload-symbols: add @sentry/cli devDep, invoke from node_modules/.bin
- remove script/lib/npx.py (dead since #48243)

* build: bump @sentry/cli to 1.70.0 for arm support

* build: bump @sentry/cli to 1.72.0, skip CDN download on test jobs

@sentry/cli fetches its platform binary from Sentry CDN at postinstall.
Only upload-symbols.py (release pipeline) needs the binary; set
SENTRYCLI_SKIP_DOWNLOAD=1 in the two test-segment workflows that
call install-dependencies. The 64k variant uses pre-built artifacts
and does not install deps.
 2026-03-31 20:23:43 +00:00
John Kleinschmidt
d9170093aa build: exit upload with error code if github upload fails (#49936) 2026-02-25 14:16:13 +01:00
John Kleinschmidt
0284b9afcc build: fixup attestation for release assets (#49732) 
* build: fixup attestation for release assets

* Generate artifact attestation for generated artifacts

* set id-token for attestation

* Add artifact-metadata permission for attestation

* add permissions for testing attestations

* Revert "add permissions for testing attestations"

This reverts commit 0284bed175.

* Revert "set id-token for attestation"

This reverts commit 69a1b13a18.

* Revert "Generate artifact attestation for generated artifacts"

This reverts commit ee0536eceb.
 2026-02-11 07:17:59 -05:00
John Kleinschmidt
fd0108907a build: fixup build attestation (#49730) 2026-02-09 11:50:17 -05:00
Samuel Attard
dec7f937ae build: generate artifact attestions for released assets (#48239) 
* build: generate artifact attestions for released assets

* chore: address review feedback

---------

Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com>
 2026-02-05 09:37:17 -05:00
Keeley Hammond
b66bf5db0c build: correct uploader copy for tar files (#48953) 2025-11-13 20:07:52 -08:00
Keeley Hammond
c896ab80fe fix: handle tar.xz files in uploaders, add to breaking changes (#48941) 
* fix: handle tar.xz files in uploaders, add to breaking changes

* docs: add additional file extension info
 2025-11-13 13:03:24 -08:00
Samuel Attard
52929c93db build: fail publish when upload fatal errors (#48537) 
We logged a fatal error but didn't exit with code 1 so the publish kept going. This was caught by a sanity check later down the release process but would have been quicker to fail out here.

Also adds some code to maybe workaround the underlying auth error
 2025-10-13 12:53:52 +02:00
Shelley Vohr
9fc94a162b build: fix python util verbose mode logic (#44431) 
build: fix verbose mode logic
 2024-10-29 11:35:57 -04:00
Samuel Attard
122685194a build: add import/order eslint rule (#44085) 
* build: add import/order eslint rule

* chore: run lint:js --fix
 2024-10-02 19:10:44 -07:00
Samuel Attard
f4ffd018e6 build: cleanup release scripts, separate cli entrypoints from logic (#44058) 
* build: cleanup release scripts, separate cli entrypoints from logic

* build: use repo/org constants
 2024-10-01 13:51:40 -07:00
Samuel Attard
61565465fd build: convert all release scripts to typescript (#44035) 
* build: convert all release scripts to typescript

* fix test imports

* build: fix version bumper export

* refactor: use as const

* spec: fix bad type spec
 2024-09-30 17:55:27 -07:00
Samuel Attard
517d04de16 build: add support for fetching github token from sudowoodo (#43808) 
* build: add support for fetching github token from sudowoodo

* chore: update release notes cache for tests

* build: support nightlies repo correctly

* build: post token
 2024-09-23 09:39:54 -07:00
Shelley Vohr
607b9b8f11 build: clean up upload-index-json error handling (#42657) 2024-06-26 09:25:58 -07:00
Keeley Hammond
a8baa6f1ad build: remove CircleCI from release pipeline (#42651) 
* build: remove CircleCI from release pipeline

* build: remove IS_GHA_RELEASE and CHECK_DIST_MANIFEST
 2024-06-25 14:25:04 -07:00
Keeley Hammond
4701795dc0 build: fix datetime module for Linux Publish (#42489) 2024-06-13 16:36:45 -05:00
Keeley Hammond
c4abaec56a build: fix upload script defaults (#42430) 2024-06-10 16:58:29 -05:00
Keeley Hammond
361b37592a build: add GitHub Actions publishing pipeline for macOS (#42236) 
* build: add publishing workflow for GHActions

* build: add test repo/bucket for uploads

* build: clean up conditionals, add macos-14-large, review comments

* build: remove host_cpu var from GCLIENT_EXTRA_ARGS
 2024-05-31 10:58:39 -07:00
Charles Kerr
61ddb1aa07 chore: bump pylint to 2.17 (#41576) 
* build: bump pylint to 2.17

Xref: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5062345

* fix pylint consider-using-f-string warnings pt 1: use flynt for automated fixes

* fix pylint consider-using-f-string warnings pt 2: manual fixes

* fix pylint consider-using-with warnings

* fix pylint line-too-long warnings

* fix pylint unspecified-encoding warnings

* fix py lint consider-using-generator warning

* fixup! fix pylint unspecified-encoding warnings

* fix pylint line-too-long warnings
 2024-03-21 09:48:23 -04:00
John Kleinschmidt
267c0796dd ci: add logging to uploading to GitHub releases (#41453) 2024-02-27 19:55:08 -05:00
Shelley Vohr
b468b5e6e8 build: print error and retry on symstore fail (#41452) 2024-02-27 15:40:42 -08:00
David Sanders
425efb5e47 chore: remove py2 compatibility code (#40375) 2023-11-01 10:20:32 -04:00
John Kleinschmidt
39d36e4462 build: actually show github upload output if verbose is true. (#40393) 
* build: actually show github upload output if verbose is true.

* chore: fixup lint
 2023-10-31 17:05:16 -04:00
John Kleinschmidt
43a646ed85 build: log uploads to GitHub (#40034) 2023-09-28 11:15:52 -04:00
Milan Burda
455f57322f refactor: use TypeError instead of generic Error when appropriate (#39209) 
refactor: use TypeError instead of generic Error when appropriate
 2023-07-25 12:08:46 -04:00
Milan Burda
abec9ead06 refactor: use node scheme imports in scripts (#38846) 
* refactor: use node scheme imports in script

* refactor: use node scheme imports in build
 2023-06-22 16:21:42 +02:00
Samuel Attard
43f5cf1eae build: update sentry cli for m1 support (#38704) 2023-06-08 16:31:15 -07:00
Shelley Vohr
a44e76fb70 build: strip warnings from stdout in get_release (#37277) 
build: strip warnings from stdout in get_release
 2023-02-16 15:20:19 +01:00
Shelley Vohr
d0cf9c4b08 build: add missing is_verbose_mode import (#37273) 
build: add missing is_verbose_mode import
 2023-02-14 22:52:53 +01:00
Keeley Hammond
fe7c535a3f chore: add logging for debugging release json (#37270) 
* chore: add debug logging for JSON

* chore: better logging
 2023-02-14 13:03:50 -08:00
Samuel Attard
d069b8fc66 build: actually upload symbol zips (#37124) 2023-02-02 17:39:51 -08:00
Shelley Vohr
33c32a798b build: remove mips64el build config (#37093) 
build: remove mips64el build config
 2023-02-02 20:53:54 +09:00
Milan Burda
fd761ec8f7 chore: strip trailing whitespace (#35969) 2023-02-01 12:59:16 +01:00
Keeley Hammond
67a0c702fa build: prefix version in uploader script (#36169) 
build: prefix v in uploader script
 2022-10-27 12:02:18 -07:00
Keeley Hammond
ff804e3a74 fix: use win_clang_x64 binary for x86 extract symbols (#35078) 
fix: use win_clang_x64 for x86 extract symbols
 2022-07-27 13:33:07 +09:00
Keeley Hammond
34fc53e5e6 chore: Revert "build: build & release libcxx objects on darwin (#34586)" (#34680) 
Revert "build: build & release libcxx objects on darwin (#34586)"

This reverts commit 2bbbc66eb8.
 2022-06-21 09:06:50 -07:00
Keeley Hammond
2bbbc66eb8 build: build & release libcxx objects on darwin (#34586) 
* build: build & release libcxx objects on darwin

* Fix merge error

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
 2022-06-21 10:35:16 +09:00
Josh Soref
ea4278754c chore: fix spelling errors in multiple files (#34574) 
* chore: fix spelling in .circleci

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in BUILD.gn

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in appveyor.yml

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in build

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in docs

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in lib

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in script

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in shell

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in spec

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* chore: fix spelling in spec-main

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
 2022-06-16 16:46:11 +09:00
Keeley Hammond
000c3d981c build: disable 32-bit Windows symbol generation (#34412) 2022-06-02 09:01:33 -07:00
Keeley Hammond
c512993744 build: re-enable 32-bit Windows symbol generation (#34162) 2022-05-11 08:27:23 -07:00
Keeley Hammond
6fea35271c build: change upload-to-s3 vars to upload-to-storage (#34105) 
* build: change upload-to-s3 vars to upload-to-az

* build: change upload-to-az to upload-to-storage
 2022-05-09 09:34:17 -04:00
Keeley Hammond
2900bc55aa build: remove ending slash upload-index-json (#34125) 2022-05-06 12:57:18 -07:00
Keeley Hammond
0696320d28 build: remove S3 uploads (#34104) 2022-05-05 21:40:34 -07:00
Keeley Hammond
3d4d39d67b chore: interpret bytes to string (#33766) 2022-04-13 14:51:00 -07:00
Keeley Hammond
2ca46058cd build: migrate urllib to python3 (#33737) 2022-04-12 14:07:40 -07:00
Jeremy Rose
c0d442364a build: explicitly run scripts with python3 (#33720) 
* build: explicitly run scripts with python3

* chore: update patches

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
 2022-04-12 13:21:55 +02:00
Keeley Hammond
41c1a7e318 chore: modify uploaded assets for win-ia32 (#33699) 
* chore: filter correct symbol files

* chore: upload correct assets
 2022-04-11 11:02:01 -07:00
John Kleinschmidt
94c2a7671c build: temporarily disable 32-bit Windows symbol generation (#33653) 
* build: temporarily disable 32-bit Windows symbol generation

* fix: modify upload.py

* chore: fix comment

Co-authored-by: VerteDinde <vertedinde@electronjs.org>
 2022-04-08 04:17:51 -07:00
Inclusive Coding Bot
68d6d8d451 chore: switch to gender neutral terms (#33532) 
* Switch to gender neutral terms

* Update docs/api/web-contents.md

Co-authored-by: Milan Burda <milan.burda@gmail.com>

* Update docs/api/webview-tag.md

Co-authored-by: Milan Burda <milan.burda@gmail.com>

* Update script/release/uploaders/upload.py

Co-authored-by: John Kleinschmidt <jkleinsc@github.com>

* Update docs/tutorial/in-app-purchases.md

Co-authored-by: Milan Burda <milan.burda@gmail.com>

Co-authored-by: inclusive-coding-bot <inclusive-coding-bot@github.com>
Co-authored-by: Milan Burda <milan.burda@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
 2022-04-06 17:19:32 -04:00