Birunthan Mohanathas
8991ad31d8
Backport (2-0-x) - Update draggable regions when changing BrowserView ( #12370 )
...
* Store InspectableWebContents instead of InspectableWebContentsView in NativeBrowserView
* Rename system_drag_exclude_areas => drag_exclude_rects
* Use NSView convertRect:toView: for BrowserView DragRegionView positioning
* Make BrowserView DragRegionViews children of the WebContents view
Previously they were children of the `InspectableWebContentsView` view,
which caused this assertion to fail:
f993888424/brightray/browser/mac/bry_inspectable_web_contents_view.mm (L162)
* Update draggable regions when changing BrowserView
Fixes #12150 .
2018-03-20 13:03:45 -05:00
trop[bot]
fae6167308
Backport (2-0-x) - Remove the race condition between new process creation and context release ( #12361 )
...
* Remove the race condition between new process creation and old process releasing remote context
Previously there was a race condition where the getId() method would return the new context ID even
though the release was for the old context. This changes it to send the "initial" context ID with
the release message to ensure there is no race.
* fetch context ID from remote in sandbox mode
2018-03-20 18:11:39 +11:00
trop[bot]
b32f332ce3
Backport (2-0-x) - Set appropriate defaults for webview options ( #12292 )
...
* Persist defaults to webPreferences object to JS land can read the inferred values instead of just user defined values
* Test inherited default propogation
* Refactor to remove coupling from fetching values and defaults
* Test description type
* Fix up tests
2018-03-15 15:06:40 +09:00
Cheng Zhao
9843ce743e
Merge pull request #12218 from electron/backport_double_preload_2_0_patch
...
browser: fix preload loading twice in 2.x
2018-03-14 10:27:42 +09:00
Robo
c846f677c9
browser: fix null pointer dereference with getWebPreferences api ( #12245 )
...
* add failing spec
* devtools webContents don't have associated webPreferences
2018-03-14 06:06:51 +09:00
deepak1556
1a43ba50b6
move ipc from rvh to rfh
2018-03-12 14:30:42 +09:00
Aleš Pergl
5471bc313f
Use content origin in screen coordinates for calculating popup menu position ( #12181 )
2018-03-09 05:55:31 +09:00
shelley vohr
36505ae00e
Merge pull request #12059 from electron/add-tabbedwindow-warning
...
add warning when addTabbedWindow is called on self
(cherry picked from commit dfa1dc43df )
2018-03-08 14:33:10 +01:00
shelley vohr
5a210f3d7a
Merge pull request #12137 from electron/deprecate-getMenuBatHeight-2.0.x
...
Deprecate screen.getMenuBarHeight (2.0.x)
2018-03-06 07:38:53 -08:00
Shelley Vohr
95539c5b63
deprecate screen.getMenuBarHeight
2018-03-05 21:00:50 -05:00
Cheng Zhao
1918da7c2e
Remove the evil URLRequestContextGetter::network_delegate
2018-02-26 09:34:40 -08:00
Cheng Zhao
38345c7267
Fix race condition when getting network delegate
2018-02-26 09:34:32 -08:00
shelley vohr
193febd18c
deprecate boolean highlightMode param ( #11993 )
...
* deprecate boolean highlightMode param
* add process.noDeprecations check
* fix native method override
* add todo
2018-02-20 22:30:32 -06:00
shelley vohr
c2575c4944
remove app.getAppMemoryInfo ( #11985 )
...
* remove app.getMemoryInfo
* semicolons are important
2018-02-20 18:52:33 -06:00
John Kleinschmidt
dcaff20cfd
Merge pull request #11981 from electron/set-tray-highlightmode
...
no longer support bool param for setHighlightMode
2018-02-20 12:57:52 -05:00
Cheng Zhao
dc62e51ba4
Fix the cyclic reference in menu delegate ( #11967 )
...
* Fix the cyclic reference in menu delegate
* Fix menu tests due to delegate change
2018-02-20 10:11:35 -06:00
Shelley Vohr
57738e6981
no longer support bool param for setHighlightMode
2018-02-20 10:06:59 -05:00
Thiago de Arruda
bc76f35691
Fix protocol filtering of net.request
...
net::URLRequest inherits from base::SupportsUserData, which allows
associating arbitrary data with the request. Use this mechanism as a
condition for filtering requests from custom protocols.
Close #11657
2018-02-16 13:03:53 -05:00
Cheng Zhao
67fa13d7cf
Merge pull request #11925 from electron/squirrel-mac-cdn
...
Update to use Squirrel.Mac that supports CDN releases
2018-02-16 15:28:39 +09:00
Cheng Zhao
af92b04eb9
Merge pull request #11654 from sethlu/set-notification-close-button-text
...
feat: Set macOS notification close button title
2018-02-15 16:01:30 +09:00
Samuel Attard
6318cd781d
Update to use Squirrel.Mac that supports CDN releases
2018-02-15 14:00:46 +11:00
Shelley Vohr
31b074ff0e
change to return emit
2018-02-14 09:28:21 -05:00
Shelley Vohr
c3d11a51cc
emit console-message in OSR mode
2018-02-14 09:09:45 -05:00
Samuel Attard
9bd7d53cf8
Handle empty handles ( #11598 )
...
* Handle empty handles
* Close and dispose window at end of void test
* Dispose of existing window before running void 0 spec
2018-02-12 14:46:29 -05:00
acheronfail
d1d50a4c92
Implement App-Scoped Security scoped bookmarks ( #11711 )
...
* implementation of security scoped bookmarks
* option is now only available on mas builds
2018-02-12 13:25:06 -05:00
John Kleinschmidt
e6ac2637d3
Merge pull request #11728 from brenca/osr-gpu-update-master
...
Improve OSR API (master)
2018-02-12 12:29:11 -05:00
Zhuo Lu
29f9929703
Organize code
2018-02-10 03:19:47 -08:00
Zhuo Lu
be118d4f13
Make it able to set close button text
2018-02-10 03:19:47 -08:00
Shelley Vohr
5b901d9f82
revert TOOLKIT_VIEWS check change
2018-02-06 13:34:27 -05:00
Shelley Vohr
ae632193c0
migrate to virtual void and start mac impl
2018-02-06 08:21:53 -05:00
Shelley Vohr
97589bbe33
first pass at api method to enable window
2018-02-05 14:49:59 -05:00
Cheng Zhao
983e1b1a70
Implement shutdown event for macOS
2018-02-05 16:20:57 +09:00
Cheng Zhao
c470e758cc
Remove the AllocateSystemIOPorts call
...
It is no longer needed and it is crashing.
2018-02-05 16:15:49 +09:00
Cheng Zhao
109e2c760f
Do not use virtual function to request shutdown
...
Would make it easier to port to other platforms.
2018-02-05 15:50:55 +09:00
Cheng Zhao
8ae3d9dd0b
Simplify the public PowerObserver interface
2018-02-05 15:28:58 +09:00
Thiago de Arruda
56b53e71aa
Implement powerMonitor 'shutdown' event for Linux.
...
The event is emitted when the OS is rebooting/shutting down, and allows
an electron app to call `e.preventDefault()` in order to delay shutdown
and exit cleanly.
2018-02-05 15:21:31 +09:00
shelley vohr
12d4f984f3
Merge pull request #11754 from electron/menu-events
...
Add and document menu events
2018-01-29 12:40:57 -05:00
Shelley Vohr
bef4c84799
turn class into observer
2018-01-27 10:40:50 -05:00
Shelley Vohr
3399480304
first pass at menu event emission
2018-01-27 09:35:58 -05:00
Heilig Benedek
df3d94b20d
Remove web_contents_impl() helper to clarify code and remove unnecessary guard
2018-01-26 10:30:20 +01:00
Heilig Benedek
406f171c88
Move OSR api to OsrWCV to allow api calls to take effect sooner
2018-01-25 16:11:56 +01:00
Cheng Zhao
0207aebad1
Merge pull request #11664 from loc/use_directx_capturer_win
...
Use same screen capturer settings for thumbnails as getUserMedia
2018-01-24 14:38:32 +09:00
Aleš Pergl
c49cb29ddf
Disallow launching unknown apps via browser client.
...
CVE-2018-1000006
2018-01-22 16:49:30 -06:00
Andy Locascio
ae65c26469
fix lint
2018-01-17 17:04:57 -08:00
Andy Locascio
8253e50e9c
use same settings for screen thumbnails as chrome does webrtc capturing
...
Following along from http://crrev.com/2961193002 : make sure the
thumbnail capturers initialize with the same settings as the capturer
from a getUserMedia request does. Otherwise, there is no guarentee that the
sources on Windows will match.
2018-01-17 15:55:10 -08:00
Charles Kerr
fa43cb6ef0
Merge pull request #11557 from josimi/master
...
Fixes hexColorDWORDToRGBA for transparent colors
2018-01-11 10:28:53 -06:00
Cheng Zhao
a883d3d50d
Fix build on other platforms
2018-01-10 17:39:16 +09:00
Cheng Zhao
e77ddd3221
Pass multiple transactions at the same time
...
This follows the design of SKPayment API.
2018-01-10 17:19:44 +09:00
Cheng Zhao
2dd545ebda
Payment should be part of Transaction
...
This follows The SKPayment API, and makes our JS wrappers easier to
implement.
2018-01-10 17:06:27 +09:00
Cheng Zhao
133bef3deb
Turn addTransactionListener into transaction-updated event
2018-01-10 16:57:52 +09:00