Charles Kerr
45bae950d5
chore: remove unused base/ includes ( #43688 )
2024-09-12 16:05:37 +02:00
Charles Kerr
60c4c9fec6
chore: remove unused #includes ( #42971 )
...
* chore: iwyu buildflags.h
* chore: iwyu dictionary.h
* chore: iwyu arguments.h
* chore: iwyu values.h
* chore: iwyu compiler_specific.h
* chore: iwyu binder_map.h
* chore: iwyu <vector>
* chore: iwyu <set>
* chore: iwyu raw_ptr
* chore: iwyu gfx/canvas.h
* chore: iwyu gfx/color_utils.h
* chore: iwyu base/strings/stringprintf.h
* chore: iwyu base/task/thread_pool.h
* chore: iwyu base/no_destructor.h
* chore: iwyu base/path_service.h
* chore: iwyu base/files/file_pathh
* chore: iwyu base/strings/sys_string_conversions.h
* chore: iwyu base/logging.h
* chore: iwyu base/command_line.h
* chore: iwyu base/files/file_util.h
* chore: iwyu base/files/scoped_file.h
* chore: iwyu base/strings/utf_string_conversions.h
* chore: iwyu base/environment.h
* chore: iwyu base/scoped_observation.h
* chore: iwyu base/strings/string_split.h
* chore: iwyu base/strings/pattern.h
* chore: iwyu base/json/string_escape.h
* chore: iwyu base/json/json_reader.h
* chore: iwyu base/memory/singleton.h
* chore: iwyu base/observer_list.h
* chore: iwyu base/timer/timer.h
* fixup! chore: iwyu values.h
* chore: iwyu shell/browser/browser.h
* chore: iwyu base/stl_util.h
* chore: iwyu base/strings/string_util.h
* chore: iwyu shell/browser/javascript_environment.h
* chore: iwyu base/memory/ref_counted.h
* chore: iwyu base/environment.h
* chore: iwyu content/public/browser/browser_thread.h
* chore: remove unused typedef gin_helper::EventEmitter::ValueArray
* chore: iwyu gin/wrappable.h
* chore: iwyu shell/common/gin_helper/function_template_extensions.h
* chore: iwyu shell/common/gin_converters/login_item_settings_converter.h
* chore: iwyu shell/common/gin_helper/arguments.h
* chore: iwyu ui/gfx/skia_util.h
* chore: iwyu ui/gfx/geometry/rect.h
* chore: iwyu ui/gfx/image/image.h
* chore: iwyu base/strings/strcat.h
* chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu shell/browser/javascript_environment.h
* fixup! chore: iwyu gfx/canvas.h
* fixup! chore: iwyu content/public/browser/browser_thread.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
* fixup! chore: iwyu ui/native_theme/native_theme.h
2024-07-22 11:31:32 +02:00
Charles Kerr
4164ef93ad
refactor: remove banned std::to_string() calls ( #41087 )
...
* refactor: do not use banned std::to_string() in ServiceWorkerContext::GetAllRunningWorkerInfo()
* refactor: do not use banned std::to_string() in REPORT_AND_RETURN_IF_FAILED()
* refactor: do not use banned std::to_string() in JSChunkedDataPipeGetter::OnWriteChunkComplete()
* refactor: do not use banned std::to_string() in SetCrashKey()
* chore: remove unused #include
2024-01-24 16:43:31 -06:00
Charles Kerr
f36ceae024
chore: migrate base::StringPiece to std::string_view ( #40915 )
...
* chore: migrate from base::StringPiece to std::string_view in keyboard_util.cc
* chore: migrate from base::StringPiece to std::string_view in error_thrower.cc
* chore: migrate from base::StringPiece to std::string_view in electron_api_web_contents.cc
* chore: migrate from base::StringPiece to std::string_view in gin_helper/dictionary.h
* chore: migrate from base::StringPiece to std::string_view in electron_api_url_loader.cc
* chore: phase out internal use of base:::StringPiece
`base::StringPiece` is being phased out upstream. Its code has been
removed upstream and it's just a typedef for `std::string_view`.
They haven't removed the typedef yet, so this PR tries to get ahead
of future breakage by migrating "internal" use (i.e. leaving alone the
places where the `base::StringPiece` name is coming from an upstream
method that we override).
Xref: https://bugs.chromium.org/p/chromium/issues/detail?id=691162
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4294483
Xref: https://docs.google.com/document/d/1d4RnD1uAE2t4iANR0nXy82ASIPGsPuw2mpO6v6T7JKs
2024-01-10 19:00:37 -06:00
Charles Kerr
5ad8b4b7d1
chore: remove unused std includes ( #38767 )
2023-06-14 11:07:18 -07:00
Charles Kerr
ab49e98401
perf: prefer base::StringPiece over std::string for build-time strings ( #38717 )
...
* perf: use base::StringPiece in InclusionStatusToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in ErrorCodeToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in MessageSourceToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in CursorTypeToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in MediaStreamTypeToString()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in ModifiersToArray()
The strings are all build-time constants and this is a private function
* perf: use base::StringPiece in WebFrameRenderer::MaybeGetRenderFrame()
The strings are all build-time constants and this is a private function
2023-06-12 09:55:22 +02:00
David Sanders
e929b2140d
chore: change some for loops to range-based ( #37857 )
2023-04-11 15:27:07 +09:00
David Sanders
5d120359f6
chore: used nested namespaces ( #34737 )
2022-06-29 12:55:47 -07:00
electron-roller[bot]
b0f315a637
chore: bump chromium to 99.0.4767.0 (main) ( #31986 )
...
* chore: bump chromium in DEPS to 98.0.4726.0
* 3292117: Remove unneeded base/compiler_specific.h includes in //chrome.
https://chromium-review.googlesource.com/c/chromium/src/+/3292117
* 3289198: Enables calculating line, word and sentence boundaries on the browser
https://chromium-review.googlesource.com/c/chromium/src/+/3289198
* 3276176: Remove expired gdi-text-printing flag and associated code.
https://chromium-review.googlesource.com/c/chromium/src/+/3276176
* 3240963: content: allow embedder to prevent locking scheme registry
https://chromium-review.googlesource.com/c/chromium/src/+/3240963
* 3269899: Rename WebContentsImpl::GetFrameTree to GetPrimaryFrameTree
https://chromium-review.googlesource.com/c/chromium/src/+/3269899
* chore: fixup patch indices
* 3276279: Enable -Wshadow by default for the "chromium code" config.
https://chromium-review.googlesource.com/c/chromium/src/+/3276279
* 3279737: appcache: Remove WebPreference/WebSetting
https://chromium-review.googlesource.com/c/chromium/src/+/3279737
* 3275564: [api] Advance API deprecation for APIs last marked in v9.6
https://chromium-review.googlesource.com/c/v8/v8/+/3275564
* 3261873: Clean up WebScriptSource constructors
https://chromium-review.googlesource.com/c/chromium/src/+/3261873
* 3279346: appcache: Remove ConsoleMessage appcache field
https://chromium-review.googlesource.com/c/chromium/src/+/3279346
* 3264212: Move legacy file loading to legacy_test_runner
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264212
Both Persistence and UI have been removed from globals, but the issues they
seemed to be patching are no longer reproducible from what I can tell, and
so we can just delete these and re-evaluate if something surfaces.
* 3290415: x11: remove the USE_X11 define.
https://chromium-review.googlesource.com/c/chromium/src/+/3290415
* chore: bump Chromium to 98.0.4728.0
* 3179530: Defer system calls in PrintingContext for OOP printing
https://chromium-review.googlesource.com/c/chromium/src/+/3179530
* 3299445: Consolidate is_win conditionals in chrome/test/BUILD.gn.
https://chromium-review.googlesource.com/c/chromium/src/+/3299445
* chore: update patch indices
* 3223975: Break PrintJobWorker OOP logic into separate class
https://chromium-review.googlesource.com/c/chromium/src/+/3223975
* chore: bump chromium in DEPS to 98.0.4730.0
* 3279001: Remove support for font-family: -webkit-pictograph
https://chromium-review.googlesource.com/c/chromium/src/+/3279001
* chore: fixup patch indices
* chore: bump chromium in DEPS to 98.0.4732.0
* chore: update patches
* chore: bump chromium in DEPS to 98.0.4734.0
* chore: bump chromium in DEPS to 98.0.4736.0
* chore: update patches
* chore: update printing patch for miracle ptr
* chore: add noexcept to fix clang error
* chore: bump chromium in DEPS to 98.0.4738.0
* chore: update patches
* chore: bump chromium in DEPS to 98.0.4740.0
* chore: bump chromium in DEPS to 98.0.4742.0
* chore: bump chromium in DEPS to 98.0.4744.0
* chore: bump chromium in DEPS to 98.0.4746.0
* chore: bump chromium in DEPS to 98.0.4748.0
* chore: bump chromium in DEPS to 98.0.4750.0
* chore: update patches
* 3293841: Remove File Handling permissions code
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3293841
* chore: update patches
3311700: Move the PpapiPluginSandboxedProcessLauncherDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/3311700
* 3289260: [CodeHealth]: Remove uses of Notification Service
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3289260
* 3301600: Disable scripted print in fenced frames
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3301600
* chore: add missing thread_restrictions headers
* 3305132: Rewrite most `Foo* field_` pointer fields to `raw_ptr<Foo> field_`.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3305132
* fix: add ppapi_sandbox header for linux
3311700: Move the PpapiPluginSandboxedProcessLauncherDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/3311700
* chore: manually bump chromium in DEPS to 98.0.4757.0
* chore: update patches
* 3321044: Remove DictionaryValue::Clear()
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3321044
* chore: update printing.patch
Refs:
- 3304556: [code health] Remove notification observation from PrintJob. | https://chromium-review.googlesource.com/c/chromium/src/+/3304556
- 3305095: [code health] Remove NotificationService from PrintViewManagerBase. | https://chromium-review.googlesource.com/c/chromium/src/+/3305095
* build: add v8-embedder-state headers to GN patch
* chore: bump chromium in DEPS to 99.0.4767.0
* chore: update patches
* chore: rename CookiePartitionKeychain
...to CookiePartitionKeyCollection
* chore: update video consumers
* refactor: use newer base::Value API
* 3232598: Convert net::DnsOverHttpsServerConfig into a class | https://chromium-review.googlesource.com/c/chromium/src/+/3232598
* 3327865: Remove the default WebContentsUserData ctor. | https://chromium-review.googlesource.com/c/chromium/src/+/3327865
* 3302814: DevTools: Add getPreference binding | https://chromium-review.googlesource.com/c/chromium/src/+/3302814
* 3301474: [tq][runtime] Use build flags for JS context promise hooks | https://chromium-review.googlesource.com/c/v8/v8/+/3301474
* oops 😵💫
* 3272411: Reland "base/allocator: Enable PartitionAlloc-Everywhere on macOS" | https://chromium-review.googlesource.com/c/chromium/src/+/3272411
build: turn PartitionAlloc back off on mac for now
* fix: WCO method got renamed
* 3344749: Revert "Stop using NSRunLoop in renderer process"
https://chromium-review.googlesource.com/c/chromium/src/+/3344749
* 3288746: [serial] Fix BluetoothSerialDeviceEnumerator threading issues.
https://chromium-review.googlesource.com/c/chromium/src/+/3288746
* Revert "3288746: [serial] Fix BluetoothSerialDeviceEnumerator threading issues."
This reverts commit 5cc69f102e43ca72ac9ef45063711bcc7d849740.
* chore: disable serial device enumerator sequence dcheck
* fix: comment out line in DeviceService dtor
* fixup! 3279001: Remove support for font-family: -webkit-pictograph
* fixup! 3279346: appcache: Remove ConsoleMessage appcache field
* chore: update patches after rebase
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: VerteDinde <khammond@slack-corp.com >
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2022-01-10 17:31:39 -05:00
Electron Bot
005101424a
chore: bump chromium to 92.0.4496.0 (master) ( #28907 )
...
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2021-05-03 20:13:46 -07:00
Samuel Maddock
3250ef551c
feat: support registering MV3 extension service workers ( #27562 )
...
* feat: support registering MV3 extension service workers
* feat: load chrome extension APIs in worker context
* feat: add more ContentRendererClient service worker overrides
* fix: lint error
* refactor: emit object for 'registration-completed'
* docs: clarify when registration-completed emits
2021-02-11 10:58:03 -05:00
Milan Burda
ddf3ef0a5f
refactor: use C++11 class member variable initialization ( #27477 )
2021-01-26 12:16:21 -06:00
Electron Bot
8798571a77
chore: bump chromium to 0e4ca9c0a63d7a39bd910997ad4c6 (master) ( #24687 )
...
* chore: bump chromium in DEPS to 1f1c4d91f6eaa4a033ec8f499d63a0717f79a42a
* viz: Do not apply white level scaling for RGBA fp16 HDR video
https://chromium-review.googlesource.com/c/chromium/src/+/2296006
* Move WebPreferences to WebContents
https://chromium-review.googlesource.com/c/chromium/src/+/2263635
* Fix missing WeakPtr check in PreconnectManager
https://chromium-review.googlesource.com/c/chromium/src/+/2309029
* Fixup swiftshader roll revision
* Update patch indices
* Move WebDeviceEmulationParams into common.
https://chromium-review.googlesource.com/c/chromium/src/+/2303356
* Move EnableDisableDeviceEmulation to blink mojom messages
https://chromium-review.googlesource.com/c/chromium/src/+/2303367
* PDF Viewer: Remove flag for two-up view
https://chromium-review.googlesource.com/c/chromium/src/+/2311130
* Add mojom definition for DeviceEmulationParams.
https://chromium-review.googlesource.com/c/chromium/src/+/2303491
* Remove ServiceWorkerContextWatcher from PaymentAppInstaller
https://chromium-review.googlesource.com/c/chromium/src/+/2291186
* Loader: Move transferrable_url_loader.mojom into blink's mojom directory
https://chromium-review.googlesource.com/c/chromium/src/+/2306123
* chore: bump chromium in DEPS to 4974f436479739025a90ebc2cc2e36d67ee1ac46
* mac: Work around Xcode 12b3 SDK bug
https://chromium-review.googlesource.com/c/chromium/src/+/2315078
* Reland Update core items for macOS Big Sur.
https://chromium-review.googlesource.com/c/chromium/src/+/2315162
* Update Swiftshader revision
* mac/arm64: When cross-building the snapshot, use page size of the target ISA instead of the host.
https://chromium-review.googlesource.com/c/v8/v8/+/2310575
* Update patch indices
* Rename {,Non}ClientView::CanClose() to OnWindowCloseRequested()
https://chromium-review.googlesource.com/c/chromium/src/+/2247838
* chore: bump chromium in DEPS to e9465d70d1dea539400f0fddad43358ea3c31d71
* chore: bump chromium in DEPS to bd5b71c5f20288eb26068a39ae6e0579566a51c5
* chore: bump chromium in DEPS to 786ee543048bd07d07c5ac50b7dbbdd6bdd8dcce
* chore: bump chromium in DEPS to 34eb6ecbf2c5894b648900bf771a2a29de204798
* chore: bump chromium in DEPS to 567ff038d68e3adb8116a01eec863cdf34d775f5
* chore: bump chromium in DEPS to 340b45c8d4ceb2dd61969fc34e1928d3c46db48c
* chore: update patches
* chore: base::DeleteFile with two params is removed
Should use base::DeleteFile and base::DeletePathRecursively when
appropriate
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2313376
* chore: add patch for NodePlatform::PostJob impl
* chore: update patches
* chore: extension file access is now instrumented
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2209995
* chore: implement SetWindowFrameInScreen in OSR RWHV
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2321409
* chore: NotifyUserActivation requires a type now
This is just for a histogram thing and therefore it does not matter what
we pass in
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2281303
* chore: update patches
* chore: bump chromium in DEPS to cd570e6dd3dcb84463ac252b04e92ceb02d8400c
* chore: update patches
* chore: bump chromium in DEPS to 0187908a31866992b90c59719ac1d016328f6ee0
* chore: bump chromium in DEPS to 3c9df38c508f3dba26a75248beed4882ddfb98e9
* chore: bump chromium in DEPS to 1a47d3b9cee710bd3c958c4f2d8b205710df9d50
* chore: bump chromium in DEPS to baac93040d96abdab72d46dd034c60f86e108702
* chore: bump chromium in DEPS to 13836145f97299e636491de38064b78861c4fb2e
* update patches
* change OS_MACOSX -> OS_MAC
Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=1105907
* patch: add header for ToExecutionContext in WebMessagePortConverter
* chore: bump chromium in DEPS to 91ab9b6ac5d04dc034a03ad847fbfa8261328c2b
* update patches
* NeedToFireBeforeUnloadOrUnload -> NeedToFireBeforeUnloadOrUnloadEvents
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2288711
* chore: bump chromium in DEPS to 290deb11f0e30cb1382fd8f8793d340560283c23
* update patches
* add dragdrop header for autofill popup
* int -> x11::Time
* patch out accessibility private API use
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2330812
* remove usage of XEvent
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2317767
* trigger recalculation of WebPreferences before renderer initialization
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2263635
* chore: bump chromium in DEPS to 6bdb484583b99c96ef3388d0c2184326581b2d5a
* chore: bump chromium in DEPS to 1eb2a79cde04fd5c8ae51b4d813e6521635269e5
* chore: bump chromium in DEPS to 3dc8e3c0f400e4ca9c0a63d7a39bd910997ad4c6
* chore: update patches
* fixup! trigger recalculation of WebPreferences before renderer initialization
* views: Make MenuButton and RadioButton default constructible
https://chromium-review.googlesource.com/c/chromium/src/+/2339586
* chore: fix code style
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
Co-authored-by: Andy Locascio <andy@slack-corp.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2020-08-12 11:33:58 -07:00
Shelley Vohr
61a05caa78
refactor: remove uses of v8::Isolate::GetCurrent ( #24179 )
2020-06-22 09:35:24 -07:00
Jeremy Apthorp
22c17bcc5b
refactor: ginify ServiceWorkerContext ( #22756 )
2020-03-20 14:15:14 -07:00
Jeremy Apthorp
19314d3caf
fix: remove catch-all HandleScope ( #22531 )
2020-03-10 18:16:58 -07:00
Samuel Attard
e7b0a9ca8f
feat: add API for receiving logs from service workers ( #20624 )
...
* feat: add API for receiving logs from service workers
* feat: add new serviceWorkerContext APIs
* chore: add missing #include's
* refactor: rename serviceWorkerContext to serviceWorkers
* chore: clean up based on review
* chore: remove native_mate
* chore: add tests for the service worker module
* Update spec-main/api-service-workers-spec.ts
Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org >
* chore: fix linting
* chore: handle renames
Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net >
2020-02-20 15:19:06 -08:00