* docs: add IPC doc
* fix: use "string" primitive
* use 'string' ipcrenderer
* use "number" primitive
* Update docs/tutorial/ipc.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* Update docs/tutorial/ipc.md
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* add code sample
Co-authored-by: Erick Zhao <erick@hotmail.ca>
Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
* Update context bridge docs about Promises
From my testing it doesn't remove Promises in nested objects,
also according to the test suite it does not:
80577a4f08/spec-main/api-context-bridge-spec.ts (L693)
* docs: Update docs for errors too
Co-authored-by: Mikael Finstad <finstaden@gmail.com>
* chore: bump chromium in DEPS to 98.0.4732.0
* chore: bump chromium in DEPS to 98.0.4734.0
* chore: bump chromium in DEPS to 98.0.4736.0
* chore: bump chromium in DEPS to 98.0.4738.0
* chore: bump chromium in DEPS to 98.0.4740.0
* chore: bump chromium in DEPS to 98.0.4742.0
* chore: bump chromium in DEPS to 98.0.4744.0
* chore: bump chromium in DEPS to 98.0.4746.0
* chore: bump chromium in DEPS to 98.0.4748.0
* chore: bump chromium in DEPS to 98.0.4750.0
* chore: bump chromium in DEPS to 98.0.4752.0
* chore: bump chromium in DEPS to 98.0.4754.0
* chore: bump chromium in DEPS to 98.0.4756.0
* chore: bump chromium in DEPS to 98.0.4758.0
* chore: bump chromium in DEPS to 98.0.4758.3
* chore: bump chromium in DEPS to 98.0.4758.5
* chore: bump chromium in DEPS to 98.0.4758.9
* chore: bump chromium in DEPS to 98.0.4758.10
* chore: bump chromium in DEPS to 98.0.4758.9
* chore: bump chromium in DEPS to 98.0.4758.10
* chore: bump chromium in DEPS to 98.0.4758.9
* chore: bump chromium in DEPS to 98.0.4758.10
* chore: bump chromium in DEPS to 98.0.4758.9
* chore: bump chromium in DEPS to 98.0.4758.10
* chore: bump chromium in DEPS to 98.0.4758.9
* chore: bump chromium in DEPS to 98.0.4758.10
* 3292117: Remove unneeded base/compiler_specific.h includes in //chrome.
https://chromium-review.googlesource.com/c/chromium/src/+/3292117
(cherry picked from commit 1a84b21a5e461927c13a0601395b036cf668077a)
* 3289198: Enables calculating line, word and sentence boundaries on the browser
https://chromium-review.googlesource.com/c/chromium/src/+/3289198
(cherry picked from commit c8b1766a789d596273fe6bee8adab62e7963bc17)
* 3276176: Remove expired gdi-text-printing flag and associated code.
https://chromium-review.googlesource.com/c/chromium/src/+/3276176
(cherry picked from commit 0abd3208d6aa42f9329d50407290536d3196a19b)
* 3240963: content: allow embedder to prevent locking scheme registry
https://chromium-review.googlesource.com/c/chromium/src/+/3240963
(cherry picked from commit 19540a965d47205cb079738d3d11b12f82edbb98)
* 3269899: Rename WebContentsImpl::GetFrameTree to GetPrimaryFrameTree
https://chromium-review.googlesource.com/c/chromium/src/+/3269899
(cherry picked from commit a5b704e184c45cffd2dbc97e42bec76d52ed3f7a)
* chore: fixup patch indices
(cherry picked from commit dd9cb2a448c7368abab9e6733e442ad75ca9fc38)
* 3276279: Enable -Wshadow by default for the "chromium code" config.
https://chromium-review.googlesource.com/c/chromium/src/+/3276279
(cherry picked from commit ec20f7fc862de2b0057fe4d59c13d94b70a9e13c)
* 3279737: appcache: Remove WebPreference/WebSetting
https://chromium-review.googlesource.com/c/chromium/src/+/3279737
(cherry picked from commit 04088b5a4413f074cd4090838ed4ccb123f32c56)
* 3275564: [api] Advance API deprecation for APIs last marked in v9.6
https://chromium-review.googlesource.com/c/v8/v8/+/3275564
(cherry picked from commit 72ef5a0bced84ca5dbacb0de4e63fe73fc8d34e5)
* 3261873: Clean up WebScriptSource constructors
https://chromium-review.googlesource.com/c/chromium/src/+/3261873
(cherry picked from commit c277b0b411b2dcfabdab2798dd489aab2a01fa2c)
* 3279346: appcache: Remove ConsoleMessage appcache field
https://chromium-review.googlesource.com/c/chromium/src/+/3279346
(cherry picked from commit ea85e829ccd6fbf019b0056300232d0a4bf6a8e8)
* 3264212: Move legacy file loading to legacy_test_runner
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264212
Both Persistence and UI have been removed from globals, but the issues they
seemed to be patching are no longer reproducible from what I can tell, and
so we can just delete these and re-evaluate if something surfaces.
(cherry picked from commit f3e01465ce8b15af93aebdb5bd08fffed9dbe81c)
* 3290415: x11: remove the USE_X11 define.
https://chromium-review.googlesource.com/c/chromium/src/+/3290415
(cherry picked from commit 1351e45cb53851018675e707941d71f44e7bb2a7)
* 3179530: Defer system calls in PrintingContext for OOP printing
https://chromium-review.googlesource.com/c/chromium/src/+/3179530
(cherry picked from commit 4e235ab720ec3f2f7112b47be948469e9fc9023a)
* 3299445: Consolidate is_win conditionals in chrome/test/BUILD.gn.
https://chromium-review.googlesource.com/c/chromium/src/+/3299445
(cherry picked from commit d09ef41fc11f8190d6174d48506291c462420bbc)
* chore: update patch indices
(cherry picked from commit 77b72f77b8322e75c72debe446c34e38ccb0468c)
* 3223975: Break PrintJobWorker OOP logic into separate class
https://chromium-review.googlesource.com/c/chromium/src/+/3223975
(cherry picked from commit e02a7b1e8025709101f13e8a82398714a3c6f451)
* 3279001: Remove support for font-family: -webkit-pictograph
https://chromium-review.googlesource.com/c/chromium/src/+/3279001
(cherry picked from commit 01ba427a032dad1a1cb272bca8a420ec4f3d2198)
* chore: fixup patch indices
(cherry picked from commit 49d33970d6f8c5b5c9393d509c5727e66f9698a1)
* chore: update patches
(cherry picked from commit 266bb0db2ede34b8569d94fe6725b567a389fa83)
* chore: update patches
(cherry picked from commit 7ec7dac00dca5f00a09d11fe6b741470e4524519)
* chore: update printing patch for miracle ptr
(cherry picked from commit 4954c64859a7d4da2e57318b66d09fdc49d11327)
* chore: add noexcept to fix clang error
(cherry picked from commit ef9b7d1826c20f5df5442962a82815732dfb0086)
* chore: update patches
(cherry picked from commit 495e5c8dfb203002300f96924199e6cb86fe272e)
* chore: update patches
(cherry picked from commit c41579b260ae71bef2f6437ff21644ec0858ec35)
* 3293841: Remove File Handling permissions code
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3293841
(cherry picked from commit e6a5c4fa0c3d3c4f4cf77961d2f73f6f2bffa4dd)
* chore: update patches
3311700: Move the PpapiPluginSandboxedProcessLauncherDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/3311700
(cherry picked from commit 1f0b5231ea12840cc3610ac306ec421d8bc884b1)
* 3289260: [CodeHealth]: Remove uses of Notification Service
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3289260
(cherry picked from commit 741d48c9d8e8740c9f3e3c2dbf2072fc76ca92ad)
* 3301600: Disable scripted print in fenced frames
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3301600
(cherry picked from commit 9ebe29ae559df0de103b29615990ff7b171e54ca)
* chore: add missing thread_restrictions headers
(cherry picked from commit 8440c2ff2ec1cb808e8f5d77eb75e41d9be7d0f6)
* 3305132: Rewrite most `Foo* field_` pointer fields to `raw_ptr<Foo> field_`.
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3305132
(cherry picked from commit f4e090c9190fe919123b660d2e0909f09a66d03b)
* fix: add ppapi_sandbox header for linux
3311700: Move the PpapiPluginSandboxedProcessLauncherDelegate | https://chromium-review.googlesource.com/c/chromium/src/+/3311700
(cherry picked from commit 00335143af0dab4a1240670d73f9061f3f7dddb3)
* 3321044: Remove DictionaryValue::Clear()
Ref: https://chromium-review.googlesource.com/c/chromium/src/+/3321044
(cherry picked from commit 2cba28ab91d6a1e60024d8826e82bbe07e4a1b6e)
* chore: update printing.patch
Refs:
- 3304556: [code health] Remove notification observation from PrintJob. | https://chromium-review.googlesource.com/c/chromium/src/+/3304556
- 3305095: [code health] Remove NotificationService from PrintViewManagerBase. | https://chromium-review.googlesource.com/c/chromium/src/+/3305095
(cherry picked from commit b3e6811a687e5883a2e74ae044a2e52f0ac000bc)
* build: add v8-embedder-state headers to GN patch
(cherry picked from commit 46b085f0ae7b2fe3556efbed2a36853a23cccc1c)
* chore: update patches
* chore: update video consumers
(cherry picked from commit e78c76f76a3bc2d868a330434e33a16be48ebc76)
* refactor: use newer base::Value API
(cherry picked from commit 7d711f6a85245bc8b80e7601c992647be2dce40f)
* oops 😵💫
(cherry picked from commit e348ab73242e96f5c4d572d00185a5c25c218d26)
* chore: rename CookiePartitionKeychain
...to CookiePartitionKeyCollection
(cherry picked from commit b88f03dcb225f219ec78dd7463058231c74603e2)
* chore: update patch after rebase
* fix: WCO method got renamed
(cherry picked from commit f80c70fdccbc4847e08b2ef08849a1d00350d341)
* build: turn PartitionAlloc back off on mac for now
(cherry picked from commit 0ef90f5385411c7f8f9ab3904c644a0f254343cf)
* 3344749: Revert "Stop using NSRunLoop in renderer process"
https://chromium-review.googlesource.com/c/chromium/src/+/3344749
(cherry picked from commit de8e4afb6f7f24db2a6062dd7d2ddcabf13f3f16)
* chore: disable serial device enumerator sequence dcheck
(cherry picked from commit c3a51158ed572cecbe5818b78e9c91cd8c7e3367)
* chore: bump chromium in DEPS to 98.0.4758.9
* fix: comment out line in DeviceService dtor
(cherry picked from commit bf2af594c7336ff0c93a1155de7710a6c7387147)
* Revert "chore: bump chromium in DEPS to 98.0.4758.9"
This reverts commit 5d2232ff9aa70fb227c984272e2317f3946b03c2.
* fix: destructor for EmbedderStateScope
* fixup! 3279001: Remove support for font-family: -webkit-pictograph
(cherry picked from commit a0707af4facb31b8458723f9647201776b8431a3)
* fixup! 3279346: appcache: Remove ConsoleMessage appcache field
(cherry picked from commit c947cf23218818b81107c18331eaf21379f11db9)
* chore: update patches
* chore: bump chromium in DEPS to 98.0.4758.9
* chore: bump chromium in DEPS to 98.0.4758.10
* chore: bump chromium in DEPS to 98.0.4758.9
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: clavin <clavin@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
The current description incorrectly states that the webFrame export represents the top frame but it actually represents the current frame.
Co-authored-by: Maciej Krawczyk <mckravchyk@gmail.com>
Changes some links around. There was no link for `NSUserNotification`, and
`UNNotificationResponse` incorrectly linked to our own `NotificationResponse`
API structure doc.
This deprecates the synchronous and blocking `webContents.getPrinters()`
function and introduces `webContents.getPrintersAsync()`, which is
asynchronous and non-blocking.
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
* WIP
* Use serialization
* Rebase windows impl of new app requestSingleInstanceLock parameter
* Fix test
* Implement posix side
* Add backwards compatibility test
* Apply PR feedback Windows
* Fix posix impl
* Switch mac impl back to vector
* Refactor Windows impl
* Use vectors, inline make_span
* Use blink converter
* fix: ownership across sequences
* Fix upstream merge from Chromium
Co-authored-by: deepak1556 <hop2deep@gmail.com>
* feat: add commandLine.removeSwitch
In some cases apps may want to remove Chromium command line switches to avoid certain Chromium behaviors being used, E.g. remote-debugging-port or gpu-launcher
* fix: add missing removeSwitch to app.ts
Co-authored-by: Milan Burda <milan.burda@gmail.com>
* feat: make desktopCapturer main-process-only
* remove --enable-api-filtering-logging
* remove test
* merge lib/browser/api/desktop-capturer.ts with lib/browser/desktop-capturer.ts
* remove desktop-capturer-get-sources event
* fix specs
* getSources needs to be async
Co-authored-by: Milan Burda <milan.burda@gmail.com>
* feat: add support for WebHID
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* Address review feedback
* Address review feedback
* chore: clear granted_devices on navigation
Also added test to verify devices get cleared
* fixup testing for device clear
* make sure navigator.hid.getDevices is run on correct frame
* clear granted devices on RenderFrameHost deletion/change
* manage device permissions per RenderFrameHost
This change makes sure we don't clear device permission prematurely due to child frame navigation
* Update shell/browser/api/electron_api_web_contents.cc
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* apply review feedback from @zcbenz
* Match upstream ObjectMap
This change matches what ObjectPermissionContextBase uses to cache object permissions: https://source.chromium.org/chromium/chromium/src/+/main:components/permissions/object_permission_context_base.h;l=52;drc=8f95b5eab2797a3e26bba299f3b0df85bfc98bf5;bpv=1;bpt=0
The main reason for this was to resolve this crash on Win x64:
ok 2 WebContentsView doesn't crash when GCed during allocation
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
gin::WrappableBase::SecondWeakCallback [0x00007FF6F2AFA005+133] (o:\gin\wrappable.cc:53)
v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacks [0x00007FF6F028F9AB+171] (o:\v8\src\handles\global-handles.cc:1400)
v8::internal::GlobalHandles::InvokeSecondPassPhantomCallbacksFromTask [0x00007FF6F028F867+391] (o:\v8\src\handles\global-handles.cc:1387)
node::PerIsolatePlatformData::RunForegroundTask [0x00007FF6F3B4D065+317] (o:\third_party\electron_node\src\node_platform.cc:415)
node::PerIsolatePlatformData::FlushForegroundTasksInternal [0x00007FF6F3B4C424+776] (o:\third_party\electron_node\src\node_platform.cc:479)
uv_run [0x00007FF6F2DDD07C+492] (o:\third_party\electron_node\deps\uv\src\win\core.c:609)
electron::NodeBindings::UvRunOnce [0x00007FF6EEE1E036+294] (o:\electron\shell\common\node_bindings.cc:631)
base::TaskAnnotator::RunTask [0x00007FF6F2318A19+457] (o:\base\task\common\task_annotator.cc:178)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl [0x00007FF6F2E6F553+963] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:361)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork [0x00007FF6F2E6EC69+137] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:266)
base::MessagePumpForUI::DoRunLoop [0x00007FF6F235AA58+216] (o:\base\message_loop\message_pump_win.cc:221)
base::MessagePumpWin::Run [0x00007FF6F235A01A+106] (o:\base\message_loop\message_pump_win.cc:79)
base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run [0x00007FF6F2E702DA+682] (o:\base\task\sequence_manager\thread_controller_with_message_pump_impl.cc:470)
base::RunLoop::Run [0x00007FF6F22F95BA+842] (o:\base\run_loop.cc:136)
content::BrowserMainLoop::RunMainMessageLoop [0x00007FF6F14423CC+208] (o:\content\browser\browser_main_loop.cc:990)
content::BrowserMainRunnerImpl::Run [0x00007FF6F144402F+143] (o:\content\browser\browser_main_runner_impl.cc:153)
content::BrowserMain [0x00007FF6F143F911+257] (o:\content\browser\browser_main.cc:49)
content::RunBrowserProcessMain [0x00007FF6EFFA7D18+112] (o:\content\app\content_main_runner_impl.cc:608)
content::ContentMainRunnerImpl::RunBrowser [0x00007FF6EFFA8CF4+1220] (o:\content\app\content_main_runner_impl.cc:1104)
content::ContentMainRunnerImpl::Run [0x00007FF6EFFA87C9+393] (o:\content\app\content_main_runner_impl.cc:971)
content::RunContentProcess [0x00007FF6EFFA73BD+733] (o:\content\app\content_main.cc:394)
content::ContentMain [0x00007FF6EFFA79E1+54] (o:\content\app\content_main.cc:422)
wWinMain [0x00007FF6EECA1535+889] (o:\electron\shell\app\electron_main.cc:291)
__scrt_common_main_seh [0x00007FF6F6F88482+262] (d:\A01\_work\6\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
BaseThreadInitThunk [0x00007FFEC0087034+20]
RtlUserThreadStart [0x00007FFEC1F02651+33]
✗ Electron tests failed with code 0xc0000005.
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
