trop[bot]
764666766f
fix: linux test shutdown error "AttributeError: type object 'DBusTestCase' has no attribute 'stop_dbus'" ( #51151 )
...
stop_dbus() was removed on 2025-09-14 by
99c4800e9echarles@charleskerr.com >
2026-04-19 01:08:04 -07:00
Samuel Attard
0686cceb7a
build: authenticate sudowoodo /token exchange via Actions OIDC (40-x-y) ( #51054 )
...
build: authenticate sudowoodo /token exchange via Actions OIDC
2026-04-14 20:44:15 -07:00
David Sanders
c5b89e9178
build: don't use //third_party/depot_tools in gn build scripts ( #50989 )
...
build: don't use //third_party/depot_tools in gn build scripts (#50858 )
2026-04-13 14:55:06 -04:00
trop[bot]
6e6dde11ac
fix: pass root_gen_dir from GN to generate_node_headers.py ( #50871 )
...
fix: pass root_gen_dir from GN to generate_node_headers.py
PR #50828 replaced a local get_out_dir() (defaulting to 'Testing') with
the shared one from script/lib/util.py (defaulting to 'Default').
Neither default is correct because the actual output directory depends
on the active build config. Pass $root_gen_dir from the GN action so
the script always uses the correct path.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-04-10 12:37:14 +02:00
Samuel Attard
218544d32e
build: replace npx with lockfile-pinned binaries ( #50717 )
...
build: replace npx with lockfile-pinned binaries (#50598 )
* build: replace npx with lockfile-pinned binaries
- nan-spec-runner: reorder yarn install first, invoke nan node-gyp bin directly
- publish-to-npm: use host npm with E404 try/catch (closes existing TODO)
- upload-symbols: add @sentry/cli devDep, invoke from node_modules/.bin
- remove script/lib/npx.py (dead since #48243 )
* build: bump @sentry/cli to 1.70.0 for arm support
* build: bump @sentry/cli to 1.72.0, skip CDN download on test jobs
@sentry/cli fetches its platform binary from Sentry CDN at postinstall.
Only upload-symbols.py (release pipeline) needs the binary; set
SENTRYCLI_SKIP_DOWNLOAD=1 in the two test-segment workflows that
call install-dependencies. The 64k variant uses pre-built artifacts
and does not install deps.
2026-04-06 16:07:36 -04:00
Samuel Attard
eb871f7eee
build: derive patches upstream-head ref from script path (40-x-y) ( #50739 )
...
build: derive patches upstream-head ref from script path (#50727 )
* build: derive patches upstream-head ref from script path
gclient-new-workdir.py symlinks each repo's .git/refs back to the source
checkout, so the fixed refs/patches/upstream-head was shared across all
worktrees. Parallel `e sync` runs in different worktrees clobbered each
other's upstream-head, breaking `e patches` and check-patch-diff.
Suffix the ref with an md5 of the script directory so each worktree writes
a distinct ref into the shared refs dir. Fall back to the legacy ref name
in guess_base_commit so existing checkouts keep working until next sync.
* fixup: also write legacy upstream-head ref and note it in docs
2026-04-06 16:00:44 -04:00
trop[bot]
a4955396e1
ci: output build cache hit rate as GHA annotation ( #50368 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2026-03-19 16:46:40 +01:00
trop[bot]
ee2d3db030
test: fix esm issue in node-spec-runner ( #50294 )
...
Chromium added a top-level package.json in CL:7485999 that sets
the type to module and breaks commonjs tests run via
node-spec-runner.js. This commit temporarily changes the type to
commonjs while running the tests, then changes it back to module when done.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-03-16 21:13:30 +01:00
trop[bot]
8c1b38d443
build: pin diff.renames for deterministic patch export ( #50127 )
...
git format-patch honors diff.renames, which defaults to 'true' (rename
detection only). If a user has diff.renames=copies configured at the
system or global level, exported patches may encode new files as copies
of similar existing files, causing spurious diffs against patches
exported on other machines. Pin diff.renames=true to match git's
default.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@anthropic.com >
2026-03-09 11:36:45 +01:00
trop[bot]
a3022df30f
build: fix code-signing for MacOS x64 tests ( #50072 )
...
* fix: code-sign binaries for notification tests
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* test: remove redundent feedURL test
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* test: move squirrel feed tests to api-autoupdater
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* fix: fix SQRLShipItRequest.JSONKeyPathsByPropertyKey mappings
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* Revert "fix: fix SQRLShipItRequest.JSONKeyPathsByPropertyKey mappings"
This reverts commit 5ad9892a67khammond@slack-corp.com >
* test: unsign tests requiring no signed app
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* fixup! fix: fix SQRLShipItRequest.JSONKeyPathsByPropertyKey mappings
chore: fix patch shear
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2026-03-05 10:27:29 +01:00
electron-roller[bot]
603bcb73e3
chore: bump node to v24.14.0 (40-x-y) ( #49939 )
...
* chore: bump node in DEPS to v24.14.0
* lib: prefer call() over apply() if argument list is not array
https://github.com/nodejs/node/pull/60796
* build,deps: replace cjs-module-lexer with merve
https://github.com/nodejs/node/pull/61456
* test: use fixture directories for sea tests
https://github.com/nodejs/node/pull/61167
* src: throw RangeError on failed ArrayBuffer BackingStore allocation
* chore: fixup patch indices
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-03-02 14:37:11 +01:00
trop[bot]
06521fad4c
build: exit upload with error code if github upload fails ( #49945 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
2026-02-25 23:58:28 -08:00
electron-roller[bot]
8ec629e871
chore: bump node to v24.13.1 (40-x-y) ( #49742 )
...
* chore: bump node in DEPS to v24.13.1
* chore: fixup patches
refs:
* https://github.com/nodejs/node/pull/60425
* https://github.com/nodejs/node/pull/61270
* https://github.com/nodejs/node/pull/61044
* fix: generate_config_gypi needs to generate valid JSON
https://github.com/nodejs/node/pull/60794
* doc: align Buffer.concat documentation with behavior
https://github.com/nodejs/node/pull/60405
* src: fix off-thread cert loading in bundled cert mode
https://github.com/nodejs/node/pull/60764
* chore: fixup patch indices
* build: fix extraneous includes
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-02-13 16:35:43 +01:00
trop[bot]
e0a61a58ef
build: generate artifact attestions for released assets ( #49767 )
...
* build: generate artifact attestions for released assets
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
* chore: address review feedback
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
* build: fixup attestation for release assets (#49732 )
* build: fixup attestation for release assets
* Generate artifact attestation for generated artifacts
* set id-token for attestation
* Add artifact-metadata permission for attestation
* add permissions for testing attestations
* Revert "add permissions for testing attestations"
This reverts commit 0284bed17569a1b13a18ee0536ecebsamuel.r.attard@gmail.com >
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2026-02-11 15:34:26 -05:00
electron-roller[bot]
21c6e4e8a0
chore: bump node to v24.13.0 (40-x-y) ( #49188 )
...
* chore: bump node in DEPS to v24.12.0
* chore: bump node in DEPS to v24.13.0
* src: use CP_UTF8 for wide file names on win32
https://github.com/nodejs/node/pull/60575
* test,crypto: handle a few more BoringSSL tests
https://github.com/nodejs/node/pull/59030
* chore: re-add accidentally removed sslv23 test
* test: make buffer sizes 32bit-aware in test-internal-util-construct-sab
https://github.com/nodejs/node/pull/61026
* chore: fixup patch indices
* chore: fixup crypto patch rebase
(cherry picked from commit 0b3baf0167f52fbdbe51#49452 )
(cherry picked from commit 73377af79ehttps://github.com/nodejs-private/node-private/pull/782
(cherry picked from commit 87bc8ebd34https://github.com/nodejs/node/pull/60497
(cherry picked from commit ae90076267shelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
2026-02-10 15:29:51 +01:00
trop[bot]
3039ced4f3
chore: improvements to script/run-clang-tidy.ts ( #49343 )
...
* chore: disable color output for clang-tidy in CI
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: small QoL improvements to run-clang-tidy.ts
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: add --fix option to script/run-clang-tidy.ts
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2026-01-09 14:43:18 -06:00
John Kleinschmidt
95cd5641dd
build: use @electron-ci/dev-root for package.json default
...
(cherry picked from commit bab6bd3dae
2026-01-06 14:28:47 -05:00
trop[bot]
a7652f68e9
build: fixup release notes generation ( #49305 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
2026-01-05 12:23:42 -05:00
trop[bot]
525917302a
build: add logging to notes generator ( #49301 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
2026-01-05 09:55:16 -05:00
trop[bot]
9dce2015f7
build: drop dugite as a dependency ( #49204 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
2025-12-15 14:40:56 -05:00
trop[bot]
1c85668558
build: upgrade yarn to 4.12.0 ( #49181 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
2025-12-10 19:21:46 -08:00
trop[bot]
9ec95c0c02
chore: bump chromium to 144.0.7527.0 (40-x-y) ( #49057 )
...
chore: bump chromium to 144.0.7527.0 40-x-y
* chore: bump chromium in DEPS to 144.0.7527.0
* 7106405: [video pip] Fix gesture handling issues
https://chromium-review.googlesource.com/c/chromium/src/+/7106405
* 7130938: Reland "Remove some dependencies from the custom_handlers component"
https://chromium-review.googlesource.com/c/chromium/src/+/7130938
* 7139361: Rename PluginService's GetPlugins methods
https://chromium-review.googlesource.com/c/chromium/src/+/7139361
* chore: fixup patch indices
* test: fix macos webgl test | 7128438: Reland "Flip SwiftShader deprecation to launched." | https://chromium-review.googlesource.com/c/chromium/src/+/7128438
* test: update webgl test to skip on fallback adapters
* Fixup spec runner to properly fail on linux when tests fail
* test: fixup dbus tests
* test: convert shared-texture-spec from old done callback to async
Fixes Error: done() called multiple times in test <sharedTexture module import shared texture produced by osr successfully imported and rendered with subtle api> of file /__w/electron/electron/src/electron/spec/api-shared-texture-spec.ts
* test: fixup shared texture spec
* Revert "test: fixup dbus tests"
This reverts commit 3e2e720003https://github.com/electron/electron/pull/48657 broke those tests
* disable sharedTexture tests on platforms other than macOS arm64
They were not working on other platforms previously but now they error out.
Also removed extraneous debugging.
* fix: use github.sha for yarn cache key to avoid hashFiles() composite action bug
* Use --immutable-cache to allow native module builds
* fix: wait for devtools blur event in focus test to avoid race condition
* fix: wait for devtools blur event in focus test to avoid race condition
* fix allow native module builds in spec workspace
* test:rebuild native modules
* Revert "fix allow native module builds in spec workspace"
This reverts commit ffda3be98c2e6eea434833560ba0de
2025-11-24 16:59:42 -05:00
electron-roller[bot]
d9446924dc
chore: bump node to v24.11.1 (40-x-y) ( #48916 )
...
* chore: bump node in DEPS to v24.11.1
* chore: bump node to v24.11.1 (main) (#48917 )
* chore: bump node in DEPS to v24.11.1
* src: add a default branch for module phase
https://github.com/nodejs/node/pull/60261
* src: conditionally disable source phase imports by default
https://github.com/nodejs/node/pull/60364
* chore: update patches
* src: update locks to use DictionaryTemplate and other minor cleanups
https://github.com/nodejs/node/pull/60061
* deps: update simdjson to 4.0.7
https://github.com/nodejs/node/pull/59883
* test: move sea tests into test/sea
https://github.com/nodejs/node/pull/60250
* fixup deps: update simdjson to 4.0.7a
* src: conditionally disable source phase imports by default
https://github.com/nodejs/node/pull/60364
* module: handle null source from async loader hooks in sync hooks
https://github.com/nodejs/node/pull/59929
* Revert "src: conditionally disable source phase imports by default"
This reverts commit 5f85b84262https://github.com/nodejs/node/pull/60364
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-18 17:07:34 -05:00
John Kleinschmidt
fe32528c50
build: update to yarn v4 ( #48993 )
2025-11-17 16:04:51 -08:00
trop[bot]
fb62a5873a
build: correct uploader copy for tar files ( #48954 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2025-11-14 10:54:37 -05:00
trop[bot]
4c042506fe
fix: handle tar.xz files in uploaders, add to breaking changes ( #48952 )
...
* fix: handle tar.xz files in uploaders, add to breaking changes
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* docs: add additional file extension info
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-11-13 13:21:43 -08:00
trop[bot]
e2606bbe48
build: apply additional compression to dsym on upload ( #48934 )
...
build: use tar.xz compression
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-11-13 13:32:13 +01:00
trop[bot]
3397626653
build: use --keep-non-patch flag with git am ( #48807 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-11-06 12:00:07 +01:00
trop[bot]
1265eccf43
build: apply additional compression on upload ( #48777 )
...
build: apply additional compression on upload for large files
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
2025-11-04 20:04:28 +01:00
trop[bot]
4138dfeb19
chore: upgrade Node.js to v24.10.0 ( #48739 )
...
* chore: upgrade Node.js to v24.10.0
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fixup crypto patch
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fixup crypto test patch
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: prepare for v8 sandboxing
https://github.com/nodejs/node/pull/58376
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* esm: fix module.exports export on CJS modules
https://github.com/nodejs/node/pull/57366
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fixup lazyload fs patch
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* esm: Source Phase Imports for WebAssembly
https://github.com/nodejs/node/pull/56919
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* module: remove --experimental-default-type
https://github.com/nodejs/node/pull/56092
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* lib,src: refactor assert to load error source from memory
https://github.com/nodejs/node/pull/59751
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: add source location to v8::TaskRunner
https://github.com/nodejs/node/pull/54077
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: remove dependency on wrapper-descriptor-based CppHeap
https://github.com/nodejs/node/pull/54077
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: do not use soon-to-be-deprecated V8 API
https://github.com/nodejs/node/pull/53174
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: stop using deprecated fields of v8::FastApiCallbackOptions
https://github.com/nodejs/node/pull/54077
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: update v8-stats test for V8 12.6
https://github.com/nodejs/node/pull/54077
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* esm: unflag --experimental-wasm-modules
https://github.com/nodejs/node/pull/57038
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: adapt assert tests to stack trace changes
https://github.com/nodejs/node/pull/58070
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src,test: unregister the isolate after disposal and before freeing
https://github.com/nodejs/node/pull/58070
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: use cppgc to manage ContextifyContext
https://github.com/nodejs/node/pull/56522
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: replace uses of FastApiTypedArray
https://github.com/nodejs/node/pull/58070
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* module: integrate TypeScript into compile cache
https://github.com/nodejs/node/pull/56629
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* deps: update ada to 3.2.7
https://github.com/nodejs/node/pull/59336
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: make minor cleanups in encoding_binding.cc
https://github.com/nodejs/node/pull/57448
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: switch from `Get/SetPrototype` to `Get/SetPrototypeV2`
https://github.com/nodejs/node/pull/55453
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: use non-deprecated Get/SetPrototype methods
https://github.com/nodejs/node/pull/59671
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: simplify string_bytes with views
https://github.com/nodejs/node/pull/54876
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: improve utf8 string generation performance
https://github.com/nodejs/node/pull/54873
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: use non-deprecated Utf8LengthV2() method
https://github.com/nodejs/node/pull/58070
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: use non-deprecated WriteUtf8V2() method
https://github.com/nodejs/node/pull/58070
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: refactor WriteUCS2 and remove flags argument
https://github.com/nodejs/node/pull/58163
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: use String::WriteV2() in TwoByteValue
https://github.com/nodejs/node/pull/58164
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* node-api: use WriteV2 in napi_get_value_string_utf16
https://github.com/nodejs/node/pull/58165
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* node-api: use WriteOneByteV2 in napi_get_value_string_latin1
https://github.com/nodejs/node/pull/58325
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: migrate WriteOneByte to WriteOneByteV2
https://github.com/nodejs/node/pull/59634
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fs: introduce dirent\.parentPath
https://github.com/nodejs/node/pull/50976
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: avoid copy by using std::views::keys
https://github.com/nodejs/node/pull/56080
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fixup patch indices
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: errant use of context->GetIsolate()
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: tweak BoringSSL compat patch for new changes
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: add back missing isolate dtor declaration
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fixup! esm: fix module.exports export on CJS modules
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* cli: remove --no-experimental-fetch flag
https://github.com/nodejs/node/pull/52611/files
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* esm: Source Phase Imports for WebAssembly
https://github.com/nodejs/node/pull/56919
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fixup! src: prepare for v8 sandboxing
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: bump @types/node to v24
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fix const assignment in crypto test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: sandbox pointer patch issues
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: rework source phase import patch
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: add percentage support to --max-old-space-size
https://github.com/nodejs/node/pull/59082
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fixup crypto tests
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: HostImportModuleWithPhaseDynamically todo
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: cjs esm failures
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: v8::Object::Wrappable issues
- b72a615754490bac24964896a0dd69shelley.vohr@gmail.com >
* chore: remove deleted specs
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: use v8::ExternalMemoryAccounter
https://github.com/nodejs/node/pull/58070
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fs: port SonicBoom module to fs module as FastUtf8Stream
https://github.com/nodejs/node/pull/58897
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: tweak sandboxed pr patch
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: disable parallel/test-os-checked-function
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: use WHATWG URL instead of url.parse
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: OPENSSL_secure_zalloc doesn't work in BoringSSL
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fix accidental extra line
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* 7017517: [defer-import-eval] Parse import defer syntax
https://chromium-review.googlesource.com/c/v8/v8/+/7017517
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-04 09:52:30 +01:00
syntax.sculptor
21dfa8c732
fix: use correct signal variable in nan-spec-runner install check ( #48639 )
...
The install process spawn was not capturing its own signal variable,
causing the error check to incorrectly reference the build signal
instead. This could lead to:
- Install termination by signal going undetected
- False positive errors when build was killed but install succeeded
This commit ensures the install signal is properly captured and
checked, matching the pattern used for the build process.
2025-10-28 11:18:47 -04:00
Erick Zhao
297319f931
ci: use <sup> in release notes generator ( #48690 )
2025-10-28 09:06:23 +01:00
Ruben R
00e01e0e82
fix: remove killed check to allow multiple signals ( #40667 )
...
* fix: remove `killed` check to allow multiple signals
* fix: signal forwarding
2025-10-23 15:20:04 -04:00
Calvin
418b8235bc
chore: bump nan to 2.23.0 ( #48591 )
...
* chore: bump nan to 2.23.0
* Fix C++ flags passed to C compiler in NAN spec runner
Passing C++-specific flags to the C compiler caused failures building native test modules.
NAN uprgaded the version of node-gyp it uses, triggering a new codepath with the C compiler that didn't occur before. In that new branch, the C++ flags present in the CFLAGS environment variable we were passing in caused the C compiler to error out:
```
error: invalid argument '-std=c++20' not allowed with 'C'
```
The fix is to only pass C++-specific flags to the C++ compiler, and not the C compiler. This is done by separating out the CFLAGS and CXXFLAGS environment variables in our nan-spec-runner.js script.
I'm curious to know more about why each of these flags are necessary, but for now this change restores the previous behavior where native test modules could be built successfully.
* test: use v8 version check instead of node version check (patch)
* Re-enable `methodswithdata-test`
2025-10-23 20:58:40 +02:00
John Kleinschmidt
2a0c368105
build: use one build target ( #48527 )
...
This reverts commit Optimizes our builds for use with siso/avoids file contention on Windows
2025-10-20 15:57:50 -04:00
お餅のCreeeper
9b740594fb
fix: enable shader-f16 on windows ( #48342 )
...
* fix: Enable shader-f16 on Windows
* fix: include dxil.dll and dxcompiler.dll for windows x64 and arm64
* fix: modified to follow the chromium dawn build configuration
* fix: include dxil.dll and dxcompiler.dll for windows x86
* fix: Modified to avoid explicitly specifying dawn_use_built_dxc
2025-10-14 15:46:12 +02:00
Samuel Attard
52929c93db
build: fail publish when upload fatal errors ( #48537 )
...
We logged a fatal error but didn't exit with code 1 so the publish kept going. This was caught by a sanity check later down the release process but would have been quicker to fail out here.
Also adds some code to maybe workaround the underlying auth error
2025-10-13 12:53:52 +02:00
David Sanders
cbf5c3331f
ci: fix release branch name in build stats script ( #48533 )
2025-10-10 22:28:09 -07:00
David Sanders
3359f90389
ci: upload build effective cache hit rate stats to Datadog ( #48509 )
2025-10-10 19:55:21 -07:00
Samuel Attard
a95180e080
build: add missing copied tarball to cloudstore paths ( #48408 )
...
It's guarunteed that `iojs-*` and `node-*` were the same origin file (we azcopy them) but this was missing in logs and it annoyed me
2025-09-29 11:16:39 -07:00
John Kleinschmidt
b51e82c5fb
test: rerun failed tests individually ( #48205 )
...
* test: rerun failed tests individually
* ci: use screencapture-nag-remover
Needed to bypass the popup message "bash" is requesting to bypass the system private window picker and directly access your screen and audio.
* Revert "chore: test with 1st quadrant of the window"
No longer needed because of the addition of the
screencapture-nag-remover script.
This reverts commit f4a7e04c0b
2025-09-24 13:35:14 -07:00
electron-roller[bot]
1f322ebce3
chore: bump node to v22.19.0 (main) ( #48222 )
...
* chore: bump node in DEPS to v22.19.0
* chore: fixup patch indices
* crypto: add tls.setDefaultCACertificates()
https://github.com/nodejs/node/pull/58822
* esm: js-string Wasm builtins in ESM Integration
https://github.com/nodejs/node/pull/59179
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-09-05 17:16:45 -04:00
David Sanders
cca55117e4
build: refactor Linux binary stripping to align with upstream ( #47932 )
2025-08-27 18:56:31 -07:00
Samuel Attard
a67aad0f50
build: use siso instead of reclient ( #47534 )
2025-08-22 14:17:02 -04:00
David Sanders
8769d5ba9e
build: check zip manifest for chromedriver.zip ( #47972 )
2025-08-06 20:04:19 -04:00
electron-roller[bot]
40cdfdb1d1
chore: bump node to v22.18.0 (main) ( #47937 )
...
* chore: bump node in DEPS to v22.18.0
* crypto: fix inclusion of OPENSSL_IS_BORINGSSL define
https://github.com/nodejs/node/pull/58845
* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4
https://github.com/nodejs/node/pull/58960
* permission: propagate permission model flags on spawn
https://github.com/nodejs/node/pull/58853
* esm: syncify default path of ModuleLoader\.load
https://github.com/nodejs/node/pull/57419
* src: remove fast API for InternalModuleStat
https://github.com/nodejs/node/pull/58489
* src: simplify adding fast APIs to ExternalReferenceRegistry
https://github.com/nodejs/node/pull/58896/
* chore: fixup patch indices
* src: fix internalModuleStat v8 fast path
https://github.com/nodejs/node/pull/58054
* test: add tests to ensure that node.1 is kept in sync with cli.md
https://github.com/nodejs/node/pull/58878
* crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4
https://github.com/nodejs/node/pull/58942
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-08-04 14:40:36 -04:00
electron-roller[bot]
03aad28412
chore: bump chromium to 140.0.7327.0 (main) ( #47902 )
...
* chore: bump chromium in DEPS to 140.0.7324.0
* chore: bump chromium in DEPS to 140.0.7325.0
* chore: remove @dsanders11's unused include patch
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6782507
* fix: apply keychain patch to new apple subdir
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6736212
* chore: update chromium patches
* chore: update other patches
* chore: bump chromium in DEPS to 140.0.7327.0
* fix: mistake in reapplied patch
* fixup! fix: apply keychain patch to new apple subdir CL: https://chromium-review.googlesource.com/c/chromium/src/+/6736212
* chore: update patches
* fix: remove OnPrivateNetworkAccessPermissionRequired override
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6769208
* fix: update colorSpace property to use new unified value
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6795085
* fix: include OverlayWindowLiveCaptionButton
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6787420
* fixup! fix: apply keychain patch to new apple subdir CL: https://chromium-review.googlesource.com/c/chromium/src/+/6736212
* fix: format chromium_src/BUILD.gn
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6787427
* fix: format BUILD.gn
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6787427
* chore: include script/ in logged path
* fix: update filenames.libcxx.gni
CL: https://chromium-review.googlesource.com/c/chromium/src/+/6787279
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-07-31 18:11:00 -04:00
Shelley Vohr
4699761649
build: improve check-zip-manifest ( #47828 )
...
* build: improve check-zip-manifest
* fix: unicode on Windows
2025-07-21 15:20:27 -04:00
electron-roller[bot]
26e1bda335
chore: bump chromium to 140.0.7301.0 (main) ( #47747 )
...
* chore: bump chromium in DEPS to 140.0.7296.0
* chore: update patches
* 6702959: Remove OwnedByWidgetPassKey usage from content analysis dialog tests | https://chromium-review.googlesource.com/c/chromium/src/+/6702959
* 6722750: Remove un-used `stream_id` argument for `AidaCodeComplete` | https://chromium-review.googlesource.com/c/chromium/src/+/6722750
* 6696478: Reland Reland [video pip] Add fade in/out animation to controls visibility changes | https://chromium-review.googlesource.com/c/chromium/src/+/6696478
* chore: update libc++-filenames
* build: explicitly include cstdlib in Boyer-Moore patch
* chore: bump chromium in DEPS to 140.0.7297.0
* chore: update patches
* 6729537: [FPF] Pipe flag state from the browser to the renderer | https://chromium-review.googlesource.com/c/chromium/src/+/6729537
* 6727996: [Win] Detect pre-IPC crashes in sandboxed utility processes | https://chromium-review.googlesource.com/c/chromium/src/+/6727996
* 6707182: Move wtf/cross_thread_copier*.* to "blink" namespace | https://chromium-review.googlesource.com/c/chromium/src/+/6707182
* 6730796: extensions: Extract safe browsing/telemetry methods to new client class | https://chromium-review.googlesource.com/c/chromium/src/+/6730796
* chore: bump chromium in DEPS to 140.0.7299.0
* chore: update patches
* chore: update main patches
* build: reset the minimum macOS SDK to 15 to match upstream
This reverts commit 499e987c77https://chromium-review.googlesource.com/c/chromium/src/+/6730215
* 6690442: Delete ppapi/buildflags/buildflags.h | https://chromium-review.googlesource.com/c/chromium/src/+/6690442
* [wip]: 6667681: Use more binaries from clang toolchain in mac build | https://chromium-review.googlesource.com/c/chromium/src/+/6667681
* chore: bump chromium in DEPS to 140.0.7301.0
* chore: update patches
* 6656309: extensions: Port proxy API to desktop Android | https://chromium-review.googlesource.com/c/chromium/src/+/6656309
* 6758510: Reland 'Move GN enable_plugins variable out of //ppapi' | https://chromium-review.googlesource.com/c/chromium/src/+/6758510
* 6701466: [Extensions] Remove NaCl arch info from Update Client URLs | https://chromium-review.googlesource.com/c/chromium/src/+/6701466
* 6735979: [FSA] Replace `request_writable` with a new enum `FileSystemAccessPermissionMode`. | https://chromium-review.googlesource.com/c/chromium/src/+/6735979
* 6712080: Reland "Turn on gender translation PAK generation everywhere" | https://chromium-review.googlesource.com/c/chromium/src/+/6712080
* 6730796: extensions: Extract safe browsing/telemetry methods to new client class | https://chromium-review.googlesource.com/c/chromium/src/+/6730796
* build: restore minimum macOS SDK to 10, restore patch
This reverts commit a04c579b99https://chromium-review.googlesource.com/c/chromium/src/+/6701466
* chore: correct node patches
* fixup! 6667681: Use more binaries from clang toolchain in mac build | https://chromium-review.googlesource.com/c/chromium/src/+/6667681
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
2025-07-21 09:32:53 -07:00
Shelley Vohr
a9504abde9
build: roll sysroots ( #47710 )
2025-07-14 11:27:19 -04:00
