Bug-Reaper
99fce5b6ca
fix: address upstream Chromium shift to enable CoreAudio Tap API for audio capture used in electron's desktopCapturer ( 🍏 macOS). ( #49717 )
...
* fix: Enable CoreAudio Tap API for Audio Capture (🍏 macOS)
* fix: addressed markdown issue which caused pre-commit hook failure
🧑🔧 : Ref : https://github.com/electron/electron/pull/49717#issuecomment-3874660013
* fix: updated docs to cover `desktopCapturer` nuances with macOS
📝 : PR https://github.com/electron/electron/pull/49717
2026-02-10 15:06:21 +01:00
Samuel Attard
60d35bbaf4
feat: add support for disclaiming utility processes ( #49128 )
...
* feat: add support for disclaiming utility processes
* chore: update patches
---------
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2026-02-05 14:37:24 -08:00
Keeley Hammond
59e434a27f
refactor: use ComPtr pattern for MSIX to avoid exception handling ( #49645 )
...
* Revert "fix: fix Windows MSIX release build errors (#49613 )"
This reverts commit 4b5d5f9dd5 .
* refactor: use WRL ComPtr pattern for MSIX to avoid exception handling
The MSIX auto-updater code was using C++/WinRT (winrt::* namespace), which requires exception handling (/EHsc). Mixing exception and non-exception handling code in the same binary is problematic at runtime. This commit refactors electron_api_msix_updater.cc to use an upstream Chromium pattern and eliminates the need for special exception handling build flags
* build: import correct packages
* build: consolidate IPackage declarations
* refactor: use IPackageManager/IPackageManager5/IPackageManager9 and
IPackage/IPackage2/IPackage4/IPackage6 interfaces as needed for
different API methods.
Also consolidates duplicate completion handler logic, fixes a bug in
RegisterRestartOnUpdate where the command line string could go out of
scope, and removes unused includes.
2026-02-05 10:42:28 -08:00
Noah Gregory
50381a6d57
refactor: don't log error just for unsigned code ( #49654 )
2026-02-05 15:26:17 +09:00
Keeley Hammond
431f77ca1c
fix: remove menu observer before destroying menu_controller_ ( #49648 )
...
* fix: remove menu observer before destroying menu_controller_
* fix: resolves private inheritance conflict
2026-02-04 16:11:00 +01:00
Shelley Vohr
8fdb7549bb
fix: alt-space should route through 'system-context-menu' ( #49619 )
...
fix: alt-space should route through system-context-menu
2026-02-03 11:34:58 -05:00
Shelley Vohr
86209f60eb
fix: possible crash in FileSystem API ( #49578 )
...
Refs https://chromium-review.googlesource.com/6880247
Fixes a crash that can arise in the File System Access API in the
following scenario:
1. Create fileHandle1 at path1.
2. Call fileHandle1.remove() or user manually delete the file.
3. Create fileHandle2 at path2.
4. fileHandle2.move(path1).
2026-02-03 15:15:54 +01:00
Mr.Chaofan
4413a0f642
fix: wrong cause and removed flag in cookie change listener ( #49103 )
2026-02-03 10:19:35 +01:00
Shelley Vohr
3776731f4a
fix: menu state in macOS dock menus ( #49574 )
2026-02-02 17:01:34 -05:00
Keeley Hammond
4b5d5f9dd5
fix: fix Windows MSIX release build errors ( #49613 )
...
* fix: fix MSIX release build
* fix: add C++/WinRT headers
* build: modify include paths
* fix: compile msix as seperate source set
* build: add additional needed deps for msix
2026-02-01 22:27:42 -08:00
axolotl
f272723a33
feat: Allow View.setBounds to animate ( #48812 )
...
* feat: allow View::SetBounds to animate
* fix: support width/height animations
* fix: jumping on subsequent animations
* fix: segfault race condition
* fix: remove layer background
* fix: layer clips not being reset
* refactor: use gfx tween gin converter
* fix: layer cleanups causing flickering views
* chore: merge artifact
* fix: missing private method in header
* fix: return type
* fix: do not set layer opacity
* refactor: update animate parameter format
* refactor: move animate into options object
* chore: typo
* docs: update
* spec: add view animation test
2026-01-30 15:18:56 -05:00
Shelley Vohr
331d1e16f5
refactor: address PathProvider TODO ( #49563 )
2026-01-30 14:16:39 -05:00
Shelley Vohr
6825a522e9
fix: duplicate fullscreen macOS menu item ( #49074 )
2026-01-30 13:23:43 -05:00
Shelley Vohr
e033c10075
fix: issues with xdg activation on Linux ( #49499 )
2026-01-30 10:53:04 -05:00
Shelley Vohr
64872a6cb8
fix: macOS menu item accelerators when item disabled ( #49553 )
...
fix: macOS menu item acceerators when item disabled
2026-01-30 10:07:16 +01:00
Jan Hannemann
d74fcfcecb
feat: msix auto-updater ( #49230 )
...
* feat: native auto updater for MSIX on Windows
* doc: added MSIX debug documentation
* fix: allow downgrade with json release file and emit update-available
* test: msix auot-update tests
* doc: API documentation
* test: add package version validation
* fix: docs typo
* fix: don't allow auto-updating when using appinstaller manifest
* fix: getPackageInfo interface implementation
* fix: review feedback, add comment
* fix: missed filename commit
* fix: install test cert on demand
* fix: time stamp mismatch in tests
* fix: feedback - rename to MSIXPackageInfo
* fix: update and reference windowsStore property
* fix: remove getPackagInfo from public API
* fix: type error bcause of removed API
2026-01-29 16:38:26 -05:00
Shelley Vohr
e6be04a7a0
fix: chrome://accessibility drift ( #49547 )
...
https://chromium-review.googlesource.com/c/chromium/src/+/6870052
2026-01-28 12:07:14 +01:00
Charles Kerr
8364b62f68
fix: potential dangling pointer in api::Screen ( #49536 )
...
fixes a regression from #49506
2026-01-27 16:27:38 -05:00
electron-roller[bot]
b847299f19
chore: bump chromium to 146.0.7650.0 (main) ( #49496 )
...
* chore: bump chromium in DEPS to 146.0.7650.0
* 7496671: WaaP: Control hung delay for Initial WebUI
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7496671
* 7494302: [//media] Rename renderable_gpu_memory_buffer_video_frame_pool*
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7494302
* chore: update patches
* 7502996: [DevTools] Add ability to toggle Chromium feature flags from DevTools
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7502996
* 7456200: Vectorize StringImpl::CopyChars and EqualIgnoringASCIICase using Highway.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7456200
* 7236627: spellcheck: supply full spelling marker info, incld. marker type
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7236627
* chore: rm dependency on wtf::string from blink public headers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7456200
added a public dependency on //third_party/highway for
//third_party/blink/renderer/platform/wtf:wtf which will not be
inherited by //content/renderer since wtf is internal dependency of
blink leading to the following compilation error
```
In file included from ../../content/public/renderer/window_features_converter.cc:5:
In file included from ../../content/public/renderer/window_features_converter.h:10:
In file included from ../../third_party/blink/public/web/web_window_features.h:38:
In file included from ../../third_party/blink/renderer/platform/wtf/text/wtf_string.h:40:
../../third_party/blink/renderer/platform/wtf/text/string_impl.h:27:10: fatal error: 'hwy/highway.h' file not found
27 | #include <hwy/highway.h>
| ^~~~~~~~~~~~~~~
1 error generated.
```
Use `gn desc out/Testing content/renderer:renderer_sources --blame`
to verify the inherited config and dependency list.
* 7493995: Restore directive part of wasm-eval error message
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7493995
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2026-01-26 11:18:09 -08:00
Charles Kerr
6766343173
refactor: simplify NativeWindow-to-BaseWindow lookup ( #49520 )
...
refactor: simplify native window to base window lookup
2026-01-26 12:28:57 +01:00
Charles Kerr
30f365d9d8
refactor: use gin::Wrappable for electron::api::PowerMonitor ( #49509 )
...
* refactor: use `gin::Wrappable` for `electron::api::PowerMonitor`
* chore: update patches
2026-01-25 22:51:31 -06:00
Charles Kerr
e8250f9955
refactor: use gin::Wrappable for electron::api::Screen ( #49506 )
2026-01-25 13:46:25 -06:00
Kyle Cutler
d5de8883a2
feat: add focusOnNavigation flag to WebPreferences ( #49425 )
...
* feat: add focusOnNavigation webPreference
* WebContentsView tests
* fix
* fix
2026-01-23 14:29:34 -05:00
Shelley Vohr
89963618d9
fix: second argument to shell.writeShortcutLink is optional ( #49476 )
...
fix: second argument to shell.writeShortcutLink is optional
2026-01-23 11:24:47 -05:00
Charles Kerr
8c5c6a6088
refactor: use gin::Wrappable for electron::api::DataPipeHolder ( #49495 )
...
* refactor: make `DataPipeHolder` inherit from `gin::Wrappable`
* test: add a test to ensure GC clears the data pipe holder
* chore: e patches all
* chore: e patches all (trivial only)
* refactor: make AllDataPipeHolders a base::flat_map of WeakPersistent
2026-01-23 20:29:01 +09:00
Charles Kerr
d76608b945
refactor: use gin::Wrappable in electron::api::PowerSaveBlocker ( #49381 )
...
* refactor: PowerSaveBlocker subclasses gin::Wrappable
* chore: update chore_add_electron_objects_to_wrappablepointertag.patch
* chore: e patches all
2026-01-22 17:31:38 -06:00
electron-roller[bot]
d689f76ff9
chore: bump chromium to 146.0.7645.0 (main) ( #49453 )
...
* chore: bump chromium in DEPS to 146.0.7643.0
* chore: bump chromium in DEPS to 146.0.7645.0
* chore: update patches
* 7402162: Refactor app shims to call ContentMain
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7402162
* 7454282: Add master key management for HTTP Cache Encryption
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7454282
* 7490440: Reland "Delete unused base::Contains()"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7490440
* chore: update patches
* 7414864: Pass CSSParserLocalContext down to CSSMathExpressionNodeParser
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7414864
* 7460969: Move child_process_id.h to common
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7460969
* 7474608: [api] Remove deprecated v8::PropertyCallbackInfo<T>::This()
Refs https://chromium-review.googlesource.com/c/v8/v8/+/7474608
* 7461067: [Viz] Rename kPreferGpuMemoryBuffer
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7461067
* 7487174: Remove GLHelper
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7487174
* 7457538: Set timeout from multi source page context fetcher
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7457538
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2026-01-22 17:01:09 -05:00
reito
e3142865b2
fix: offscreen rendering with correct screen info. ( #48730 )
...
fix: osr use correct screen info.
2026-01-22 14:58:54 -05:00
Shelley Vohr
bad88c6ed4
fix: potential devtools crash on empty ( #49468 )
2026-01-21 17:05:26 -08:00
Noah Gregory
534cb33465
fix: return early from platform_util::Beep() on Linux if there is no default GDK display ( #49442 )
...
fix: return early from beep on linux if there is no default gdk display
2026-01-21 15:55:24 -05:00
Shelley Vohr
49d91dd02b
revert: use deprecated setAllowedFileTypes in macOS dialogs ( #49444 )
...
* revert: use deprectated setAllowedFileTypes in macOS dialogs
Closes https://github.com/electron/electron/issues/48191
* chore: remove stray import
2026-01-21 13:08:04 +01:00
David Franco
2f20d287d1
feat: import shared texture supports p010le ( #49272 )
...
feat: import shared texture supports p010le.
2026-01-20 11:50:30 +01:00
electron-roller[bot]
486a9a61d2
chore: bump chromium to 146.0.7635.0 (main) ( #49408 )
...
* chore: bump chromium in DEPS to 146.0.7635.0
* chore: update patch hunk headers
* 7078551: [wasm] Refactor caching API
https://chromium-review.googlesource.com/c/v8/v8/+/7078551
* 7141498: [api] Remove unused context parameter from FixedArray::Get
https://chromium-review.googlesource.com/c/v8/v8/+/7141498
* 7454865: Add timeouts to content API for CopyFromSurface
https://chromium-review.googlesource.com/c/chromium/src/+/7454865
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-01-19 15:37:02 +01:00
Shelley Vohr
5bd2938f6a
fix: try clearing InspectableWebContents delegate earlier ( #49406 )
...
fix: try clearing InspectableWebContents delegate earlier
2026-01-16 21:36:34 +01:00
Daniel Gräfe
5dd509d2f4
fix: restore AXDocument accessibility attribute for representedFilename on macOS ( #49346 )
...
Starting from Chromium 134.0.6989.0 (Electron 35.0.0-beta.5), the
NativeWidgetMacNSWindow class overrides accessibilityDocument to return
the web content URL from the accessibility tree, but doesn't fall back
to NSWindow's default behavior when that URL is empty.
This broke Electron's setRepresentedFilename() API - the file path was
still set on the NSWindow, but no longer exposed via the AXDocument
accessibility attribute that screen readers use.
This fix adds an accessibilityDocument override in ElectronNSWindow that
checks representedFilename first, falling back to Chromium's behavior
for web content URLs.
Fixes: https://github.com/electron/electron/issues/XXXXX
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com >
2026-01-16 10:27:29 +01:00
Alex Schwartz
bdd7730a24
fix: make toplevel icon Wayland protocol work ( #49290 )
2026-01-16 09:55:52 +01:00
Charles Kerr
c769361af2
fix: warning: default arguments on virtual or override methods ( #49398 )
...
fix: warning: default arguments on virtual or override methods are prohibited [google-default-arguments]
we never override these, so just make them nonvirtual
2026-01-15 16:09:43 -08:00
electron-roller[bot]
6ea7d6d5a4
chore: bump chromium to 146.0.7633.0 (main) ( #49390 )
...
* chore: bump chromium in DEPS to 146.0.7633.0
* chore: fixup patch indices
* chore: fix unsafe buffer usage in browser_linux.cc
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-01-15 10:52:42 -05:00
Charles Kerr
ddeb970f18
refactor: make ReplyChannel inherit from gin::Wrappable ( #49339 )
...
* refactor: make ReplyChannel inherit from gin::Wrappable
* chore: add kElectronReplyChannel to chore_add_electron_objects_to_wrappablepointertag.patch
* fix: use gin::PerIsolateData::DisposeObserver
* fix: lifetime issues
* chore: rm perisolatedata hook in favor of prefinalizer
---------
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2026-01-14 18:35:01 -06:00
electron-roller[bot]
5d80264944
chore: bump chromium to 145.0.7628.0 (main) ( #49331 )
...
* chore: bump chromium in DEPS to 145.0.7620.0
* chore: bump chromium in DEPS to 145.0.7622.0
* chore: bump chromium in DEPS to 145.0.7624.0
* chore: bump chromium in DEPS to 145.0.7626.0
* chore: bump chromium in DEPS to 145.0.7628.0
* 7362759: Migrate various base::Contains() to contains() in ui | https://chromium-review.googlesource.com/c/chromium/src/+/7362759
* chore: update patches
* 7411324: url: Mark deprecated functions as UNSAFE_BUFFER_USAGE
https://chromium-review.googlesource.com/c/chromium/src/+/7411324
* 7366867: Store property info in CSSParserLocalContext for random()
https://chromium-review.googlesource.com/c/chromium/src/+/7366867
* 7277406: Exclude PiP from getDisplayMedia picker thumbnails
https://chromium-review.googlesource.com/c/chromium/src/+/7277406
* 7253489: activity_reporter: Create stub module owned by browser_process
https://chromium-review.googlesource.com/c/chromium/src/+/7253489
* 7404514: Create device parental controls delegate
https://chromium-review.googlesource.com/c/chromium/src/+/7404514
* 7269504: Update histograms to use the updated MediaStreamRequestResult enum
https://chromium-review.googlesource.com/c/chromium/src/+/7269504
* fixup! 7253489: activity_reporter: Create stub module owned by browser_process
* 7368549: Reland "Use native rollup"
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7368549
* 4803165: Enable suppressing input event dispatch while paint-holding.
https://chromium-review.googlesource.com/c/chromium/src/+/4803165
* chore: make device_parental_controls lazy
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-01-14 15:34:24 +01:00
Keeley Hammond
1b2679b315
fix: revert os_crypt async cookie provider implementation ( #49382 )
...
* Revert "fix: provide explicit cookie encryption provider for cookie encryption (#49348 )"
This reverts commit 95f097a392 .
* Revert "fix: fix cookie encryption provider loading on Windows and Linux (#49371 )"
This reverts commit 0e4ee9f03a .
* revert: 6996667: Reland "Port net::CookieCryptoDelegate to os_crypt async" | https://chromium-review.googlesource.com/c/chromium/src/+/6996667
2026-01-14 09:34:00 +01:00
Keeley Hammond
0e4ee9f03a
fix: fix cookie encryption provider loading on Windows and Linux ( #49371 )
...
* fix: support cookie encryption provider cross-platform
* fix: add async macos key provider
2026-01-12 19:39:29 -08:00
Charles Kerr
ae94cefdba
refactor: add static ReplyChannel::SendError() helper ( #49338 )
...
* refactor: add static void ReplyChannel::SendError()
* refactor: use static SendError() instead of instantiating a temporary
* refactor: remove non-static version of SendError()
* refactor: remove redundant callback-is-non-null checks
2026-01-12 17:02:58 -06:00
Calvin
9a5ffd920c
feat: suppress devtools console logging ( #49292 )
...
* feat: suppress devtools console logging
* Emit messages as-is in testing builds
* Promote `DCHECK_IS_ON()` to preprocessor check
2026-01-12 11:31:33 +01:00
Charles Kerr
cf2e283332
fix: clang-tidy warnings, pt. 1 ( #49083 )
...
* fix: google-readability-casting warning about the uint32_t cast
* fix: modernize-use-equals-default warnings
* fix: readability-redundant-member-init warning
* fix: modernize-make-unique warnings
* fix: modernize-use-emplace
warning: use emplace_back instead of push_back
* refactor: address code review feedback
2026-01-09 22:57:38 -08:00
Keeley Hammond
95f097a392
fix: provide explicit cookie encryption provider for cookie encryption ( #49348 )
...
fix: provide explicit cookie encryption provider
Fixes 6996667: Reland "Port net::CookieCryptoDelegate to os_crypt async" | https://chromium-review.googlesource.com/c/chromium/src/+/6996667
2026-01-09 11:53:58 -08:00
Charles Kerr
b5a7d81c7d
refactor: have GetXdgAppId() return a std::optional<std::string> ( #49318 )
...
* refactor: GetXdgAppId() now returns std::optional<std::string>
* refactor: slightly simplify app.setDesktopName() ts calls
* refactor: add better documentation for dekstop-entry in XDG notifications
2026-01-07 14:30:09 -05:00
electron-roller[bot]
a1f0ef80d4
chore: bump chromium to 145.0.7616.0 (main) ( #49279 )
...
* chore: bump chromium in DEPS to 145.0.7605.0
* chore: bump chromium in DEPS to 145.0.7606.0
* chore: bump chromium in DEPS to 145.0.7608.0
* chore: update patches
* chore: bump chromium in DEPS to 145.0.7610.0
* chore: update patches
* [InputVizard] Fix missing touch cancel in InputTransferHandlerAndroid
using InputEventSource
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7302368
* chore: bump chromium in DEPS to 145.0.7611.0
* chore: update patches
* chore: bump chromium in DEPS to 145.0.7614.0
* chore: bump chromium in DEPS to 145.0.7615.0
* chore: update patches
* chore: bump chromium in DEPS to 145.0.7616.0
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2026-01-05 13:34:36 -05:00
Calvin
46922de638
fix: drag regions in child windows ( #49231 )
...
* fix: drag regions in child windows
* Update comments
2026-01-05 10:34:01 -05:00
electron-roller[bot]
9eb43f3286
chore: bump chromium to 145.0.7604.0 (main) ( #49265 )
...
* chore: bump chromium in DEPS to 145.0.7599.0
* chore: bump chromium in DEPS to 145.0.7600.0
* chore: bump chromium in DEPS to 145.0.7602.0
* chore: bump chromium in DEPS to 145.0.7604.0
* chore: update patches (trivial only)
* [bytesize] Migrate network data in Task Manager to ByteSize.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/7266090
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-12-28 20:40:50 -08:00