5 Commits

Author	SHA1	Message	Date
Cheng Zhao	cb6a1e2c5e	fix: set default menu in will-finish-launching event (#23214)	2020-04-23 10:51:31 -07:00
Samuel Attard	5d657dece4	build: enable JS semicolons (#22783)	2020-03-20 13:28:31 -07:00
Cheng Zhao	47e27aee5b	test: no need to loadURL in menu test (#22737)	2020-03-19 10:49:40 +09:00
Charles Kerr	c83f836faf	refactor: prefer using app.whenReady() (#21972) ... * docs: add references to app.whenReady() in isReady * refactor: prefer app.whenReady() In the docs, specs, and lib, replace instances of `app.once('ready')` (seen occasionally) and `app.on('ready')` (extremely common) with `app.whenReady()`. It's better to encourage users to use whenReady(): 1. it handles the edge case of registering for 'ready' after it's fired 2. it avoids the minor wart of leaving an active listener alive for an event that wll never fire again	2020-02-03 22:43:22 +00:00
Cheng Zhao	3cb0ed306b	fix: hiding window menu should work on startup (#21436) ... * fix: menu visibility should not be overwritten on startup * fix: removing menu for window without global menubar * test: setMenu tests are not for mac	2019-12-09 11:17:36 -08:00