* Use std::forward_list instead of base::LinkedList for better perf,
more consistent memory management. Better than std::list because we
don't need the double-linked-list behavior of std::list
* Use std::unordered_map instead of std::map for the v8 hash table
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
base::LinkedList does not delete its members on destruction. We need to
manually ensure the linkedlist is empty when the ObjectCache is
destroyed.
Fixes#27039
Notes: Fixed memory leak when sending non-primitives over the context
bridge
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
* feat: add worldSafe flag for executeJS results
* chore: do not log warning for webContents.executeJS
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* chore: apply PR feedback
* chore: split logic a bit
* chore: allow primitives through the world safe checl
* chore: clean up per PR feedback
* chore: flip boolean logic
* chore: update per PR feedback
* chore: fix typo
* chore: fix spec
* Update web-frame.ts
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
* chore: bump chromium in DEPS to 85.0.4165.1
* chore: bump chromium in DEPS to 85.0.4166.1
* chore: bump chromium in DEPS to 85.0.4166.2
* chore: bump chromium in DEPS to 85.0.4166.3
* update patches
* fixup! Revert "[printing] Mojofy PrintHostMsg_CheckForCancel"
(cherry picked from commit 2cc1caf5d7d716ceefb23d5228a79544a2e91206)
* update patches
* Revert "[printing] Mojofy PrintHostMsg_CheckForCancel"
(cherry picked from commit c2b389957836ad77eb8e977872e6a8590666f3da)
* Remove WebImeTextSpan
https://chromium-review.googlesource.com/c/chromium/src/+/2225240
(cherry picked from commit d839261d71b156c972d3878f16f971e6b6d98f45)
* Remove PDFAnnotations flag altogether.
https://chromium-review.googlesource.com/c/chromium/src/+/2229317
(cherry picked from commit 50384ed12602d4a9da3209eacfca4faae78f9986)
* Rework find-from-selection so it's synchronous -- fixes flaky tests
https://chromium-review.googlesource.com/c/chromium/src/+/2181570
(cherry picked from commit 3e9241560390fb18969393beda425afc63f5a151)
* Use ExtensionSystem::is_ready() instead of ExtensionService::is_ready()
https://chromium-review.googlesource.com/c/chromium/src/+/2207499
(cherry picked from commit 2424589454a9a2ef9cc89c232b4ee87b0bf400cc)
* update sysroots
(cherry picked from commit b5ea653e602152dde00303d1cfb915d4df320983)
* chore: bump chromium in DEPS to 85.0.4167.1
* Take RFH as a parameter for DidUpdateFavicon/ManifestURL
https://chromium-review.googlesource.com/c/chromium/src/+/2224745
(cherry picked from commit ad40668221732e28bcc8b9b270ab4686c42e956a)
* update patches
* update patches
* Rename net::cookie_util::StripStatuses to StripAccessResults
https://chromium-review.googlesource.com/c/chromium/src/+/2212697
(cherry picked from commit bf3de1fe1cbb17feb46b40c81f0eb13b1e7b6412)
* use net::CookieAccessResultList instead of net::CookieAccessResultList
(cherry picked from commit 400da79504da2310b7c1177b4b3f9f83a3f2b305)
* chore: bump chromium in DEPS to 85.0.4168.1
* fix mas_no_private_api patch
https://chromium-review.googlesource.com/c/chromium/src/+/2230281
(cherry picked from commit 9b127147e0ba7ef1d4454099effe49327b1a5ab6)
* Update patches
* fix: add new navigation state REUSE_SITE_INSTANCE
To fix the new set of state checks added in
https://chromium-review.googlesource.com/c/chromium/src/+/2215141
(cherry picked from commit 3a91b684efdc7742e7c5efa65263f80e8a24ec4a)
* chore: bump chromium in DEPS to 85.0.4169.1
* update patches
* chore: bump chromium in DEPS to 85.0.4170.1
* chore: bump chromium in DEPS to 85.0.4171.1
* chore: bump chromium in DEPS to 85.0.4172.1
* chore: bump chromium in DEPS to 85.0.4173.1
* chore: bump chromium in DEPS to 85.0.4174.1
* chore: bump chromium in DEPS to 85.0.4175.3
* chore: bump chromium in DEPS to 85.0.4176.1
* chore: bump chromium in DEPS to 85.0.4177.2
* chore: bump chromium in DEPS to 85.0.4178.1
* chore: bump chromium in DEPS to 85.0.4178.3
* refactor: MessageLoop, you are terminated \o/
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2246173
(cherry picked from commit 0368131d60)
* chore: bump chromium in DEPS to 85.0.4178.4
* update patches
* update lib_src_switch_buffer_kmaxlength_to_size_t.patch
(cherry picked from commit c5efbdd166)
* [v8] Allow for 4GB TypedArrays
https: //chromium-review.googlesource.com/c/v8/v8/+/2249668
(cherry picked from commit 2c1d6bfd9d)
Co-Authored-By: Robo <hop2deep@gmail.com>
* Cleanup usages of old mojo types and remove unused code
https://chromium-review.googlesource.com/c/chromium/src/+/2235699
(cherry picked from commit e89cb21e8e)
* refactor: plumb DownloadSchedule to DownloadItem
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2242202
(cherry picked from commit 4d549ae2b0)
* chore: fix variable typo in IPC
(cherry picked from commit 7251b1e6c5)
* chore: s/BindPipeAndPassReceiver/BindNewPipeAndPassReceiver
(cherry picked from commit e89bd6c639)
* chore: XEvent becomes x11::Event
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2240355
(cherry picked from commit 4d832da740)
* fixup! refactor: MessageLoop, you are terminated \o/
(cherry picked from commit 902d72d740)
* fixup! chore: XEvent becomes x11::Event
(cherry picked from commit 27043549f3)
* chore: fix windows build
(cherry picked from commit 4977098eb3)
* chore: disable SameSite-by-default changes
https://chromium-review.googlesource.com/c/chromium/src/+/2231445
(cherry picked from commit d8318aafff)
* update printing.patch
(cherry picked from commit e2037f527f)
* Convert WidgetHostMsg_SelectionBoundsChanged/TextInputStateChanged
https://chromium-review.googlesource.com/c/chromium/src/+/2243531
(cherry picked from commit 60ff2e067d)
* [XProto] Replace usages of XID and ::Window with x11::Window
https://chromium-review.googlesource.com/c/chromium/src/+/2249389
(cherry picked from commit 97f5b59e06)
* Update VideoFrameMetadata to use base::Optionals
https://chromium-review.googlesource.com/c/chromium/src/+/2231706https://chromium-review.googlesource.com/c/chromium/src/+/2238361
(cherry picked from commit 4787e1f541)
* --disable-dev-shm-usage for gpu process crash
(cherry picked from commit 207d8a380a)
* update patches
* fixup: Cleanup usages of old mojo types and remove unused code
* update patches
* chore: bump chromium in DEPS to 85.0.4180.1
* build: update v8 headers
(cherry picked from commit 4808975f75)
* Update patches
* fixup: build: update v8 headers
* Fixup ssl_security_state_tab_helper.patch
* Add missing headers
* Adds icon loading service with sandbox for Windows.
https://chromium-review.googlesource.com/c/chromium/src/+/1987273
* disable app.getGPUInfo spec on linux
(cherry picked from commit b7ea16c4b7)
* Add missing headers for Linux and Windows
* Fixup Adds icon loading service with sandbox for Windows
* chore: bump chromium in DEPS to 85.0.4181.1
* update patches
* Fixup: (for real) Adds icon loading service with sandbox for Windows
* No more Vulkan info collection for UMA on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/2252818
* extensions: Rename SharedUserScriptMaster to SharedUserScriptManager
https://chromium-review.googlesource.com/c/chromium/src/+/2258357
* Add missing headers
* fixup: extensions: Rename SharedUserScriptMaster to SharedUserScriptManager
* fixup: No more Vulkan info collection for UMA on Windows
* Add missing header
* Add resource for IDS_UTILITY_PROCESS_UTILITY_WIN_NAME
* fix build on windows
* fix gn check
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
* refactor: port window.open and window.opener to use ctx bridge instead of hole punching
* refactor: only run the isolated init bundle when webview is enabled
* fix(extensions): set lowest isolated world id
* refactor: move world IDs into separate header file
Several files are including electron_render_frame_observer.h just for the world IDs.
* refactor: use gin in Promise
* refactor: separate Promise impl that returns nothing
* refactor: use Promise<void> for promise that returns nothing
* fix: methods should be able to run on both browser and renderer process
* fix: should not pass base::StringPiece across threads
* refactor: no more need to use different ResolvePromise for empty Promise
* refactor: move Promise to gin_helper
* refactor: remove a few uses of native_mate/gfx_converter.h
* refactor: deprecate mate::EventEmitter
* refactor: add gin_helper::EventEmitter
* refactor: convert a few classes to use gin_helper::EventEmitter
* refactor: get rid of native_mate_converters/gfx_converter.h
* fix: follow native_mate on reporting errors
* fix: gin is weak at guessing parameter types
* fix: incorrect full class name
* fix: gin::Handle does not accept null
* feat: add a new contextBridge module
* chore: fix docs linting
* feat: add support for function arguments being proxied
* chore: ensure that contextBridge can only be used when contextIsolation is enabled
* docs: getReverseBinding can be null
* docs: fix broken links in md file
* feat: add support for promises in function parameters
* fix: linting failure for explicit constructor
* Update atom_api_context_bridge.cc
* chore: update docs and API design as per feedback
* refactor: remove reverse bindings and handle GC'able functions across the bridge
* chore: only expose debugGC in testing builds
* fix: do not proxy promises as objects
* spec: add complete spec coverage for contextBridge
* spec: add tests for null/undefined and the anti-overwrite logic
* chore: fix linting
* spec: add complex nested back-and-forth function calling
* fix: expose contextBridge in sandboxed renderers
* refactor: improve security of default_app using the new contextBridge module
* s/bindAPIInMainWorld/exposeInMainWorld
* chore: sorry for this commit, its a big one, I fixed like everything and refactored a lot
* chore: remove PassedValueCache as it is unused now
Values transferred from context A to context B are now cachde in the RenderFramePersistenceStore
* chore: move to anonymous namespace
* refactor: remove PassValueToOtherContextWithCache
* chore: remove commented unused code blocks
* chore: remove .only
* chore: remote commented code
* refactor: extract RenderFramePersistenceStore
* spec: ensure it works with numbered keys
* fix: handle number keys correctly
* fix: sort out the linter
* spec: update default_app asar spec for removed file
* refactor: change signatures to return v8 objects directly rather than the mate dictionary handle
* refactor: use the v8 serializer to support cloneable buffers and other object types
* chore: fix linting
* fix: handle hash collisions with a linked list in the map
* fix: enforce a recursion limit on the context bridge
* chore: fix linting
* chore: remove TODO
* chore: adapt for PR feedback
* chore: remove .only
* chore: clean up docs and clean up the proxy map when objects are released
* chore: ensure we cache object values that are cloned through the V8 serializer
* refactor: use v8 serialization for ipc
* cloning process.env doesn't work
* serialize host objects by enumerating key/values
* new serialization can handle NaN, Infinity, and undefined correctly
* can't allocate v8 objects during GC
* backport microtasks fix
* fix compile
* fix node_stream_loader reentrancy
* update subframe spec to expect undefined instead of null
* write undefined instead of crashing when serializing host objects
* fix webview spec
* fix download spec
* buffers are transformed into uint8arrays
* can't serialize promises
* fix chrome.i18n.getMessage
* fix devtools tests
* fix zoom test
* fix debug build
* fix lint
* update ipcRenderer tests
* fix printToPDF test
* update patch
* remove accidentally re-added remote-side spec
* wip
* don't attempt to serialize host objects
* jump through different hoops to set options.webContents sometimes
* whoops
* fix lint
* clean up error-handling logic
* fix memory leak
* fix lint
* convert host objects using old base::Value serialization
* fix lint more
* fall back to base::Value-based serialization
* remove commented-out code
* add docs to breaking-changes.md
* Update breaking-changes.md
* update ipcRenderer and WebContents docs
* lint
* use named values for format tag
* save a memcpy for ~30% speedup
* get rid of calls to ShallowClone
* extra debugging for paranoia
* d'oh, use the correct named tags
* apparently msstl doesn't like this DCHECK
* funny story about that DCHECK
* disable remote-related functions when enable_remote_module = false
* nits
* use EnableIf to disable remote methods in mojom
* fix include
* review comments
* deprecate native_mate/native_mate/object_template_builder.h
* add gin_helper/object_template_builder.h
* add patch to avoid ambiguous error
* remove usage of object_template_builder_deprecated.h in a few files
* add note we should remove gin_helper/object_template_builder.h in future
* refactor: fix clang-tidy vector operation warnings
Fix vector population performance-inefficient-vector-operation warnings
generated by clang-tidy
* refactor: fix clang-tidy emplace_back warnings
In cases where a temporary is created to be passed
to push_back(), replace it with emplace_back().
Warning: modernize-use-emplace
* refactor: fix clang-tidy loop iteration warnings
When practical, use range-based for loops instead of C-style for loops.
clang-tiny check: modernize-loop-convert
* refactor: fix clang-tidy string initialize warning
Remove redundant empty string initialization.
clang-tidy check: readability-redundant-string-init
* use gin converter in atom_api_menu
* please only put necessary includes in header
Having include in header means they have dependency relationship,
putting arbitrary includes really really really really really makes
refacoring much harder.
* remove some simple uses of callback_converter_deprecated.h
* use gin callback converter in file_dialog code
* use gin in ErrorThrower
* use gin in atom_bundle_mover
* fix mistake in node stream
* deprecate native_mate version of event_emitter_caller
* use gin in node_bindings
* remove usages of native_mate event_emitter_caller.h except for EventEmitter
* fix compilation on Windows
* gin::Arguments behaves differently on GetNext
* just use StringToV8
* add notice to files being removed
* add gin version of function_template.h
* rename callback.h to avoid confliction
* add gin version of callback_converter
* add gin converter for OnceCallback
* remove callback_converter_gin_adapter.h
* remove gin_util.h and gin_utils.h
* fix lint warning
* add helper for setting methods
