github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity
24,076 Commits 423 Branches 3,573 Tags
v10.4.6
Commit Graph

333 Commits

Author SHA1 Message Date
trop[bot]
51f9712c8f fix: DesktopCapturer gc'd prior to capture completion (#28279) 
desktopCapture.getSources() returns a promise which should resolve
when capturing finishes. Internally it creates an instance of
DesktopCapturer which is responsible for resolving or rejecting
the promise.

Between the time DesktopCapturer starts capturing frames and when
it finishes, it's possible for its handle to be GC'd leading to
it never resolving.

These changes pin the instance of DesktopCapturer until it either
finishes or errors.

fixes #25595

Co-authored-by: samuelmaddock <samuel.maddock@gmail.com>
 2021-03-22 11:03:41 +09:00
trop[bot]
6e9db782c7 fix: ensure owner window valid (#27946) 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2021-03-02 09:44:05 -08:00
Shelley Vohr
a64d0713cd fix: set WebContents background color ubiquitously (#27945) 
Move it from LoadURL to RenderViewCreated which is present
in all window creation cases and is called early enough to be
relevant from user prespective and after RenderWidgetHostView
is already present.

Co-authored-by: marekharanczyk <48673767+marekharanczyk@users.noreply.github.com>
 2021-03-01 13:21:32 -08:00
Eryk Rakowski
4293389679 feat: add win.setTopBrowserView() so that BrowserViews can be raised (#27711) 
* feat: add `win.setTopBrowserView()` so that BrowserViews can be raised (#27007)

* feat: Raise a browser view via `BrowserWindow.setTopBrowserView()`.

This is similar to removing and re-adding a browser view, but avoids a visible flicker as the browser view is not removed from the window when using `setTopBrowserView`. Note: if the given browser view is not attached to the window, it will be added.

This commit contains the macOS implementation.

* feat: setTopBrowserView support for Windows and Linux

* docs: add info about setTopBrowserView

* docs: Clarify behavior when browserView is not yet attached.

* fix: throw en error when browserView is not attached to the window

* fix: build error

* fix: test

* fix: add test case

* fix: tests

* fix: reparenting

* fix: close second window in tests

Co-authored-by: sentialx <sentialx@gmail.com>

* fix: build error

Co-authored-by: Stewart Lord <stew@offbynone.com>
 2021-02-18 19:17:04 +09:00
Cheng Zhao
779efcfa11 fix: check WebContents before emitting render-process-gone event (#27758) 2021-02-17 15:52:05 -08:00
Milan Burda
13a0757acb build: fix build with enable_printing=false (#27456) (#27505) 2021-01-27 16:35:38 +09:00
trop[bot]
340b4a2c1e fix: actually clear pending requests in devtoolsagenthost (#27438) 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2021-01-21 12:51:03 -08:00
Shelley Vohr
fe4bc1d568 refactor: use platform-specific TaskRunner to print (#27328) 2021-01-19 15:24:09 +09:00
Shelley Vohr
08da5ee22a fix: handle BrowserView reparenting (#27220) 2021-01-11 10:49:56 +09:00
Eryk Rakowski
d3f7ad2035 feat: add support for webContents option in BrowserView (#27094) 
* feat: add support for webContents option in BrowserView (#26802)

* feat: add support for webContents option in BrowserView

* tests: add tests

* fix: missing webContents import

* fix: WebContents::New -> Create
 2021-01-05 11:22:56 +09:00
Jeremy Rose
fea41c6f6d fix: throw when using globalShortcut before ready (#27023) 
* fix: throw when using globalShortcut before ready (#27002)

* add missing include
 2020-12-17 10:07:44 +09:00
Jeremy Rose
0bbd268eb4 fix: restrict sendToFrame to same-process frames by default (#26875) (#26927) 
* fix: restrict sendToFrame to same-process frames by default (#26875)

* missed a conflict

* fix build

* fix build again

* fix usage of defer
 2020-12-11 13:01:40 -08:00
trop[bot]
70e41bcf43 fix: draggable regions calculation in BrowserWindow/BrowserView (#26753) 2020-12-01 11:30:08 -08:00
trop[bot]
7bd2f0db23 fix: make draggable regions work when devtools is opened on macOS (#26394) 
* fix: make draggable region work when devtools is open

* fix: update draggable regions when resizing

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
 2020-11-16 15:38:25 +09:00
trop[bot]
7558b5878b chore: synchronously destroy WebContents on event prevented (#26417) 
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
 2020-11-11 10:07:02 -05:00
Shelley Vohr
a3c1866581 fix: draggable region edge calculation on resize (#26321) 2020-11-03 15:01:55 -08:00
Shelley Vohr
6543acce1d fix: draggable regions exclusively on BrowserViews (#26260) 2020-11-02 16:07:45 +09:00
trop[bot]
15db70d661 chore: change some for loops to range-based (#26262) 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
 2020-10-30 09:58:43 -07:00
David Sanders
6147bd77ac chore: use auto to avoid repeating type (#26255) 2020-10-29 08:50:29 -07:00
trop[bot]
ccbf615da0 fix: delay emitting powerMonitor events on windows (#26180) 
* fix: delay emitting powerMonitor events

* Update electron_api_power_monitor_win.cc

* Update electron_api_power_monitor_win.cc

* syntax

* Update electron_api_power_monitor_win.cc

* Update electron_api_power_monitor_win.cc

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
 2020-10-28 12:38:31 -05:00
David Sanders
776f76c6f5 chore: prefer empty() check for readability (#26159) 2020-10-26 11:48:03 -07:00
trop[bot]
4a312e9c6b fix: return early on promise rejection (#26110) 
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
 2020-10-22 14:45:09 -05:00
Shelley Vohr
13722f83e3 fix: ensure ready-to-show event is fired (#25932) 
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
 2020-10-15 10:02:36 +09:00
Milan Burda
7ae4b2b559 fix: session argument of app 'session-created' event (#25798) 
Co-authored-by: Milan Burda <miburda@microsoft.com>
 2020-10-08 16:32:26 -05:00
trop[bot]
e964c1ed7b fix: prevent destroyed view references from causing crashes (#25511) 2020-09-24 11:26:58 -07:00
Shelley Vohr
6fe6dffe93 fix: honor pageRanges when printing (#25597) 2020-09-24 11:53:09 -04:00
Shelley Vohr
0b75053fdc fix: check printer list when no default printers (#25606) 2020-09-23 15:44:19 -07:00
Shelley Vohr
894d41ef5a fix: close window when leave fs crash (#25604) 2020-09-23 15:44:00 -07:00
Samuel Maddock
9582f0b457 fix(extensions): devtools now open for background pages (#25566) 2020-09-22 07:12:43 -07:00
Cheng Zhao
80ef3c7c84 fix: ensure ready-to-show event is fired (#25476) 2020-09-16 07:58:53 -06:00
trop[bot]
303b420200 fix: avoid creating client_id file for empty DIR_CRASH_DUMPS (#25309) 
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2020-09-08 17:13:13 +09:00
Samuel Attard
fa3652a14f fix: only focus a webContents if the window was not initially hidden (#25323) (#25330) 
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
 2020-09-08 16:55:46 +09:00
trop[bot]
2206330795 fix: resolve RegisterSuspendResumeNotification dynamically (#25167) 
Co-authored-by: Milan Burda <milan.burda@gmail.com>
 2020-08-27 13:45:23 -07:00
Shelley Vohr
34a321f46b feat: reinvigorate visibleOnFullscreen option (#25125) 
* feat: reinvigorate visibleOnFullscreen option

* Update electron_api_top_level_window.cc

Co-authored-by: Samuel Attard <sattard@slack-corp.com>
 2020-08-26 23:49:46 -07:00
trop[bot]
0b834877fe feat: expose currencyCode on Product struct in IAP module (#25084) 
Co-authored-by: Shur Singh <ssingh@evernote.com>
 2020-08-26 16:18:09 -07:00
Samuel Attard
1861392561 refactor: wire will-navigate up to a navigation throttle instead of OpenURL (#25108) 
* refactor: wire will-navigate up to a navigation throttle instead of OpenURL (#25065)

* refactor: wire will-navigate up to a navigation throttle instead of OpenURL

* spec: add test for x-site _top navigation

* chore: old code be old
 2020-08-25 19:22:24 +09:00
trop[bot]
44ecd34289 fix: register for connected standby changes (#25111) 
Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
 2020-08-24 22:24:48 -07:00
trop[bot]
50046f8df6 fix: add handling for non-absolute extension paths (#25074) 
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
 2020-08-21 12:34:22 -07:00
Charles Kerr
8191a8418f fix: revert 6ecf729 to fix Linux titlebar dark mode (#25056) 
Fixes #24741
 2020-08-21 09:05:51 -05:00
Shelley Vohr
6582017231 fix: add handle scope in SelectClientCertificate (#25019) 2020-08-18 13:32:15 -07:00
Jeremy Rose
72901f9d91 fix: browser contexts live forever (#25001) 2020-08-17 19:49:09 -07:00
trop[bot]
d77f4f62fd fix: send guid with linux crashes (#24897) 
* fix: send guid with linux crashes

* simplify with file_util

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
 2020-08-10 09:59:09 -07:00
trop[bot]
58045d85c8 fix: duplicate suspend/resume events (#24843) 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2020-08-06 08:30:48 -07:00
Jeremy Rose
99f1d7e57a fix: wrap OnWindowMessage w/ handlescope (#24716) (#24768) 2020-07-28 20:34:20 -07:00
trop[bot]
009105db4f fix: crash when navigating from a page with webview that has inherited zoom level (#24763) 
* fix: cleanup webview zoom level observers on navigation

* add spec

* webview should be on same partition

* wait for webview to finish loading

Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2020-07-28 19:18:39 -07:00
trop[bot]
4c596ab969 fix: default to simplex for printing DuplexMode (#24527) 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2020-07-13 22:07:14 -07:00
Electron Bot
d608a30015 chore: bump chromium to 85.0.4183.19 (10-x-y) (#24299) 
* chore: bump chromium in DEPS to 85.0.4182.1

* chore: bump chromium in DEPS to 85.0.4183.2

* chore: bump chromium in DEPS to 85.0.4183.4

* chore: bump chromium in DEPS to 85.0.4183.5

* update patches

* chore: bump chromium in DEPS to 85.0.4183.6

* chore: bump chromium in DEPS to 85.0.4183.7

* update patches

* chore: bump chromium in DEPS to 85.0.4183.8

* remove chromeos-only TtsControllerDelegate

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2255314
(cherry picked from commit f975f84a3c)

* rename GetHighContrastColorScheme -> GetPlatformHighContrastColorScheme

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2250224
(cherry picked from commit 014b487258)

* add max_xcode_version build var

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2264867
(cherry picked from commit 2c3b94f497)

* add empty floc blocklist to BrowserProcessImpl

Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2240873
(cherry picked from commit 3cdaae146d)

* Move zygote from //services/service_manager back to //content

https://chromium-review.googlesource.com/c/chromium/src/+/2252466
(cherry picked from commit e0d6dbcf1e)

* Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"

https://chromium-review.googlesource.com/c/chromium/src/+/2264297
(cherry picked from commit 1407040133)

* Update mas private api patch

* Reland "Reland "New toolchain for Windows 10 19041 SDK""

https://chromium-review.googlesource.com/c/chromium/src/+/2255527
(cherry picked from commit 8101d956f5)

* [XProto] Remove usage of Shape extension

https://chromium-review.googlesource.com/c/chromium/src/+/2262113
(cherry picked from commit 72b6f11958)

* chore: bump chromium in DEPS to 85.0.4183.9

* chore: bump chromium in DEPS to 85.0.4183.10

* chore: bump chromium in DEPS to 85.0.4183.11

* chore: bump chromium in DEPS to 85.0.4183.12

* chore: bump chromium in DEPS to 85.0.4183.13

* update patches

* fixup! add empty floc blocklist to BrowserProcessImpl

(cherry picked from commit 07b0b65c1d)

* fixup! Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"

(cherry picked from commit f91c1ab162)

* Check for GDI exhaustion if window creation fails

https://chromium-review.googlesource.com/c/chromium/src/+/2244124
(cherry picked from commit 3d45d7b78c)

* chore: bump chromium in DEPS to 85.0.4183.14

* Fixup lint issue

* update patches

* fix: include missing header file

* chore: bump chromium in DEPS to 85.0.4183.19

* update patches

* refactor: match upstream print preview handling (#24452)

(cherry picked from commit 004e29ad33)

* use PrintHostMsg_DidPreviewPage_Params

https://chromium-review.googlesource.com/c/chromium/src/+/2257124

Co-authored-by: Andy Locascio <andy@slack-corp.com>
Co-authored-by: Electron Bot <anonymous@electronjs.org>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2020-07-09 10:04:19 -04:00
trop[bot]
d4a6affa4b fix: use try/catch for base class converter error (#24450) 
* fix: use try/catch for base class converter error

* Place try/catch in a block

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
 2020-07-07 20:00:46 -07:00
trop[bot]
c32c69604a feat: expose sessionId in debugger module (#24397) 
Co-authored-by: deepak1556 <hop2deep@gmail.com>
 2020-07-06 12:38:01 -07:00
trop[bot]
39bc7c82a6 feat: implement systemPreferences.getMediaAccessStatus() on Windows (#24311) 
Co-authored-by: Milan Burda <milan.burda@gmail.com>
 2020-07-01 16:51:10 -07:00