Keeley Hammond
1f1ff0e51f
fix: documentEdited property on BrowserWindow ( #28159 )
2021-03-14 17:27:36 -07:00
Michaela Laurencin
c6f8625947
fix: replace default frameName title with null check ( #27813 ) ( #27868 )
...
* fix: replace default frameName title with null check (#27521 )
* refactor: replace default frameName title with null check
* add isNativeWindowOpen check in makeBrowserWindowOptions
* modify snapshot test files
* replace title with frame-name again for proxy - not native open
* modify proxy snapshot title key-value to come after height key-value
* add nativewindowopen check to null title
* fix lint and json formatting
* reformat test cases for this branch
the merged changes included some rearrangements to the json items that
do not apply to this branch, so the items were reordered according to
this branch's previous files.
* remove default frameName title for native open call and modify test txts
2021-02-23 10:26:01 -05:00
Jeremy Rose
0bbd268eb4
fix: restrict sendToFrame to same-process frames by default ( #26875 ) ( #26927 )
...
* fix: restrict sendToFrame to same-process frames by default (#26875 )
* missed a conflict
* fix build
* fix build again
* fix usage of defer
2020-12-11 13:01:40 -08:00
Milan Burda
883b089e0f
fix: systemPreferences.effectiveAppearance returning systemPreferences.getAppLevelAppearance() ( #26852 ) ( #26882 )
2020-12-09 14:59:01 +09:00
Shelley Vohr
38d126fb5c
fix: order menu items before filtering excess separators ( #25931 )
...
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
2020-10-15 11:13:55 -04:00
Shelley Vohr
13722f83e3
fix: ensure ready-to-show event is fired ( #25932 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
2020-10-15 10:02:36 +09:00
Milan Burda
7ae4b2b559
fix: session argument of app 'session-created' event ( #25798 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2020-10-08 16:32:26 -05:00
trop[bot]
de0ddd5b56
chore: tsify net-log ( #25670 )
...
* chore: tsify net-log
* comment
* gn
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2020-09-29 12:56:54 -04:00
trop[bot]
4a0f2bede2
chore: improve renderer crash logging ( #25621 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2020-09-24 13:23:41 -07:00
trop[bot]
21a46bc0eb
chore: log hint on renderer crash ( #25472 )
...
* chore: log hint on renderer crash
* Address feedback from review
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-09-15 14:01:49 -06:00
Samuel Attard
fa3652a14f
fix: only focus a webContents if the window was not initially hidden ( #25323 ) ( #25330 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
2020-09-08 16:55:46 +09:00
George Xu
d73b67f386
feat: add nativeImage.createThumbnailFromPath API ( #25072 )
...
* cherry-picking
* add documentation
* convert createThumbnailFromPath to async function
* windows impl protoype
* add tests
* clean up
* fix
* fix test
* update docs
* cleaning up code
* fix test
* refactor from app to native_image
* windows build
* lint
* lint
* add smart pointers, fix test
* change tests and update docs
* fix test, remove nolint
* add renderer-main process routing to fix tests
* lint
* thanks sam
* cherry-pick
* lint
* remove getApplicationInfoForProtocol code
* chore: fix filenames conflict
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2020-08-26 16:18:28 -07:00
Shelley Vohr
39edbd6af4
fix: always callback error with invalid print settings ( #24507 )
2020-07-13 08:55:30 -07:00
Electron Bot
d608a30015
chore: bump chromium to 85.0.4183.19 (10-x-y) ( #24299 )
...
* chore: bump chromium in DEPS to 85.0.4182.1
* chore: bump chromium in DEPS to 85.0.4183.2
* chore: bump chromium in DEPS to 85.0.4183.4
* chore: bump chromium in DEPS to 85.0.4183.5
* update patches
* chore: bump chromium in DEPS to 85.0.4183.6
* chore: bump chromium in DEPS to 85.0.4183.7
* update patches
* chore: bump chromium in DEPS to 85.0.4183.8
* remove chromeos-only TtsControllerDelegate
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2255314
(cherry picked from commit f975f84a3c )
* rename GetHighContrastColorScheme -> GetPlatformHighContrastColorScheme
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2250224
(cherry picked from commit 014b487258 )
* add max_xcode_version build var
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2264867
(cherry picked from commit 2c3b94f497 )
* add empty floc blocklist to BrowserProcessImpl
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2240873
(cherry picked from commit 3cdaae146d )
* Move zygote from //services/service_manager back to //content
https://chromium-review.googlesource.com/c/chromium/src/+/2252466
(cherry picked from commit e0d6dbcf1e )
* Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"
https://chromium-review.googlesource.com/c/chromium/src/+/2264297
(cherry picked from commit 1407040133 )
* Update mas private api patch
* Reland "Reland "New toolchain for Windows 10 19041 SDK""
https://chromium-review.googlesource.com/c/chromium/src/+/2255527
(cherry picked from commit 8101d956f5 )
* [XProto] Remove usage of Shape extension
https://chromium-review.googlesource.com/c/chromium/src/+/2262113
(cherry picked from commit 72b6f11958 )
* chore: bump chromium in DEPS to 85.0.4183.9
* chore: bump chromium in DEPS to 85.0.4183.10
* chore: bump chromium in DEPS to 85.0.4183.11
* chore: bump chromium in DEPS to 85.0.4183.12
* chore: bump chromium in DEPS to 85.0.4183.13
* update patches
* fixup! add empty floc blocklist to BrowserProcessImpl
(cherry picked from commit 07b0b65c1d )
* fixup! Reland "[base] Stop including check.h, notreached.h, etc. in logging.h"
(cherry picked from commit f91c1ab162 )
* Check for GDI exhaustion if window creation fails
https://chromium-review.googlesource.com/c/chromium/src/+/2244124
(cherry picked from commit 3d45d7b78c )
* chore: bump chromium in DEPS to 85.0.4183.14
* Fixup lint issue
* update patches
* fix: include missing header file
* chore: bump chromium in DEPS to 85.0.4183.19
* update patches
* refactor: match upstream print preview handling (#24452 )
(cherry picked from commit 004e29ad33 )
* use PrintHostMsg_DidPreviewPage_Params
https://chromium-review.googlesource.com/c/chromium/src/+/2257124
Co-authored-by: Andy Locascio <andy@slack-corp.com >
Co-authored-by: Electron Bot <anonymous@electronjs.org >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-07-09 10:04:19 -04:00
trop[bot]
72f2dad3a1
Make pasteandmatchstyle accelerator OS specific ( #24182 )
...
Co-authored-by: Elena Topaka <el1topa@gmail.com >
2020-06-17 21:47:47 -07:00
trop[bot]
57b766aa82
fix: showing certificate dialog with no window ( #24118 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-06-13 08:22:36 -07:00
trop[bot]
1fb11e1e76
fix: trigger about panel for about role on on win ( #23717 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-05-22 00:55:25 -07:00
Milan Burda
df53816eea
feat: expose the desktopCapturer module in the main process ( #23548 )
2020-05-20 20:25:49 -04:00
LuoJinghua
9d851b8791
net: Don't ignore the referer header in net.request ( #23386 )
2020-05-20 13:28:38 -04:00
Jeremy Apthorp
8de06f0c57
feat: deprecate uncompressed crash uploads ( #23598 )
2020-05-19 13:47:21 -07:00
Jeremy Apthorp
de44d28c8e
refactor: ginify Session ( #23569 )
2020-05-19 10:18:12 -07:00
Jeremy Apthorp
7e841ceb5c
refactor: tsify net module ( #23618 )
2020-05-18 10:22:48 -07:00
Milan Burda
52b50e6b33
feat: add app render-process-gone event ( #23560 )
2020-05-17 17:05:05 +02:00
Milan Burda
4afc756094
feat: add contents.getBackgroundThrottling() + backgroundThrottling property ( #21036 )
2020-05-14 15:11:45 +02:00
Milan Burda
392ea320cf
build: allow use of BUILDFLAG directives from within JS code ( #20328 )
2020-05-11 01:06:07 +02:00
Jeremy Apthorp
06bf0d08dc
fix: crashReporter incompatible with sandbox on Linux ( #23265 )
2020-05-07 13:31:26 -07:00
shelley vohr
0f0cc51b35
refactor: return null when passing empty menu templates ( #23364 )
2020-05-04 08:19:21 -07:00
shelley vohr
f50f725a9c
fix: prevent Menu.buildFromTemplate with empty array ( #23308 )
...
Prevent issues with menu creation and subsequent pane focus from menu bar by preventing menus from being created from an empty array. I can't conceive a valid use case for this, since if one wants to remove a menu they should be be passing null to win.setMenu() or calling win.removeMenu(). This issue is also specific to top-level menus, and not submenus, so the new check and exception is scoped to top-level menus.
2020-04-30 08:29:02 -07:00
Samuel Attard
abe5cf398c
refactor: port window.open and window.opener to use ctx bridge instead of hole punching ( #23235 )
...
* refactor: port window.open and window.opener to use ctx bridge instead of hole punching
* refactor: only run the isolated init bundle when webview is enabled
2020-04-27 12:46:04 -07:00
loc
aca2e4f968
refactor: improve feature string parsing ( #23130 )
...
* test: add pre-change snapshot of new-window event
* move to .ts file for easier diff
* refactor: improve feature string parsing logic
* test: update snapshots
* update type names per review
* update comma-separated parse test
* use for loop instead of reduce per review
* tighten up types
* avoid variable guest contents id returnValue in test snapshot
2020-04-21 16:23:00 -04:00
Shelley Vohr
f3dc3997b1
feat: support fullScreen BrowserWindow property ( #23145 )
2020-04-20 20:25:18 -07:00
Cheng Zhao
ca947307db
chore: make WebContentsView take webPreferences as parameter ( #22997 )
...
* chore: add WebContentsView.webContents helper
* chore: no need to handle webContents option
* chore: Create WebContentsView in C++
* chore: make WebContentsView accept web_preferences
* fix: nativeWindowOpen still passes WebContents to BrowserWindow
* chore: no more need of WebContentsViewRelay
* test: WebContentsView now takes options
* fix: avoid creating 2 constructors
2020-04-09 16:01:16 +09:00
Jeremy Apthorp
0a78ab4b98
refactor: ginify DownloadItem ( #22924 )
2020-04-02 17:22:46 -07:00
Jeremy Apthorp
6159066c26
refactor: ginify Menu ( #22916 )
2020-04-02 16:07:56 -07:00
Shelley Vohr
da67cbf551
feat: add property support for remainder of BrowserWindow ( #22771 )
...
Adds property-based support for the remainder of primitive gette/setter pairs on `BrowserWindow`.
Namely:
- `win.simpleFullScreen`
- `win.title`
- `win.visibleOnAllWorkspaces`
- `win.documentEdited`
- `win.representedFilename`
- `win.shadow`
- `win.kiosk`
- `win.menuBarVisible`
2020-04-01 08:22:32 -07:00
Cheng Zhao
d74ad631e7
chore: there is no need to define _init ( #22882 )
2020-03-31 14:50:03 -07:00
Jeremy Apthorp
765c08c600
refactor: ginify Notification ( #22821 )
2020-03-31 11:42:32 -07:00
Jeremy Apthorp
a3e28788ce
refactor: ginify Tray ( #22822 )
...
* refactor: ginify Tray
* lint
* improve argument parsing logic
* remove redundant imports from tray.js
* new Tray produces an instanceof Tray
* make Constructible generic
* lint
* clean up on exit
2020-03-30 10:32:02 +09:00
Cheng Zhao
76ae3b7ecb
chore: remove unused classes of views API ( #22861 )
...
* chore: remove unused views API classes
* chore: remove LayoutManager code
* chore: no more need to make View inherit from TrackabeObject
* chore: make enable_view_api default to true
* chore: enable_view_api => enable_views_api
2020-03-28 15:44:57 +09:00
Heilig Benedek
74372d65ae
feat: enhance native window.open to match the custom implementation's behavior ( #19703 )
...
Co-authored-by: Andy Locascio <andy@slack-corp.com >
2020-03-26 11:05:45 -07:00
Jeremy Apthorp
e73d5e3db5
refactor: ginify protocol ( #22812 )
2020-03-26 10:34:32 -07:00
Jeremy Apthorp
222022556f
refactor: ginify Cookies ( #22823 )
2020-03-25 15:34:53 -07:00
Jeremy Apthorp
07cd70a37e
refactor: ginify powerMonitor ( #22751 )
2020-03-24 09:03:29 -07:00
Jeremy Apthorp
decbca734f
refactor: ginify net.request ( #22779 )
2020-03-23 13:09:45 -07:00
Cheng Zhao
341f643b81
feat: add ImageView ( #22738 )
2020-03-22 19:11:43 +09:00
Samuel Attard
60bd52880f
feat: add support for net requests to use the session cookie store ( #22704 )
2020-03-20 15:56:02 -07:00
Jeremy Apthorp
22c17bcc5b
refactor: ginify ServiceWorkerContext ( #22756 )
2020-03-20 14:15:14 -07:00
Samuel Attard
5d657dece4
build: enable JS semicolons ( #22783 )
2020-03-20 13:28:31 -07:00
Samuel Attard
b87b501161
build: update eslint + eslint plugins ( #22777 )
...
* build: run eslint --fix
* chore: manually fix all hasOwnProperty errors
* chore: manually fix all void 0 vs undefined errors
* chore: manually fix all async-in-promise errors
* chore: manually fix lexical declaration in case block
2020-03-20 11:12:18 -04:00
Jeremy Apthorp
c4a7eade28
refactor: ginify session.netLog ( #22732 )
2020-03-18 16:46:05 -07:00