Milan Burda
ab3e65ae34
fix: [webview] fix missing properties on events when contextIsolation: true ( #29143 )
...
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-05-13 23:39:16 +02:00
Milan Burda
29d8cf5423
fix: <webview> focus / blur events don't work with contextIsolation enabled ( #29004 ) ( #29026 )
2021-05-07 11:15:45 +09:00
Milan Burda
581b47582f
fix: warning when worldSafeExecuteJavaScript is disabled ( #27974 )
2021-03-05 10:15:37 +09:00
trop[bot]
2345ff0644
fix: enableBlinkFeatures warning in webviews ( #27788 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-02-18 14:06:56 -08:00
trop[bot]
2e98e11364
fix: <webview> not working with Trusted Types ( #27465 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-01-25 11:47:33 -08:00
trop[bot]
62b2243574
fix: CSP with unsafe-eval detection with Trusted Types ( #27468 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-01-25 08:33:25 -08:00
trop[bot]
9562a92c5d
fix: handle security warnings promise when JS is disabled ( #26871 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2020-12-07 13:03:37 -08:00
Milan Burda
f7a61c4592
fix: <webview> render-process-gone event dispatch ( #26577 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2020-11-18 17:56:44 -06:00
Milan Burda
83db340eb3
fix: ensure that internal messages are sent from the main process ( #26439 )
2020-11-16 15:32:00 +09:00
trop[bot]
ae3c79d6ce
refactor: store <webview> attributes as typed Map ( #26329 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2020-11-05 11:25:53 -05:00
trop[bot]
56a764d510
fix: suppress worldSafe warning emitted from security checks ( #25827 )
...
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2020-10-08 20:20:09 -07:00
George Xu
d73b67f386
feat: add nativeImage.createThumbnailFromPath API ( #25072 )
...
* cherry-picking
* add documentation
* convert createThumbnailFromPath to async function
* windows impl protoype
* add tests
* clean up
* fix
* fix test
* update docs
* cleaning up code
* fix test
* refactor from app to native_image
* windows build
* lint
* lint
* add smart pointers, fix test
* change tests and update docs
* fix test, remove nolint
* add renderer-main process routing to fix tests
* lint
* thanks sam
* cherry-pick
* lint
* remove getApplicationInfoForProtocol code
* chore: fix filenames conflict
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2020-08-26 16:18:28 -07:00
trop[bot]
bc4884788c
feat: add worldSafe flag for executeJS results ( #24711 )
...
* feat: add worldSafe flag for executeJS results
* chore: do not log warning for webContents.executeJS
* Apply suggestions from code review
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
* chore: apply PR feedback
* chore: split logic a bit
* chore: allow primitives through the world safe checl
* chore: clean up per PR feedback
* chore: flip boolean logic
* chore: update per PR feedback
* chore: fix typo
* chore: fix spec
* Update web-frame.ts
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2020-08-05 10:24:51 -07:00
Shelley Vohr
9d2aa93581
fix: ensure nativeImage serialization main->renderer ( #23794 )
...
* refactor: use typeutils for nativeImage serialization (#23693 )
* fix: ensure nativeImage serialization main->renderer
2020-05-28 12:07:33 -07:00
trop[bot]
eb93acc463
fix: handle asynchronous URL loading in bw proxy ( #23804 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2020-05-28 09:41:54 -07:00
Milan Burda
df53816eea
feat: expose the desktopCapturer module in the main process ( #23548 )
2020-05-20 20:25:49 -04:00
Shelley Vohr
4b23a85475
refactor: correctly serialize nativeImage/buffer with typeUtils ( #23666 )
...
* refactor: correctly serialize nativeImage/buffer with typeUtils
* test: add serialization specs
* fix: construct from dataURL
* test: test for dataURL specificity
2020-05-20 13:42:42 -07:00
Shelley Vohr
ee0f67d541
fix: nativeImage remote serialization ( #23543 )
...
We weren't serializing nativeImages properly in the remote module, leading to gin conversion errors when trying to, for example, create a new context menu in the renderer with icons using nativeImage. This fixes that by adding a new special case to handle them.
2020-05-18 09:29:24 -07:00
Samuel Attard
9d7ba98209
refactor: remove the RenderFrameFunctionStore and use privates to memory manage ( #23592 )
2020-05-15 11:57:40 -07:00
Milan Burda
85fae67966
perf: use type-utils for desktopCapturer.getSources() result serialization ( #23549 )
2020-05-13 19:05:53 +02:00
Samuel Attard
7f9b7b2e95
chore: clean up context bridge scopes and add specs for internal bridge ( #23334 )
...
* chore: clean up context bridge context scopes
* spec: add specs for internalContextBridge
2020-05-11 13:41:42 -07:00
Milan Burda
392ea320cf
build: allow use of BUILDFLAG directives from within JS code ( #20328 )
2020-05-11 01:06:07 +02:00
Jeremy Apthorp
06bf0d08dc
fix: crashReporter incompatible with sandbox on Linux ( #23265 )
2020-05-07 13:31:26 -07:00
Robo
c438b93f18
fix: ensure guest-embedder map is updated when webview is removed ( #23342 )
...
There are use cases of webview where the container holding the webview is not
actually destroyed first, instead just webview gets removed from DOM, in such
situations the browser process map is not updated accordingly and holds reference
to stale guest contents, and any window operations like scroll, resize or keyboard
events that has to chain through browser embedder will lead to UAF crash.
Ref: https://github.com/microsoft/vscode/issues/92420
2020-04-30 21:33:14 -07:00
Jeremy Apthorp
8d0a612265
refactor: remove code for non-native extensions shim ( #23340 )
2020-04-30 09:38:09 -07:00
Samuel Attard
7377bb3736
fix: do not add 104 to the history length ( #23301 )
2020-04-27 15:53:47 -07:00
Samuel Attard
abe5cf398c
refactor: port window.open and window.opener to use ctx bridge instead of hole punching ( #23235 )
...
* refactor: port window.open and window.opener to use ctx bridge instead of hole punching
* refactor: only run the isolated init bundle when webview is enabled
2020-04-27 12:46:04 -07:00
Samuel Attard
8262f24fd8
fix: do not mutate ipc instances across contexts ( #23236 )
2020-04-22 16:36:15 -07:00
Samuel Attard
96bf9ce77f
refactor: port parts of window-setup to use ctx bridge instead of being run in the main world ( #23194 )
...
* refactor: port parts of window-setup to use ctx bridge instead of being run in the main world
* chore: update ctx bridge specs for new base numbers
2020-04-22 12:42:51 -07:00
Samuel Attard
b03bd8c45c
chore: rename atom things to electron things in our docs / scripts ( #23100 )
2020-04-13 14:32:29 -07:00
Jeremy Apthorp
b327478cf0
fix: prevent remote from messing with constructor names ( #22820 )
2020-03-25 13:13:10 -07:00
Samuel Attard
5d657dece4
build: enable JS semicolons ( #22783 )
2020-03-20 13:28:31 -07:00
Samuel Attard
b87b501161
build: update eslint + eslint plugins ( #22777 )
...
* build: run eslint --fix
* chore: manually fix all hasOwnProperty errors
* chore: manually fix all void 0 vs undefined errors
* chore: manually fix all async-in-promise errors
* chore: manually fix lexical declaration in case block
2020-03-20 11:12:18 -04:00
Samuel Attard
5e4e50c5eb
fix: remove bad usages of for-in and guard against it ( #22616 )
...
* fix: remove bad usages of for-in and guard against it
* Apply suggestions from code review
Co-Authored-By: Samuel Maddock <samuel.maddock@gmail.com >
* Apply suggestions from code review
Co-Authored-By: Jeremy Apthorp <jeremya@chromium.org >
* Update remote.js
Co-authored-by: Samuel Maddock <samuel.maddock@gmail.com >
Co-authored-by: Jeremy Apthorp <jeremya@chromium.org >
2020-03-17 13:17:55 -07:00
Jeremy Apthorp
b4d07f76d3
feat: MessagePorts in the main process ( #22404 )
2020-03-11 18:07:54 -07:00
Shelley Vohr
efc11563e8
fix: properly forward properties to webview ( #22485 )
2020-03-03 22:25:14 +00:00
Samuel Attard
360c1cad1b
chore: do not override history methods when rendererprocessreuse is enabled ( #22335 )
2020-02-24 12:14:11 -08:00
Jeremy Apthorp
602913cb4c
chore: rename node bindings atom => electron ( #22176 )
2020-02-14 06:25:39 -05:00
Jeremy Apthorp
b77f701aeb
feat: disable the remote module by default ( #22091 )
2020-02-10 10:49:09 -08:00
Jeremy Apthorp
ea89120c9e
chore: remove debugging log ( #22093 )
2020-02-07 12:31:08 -08:00
Jeremy Apthorp
2e1531ad90
feat: warn when remote is used without enableRemoteModule: true ( #21546 )
...
* feat: warn when remote is used without enableRemoteModule: true
* fix security warning
2020-01-13 15:23:03 +09:00
Milan Burda
31c93fec67
fix: load window-setup in sandboxed renderer ( #21416 )
2020-01-06 22:23:03 +01:00
Joël Charles
0bcfae752e
feat: allow pages to override window.history.length ( #17742 )
...
* fix: allow pages to override window.history.length
* Update lib/renderer/window-setup.ts
Co-Authored-By: magne4000 <joel.charles91@gmail.com >
* fix: lint error
2019-12-16 11:14:27 +09:00
Jeremy Apthorp
dc9beda182
feat: remove deprecated setLayoutZoomLevelLimits ( #21383 )
2019-12-06 13:14:25 -08:00
Jeremy Apthorp
9526c5584e
fix: deprecate setLayoutZoomLevelLimits ( #21296 )
2019-12-02 13:27:03 -08:00
Samuel Attard
ee58d60612
fix: ensure no node globals passively leak when nodeIntegration is disabled ( #21342 )
2019-12-02 10:09:47 -08:00
Milan Burda
1d596f616d
fix: NativeImage serialization of <webview>.capturePage() result ( #20825 )
2019-11-12 21:56:17 +01:00
Milan Burda
093f2dd4a6
chore: remove deprecated <webview>.getWebContents() ( #20986 )
2019-11-08 15:46:35 -05:00
Milan Burda
f1e7393e30
feat: deprecate <webview>.getWebContents() ( #20726 )
2019-11-07 09:43:19 -08:00
Milan Burda
a034f5db0d
refactor: add Error to isSerializableObject() ( #20886 )
2019-11-04 14:35:57 -08:00