trop[bot]
883f692dad
feat: warn when ipcRenderer.sendSync() called with no listeners for channel ( #31432 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-10-21 09:09:33 +09:00
Robo
3b3430fba6
refactor: only access memory coordinator interface from browser process ( #31305 )
...
* refactor: only access memory coordinator interface from browser process (#31295 )
Refs https://chromium-review.googlesource.com/c/chromium/src/+/3174305
* chore: fix build
* chore: fix lint
2021-10-06 15:43:45 -07:00
trop[bot]
dfcb2afffd
fix: suppress insecure resource warning for more local hostnames ( #31035 )
2021-09-21 11:29:02 +02:00
trop[bot]
f75b755f21
feat: add webContents.fromDevToolsTargetId() ( #30731 )
...
* feat: add webContents.fromDevToolsTargetId()
* refactor: avoid using FromOrCreate
Co-authored-by: samuelmaddock <samuel.maddock@gmail.com >
2021-09-09 11:54:13 +02:00
Jeremy Rose
ca1cae64d9
fix: remove ipc wrapper for nativeImage.createThumbnailFromPath ( #30736 )
2021-08-30 19:32:21 +09:00
trop[bot]
2e096ac6bc
fix: adjust initial webContents focus calculation ( #29234 )
...
* fix: adjust initial webContents focus calculation
* fix: active window check on mac
* fix: about:blank focus behavior
* chore: add spec
* fix: window ordering on mac
* chore: focus <webview> after navigation
* chore: fix flaky fullscreen inheritance test
* chore: disable fullscreen test on mac arm
* chore: simplify found-in-page spec
* chore: fix lint
* chore: move found-in-page spec to main process
* chore: fix lint
* chore: remove focus workaround
* chore: improve found-in-page spec
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2021-07-14 11:03:01 -07:00
trop[bot]
2195890a46
fix: self.module.paths not working in web workers ( #30013 )
...
* fix: global.module.paths in workers
* spec: add a regression test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-07-05 15:27:20 +09:00
trop[bot]
fa3767564a
fix: stop window.open from hanging when prevented ( #29882 )
...
* fix: stop window.open from hanging when prevented
* add test
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-06-28 15:24:18 +09:00
trop[bot]
9b1d2d5b88
fix: Inspector method overrides when contextIsolation enabled ( #29885 )
...
* fix: Inspector method overrides when contextIsolation enabled
* fix: handle DevToolsAPI call
* refactor: always use webFrame.executeJavaScript
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-06-25 17:50:39 +09:00
Milan Burda
62402870fd
fix: warnAboutRemoteModuleWithRemoteContent ( #29691 )
...
Co-authored-by: Milan Burda <miburda@microsoft.com >
2021-06-15 12:02:03 +02:00
trop[bot]
d7736e5924
fix: improper wrapping of fs.promises.readFile ( #29576 )
2021-06-08 10:31:27 +02:00
Keeley Hammond
c69d0eea2e
feat: add more info in setWindowOpenHandler details ( #28518 ) ( #29277 )
...
* fix: invoke the window open handler for _blank links
* feat: add disposition to setWindowOpenHandler details
* fix: pass postData to new-window event
* postData can be heterogeneous
* fix type of postBody
* fix type of UploadFile and UploadRawData to be discriminated unions
* exclude the empty string from additionalFeatures
* add a test
* add postBody and referrer to setWindowOpenHandler args
* appease typescript
* Update api-browser-window-spec.ts
* update snapshots
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-05-24 16:49:52 +09:00
trop[bot]
af6a5e6c30
fix: Menu.setApplicationMenu can return a useless array 29088 ( #29129 )
...
Co-authored-by: tabishmahfuz1 <tabish.mahfuz1@gmail.com >
2021-05-12 17:35:23 -07:00
trop[bot]
20a43d9a72
fix: <webview> focus / blur events don't work with contextIsolation enabled ( #29025 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-05-06 20:25:18 +09:00
trop[bot]
ae67ec24f3
refactor: use "as const" for constant mappings ( #29000 )
...
Co-authored-by: Milan Burda <milan.burda@gmail.com >
2021-05-05 15:59:47 +09:00
trop[bot]
87d3530d1b
fix: provide no-op implementation of app.setUserModelId ( #28921 )
...
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2021-04-29 09:56:20 +02:00
trop[bot]
f4d77d97e3
fix: do not handle write errors after request is aborted ( #28720 )
...
This fixes a flake on linux CI which started recently where the "write"
promise is being rejected after the request has been aborted /
cancelled. In this case we should drop the error to the floor but
instead we pass it down the stack where it eventually emits a now
unhandled error event.
Example failure: https://app.circleci.com/pipelines/github/electron/electron/38072/workflows/c1faf19b-aa41-4f99-a564-165729222859/jobs/838813
Verified fix by running the test that caused it 10000 times before fix
and 10000 times after. ~50 failures before, 0 after.
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
2021-04-19 11:26:20 -07:00
trop[bot]
7ce5af334e
fix: invoke the window open handler for _blank links ( #28536 )
...
* fix: invoke the window open handler for _blank links
* add test
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-04-07 10:05:12 +09:00
trop[bot]
5605358f99
fix: pass postData to new-window event ( #28542 )
...
* fix: pass postData to new-window event
* fix type of postBody
* fix type of UploadFile and UploadRawData to be discriminated unions
* exclude the empty string from additionalFeatures
* add a test
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-04-07 09:59:34 +09:00
trop[bot]
c87ecabf19
chore: update Community link in default menu ( #28459 )
...
Co-authored-by: Erick Zhao <erick@hotmail.ca >
2021-03-31 01:31:51 -07:00
trop[bot]
831bbc4b55
feat: allow omitting submitURL when uploadToServer is false ( #28283 )
...
* feat: allow omitting submitURL when uploadToServer is false
* docs
* fix test
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-03-24 19:52:42 -04:00
trop[bot]
38de02c50a
fix: window.print() in pdf plugin ( #28351 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2021-03-24 10:01:33 +09:00
trop[bot]
3b049c9074
feat: add process.contextId used by @electron/remote ( #28251 )
...
* feat: add process.contextId used by @electron/remote
* Update docs/api/process.md
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: Milan Burda <milan.burda@gmail.com >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
2021-03-18 15:16:46 +09:00
trop[bot]
010c6fd5be
fix: revert "refactor: mmap asar files ( #24470 )" ( #28203 )
...
This reverts commit 01a2e23194 .
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-03-16 19:21:21 +09:00
trop[bot]
c11d6813e4
fix: ensure child window transparency works ( #28112 )
...
* fix: ensure child window transparency works
Windows opened via window.open and intecepted via setWindowOpenHandler
or the `new-window` event should (a) have the correct background color
and (b) that background color should be transparent if specified.
The changes in api_web_contents fix (a) and the changes in
web_contents_preferences fix (b).
Notes: Child windows with specified background colors or transpency now
work as intended
* fix: set background_color in blink prefs apply logic
* chore: update for PR comments
Co-authored-by: Samuel Attard <sattard@slack-corp.com >
2021-03-12 09:18:41 -08:00
John Kleinschmidt
2ce64944ab
chore: bump chromium to 90.0.4415.0 (master) ( #27694 ) ( #28082 )
...
* chore: bump chromium in DEPS to 520c02b46668fc608927e0fcd79b6a90885a48bf
* chore: bump chromium in DEPS to 90.0.4414.0
* resolve chromium conflicts
* resolve v8 conflicts
* fix node gn files
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2676903: [mojo] Remove most legacy Binding classes.
https://chromium-review.googlesource.com/c/chromium/src/+/2676903
* 2644847: Move self-deleting URLLoaderFactory base into //services/network.
https://chromium-review.googlesource.com/c/chromium/src/+/2644847
* 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* 2672923: Remove RAPPOR reporting infrastructure.
https://chromium-review.googlesource.com/c/chromium/src/+/2672923
* 2673502: Remove RenderViewCreated use from ExtensionHost.
https://chromium-review.googlesource.com/c/chromium/src/+/2673502
* 2655126: Convert FrameHostMsg_ContextMenu and FrameMsg_ContextMenuClosed|CustomContextMenuAction to Mojo
https://chromium-review.googlesource.com/c/chromium/src/+/2655126
* 2628705: Window Placement: Implement screen.isExtended and change event
https://chromium-review.googlesource.com/c/chromium/src/+/2628705
* 2643161: Refactor storage::kFileSystem*Native*
https://chromium-review.googlesource.com/c/chromium/src/+/2643161
* fix build
* only remove the biggest subdir of //ios
* chore: bump chromium in DEPS to 90.0.4415.0
* update patches
* update sysroots
* 2686147: Remove WebContentsObserver::RenderViewCreated().
https://chromium-review.googlesource.com/c/chromium/src/+/2686147
* 2596429: Fixing how extension's split and spanning modes affect OriginAccessList.
https://chromium-review.googlesource.com/c/chromium/src/+/2596429
* 2686026: [mojo] Delete AssociatedInterfacePtr (replaced by AssociatedRemote)
https://chromium-review.googlesource.com/c/chromium/src/+/2686026
* 2651705: Move ui/base/dragdrop/file_info to ui/base/clipboard
https://chromium-review.googlesource.com/c/chromium/src/+/2651705
* 358217: drawBitmap is deprecated
https://skia-review.googlesource.com/c/skia/+/358217
* fix gn check
* 2678098: Use gen/front_end as input to generate_devtools_grd
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2678098
* 2674530: Remove CertVerifierService feature
https://chromium-review.googlesource.com/c/chromium/src/+/2674530
* fixup 2664006: Remove from mojo::DataPipe.
https://chromium-review.googlesource.com/c/chromium/src/+/2664006
* fixup build_add_electron_tracing_category.patch
* 2673415: [base] Prepare CrashReporterClient for string16 switch
https://chromium-review.googlesource.com/c/chromium/src/+/2673415
* 2673413: Add CursorFactoryWin to handle Cursors on Windows
https://chromium-review.googlesource.com/c/chromium/src/+/2673413
* 2668748: Move OnSSLCertificateError to a new interface.
https://chromium-review.googlesource.com/c/chromium/src/+/2668748
* fix mas gn check
* update patch after merge
* Update node for .mjs files
* build: load v8_prof_processor dependencies as ESM
* chore: add patch to fix linux 32bit
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
Co-authored-by: Jeremy Rose <jeremya@chromium.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com >
(cherry picked from commit ca75bca667 )
Co-authored-by: Electron Bot <electron@github.com >
2021-03-10 10:24:58 -08:00
Milan Burda
bf7e445883
fix: warning when worldSafeExecuteJavaScript is disabled ( #27928 )
2021-03-02 09:45:27 -08:00
Erick Zhao
2d0ad0b96a
fix: make TouchBarPopover and TouchBarGroup work ( #27901 )
...
* fix: use correct `orderedItem` touchbar property
* fix: correct parent in touchbar group and popover
* fix: preserve property hook order
2021-03-01 13:34:00 -08:00
Emil Pettersson
a9b25dda85
fix: race-condition in electron.net ( #27898 )
2021-02-26 13:18:46 -08:00
Tony
b181dae146
fix: isFullScreen typo ( #27823 )
...
* fix isFullScreen typo
* Update lib/browser/api/base-window.ts
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
Co-authored-by: Tony Wu <tonywoo@fb.com >
Co-authored-by: John Kleinschmidt <jkleinsc@github.com >
2021-02-22 15:33:46 -05:00
Shelley Vohr
599f398ddc
fix: enableBlinkFeatures warning in webviews ( #27753 )
2021-02-18 11:11:35 -08:00
Jeremy Rose
706d9ede9b
refactor: only allow internal messages from the main process ( #27676 )
2021-02-09 17:12:26 -08:00
Shelley Vohr
e46446e7e4
chore: bump chromium to e836cbe709f3cd703f233de8eb6cc6ec99b72c9d ( #27475 )
...
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Jeremy Rose <nornagon@nornagon.net >
2021-02-09 12:16:21 -08:00
Milan Burda
bc7c290601
refactor: load preload script directly as a string ( #27546 )
2021-02-08 09:32:20 -08:00
Michaela Laurencin
c175d41ae8
fix: remove windowName set as title for native window.open() ( #27481 )
2021-02-05 11:20:58 -08:00
Milan Burda
79b3393768
chore: remove bunch of usages of any ( #27512 )
2021-01-29 12:41:59 -08:00
Michaela Laurencin
357becd113
fix: replace default frameName title with null check ( #27521 )
...
* refactor: replace default frameName title with null check
* add isNativeWindowOpen check in makeBrowserWindowOptions
* modify snapshot test files
* replace title with frame-name again for proxy - not native open
* modify proxy snapshot title key-value to come after height key-value
2021-01-29 07:24:30 -06:00
Milan Burda
64b7be751a
fix: CSP with unsafe-eval detection with Trusted Types ( #27446 )
2021-01-25 10:31:25 +09:00
Milan Burda
4a5c5843c4
fix: <webview> not working with Trusted Types ( #27445 )
2021-01-25 10:29:25 +09:00
Milan Burda
70190ec2b1
chore: update to latest TypeScript, which has built-in WeakRef declarations ( #27425 )
2021-01-22 11:25:47 -08:00
Milan Burda
8b74361b0c
refactor: store WeakMaps in CallbacksRegistry / ObjectsRegistry ( #27037 )
2021-01-20 14:03:10 -08:00
Milan Burda
2be3d03630
feat: add webFrameMain.send() / webFrameMain.postMessage() ( #26807 )
2021-01-15 09:00:37 +09:00
Milan Burda
a55e028b12
fix: handle _sendToFrameInternal() throwing an exception in remote/server.ts ( #27046 )
2020-12-17 14:28:40 -08:00
Jeremy Rose
da3d21e5e3
fix: make webContents.id work even after destroy ( #27038 )
2020-12-17 12:10:29 -08:00
Jeremy Rose
6a3679dc55
fix: memory leak in desktopCapturer.getSources ( #27031 )
2020-12-16 16:11:39 -08:00
Cheng Zhao
998f17ee59
fix: make protocol wrapper remote-friendly again ( #27009 )
2020-12-16 16:56:53 +09:00
Milan Burda
6932e17088
chore: remove deprecated systemPreferences methods ( #26849 )
2020-12-16 08:34:24 +09:00
Avi Vahl
9b02d94e97
fix(asar): readdir(withFileTypes) fails on deep directory ( #26865 )
...
when using readdirSync on a deep directory within the archive, the code fails to get the stats of child paths.
2020-12-15 11:21:49 +09:00
Milan Burda
cec6378881
feat: add event.senderFrame property returning the originating webFrameMain ( #26764 )
2020-12-09 15:34:06 -08:00
Jeremy Rose
07a1c2a3e5
fix: restrict sendToFrame to same-process frames by default ( #26875 )
2020-12-09 12:48:16 -08:00