trop[bot]
4bd6182e83
fix: only call popup closecallback for top-level menu ( #49047 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-23 21:35:11 +01:00
Nikita Skovoroda
b32853b8aa
fix: devtools crashing on Linux in detach mode ( #48926 )
...
Backport of https://github.com/electron/electron/pull/48600
(8756e82b5f24dcda13225968c3655d37f73d195e)
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-13 15:28:25 -05:00
trop[bot]
074cedd561
feat: Focus DevTools when breakpoint is triggered ( #48701 )
...
`bringToFront` DevTools message is sent when breakpoint is triggered
or inspect is called and Chromium upon this message activates DevTools
via `DevToolsUIBindings::Delegate::ActivateWindow`:
```
void DevToolsWindow::ActivateWindow() {
if (life_stage_ != kLoadCompleted)
return;
\#if BUILDFLAG(IS_ANDROID)
NOTIMPLEMENTED();
\#else
if (is_docked_ && GetInspectedBrowserWindow())
main_web_contents_->Focus();
else if (!is_docked_ && browser_ && !browser_->window()->IsActive())
browser_->window()->Activate();
\#endif
}
```
which implements: `DevToolsUIBindings::Delegate::ActivateWindow`.
Electron also implements this interface in:
`electron::InspectableWebContents`. However it was only setting
a zoom level, therefore this commit extends it with activation
of the DevTools.
Only supported for DevTools manged by `electron::InspectableWebContents`.
Closes : #37388
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Michał Pichliński <michal.pichlinski@here.io >
2025-11-10 16:41:46 -05:00
trop[bot]
a924f1a629
fix: CSD window frame tiles properly on Wayland ( #48836 )
...
fix: CSD window frame tiles properly on Linux
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Mitchell Cohen <mitch.cohen@me.com >
2025-11-07 18:41:47 +01:00
trop[bot]
3d5f13a44a
fix(reland): allow disabling all NSMenuItems ( #48829 )
...
* fix: allow disabling all `NSMenuItems` (#48598 )
fix: allow disabling all NSMenuItems
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: add guard for type
Co-authored-by: George Xu <george.xu@slack-corp.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: George Xu <george.xu@slack-corp.com >
2025-11-07 10:37:00 +01:00
trop[bot]
88a4d1c593
fix: revert allow disabling all NSMenuItems, fix menu crash ( #48801 )
...
Revert "fix: allow disabling all `NSMenuItems` (#48598 )"
This reverts commit 0cb4fdd0f2khammond@slack-corp.com >
2025-11-06 10:56:16 -08:00
trop[bot]
112489328c
fix: allow disabling all NSMenuItems ( #48710 )
...
fix: allow disabling all NSMenuItems
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-10-30 12:07:50 +01:00
trop[bot]
a0be2f521d
fix: crash on empty dialog extensions array on Windows ( #48660 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-10-27 09:17:27 +01:00
trop[bot]
9008cf70f5
fix: background hover contrast for WCO buttons ( #48595 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-10-23 16:09:53 +02:00
trop[bot]
955afdd92b
fix: trafficLightPosition incorrect with customButtonsOnHover ( #48620 )
...
fix: trafficLightPosition incorrect with customButtonsOnHover
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-10-21 19:30:59 +02:00
trop[bot]
af55e45ce8
fix: dialog.showMessageBox defaultid on Windows ( #48519 )
...
* fix: dialog.showMessageBox defaultid on Windows
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* Update shell/browser/ui/message_box_win.cc
Co-authored-by: Robo <hop2deep@gmail.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-10-11 10:02:29 +02:00
trop[bot]
81db417caa
fix: MacOS 26 Tahoe - stop overriding private cornerMask API to fix WindowServer GPU load ( #48398 )
...
fix: MacOS 26 Tahoe - stop overriding private cornerMask API to fix WindowServer GPU load (#48376 )
fix: macOS stop overriding private cornerMask API to fix WindowServer GPU load spike
Electron fetched a custom `_cornerMask` for `ElectronNSWindow` to smooth
vibrancy corners. On macOS 15 (Tahoe) that private hook forces the window
shadow to be rendered from a fully transparent surface, causing the
WindowServer GPU load regression. Remove the `cornerMask` property and
the `_cornerMask` override so we stay on Apple’s default shadow path.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: avarayr <7735415+avarayr@users.noreply.github.com >
2025-09-27 16:16:33 -07:00
trop[bot]
d5907878bc
fix: showMessageDialog should center dialog to parent ( #48215 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-09-01 14:56:47 -07:00
trop[bot]
0098160f2a
fix: ensure dragging works again after emitting contextmenu event ( #48224 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-08-29 13:15:17 -04:00
electron-roller[bot]
cc67728226
chore: bump chromium to 140.0.7339.24 (38-x-y) ( #48147 )
...
* chore: bump chromium in DEPS to 140.0.7339.24
* chore: update patches
* Track DevTools feature usage in new badge tracker
https://chromium-review.googlesource.com/c/chromium/src/+/6842401
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-08-22 14:30:23 +02:00
Shelley Vohr
20a563c27d
feat: allow macOS tray to maintain position ( #48077 )
2025-08-20 13:03:54 -04:00
trop[bot]
9b1dfe90f4
fix: dark mode on Linux default themeing ( #47919 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-07-31 14:29:43 +02:00
trop[bot]
a41ca28b63
fix: window content protection on older Windows versions ( #47886 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-07-31 10:53:15 +02:00
trop[bot]
edccb0a7ea
chore: bump chromium to 140.0.7312.0 (38-x-y) ( #47881 )
...
* chore: bump chromium in DEPS to 140.0.7312.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 6769540: Move NetworkTrafficAnnotationTag out of PreconnectManager.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6769540
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* 6771377: Roll libc++ from 3eda1e62e799 to 569aa83b4bbc (7 revisions)
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6771377
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* 6771398: Remove unnecessary std::optional wrappers in ResolveHostClient
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6771398
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: update patches
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* 6776165: Use shared session bus for MPRIS
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6776165
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
2025-07-24 09:33:14 -04:00
trop[bot]
124bfd25f8
chore: bump chromium to 140.0.7301.0 (38-x-y) ( #47849 )
...
* chore: bump chromium in DEPS to 140.0.7296.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6702959: Remove OwnedByWidgetPassKey usage from content analysis dialog tests | https://chromium-review.googlesource.com/c/chromium/src/+/6702959
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6722750: Remove un-used `stream_id` argument for `AidaCodeComplete` | https://chromium-review.googlesource.com/c/chromium/src/+/6722750
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6696478: Reland Reland [video pip] Add fade in/out animation to controls visibility changes | https://chromium-review.googlesource.com/c/chromium/src/+/6696478
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
* chore: update libc++-filenames
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
* build: explicitly include cstdlib in Boyer-Moore patch
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
* chore: bump chromium in DEPS to 140.0.7297.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6729537: [FPF] Pipe flag state from the browser to the renderer | https://chromium-review.googlesource.com/c/chromium/src/+/6729537
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6727996: [Win] Detect pre-IPC crashes in sandboxed utility processes | https://chromium-review.googlesource.com/c/chromium/src/+/6727996
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6707182: Move wtf/cross_thread_copier*.* to "blink" namespace | https://chromium-review.googlesource.com/c/chromium/src/+/6707182
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6730796: extensions: Extract safe browsing/telemetry methods to new client class | https://chromium-review.googlesource.com/c/chromium/src/+/6730796
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* chore: bump chromium in DEPS to 140.0.7299.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
* chore: update main patches
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* build: reset the minimum macOS SDK to 15 to match upstream
This reverts commit 499e987c77khammond@slack-corp.com >
* 6730215: Remove IPC_MESSAGE_LOG_ENABLED ifdef blocks. | https://chromium-review.googlesource.com/c/chromium/src/+/6730215
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6690442: Delete ppapi/buildflags/buildflags.h | https://chromium-review.googlesource.com/c/chromium/src/+/6690442
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6667681: Use more binaries from clang toolchain in mac build | https://chromium-review.googlesource.com/c/chromium/src/+/6667681
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* chore: bump chromium in DEPS to 140.0.7301.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6656309: extensions: Port proxy API to desktop Android | https://chromium-review.googlesource.com/c/chromium/src/+/6656309
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6758510: Reland 'Move GN enable_plugins variable out of //ppapi' | https://chromium-review.googlesource.com/c/chromium/src/+/6758510
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6701466: [Extensions] Remove NaCl arch info from Update Client URLs | https://chromium-review.googlesource.com/c/chromium/src/+/6701466
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6735979: [FSA] Replace `request_writable` with a new enum `FileSystemAccessPermissionMode`. | https://chromium-review.googlesource.com/c/chromium/src/+/6735979
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6712080: Reland "Turn on gender translation PAK generation everywhere" | https://chromium-review.googlesource.com/c/chromium/src/+/6712080
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* 6730796: extensions: Extract safe browsing/telemetry methods to new client class | https://chromium-review.googlesource.com/c/chromium/src/+/6730796
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* build: restore minimum macOS SDK to 10, restore patch
This reverts commit a04c579b99khammond@slack-corp.com >
* fixup! 6701466: [Extensions] Remove NaCl arch info from Update Client URLs | https://chromium-review.googlesource.com/c/chromium/src/+/6701466
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* chore: correct node patches
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
* fixup! 6667681: Use more binaries from clang toolchain in mac build | https://chromium-review.googlesource.com/c/chromium/src/+/6667681
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
2025-07-21 11:55:08 -07:00
trop[bot]
ea0773c7c7
fix: dialog file filters and macOS app bundles ( #47841 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-07-21 19:44:16 +02:00
trop[bot]
b20e91d86f
fix: abnormal behavior of windows background material ( #47814 )
...
* fix: abnormal behavior of windows background material
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: zoy <zoy-l@outlook.com >
* chore: update patches
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
* fix: setting background material after init
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: zoy <zoy-l@outlook.com >
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-07-18 10:30:37 +02:00
trop[bot]
5081fbe830
fix: handle missing NativeWindowMac in ElectronNSWindow ( #47812 )
...
fix: handle missing NativeWindowMac in ElectronNSWindow
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-07-17 11:33:25 -04:00
electron-roller[bot]
2783f76f1f
chore: bump chromium to 140.0.7281.0 (38-x-y) ( #47559 )
...
* chore: bump chromium in DEPS to 139.0.7258.6
* chore: bump chromium in DEPS to 139.0.7258.5
* chore: bump chromium in DEPS to 140.0.7270.1
* chore: bump chromium in DEPS to 140.0.7271.1
* chore: bump chromium in DEPS to 140.0.7273.0
* chore: bump chromium in DEPS to 140.0.7273.1
* chore: bump chromium in DEPS to 140.0.7275.1
* chore: bump chromium in DEPS to 140.0.7275.4
* chore: bump chromium in DEPS to 140.0.7277.1
* chore: bump chromium in DEPS to 140.0.7279.1
* chore: bump chromium in DEPS to 140.0.7281.1
* chore: bump chromium in DEPS to 140.0.7283.1
* chore: bump chromium in DEPS to 140.0.7285.1
* chore: bump chromium in DEPS to 140.0.7287.1
* chore: bump chromium in DEPS to 140.0.7289.0
* chore: bump chromium in DEPS to 140.0.7289.1
* chore: bump chromium in DEPS to 140.0.7291.1
* chore: bump chromium in DEPS to 140.0.7293.1
* chore: bump chromium in DEPS to 140.0.7295.1
* chore: bump chromium in DEPS to 140.0.7296.0
* chore: bump chromium to 140.0.7281.0 (main) (#47616 )
cherry picked from 603cafad7ehttps://chromium-review.googlesource.com/c/chromium/src/+/6516731
* 6694809: dbus: Ensure systemd scope is started before using any portal services | https://chromium-review.googlesource.com/c/chromium/src/+/6694809
* chore: patch chromium
* chore: export patches
* chore: bump chromium in DEPS to 140.0.7275.0
* 6677511: [pepper] More pepper removal | https://chromium-review.googlesource.com/c/chromium/src/+/6677511
* 6513641: [gin] Rename gin::Wrappable to gin::DeprecatedWrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6513641
* chore: export chromium patches
* 6513641: [gin] Rename gin::Wrappable to gin::DeprecatedWrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6513641
* chore: bump chromium in DEPS to 140.0.7277.0
* chore: bump chromium in DEPS to 140.0.7279.0
* chore: bump chromium in DEPS to 140.0.7281.0
* 6677314: Plumb enabled client hints in the network requestion to network layer
https://chromium-review.googlesource.com/c/chromium/src/+/6677314
* 6351556: [source-phase-imports] Support Wasm Source Phase Imports
https://chromium-review.googlesource.com/c/chromium/src/+/6351556
* 6700077: [renderer] Avoid calls to deprecated GetIsolate methods
https://chromium-review.googlesource.com/c/chromium/src/+/6700077
* 6692873: Reland "Reland "FSA: Only normalize the hardcoded rules once during initialization""
https://chromium-review.googlesource.com/c/chromium/src/+/6692873
* 6686234: [gin] Cleanup NamedPropertyInterceptor for Wrappable
https://chromium-review.googlesource.com/c/chromium/src/+/6686234
* chore: export patches
* 6667723: Remove content_enable_legacy_ipc GN arg.
https://chromium-review.googlesource.com/c/chromium/src/+/6667723
* 6646566: ui: Move NativeWindowTracker to its own directory
https://chromium-review.googlesource.com/c/chromium/src/+/6646566
* fix: add missing includes
* 6580522: [WAR, DNR] Fix unsafe redirect error to web accessible resource
https://chromium-review.googlesource.com/c/chromium/src/+/6580522
* 6680477: Implement `completeCode` endpoint and expose to DevTools
https://chromium-review.googlesource.com/c/chromium/src/+/6680477
* 6677511: [pepper] More pepper removal
https://chromium-review.googlesource.com/c/chromium/src/+/6677511
* 6696689: Rename views::WidgetFocusManager -> NativeViewFocusManager
https://chromium-review.googlesource.com/c/chromium/src/+/6696689
* 6702812: Move wtf/text/string_impl*.* to "blink" namespace
https://chromium-review.googlesource.com/c/chromium/src/+/6702812
* chore: fix dialog patch
* 6702431: [animation-trigger] Parse timeline-trigger-name
https://chromium-review.googlesource.com/c/chromium/src/+/6702431
* chore: fixup patch indices
* feat: replace webFrame.routingId with webFrame.frameToken
* feat: WebFrameMain.prototype.frameToken
* test: refactor to use replacement APIs
* chore: fixup pip patch
* test: adjust webFrame tests for frameToken changes
* 6703757: Reland "Enable -fsanitize=array-bounds in non-UBSan builds"
https://chromium-review.googlesource.com/c/chromium/src/+/6703757
* test: switch to frameTokens
* test: routingId is fine to test in the main process
* docs: add routingId to breaking changes
* docs: update plugin-crashed event
* chore: fixup linux dialog patch
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
(cherry picked from commit 603cafad7ejkleinsc@electronjs.org >
Co-authored-by: alice <alice@makenotion.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-07-15 12:05:29 -04:00
trop[bot]
0b77096f2a
fix: default to system accent color on invalid user color ( #47684 )
...
fix: default to system accent color on invalid user color"
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-07-08 15:21:44 +02:00
trop[bot]
130f00dfcd
fix: fullscreen for windows without rounded corners ( #47681 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-07-08 15:21:13 +02:00
trop[bot]
85a8bfaa31
chore: bump chromium to 139.0.7256.0 (38-x-y) ( #47615 )
...
* chore: bump chromium in DEPS to 139.0.7242.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update render_widget_host_view_mac.patch
no code changes; just updating patch context
Do a cleanup pass on the history swiper code | https://chromium-review.googlesource.com/c/chromium/src/+/6604367
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update mas_avoid_private_macos_api_usage.patch.patch
no code changes; just updating patch context
[tracing] Delete base/trace_event/base_tracing.h | https://chromium-review.googlesource.com/c/chromium/src/+/6624012
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
no manual changes; just updating patch context
[ActorFramework] Refactor Actor Task Management | https://chromium-review.googlesource.com/c/chromium/src/+/6618684
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update fix_move_autopipsettingshelper_behind_branding_buildflag.patch
[pip] Tuck picture-in-picture windows when a file dialog is open | https://chromium-review.googlesource.com/c/chromium/src/+/6449682
Reland "[document pip] Restrict the size that a website can request" | https://chromium-review.googlesource.com/c/chromium/src/+/6372104
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update feat_corner_smoothing_css_rule_and_blink_painting.patch
Xref: corner-shape: constraint radii based on opposite corner overlap | https://chromium-review.googlesource.com/c/chromium/src/+/6592572
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update revert_code_health_clean_up_stale_macwebcontentsocclusion.patch
no manual changes; just updating patch context
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: update fix_rename_sqlite_win32_exports_to_avoid_conflicts_with_node_js.patch
no code changes; just updating patch context
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: e patches all
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Plumb Verify2QwacBinding and hook it up in QwacWebContentsObserver
https://chromium-review.googlesource.com/c/chromium/src/+/6624719
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Remove host delegate OnMainFrameCreatedForBackgroundPage
https://chromium-review.googlesource.com/c/chromium/src/+/6631123
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Extensions: Rename GetResourceURL to ResolveExtensionURL
https://chromium-review.googlesource.com/c/chromium/src/+/6625053
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Consolidate NativeFrameViewMac
https://chromium-review.googlesource.com/c/chromium/src/+/6614239
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* ICWYU
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Remove dead code WidgetAXTreeIDMap
https://chromium-review.googlesource.com/c/chromium/src/+/6619701
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Reland "extensions: Add `WillPrepareForEvaluation` to setup MojoJS"
https://chromium-review.googlesource.com/c/chromium/src/+/6630056
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* NavigationThrottleRunner2: Remove MaybeAddThrottle
https://chromium-review.googlesource.com/c/chromium/src/+/6628079
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Tuck picture-in-picture windows when a file dialog is open
https://chromium-review.googlesource.com/c/chromium/src/+/6449682
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* build: fix snapshot_blob.bin build error
xref: https://issues.chromium.org/issues/416540976
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: e patches all
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* build: freeup disk space on macos
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: bump chromium in DEPS to 139.0.7244.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update printing.patch
no manual changes; just updating patch context
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: remove upstreamed ignore_parse_errors_for_resolveshortcutproperties.patch
Prevent Windows crash on unexpected shortcut type | https://chromium-review.googlesource.com/c/chromium/src/+/6633298
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: e patches all
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Revert "Reland "extensions: Add `WillPrepareForEvaluation` to setup MojoJS""
This reverts commit 77c4f967a6http://crash/28f897bb9743dfe0 | https://chromium-review.googlesource.com/c/chromium/src/+/6641819
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Fix spec's expected base64-encoded PNG strings to match upstream changes.
[rust png] Enable by default. | https://chromium-review.googlesource.com/c/chromium/src/+/6085801
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: bump chromium in DEPS to 139.0.7246.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: e patches all
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* chore: bump chromium in DEPS to 139.0.7248.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: update patches
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* siso: Enable Siso by default for non-Google builds
https://chromium-review.googlesource.com/c/chromium/src/+/6638830
Disabling for now until we are ready to build siso on all platforms.
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Revert "revert Don't use static variable for UseExternalPopupMenus"
This reverts commit e91e3894e6jkleinsc@electronjs.org >
* Update mac_sdk_min to match minimum required SDK version
https://chromium-review.googlesource.com/c/chromium/src/+/6493969
(cherry picked from commit 3e7cbe912djkleinsc@electronjs.org >
* Use default window styling on Mac
https://chromium-review.googlesource.com/c/chromium/src/+/6648665
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* Reland "Force the unintentional renderer process creation check by default"
https://chromium-review.googlesource.com/c/chromium/src/+/6626905
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* fixup: Reland "Force the unintentional renderer process creation check by default
https://chromium-review.googlesource.com/c/chromium/src/+/6626905
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: bump chromium in DEPS to 139.0.7249.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* fixup: Reland "Force the unintentional renderer process creation check by default
https://chromium-review.googlesource.com/c/chromium/src/+/6626905
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: update patches
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
* chore: bump chromium in DEPS to 139.0.7250.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 139.0.7252.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: bump chromium in DEPS to 139.0.7254.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* 6638187: browser level TOCTOU check for coordinate target
https://chromium-review.googlesource.com/c/chromium/src/+/6638187
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fixup patch indices
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: add missing base/notimplemented includes
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* 6652910: [Frame Cleanup] Push down/hide implementation-specific API
https://chromium-review.googlesource.com/c/chromium/src/+/6652910
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: bump chromium in DEPS to 139.0.7256.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* chore: fix lint
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fixup! 6652910: [Frame Cleanup] Push down/hide implementation-specific API
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: move HandleScope location
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: bump chromium in DEPS to 139.0.7258.0
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
* fixup! [NonClientFrameView] Consolidate NativeFrameViewMac
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* Revert "chore: bump chromium in DEPS to 139.0.7258.0"
This reverts commit 264b2e934fhop2deep@gmail.com >
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: patchup[bot] <73610968+patchup[bot]@users.noreply.github.com>
2025-06-30 12:29:54 -04:00
trop[bot]
34dcfb5422
fix: Reland "[accessibility] Platform node lifetime cleanups" ( #47610 )
...
Reland "[accessibility] Platform node lifetime cleanups"
https://chromium-review.googlesource.com/c/chromium/src/+/6462552
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-06-30 10:59:26 +02:00
trop[bot]
68c769de94
refactor: avoid copies of large objects in range based for loops ( #47606 )
...
* Avoid copies of large objects in range-based for-loops.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/6527689
Co-authored-by: Charles Kerr <charles@charleskerr.com >
* Avoid copies of large objects in range-based for-loops in Browser::ShowAboutPanel()
Co-authored-by: Charles Kerr <charles@charleskerr.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-06-30 10:28:53 +02:00
trop[bot]
4268bf91e4
refactor: remove stray .c_str() calls for absl::StrFormat() ( #47578 )
...
refactor: remove stray .c_str() calls for absl::StrFormat()
StrFormat() understands std::string, std::string_view
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2025-06-26 11:41:48 -05:00
Shelley Vohr
93d5152a25
fix: chrome://accessibility loading correctly ( #47497 )
...
fix: chrome://accessibility loading correctly
2025-06-23 14:38:29 +02:00
electron-roller[bot]
6779769d22
chore: bump chromium to 139.0.7219.0 (main) ( #47348 )
...
* chore: bump chromium in DEPS to 139.0.7205.0
* 6543986: Mac: decouple deserializing and applying sandbox policy
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6543986
* 6580079: Reland 'Remove the third-party blocking feature'
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6580079
* 6505716: guest-contents: Add components/guest_contents
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6505716
* 6572556: Move LogMessageManager out of gpu_service_impl.cc.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6572556
* 6566111: Change UtilityProcessHost to manage its instance internally
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6566111
* 6550237: Rename ReconnectEventObserver to ConnectionChangeObserverClient
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6550237
* 6565918: Validate path is valid UTF8 in SelectFileDialogLinuxPortal
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6565918
* 6579713: Remove base::NotFatalUntil::M130 usage
6566111: Change UtilityProcessHost to manage its instance internally
Refs
https://chromium-review.googlesource.com/c/chromium/src/+/6579713
https://chromium-review.googlesource.com/c/chromium/src/+/6566111
* chore: update chromium patches
* chore: update remaining patches
* fixup! 6566111: Change UtilityProcessHost to manage its instance internally Refs https://chromium-review.googlesource.com/c/chromium/src/+/6566111
* 6577970: Remove superfluous includes for base/strings/stringprintf.h in headers
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6577970
* 6568811: Add FunctionCall structured metrics event for DevTools
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6568811
* [PDF Ink Signatures] Support PdfAnnotationsEnabled policy
https://chromium-review.googlesource.com/c/chromium/src/+/6558970
* build: disable libcxx modules for rbe
* chore: bump chromium in DEPS to 139.0.7217.0
* chore: bump chromium in DEPS to 139.0.7218.0
* chore: update patches
fix_use_delegated_generic_capturer_when_available.patch was updated to handle a small change:
6582142: Use content::Create*Capturer in DesktopCaptureDevice. | https://chromium-review.googlesource.com/c/chromium/src/+/6582142
* chore: bump chromium in DEPS to 139.0.7219.0
* chore: update patches
* 6594615: Change Chromium's deployment target to macOS 12
https://chromium-review.googlesource.com/c/chromium/src/+/6594615
Updated the assertion message to match the docs structure now too. I removed the callout to the supported versions doc because it has moved and doesn't contain minimum platform version information.
* 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_
https://chromium-review.googlesource.com/c/chromium/src/+/6606232
|NativeWindow::GetContentMinimumSize| and |NativeWindow::GetContentMaximumSize| may be good opportunities for a refactor now.
* add squirrel.mac patch for removed function
This was triggered by the macOS 12.0 deployment upgrade change.
See: https://developer.apple.com/documentation/coreservices/1444079-uttypeconformsto?language=objc
* 6582142: Use content::Create*Capturer in DesktopCaptureDevice.
https://chromium-review.googlesource.com/c/chromium/src/+/6582142
* 6579732: Two minor API "quality of life" cleanups in OSCrypt Async
https://chromium-review.googlesource.com/c/chromium/src/+/6579732
* chore: add include for base::SingleThreadTaskRunner
Not sure what change caused this, I expect it would be a removed include somewhere else, but it's likely not important to track down.
* chore: update libcxx filenames
* chore: update CI build-tools commit target for macOS SDK 15.4
The following change uses an API that was added in the macOS 15.4 SDK. Support for that SDK version was added later than the current build-tools commit target.
6575804: Use a quick-and-dirty solution to avoid glitching with paste-and-go | https://chromium-review.googlesource.com/c/chromium/src/+/6575804
See: https://developer.apple.com/documentation/appkit/nspasteboard/accessbehavior-swift.enum?language=objc
* fixup! 6606232: [views] Remove DesktopWindowTreeHostWin::window_enlargement_ https://chromium-review.googlesource.com/c/chromium/src/+/6606232
* chore: bump chromium in DEPS to 139.0.7220.0
* chore: update patches
Minor changes due to:
6613978: pwa: let events fall through in the transparent area of TopContainerView | https://chromium-review.googlesource.com/c/chromium/src/+/6613978
6614778: Refactor auto pip tab observer for Android support | https://chromium-review.googlesource.com/c/chromium/src/+/6614778
* 6543986: Mac: decouple deserializing and applying sandbox policy
https://chromium-review.googlesource.com/c/chromium/src/+/6543986
The DecodeVarInt and DecodeString functions look benign from a MAS perspective. I suspect they were patched out to avoid "unused function" errors. Their complements for encoding are unpatched, supporting this idea.
The code that uses these functions was refactored out of the section that we patch out. Instead of patching out that new function, I decided to treat it the same as the serialization function that is unpatched.
* chore: bump chromium in DEPS to 139.0.7222.0
* chore: bump chromium in DEPS to 139.0.7224.0
* chore: bump chromium in DEPS to 139.0.7226.0
* chore: bump chromium in DEPS to 139.0.7228.0
* chore: update patches
* Don't use static variable for UseExternalPopupMenus
https://chromium-review.googlesource.com/c/chromium/src/+/6534657
* Reland "Roll libc++ from a01c02c9d4ac to a9cc573e7c59
https://chromium-review.googlesource.com/c/chromium/src/+/6607589
* chore: bump chromium in DEPS to 139.0.7219.0
* chore: update patches
* revert Don't use static variable for UseExternalPopupMenus
* tls: remove deprecated tls.createSecurePair and SecurePair
https://github.com/nodejs/node/pull/57361
* Revert "Reland "Roll libc++ from a01c02c9d4ac to a9cc573e7c59"
This reverts commit 33e1436a0chttps://chromium-review.googlesource.com/c/chromium/src/+/6606232 "
This reverts commit 32e75651c189c51aa1c7https://chromium-review.googlesource.com/c/chromium/src/+/6606232
Reverting as we need this functionality for now.
* fixup: remove patch that was accidentally added back
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: clavin <clavin@electronjs.org >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-06-16 12:46:06 -05:00
Charles Kerr
6f915e85e2
refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath> ( #47428 )
...
* refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
* fixup! refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath>
2025-06-12 12:25:40 +02:00
electron-roller[bot]
53fd879043
chore: bump chromium to 138.0.7190.0 (main) ( #47107 )
...
* chore: bump chromium in DEPS to 138.0.7180.0
* 6546797: Add a metric for the overall success of the "safe storage" item retrieval.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6546797
* 6548078: extensions: Fix TODO in ScriptInjectionTracker for desktop Android
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6548078
* 6544950: Revert "FSA: Only normalize the hardcoded rules once during initialization"
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6544950
* chore: bump chromium in DEPS to 138.0.7181.0
* chore: update patches
* fix: correctly clamp HSL shift values between 0 and 1
* chore: bump DEPS to 138.0.7183.0
* 6553142: Remove SelectFileDialogLinuxKde | https://chromium-review.googlesource.com/c/chromium/src/+/6553142
* chore: update patches
* chore: bump chromium in DEPS to 138.0.7184.0
* chore: bump chromium in DEPS to 138.0.7186.0
* chore: bump chromium in DEPS to 138.0.7190.0
* chore: update patches
* 6547778: Remove some superfluous //ui/gfx includes from //chrome headers | https://chromium-review.googlesource.com/c/chromium/src/+/6547778
* 6556022https://chromium-review.googlesource.com/c/chromium/src/+/6556022
* fix: remove pdf_extension_util::AddAdditionalData
https://chromium-review.googlesource.com/c/chromium/src/+/4099130
This was removed 2 years ago in Chrome.
* fix: provide BrowserContext to pdf_extension_util::AddAdditionalData
https://chromium-review.googlesource.com/c/chromium/src/+/6558173
* fixup! 6556022https://chromium-review.googlesource.com/c/chromium/src/+/6556022
* fix: pass in navigation throttle registry
https://chromium-review.googlesource.com/c/chromium/src/+/6536175
* fixup! 6556022https://chromium-review.googlesource.com/c/chromium/src/+/6556022
This partially reverts commit 20d709dd15ba0ff332e24ee314149d642dc5d47c.
* 6545984: corner-shape: render dashed & dotted borders
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6545984
* Update corner smoothing expected images
* Apply "future" revert commit to fix windows build
> Reason for revert: Multiple eng reporting that this is causing build failures due to too-long pathnames, with no immediate feasible workaround
This issue also affects our CI builds.
Problematic CL in current roll: 6494836: [webgl] Add stub WebGL[2]RenderingContextWebGPU | https://chromium-review.googlesource.com/c/chromium/src/+/6494836
"Future" revert CL: 6565622: Revert "[webgl] Add stub WebGL[2]RenderingContextWebGPU" | https://chromium-review.googlesource.com/c/chromium/src/+/6565622
This patch should automatically disappear when we roll the revert.
* 6533919: win: don't add WS_CAPTION style to popup windows
https://chromium-review.googlesource.com/c/chromium/src/+/6533919
This mirrors the change made earlier to the code ours is based on: 6374074: [headless] Provide headless aware window metrics on Windows | https://chromium-review.googlesource.com/c/chromium/src/+/6374074
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
Co-authored-by: clavin <clavin@electronjs.org >
2025-06-03 11:19:20 -04:00
Robo
5ccbfa2faf
fix: regression with directory selection in macOS dialogs ( #47259 )
2025-05-27 19:08:11 +09:00
Shelley Vohr
f89c2a0ef4
fix: titlebar showing in content protected window ( #47241 )
...
Closes https://github.com/electron/electron/issues/47152 .
2025-05-26 09:46:04 +02:00
Shelley Vohr
c6f368acc6
chore: debug crash on DevTools SetOwnerWindow ( #47243 )
2025-05-26 09:45:43 +02:00
Gellert Hegyi
b9b96a96f7
feat: add menu item role palette and header ( #45538 )
...
* feat: add menu item role `palette` and `header`
* adds comments
* refactors new role items to new item types
* docs: custom type
* docs: note types only available on mac 14+
---------
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com >
2025-05-23 12:43:49 -04:00
Charles Kerr
2e8fc17f07
refactor: pass views::Widget* into constructors of our TreeHosts and NativeWidgets ( #47177 )
...
* refactor: remove unnecessary downcast in MenuViews::PopupAt()
* refactor: pass a views::Widget as an arg to the ElectronDesktopWindowTreeHostLinux ctor
* refactor: pass a views::Widget as an arg to the ElectronDesktopNativeWidgetAura ctor
* refactor: pass a views::Widget as an arg to the ElectronDesktopWindowTreeHostWin ctor
* refactor: create desktop_window_tree_host_ in the ElectronDesktopNativeWidgetAura constructor
* fixup! refactor: create desktop_window_tree_host_ in the ElectronDesktopNativeWidgetAura constructor
fix: tyop
2025-05-21 16:02:55 -05:00
Charles Kerr
21155679a0
refactor: add NativeWindowViews::GetClientFrameViewLinux() ( #47130 )
...
* refactor: add NativeWindowViews::GetClientFrameViewLinux()
* chore: clarify code comment
2025-05-20 14:15:06 -05:00
Charles Kerr
8efd24c339
perf: don't create unused menuitem icons ( #47100 )
...
GTK >= 3.90.0 removed support for menuitem icons. When Electron is
built with GTK >= 3.90.0, our code builds these icons and then throws
them away unused. Instead, let's just not build them.
Our gtk_util::GdkPixbufFromSkBitmap utility uses BGRAToRGBA and is
expensive to call.
2025-05-16 02:43:03 -05:00
Charles Kerr
77c58658c5
refactor: decouple NativeWindowViews and GlobalMenuBarX11 ( #47094 )
...
The GlobalMenuBar used to hold a raw_ptr reference to its NativeWindow;
but since it doesn't use it & only wants the gfx::AcceleratedWidget info,
let's remove the NativeWindowViews reference.
AFAICT, GlobalMenuBarX11::window_ has never been used
2025-05-15 16:10:56 -05:00
Robo
99a3e360ec
fix: opening package paths as directory on macOS ( #47077 )
2025-05-15 12:47:46 -05:00
Charles Kerr
9a7b73b533
refactor: use kKeyModifiers in IsAltModifier() ( #47066 )
...
We probably didn't use this before because IsAltModifier() was written
two years before the KeyModifiers mask was added upstream in 98ec378a.
2025-05-14 11:00:00 -04:00
electron-roller[bot]
d65a856bf3
chore: bump chromium to 138.0.7177.0 (main) ( #47081 )
...
* chore: bump chromium in DEPS to 138.0.7177.0
* 6530423: [WebContents] Fix IsNeverComposited() calls during initialization
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6530423
* 6512551: [ios] Enable -Wobjc-property-assign-on-object-type
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6512551
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2025-05-14 10:08:31 -04:00
Charles Kerr
11fa915724
refactor: remove introduce_ozoneplatform_electron_can_call_x11_property.patch ( #47075 )
...
* refactor: use x11_util::IsX11() in BuildSubmenuFromModel()
* refactor: use x11_util::IsX11() in ElectronDesktopWindowTreeHostLinux::OnBoundsChanged()
* refactor: use skia_can_fall_back_to_x11 in x11_util::IsX11()
it is identical in practice to electron_can_call_x11 and does not require a Chromium patch
* chore: remove introduce_ozoneplatform_electron_can_call_x11_property.patch
* refactor: use ui::GetOzonePlatformId() to test for x11
2025-05-14 13:38:35 +09:00
Shelley Vohr
7ab032f594
fix: white window flicker on window creation ( #47022 )
2025-05-10 18:24:35 -05:00
Michaela Laurencin
10e4f9ad37
feat: enable secondary label for macOS menu ( #46887 )
...
* feat: enable secondary label for macOS menu
* Update shell/browser/ui/cocoa/electron_menu_controller.mm
Co-authored-by: Robo <hop2deep@gmail.com >
* fix for lint
* update docs for sublabel
---------
Co-authored-by: Robo <hop2deep@gmail.com >
2025-05-09 12:05:26 -04:00
Shelley Vohr
75cf8ea96d
fix: restore previous Windows screenshotting ( #47020 )
...
Fixes https://github.com/electron/electron/issues/45990
We previously made a change in https://github.com/electron/electron/pull/45868
to fix content protection being lost on hide and re-show. However, this
cause a breaking change where protected windows were made opaque black
instead of being hidden as before. This overrides relevant methods in
ElectronDesktopWindowTreeHostWin to restore the previous behavior.
without regressing the original issue.
2025-05-09 09:38:27 -05:00
Robo
8e8d3a4f3e
fix: use-after-move of bus connection in xdg portal detection ( #47008 )
2025-05-09 18:32:08 +09:00
