trop[bot]
9be5389e77
fix: preserve staged update dir when pruning orphaned updates on macOS ( #50216 )
...
* fix: preserve staged update dir when pruning orphaned update dirs on macOS
The previous squirrel.mac patch cleaned up all staged update directories
before starting a new download. This kept disk usage bounded but broke
quitAndInstall() if called while a subsequent checkForUpdates() was in
flight — the already-staged bundle would be deleted out from under it.
This reworks the patch to read ShipItState.plist and preserve the
directory it references, deleting only truly orphaned update.XXXXXXX
directories. Disk footprint stays bounded (at most 2 dirs: staged +
in-progress) and quitAndInstall() remains safe mid-check.
Also adds test coverage for the quitAndInstall/checkForUpdates race and
a triple-stack scenario where 3 updates arrive without a restart.
Refs https://github.com/electron/electron/issues/50200
Co-authored-by: Samuel Attard <sattard@anthropic.com >
* chore: update patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@anthropic.com >
Co-authored-by: Keeley Hammond <vertedinde@electronjs.org >
2026-03-12 01:57:22 +00:00
trop[bot]
de5d94bc49
fix: validate protocol scheme names in setAsDefaultProtocolClient ( #50158 )
...
fix: validate protocol scheme names in setAsDefaultProtocolClient
On Windows, `app.setAsDefaultProtocolClient(protocol)` directly
concatenates the protocol string into the registry key path with no
validation. A protocol name containing `\` could write to an arbitrary
subkey under `HKCU\Software\Classes\`, potentially hijacking existing
protocol handlers.
To fix this, add `Browser::IsValidProtocolScheme()` which validates that a protocol
name conforms to the RFC 3986 scheme grammar:
scheme = ALPHA *( ALPHA / DIGIT / "+" / "-" / "." )
This rejects backslashes, forward slashes, whitespace, and any other
characters not permitted in URI schemes.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-03-10 00:04:27 -05:00
trop[bot]
04e39e24e6
refactor: use WHATWG URL instead of url.parse ( #50142 )
...
refactor: use WHATWG URL instead of url.parse
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-03-09 17:36:12 -04:00
trop[bot]
15b95fcd52
fix: Revert "updated Alt detection to explicitly exclude AltGraph/AltGr ( #49778 )" ( #50110 )
...
Revert "fix: updated Alt detection to explicitly exclude AltGraph/AltGr (#49778 )"
This reverts commit 90c9de70achttps://github.com/electron/electron/issues/50050
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: clavin <clavin@electronjs.org >
2026-03-06 21:05:45 -08:00
trop[bot]
a3022df30f
build: fix code-signing for MacOS x64 tests ( #50072 )
...
* fix: code-sign binaries for notification tests
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* test: remove redundent feedURL test
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* test: move squirrel feed tests to api-autoupdater
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* fix: fix SQRLShipItRequest.JSONKeyPathsByPropertyKey mappings
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* Revert "fix: fix SQRLShipItRequest.JSONKeyPathsByPropertyKey mappings"
This reverts commit 5ad9892a67khammond@slack-corp.com >
* test: unsign tests requiring no signed app
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
* fixup! fix: fix SQRLShipItRequest.JSONKeyPathsByPropertyKey mappings
chore: fix patch shear
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com >
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2026-03-05 10:27:29 +01:00
trop[bot]
79d1e32281
fix: uaf in non-client hittest during view teardown ( #50053 )
...
* fix: uaf in non-client hittest during view teardown
Co-authored-by: deepak1556 <hop2deep@gmail.com >
* chore: update crash spec
Co-authored-by: deepak1556 <hop2deep@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2026-03-03 14:16:05 -05:00
trop[bot]
1bbe8c9610
fix: use destination context when wrapping VideoFrame in contextBridge ( #50022 )
...
Enter the destination context scope before creating the VideoFrame V8
wrapper, matching the sibling Element and Blob branches. Without this,
ScriptState::ForCurrentRealm resolved to the calling context instead of
the target context, producing an incorrect wrapper.
Also switch to ScriptState::From with an explicit context argument to
make the intent clearer.
Adds spec coverage for VideoFrame crossing the bridge in both
directions and adds VideoFrame to the existing prototype checks.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@anthropic.com >
2026-03-02 23:30:16 -08:00
trop[bot]
649c19c877
fix: menu bar hiding on two setFullscreen(false) ( #49994 )
...
* test: add failing test for `setFullscreen(false)`
`setFullscreen(false)` should do nothing
when not already in fullscreen, but it hides the menu bar
on Linux.
Co-authored-by: WofWca <wofwca@protonmail.com >
* fix: menu bar hiding on two setFullScreen(false)
This fixes the following bug on Linux (and maybe macOS):
1. Create a window with a menu bar.
2. Call `win.setFullScreen(false)`.
The menu bar will hide.
See the original bug in our project:
https://github.com/deltachat/deltachat-desktop/issues/4752 .
Co-authored-by: WofWca <wofwca@protonmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: WofWca <wofwca@protonmail.com >
2026-03-02 16:01:22 +01:00
trop[bot]
488af02eaa
fix: menu close event missing after opening a submenu ( #49963 )
...
* fix: menu close event missing after opening a submenu
Co-authored-by: Jarek Radosz <jarek@cvx.dev >
* add a unit-like test
Co-authored-by: Jarek Radosz <jarek@cvx.dev >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Jarek Radosz <jarek@cvx.dev >
2026-02-26 17:29:31 -05:00
reito
589e08af80
fix: offscreen rendering with correct screen info. ( #49681 )
...
* fix: osr use correct screen info.
* fix: 40-x-y types
* Update breaking changes documentation
Removed details about planned breaking API changes for versions 41.0 and 42.0.
2026-02-26 11:08:34 -05:00
trop[bot]
d6e6fcea86
feat: add support for --experimental-transform-types ( #49883 )
...
* feat: add support for `--experimental-transform-types`
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: add tests
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* docs: add `--experimental-transform-types` to docs
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2026-02-25 12:54:38 -05:00
trop[bot]
a9837ed476
fix: updated Alt detection to explicitly exclude AltGraph/AltGr ( #49915 )
...
fix: updated Alt detection to explicitly exclude AltGraph/AltGr (#49778 )
Updated Alt detection to explicitly exclude AltGraph/AltGr
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shashwat Raj <65155843+darthvader58@users.noreply.github.com >
2026-02-23 15:29:25 -08:00
trop[bot]
1f7269f482
fix: apply zoomFactor from setWindowOpenHandler to window.open() windows ( #49909 )
...
fix: apply zoomFactor from setWindowOpenHandler to window.open() windows
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-02-23 11:36:55 +01:00
trop[bot]
adfc062313
fix: fullscreen restoration on Windows ( #49892 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-02-20 14:29:48 -05:00
trop[bot]
4c5637c687
ci: log mocha retries in spec runner ( #49877 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Nilay Arya <84241885+nilayarya@users.noreply.github.com >
2026-02-19 16:22:21 -06:00
trop[bot]
ada2c4e072
feat: add focusOnNavigation flag to WebPreferences ( #49512 )
...
* feat: add focusOnNavigation webPreference
Co-authored-by: Kyle Cutler <kycutler@microsoft.com >
* WebContentsView tests
Co-authored-by: Kyle Cutler <kycutler@microsoft.com >
* fix
Co-authored-by: Kyle Cutler <kycutler@microsoft.com >
* fix
Co-authored-by: Kyle Cutler <kycutler@microsoft.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Kyle Cutler <kycutler@microsoft.com >
2026-02-18 15:51:20 -05:00
trop[bot]
1a76e35971
feat: add support for long-animation-frame script attribution ( #49772 )
...
* feat: add support for `long-animation-frame` script attribution
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* docs: document `AlwaysLogLOAFURL`
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: add test
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* docs: adjust docs as per PR comment
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* fix: test failures
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: simplify test
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* fix: tests on Windows and Linux
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
* chore: fixup patches
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Niklas Wenzel <dev@nikwen.de >
2026-02-18 14:22:00 -05:00
trop[bot]
3d475716f4
feat: improve Windows Toast actions support ( #49786 )
...
* feat: improve Windows Toast actions support
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: ensure MSIX compatibility
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: add bad clsid format test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-02-18 13:22:10 -05:00
Keeley Hammond
fdd31a7aa4
feat: add support for disclaiming utility processes ( #49695 )
...
feat: add support for disclaiming utility processes (#49128 )
* feat: add support for disclaiming utility processes
* chore: update patches
---------
2026-02-11 16:51:03 +01:00
trop[bot]
bf4746c7c9
fix: default accelerator for role-based menu items ( #49669 )
...
fix: apply default accelerator for role-based menu items
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-02-09 10:09:18 -05:00
trop[bot]
394d4cf60c
fix(squirrel.mac): clean up old staged updates before downloading new update ( #49638 )
...
fix: clean up old staged updates before downloading new update
When checkForUpdates() is called while an update is already staged,
Squirrel creates a new temporary directory for the download without
cleaning up the old one. This can lead to disk usage growth when
new versions are released while the app hasn't restarted.
This adds a force parameter to pruneUpdateDirectories that bypasses
the AwaitingRelaunch state check. This is called before creating a
new temp directory, ensuring old staged updates are cleaned up.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Andy Locascio <loc@anthropic.com >
2026-02-04 18:54:03 +01:00
trop[bot]
af272ec773
feat: msix auto-updater ( #49587 )
2026-02-02 14:22:04 +01:00
trop[bot]
cd00dcbafd
test: remove split dependency ( #49557 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
2026-01-28 22:11:08 +01:00
trop[bot]
ac4efed3d1
fix: second argument to shell.writeShortcutLink is optional ( #49501 )
...
fix: second argument to shell.writeShortcutLink is optional
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2026-01-26 14:29:56 +01:00
electron-roller[bot]
ba26a5d4d3
chore: bump chromium to 144.0.7559.59 (40-x-y) ( #49330 )
...
* chore: bump chromium in DEPS to 144.0.7559.59
* chore: update patches
* [InputVizard] Fix missing touch cancel in InputTransferHandlerAndroid
using InputEventSource
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7302368
(cherry picked from commit f31f9e06db4ef78d3ee7https://chromium-review.googlesource.com/c/chromium/src/+/7264893
Co-Authored-By: Alice Zhao <66543449+alicelovescake@users.noreply.github.com >
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
Co-authored-by: deepak1556 <hop2deep@gmail.com >
Co-authored-by: Alice Zhao <66543449+alicelovescake@users.noreply.github.com >
2026-01-13 19:09:12 -05:00
Shelley Vohr
05b4b57151
feat: support WebSocket authentication handling ( #49064 )
...
* feat: support WebSocket authentication handling
* chore: make linter happy
---------
Co-authored-by: Charles Kerr <charles@charleskerr.com >
2026-01-12 11:23:31 -05:00
trop[bot]
c4bfc1491a
fix: webRequest.onBeforeSendHeaders not being able to modify reserved headers ( #49241 )
...
* fix: `webRequest.onBeforeSendHeaders` not being able to modify reserved headers
Co-authored-by: Samuel Attard <sattard@anthropic.com >
* chore: add unit test for reserved header
Co-authored-by: Samuel Attard <sattard@anthropic.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <sattard@anthropic.com >
2026-01-06 10:31:09 -05:00
trop[bot]
9dce2015f7
build: drop dugite as a dependency ( #49204 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com >
2025-12-15 14:40:56 -05:00
trop[bot]
9ec95c0c02
chore: bump chromium to 144.0.7527.0 (40-x-y) ( #49057 )
...
chore: bump chromium to 144.0.7527.0 40-x-y
* chore: bump chromium in DEPS to 144.0.7527.0
* 7106405: [video pip] Fix gesture handling issues
https://chromium-review.googlesource.com/c/chromium/src/+/7106405
* 7130938: Reland "Remove some dependencies from the custom_handlers component"
https://chromium-review.googlesource.com/c/chromium/src/+/7130938
* 7139361: Rename PluginService's GetPlugins methods
https://chromium-review.googlesource.com/c/chromium/src/+/7139361
* chore: fixup patch indices
* test: fix macos webgl test | 7128438: Reland "Flip SwiftShader deprecation to launched." | https://chromium-review.googlesource.com/c/chromium/src/+/7128438
* test: update webgl test to skip on fallback adapters
* Fixup spec runner to properly fail on linux when tests fail
* test: fixup dbus tests
* test: convert shared-texture-spec from old done callback to async
Fixes Error: done() called multiple times in test <sharedTexture module import shared texture produced by osr successfully imported and rendered with subtle api> of file /__w/electron/electron/src/electron/spec/api-shared-texture-spec.ts
* test: fixup shared texture spec
* Revert "test: fixup dbus tests"
This reverts commit 3e2e720003https://github.com/electron/electron/pull/48657 broke those tests
* disable sharedTexture tests on platforms other than macOS arm64
They were not working on other platforms previously but now they error out.
Also removed extraneous debugging.
* fix: use github.sha for yarn cache key to avoid hashFiles() composite action bug
* Use --immutable-cache to allow native module builds
* fix: wait for devtools blur event in focus test to avoid race condition
* fix: wait for devtools blur event in focus test to avoid race condition
* fix allow native module builds in spec workspace
* test:rebuild native modules
* Revert "fix allow native module builds in spec workspace"
This reverts commit ffda3be98c2e6eea434833560ba0de
2025-11-24 16:59:42 -05:00
trop[bot]
f8d3e0f3cd
fix: abort more descriptively for beforeunload ( #49010 )
...
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-19 15:41:59 -05:00
John Kleinschmidt
fe32528c50
build: update to yarn v4 ( #48993 )
2025-11-17 16:04:51 -08:00
trop[bot]
fd1db6a8b6
test: add view.getBounds|setBounds tests ( #48962 )
...
test: add view.getBounds|setBounds tests
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-14 10:57:24 -05:00
trop[bot]
7a5e34e6ca
feat: add bypassCustomProtocolHandlers option to net.request ( #48883 )
...
* feat: add bypassCustomProtocolHandlers option to net.request
Co-authored-by: Kai <udbmnm@163.com >
* style: fix lint errors in api-protocol-spec
Co-authored-by: Kai <udbmnm@163.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Kai <udbmnm@163.com >
2025-11-13 10:36:25 -05:00
trop[bot]
c229e274a0
feat: add sharedTexture module to import shared texture ( #48831 )
...
feat: add `sharedTexture` module.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: reito <reito@chromium.org >
2025-11-11 11:55:54 -05:00
trop[bot]
9e6546da7c
chore: delay load pdfjs-dist for pdf spec ( #48890 )
...
trap handlers will be initialized once the user script starts
but before app#ready. Wasm compilation before that phase will
break trap handler registeration due to the check in
v8::internal::wasm::UpdateComputedInformation. For some reason
this issue was only visible in <= 39-x-y when pdf-reader.mjs
was being loaded, maybe some module loading logic changed in >= 40-x-y
which are based on Node.js v24.x. In either case, it is best to
align the loading of wasm module required for the tests in light
of changes to how we are registering the trap handlers for the
main process.
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com >
2025-11-11 16:02:34 +01:00
trop[bot]
fe396ef002
feat: add SF Symbol support to NativeImage::CreateFromNamedImage ( #48772 )
...
* feat: add SF Symbol support to NativeImage::CreateFromNamedImage
Co-authored-by: TheCommieAxolotl <87679354+TheCommieAxolotl@users.noreply.github.com >
* use obj-c name in NSImage constructor
Co-authored-by: TheCommieAxolotl <87679354+TheCommieAxolotl@users.noreply.github.com >
* add test for named symbol image
Co-authored-by: TheCommieAxolotl <87679354+TheCommieAxolotl@users.noreply.github.com >
* apply suggested simplification
Co-authored-by: TheCommieAxolotl <87679354+TheCommieAxolotl@users.noreply.github.com >
* fix: support NX cocoa prefix
Co-authored-by: TheCommieAxolotl <87679354+TheCommieAxolotl@users.noreply.github.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: TheCommieAxolotl <87679354+TheCommieAxolotl@users.noreply.github.com >
2025-11-10 21:18:00 +01:00
trop[bot]
4138dfeb19
chore: upgrade Node.js to v24.10.0 ( #48739 )
...
* chore: upgrade Node.js to v24.10.0
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fixup crypto patch
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fixup crypto test patch
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: prepare for v8 sandboxing
https://github.com/nodejs/node/pull/58376
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* esm: fix module.exports export on CJS modules
https://github.com/nodejs/node/pull/57366
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fixup lazyload fs patch
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* esm: Source Phase Imports for WebAssembly
https://github.com/nodejs/node/pull/56919
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* module: remove --experimental-default-type
https://github.com/nodejs/node/pull/56092
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* lib,src: refactor assert to load error source from memory
https://github.com/nodejs/node/pull/59751
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: add source location to v8::TaskRunner
https://github.com/nodejs/node/pull/54077
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: remove dependency on wrapper-descriptor-based CppHeap
https://github.com/nodejs/node/pull/54077
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: do not use soon-to-be-deprecated V8 API
https://github.com/nodejs/node/pull/53174
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: stop using deprecated fields of v8::FastApiCallbackOptions
https://github.com/nodejs/node/pull/54077
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: update v8-stats test for V8 12.6
https://github.com/nodejs/node/pull/54077
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* esm: unflag --experimental-wasm-modules
https://github.com/nodejs/node/pull/57038
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: adapt assert tests to stack trace changes
https://github.com/nodejs/node/pull/58070
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src,test: unregister the isolate after disposal and before freeing
https://github.com/nodejs/node/pull/58070
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: use cppgc to manage ContextifyContext
https://github.com/nodejs/node/pull/56522
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: replace uses of FastApiTypedArray
https://github.com/nodejs/node/pull/58070
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* module: integrate TypeScript into compile cache
https://github.com/nodejs/node/pull/56629
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* deps: update ada to 3.2.7
https://github.com/nodejs/node/pull/59336
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: make minor cleanups in encoding_binding.cc
https://github.com/nodejs/node/pull/57448
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: switch from `Get/SetPrototype` to `Get/SetPrototypeV2`
https://github.com/nodejs/node/pull/55453
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: use non-deprecated Get/SetPrototype methods
https://github.com/nodejs/node/pull/59671
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: simplify string_bytes with views
https://github.com/nodejs/node/pull/54876
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: improve utf8 string generation performance
https://github.com/nodejs/node/pull/54873
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: use non-deprecated Utf8LengthV2() method
https://github.com/nodejs/node/pull/58070
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: use non-deprecated WriteUtf8V2() method
https://github.com/nodejs/node/pull/58070
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: refactor WriteUCS2 and remove flags argument
https://github.com/nodejs/node/pull/58163
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: use String::WriteV2() in TwoByteValue
https://github.com/nodejs/node/pull/58164
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* node-api: use WriteV2 in napi_get_value_string_utf16
https://github.com/nodejs/node/pull/58165
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* node-api: use WriteOneByteV2 in napi_get_value_string_latin1
https://github.com/nodejs/node/pull/58325
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: migrate WriteOneByte to WriteOneByteV2
https://github.com/nodejs/node/pull/59634
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fs: introduce dirent\.parentPath
https://github.com/nodejs/node/pull/50976
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: avoid copy by using std::views::keys
https://github.com/nodejs/node/pull/56080
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fixup patch indices
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: errant use of context->GetIsolate()
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: tweak BoringSSL compat patch for new changes
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: add back missing isolate dtor declaration
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fixup! esm: fix module.exports export on CJS modules
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* cli: remove --no-experimental-fetch flag
https://github.com/nodejs/node/pull/52611/files
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* esm: Source Phase Imports for WebAssembly
https://github.com/nodejs/node/pull/56919
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fixup! src: prepare for v8 sandboxing
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: bump @types/node to v24
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fix const assignment in crypto test
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: sandbox pointer patch issues
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: rework source phase import patch
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: add percentage support to --max-old-space-size
https://github.com/nodejs/node/pull/59082
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fixup crypto tests
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: HostImportModuleWithPhaseDynamically todo
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: cjs esm failures
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: v8::Object::Wrappable issues
- b72a615754490bac24964896a0dd69shelley.vohr@gmail.com >
* chore: remove deleted specs
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* src: use v8::ExternalMemoryAccounter
https://github.com/nodejs/node/pull/58070
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fs: port SonicBoom module to fs module as FastUtf8Stream
https://github.com/nodejs/node/pull/58897
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: tweak sandboxed pr patch
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: disable parallel/test-os-checked-function
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* test: use WHATWG URL instead of url.parse
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* fix: OPENSSL_secure_zalloc doesn't work in BoringSSL
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* chore: fix accidental extra line
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
* 7017517: [defer-import-eval] Parse import defer syntax
https://chromium-review.googlesource.com/c/v8/v8/+/7017517
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
---------
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-11-04 09:52:30 +01:00
electron-roller[bot]
29e0948f7b
chore: bump chromium to 143.0.7497.0 (main) ( #48657 )
...
* chore: bump chromium in DEPS to 143.0.7492.0
* chore: bump chromium in DEPS to 143.0.7493.0
* chore: update mas_avoid_private_macos_api_usage.patch.patch
Move os_crypt/sync and os_crypt/async shared code to os_crypt/common | https://chromium-review.googlesource.com/c/chromium/src/+/7081087
* chore: update add_didinstallconditionalfeatures.patch
no manual changes; patch applied with fuzz
Reland "Remove BackForwardTransitions flag" | https://chromium-review.googlesource.com/c/chromium/src/+/7079411
* chore: update printing.patch
Avoid a reachable NOTREACHED() in PrintingContextLinux | https://chromium-review.googlesource.com/c/chromium/src/+/7081117
* chore: update allow_in-process_windows_to_have_different_web_prefs.patch
patch reapplied manually due to context shear
Reland "Remove BackForwardTransitions flag" | https://chromium-review.googlesource.com/c/chromium/src/+/7079411
* chore: update chore_provide_iswebcontentscreationoverridden_with_full_params.patch
patch reapplied manually due to context shear
Cleanup: format some content files | https://chromium-review.googlesource.com/c/chromium/src/+/7083290
* chore: update feat_ensure_mas_builds_of_the_same_application_can_use_safestorage.patch
patch manually reapplied for files moved upstream
Move os_crypt/sync and os_crypt/async shared code to os_crypt/common | https://chromium-review.googlesource.com/c/chromium/src/+/7081087
* chore: update revert_cleanup_remove_feature_windelayspellcheckserviceinit.patch
no manual changes; patch applied with fuzz
[spelling+grammar restrictions] fix feature param name | https://chromium-review.googlesource.com/c/chromium/src/+/7081186
* chore: update patches
* chore: fix broken includes in ElectronBrowserMainParts
Move os_crypt/sync and os_crypt/async shared code to os_crypt/common | https://chromium-review.googlesource.com/c/chromium/src/+/7081087
* chore: bump chromium in DEPS to 143.0.7495.0
* chore: fixup patch indices
* chore: bump chromium in DEPS to 143.0.7497.0
* chore: fixup patch indices
* 7085081: Roll libc++ from d6739a332fe9 to bc00f6e9f739 (1 revision)
https://chromium-review.googlesource.com/c/chromium/src/+/7085081
* 7081087: Move os_crypt/sync and os_crypt/async shared code to os_crypt/common
https://chromium-review.googlesource.com/c/chromium/src/+/7081087
* test: fix failing spec
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com >
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com >
2025-10-28 11:17:29 -04:00
michal-pichlinski-openfin
28f1cf1f11
feat: Focus DevTools when breakpoint is triggered ( #46386 )
...
`bringToFront` DevTools message is sent when breakpoint is triggered
or inspect is called and Chromium upon this message activates DevTools
via `DevToolsUIBindings::Delegate::ActivateWindow`:
```
void DevToolsWindow::ActivateWindow() {
if (life_stage_ != kLoadCompleted)
return;
\#if BUILDFLAG(IS_ANDROID)
NOTIMPLEMENTED();
\#else
if (is_docked_ && GetInspectedBrowserWindow())
main_web_contents_->Focus();
else if (!is_docked_ && browser_ && !browser_->window()->IsActive())
browser_->window()->Activate();
\#endif
}
```
which implements: `DevToolsUIBindings::Delegate::ActivateWindow`.
Electron also implements this interface in:
`electron::InspectableWebContents`. However it was only setting
a zoom level, therefore this commit extends it with activation
of the DevTools.
Only supported for DevTools manged by `electron::InspectableWebContents`.
Closes : #37388
2025-10-28 08:46:33 -04:00
Shelley Vohr
b389377c63
feat: add app.isHardwareAccelerationEnabled() ( #47614 )
...
* feat: add app.isHardwareAccelerationEnabled()
* chore: address review feedback
2025-10-27 14:03:08 -05:00
Tau Gärtli
7ec0ebc50a
feat: Add getAccentColor on Linux ( #48027 )
...
* feat: Implement `getAccentColor` on Linux
* doc: Update OS support for accent color APIs
2025-10-21 14:26:30 -04:00
Shelley Vohr
e766d378e1
feat: enable more granular a11y feature management ( #48042 )
...
* feat: enable more granular a11y feature management
* Update docs/api/app.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
2025-10-21 10:56:14 -04:00
Shelley Vohr
0a19176917
feat: enable resetting accent color ( #48274 )
2025-10-21 10:49:08 -04:00
Shelley Vohr
6562d6ed0b
fix: systemPreferences.getAccentColor inverted color ( #48511 )
...
fix: systemPreferences.getAccentColor inverted color
2025-10-21 10:46:46 -04:00
Shelley Vohr
11f76118db
fix: unexpected openExternal dialog on macOS Tahoe ( #48502 )
...
fix: unexpected openExternal dialog on macOS Tahoe
2025-10-10 12:48:44 +02:00
zoy
3a53c71324
fix: broken transparent window styles on resizable change ( #48378 )
...
* fix: wrong api call
* fix: consistency of the resize state
* fix: edge cases
* chore: add detailed comments
* fix: lint
* chore: only windows
* chore: use transparent
2025-10-09 09:49:20 +02:00
Fedor Indutny
e8e91c331a
feat: dynamic ESM import in preload without context isolation ( #48375 )
...
Dynamic ESM import in non-context-isolated preload
Extend `HostImportModuleWithPhaseDynamically`'s routing to support
Node.js import resolution in non-context-isolated preloads through
`v8_host_defined_options` length check. The length of host defined
options is distinct between Blink and Node.js and we can use it to
determine which resolver to use.
2025-10-08 10:44:09 +02:00
John Kleinschmidt
b51e82c5fb
test: rerun failed tests individually ( #48205 )
...
* test: rerun failed tests individually
* ci: use screencapture-nag-remover
Needed to bypass the popup message "bash" is requesting to bypass the system private window picker and directly access your screen and audio.
* Revert "chore: test with 1st quadrant of the window"
No longer needed because of the addition of the
screencapture-nag-remover script.
This reverts commit f4a7e04c0b
2025-09-24 13:35:14 -07:00
electron-roller[bot]
1fda08b8c8
chore: bump chromium to 142.0.7417.0 (main) ( #48275 )
...
* chore: bump chromium in DEPS to 142.0.7401.0
* 6911185: Reland "Send touch moves async immediately after scroll starts."
https://chromium-review.googlesource.com/c/chromium/src/+/6911185
* 6906887: mac: click through content area in main window
https://chromium-review.googlesource.com/c/chromium/src/+/6906887
* 6916667: Expose helper to eliminate duplicate recipes.
https://chromium-review.googlesource.com/c/chromium/src/+/6916667
* 6909842: Switch LegacyRenderWidgetHostHWND from atlcrack.h to msg_util.h.
https://chromium-review.googlesource.com/c/chromium/src/+/6909842
* 6884056: Remove the SecKeychain implementation for the Keychain interface
https://chromium-review.googlesource.com/c/chromium/src/+/6884056
* 6904906: Remove `WTF::` in renderer/core/[p-x].*/
https://chromium-review.googlesource.com/c/chromium/src/+/6904906
* 6556585: [persistent_cache]: PersistentCache for CodeCache
https://chromium-review.googlesource.com/c/chromium/src/+/6556585
* 6904864: Layout: Support abort on the text placeholder layout
https://chromium-review.googlesource.com/c/chromium/src/+/6904864
* chore: fixup patch indices
* chore: bump chromium in DEPS to 142.0.7402.0
* fixup! 6556585: [persistent_cache]: PersistentCache for CodeCache
* chore: fixup patch indices
* 6905244: [api] Remove deprecated `GetIsolate`
https://chromium-review.googlesource.com/c/v8/v8/+/6905244
* 6897694: Remove NativeTheme::UserHasContrastPreference().
https://chromium-review.googlesource.com/c/chromium/src/+/6897694
* 6897477: Remove GetPlatformHighContrastColorScheme() and enum.
https://chromium-review.googlesource.com/c/chromium/src/+/6897477
* 6918198: Reland "Rename display::Screen::GetScreen() to display::Screen::Get()"
https://chromium-review.googlesource.com/c/chromium/src/+/6918198
* 6907147: [LNA] add use counter for websocket mixed-content issues
https://chromium-review.googlesource.com/c/chromium/src/+/6907147
* 6914538: Replace WTF::String with blink::String
https://chromium-review.googlesource.com/c/website/+/6914538
* 6892538: [video pip] Allow touchscreen users to toggle live caption
https://chromium-review.googlesource.com/c/chromium/src/+/6892538
* chore: fix patch
* chore: bump chromium in DEPS to 142.0.7403.0
* build: remove ninja logs
* chore: fixup patch indices
* 6920670: [PDF] Change pdf_extension_util to return dictionaries
https://chromium-review.googlesource.com/c/chromium/src/+/6920670
* 6917864: Devirtualize and inline various NativeTheme getters.
https://chromium-review.googlesource.com/c/chromium/src/+/6917864
* 6920873: [PDF] Simplify PDFDocumentHelperClient::OnSaveURL()
https://chromium-review.googlesource.com/c/chromium/src/+/6920873
* build: don't kill blink/web_tests
* 6923655: Roll libc++ from 954086abf121 to b87b2bb112f8 (4 revisions)
https://chromium-review.googlesource.com/c/chromium/src/+/6923655
* 6905242: Reland "[CSP] Clarify report-only console messages."
https://chromium-review.googlesource.com/c/chromium/src/+/6905242
* fixup! 6897694: Remove NativeTheme::UserHasContrastPreference().
* chore: bump chromium in DEPS to 142.0.7405.0
* 6910012: [LNA] Enable LNA enforcement by default
https://chromium-review.googlesource.com/c/chromium/src/+/6910012
* 6929444: Combine GetInstanceForXXX() implementations.
https://chromium-review.googlesource.com/c/chromium/src/+/6929444
* 6927873: Rename native_widget_types.h -> native_ui_types.h
https://chromium-review.googlesource.com/c/chromium/src/+/6927873
* 6853978: Init perfetto really early in WebView
https://chromium-review.googlesource.com/c/chromium/src/+/6853978
* 6874886: Use only one picker observer to avoid getting duplicate notifications
https://chromium-review.googlesource.com/c/chromium/src/+/6874886
* chore: fixup patch indices
* fix: Protocol complex inline dtor
* chore: bump chromium in DEPS to 142.0.7407.0
* chore: bump chromium in DEPS to 142.0.7409.0
* chore: bump chromium in DEPS to 142.0.7411.0
* chore: bump chromium in DEPS to 142.0.7413.0
* fixup! 6905242: Reland "[CSP] Clarify report-only console messages."
* 6927233: Remove NativeTheme "use dark colors" bit.
https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* chore: fixup patch indices
* 6899206: [PermissionOptions] Multi-state permission subscriptions & setting changes
https://chromium-review.googlesource.com/c/chromium/src/+/6899206
* chore: bump chromium in DEPS to 142.0.7415.0
* 6936895: [headless] Remove headless flag from views::Widget class
https://chromium-review.googlesource.com/c/chromium/src/+/6936895
We should probably followup on this to see if there is a way to do this without reverting this CL.
* 6937023: Reland "Use new DBus type system in dbus_xdg::Request"
https://chromium-review.googlesource.com/c/chromium/src/+/6937023
* chore: update patches
* 6944749: Add GN visibility list to //components/os_crypt/sync
https://chromium-review.googlesource.com/c/chromium/src/+/6944749
* Further replace sub_capture_target_version with CaptureVersion
https://chromium-review.googlesource.com/c/chromium/src/+/6935455
* fixup for lint
* chore: update filenames.libcxx.gni
* chore: bump chromium in DEPS to 142.0.7417.0
* 6944136: Reorder NativeTheme headers/.cc files.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944136
* 6939701: [DSSC][4] Make FSVCI objects aware of their capture-version-source
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6939701
* 6944404: Remove extraneous callback call
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6944404
* 6936124: [FPF-CI]: Introduce blink::NoiseToken for fingerprinting protection
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6936124
* chore: update patches
* fixup! 6927233: Remove NativeTheme "use dark colors" bit.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* fixup! 6917864: Devirtualize and inline various NativeTheme getters.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6917864
* 6937588: Add initial OsSettingsProvider object, supplying caret blink interval.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6937588
* fixup! 6905242: Reland "[CSP] Clarify report-only console messages."
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6905242
* 6907515: Replace SingletonHwndObserver with a CallbackList on SingletonHwnd.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6907515
* 6910482: [Save to Drive] Implement retry functionality
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6910482
* fixup! 6927233: Remove NativeTheme "use dark colors" bit.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/6927233
* Revert "build: remove ninja logs"
This reverts commit 72874740fdshelley.vohr@gmail.com >
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org >
Co-authored-by: David Sanders <dsanders11@ucsbalum.com >
Co-authored-by: Alice Zhao <alicelovescake@anthropic.com >
2025-09-22 20:16:27 -07:00
Shelley Vohr
bac383c219
feat: add fileSystem to ses.setPermissionCheckHandler ( #48170 )
...
feat: add fileSystem to ses.setPermissionCheckHandler
2025-09-15 17:00:58 -04:00
