refactor: move ElectronExtensionsBrowserClient::PermitExternalProtocolHandler() empty function into header

shell/browser/api/electron_api_notification.cc

@@ -156,8 +156,6 @@ void Notification::NotificationFailed(const std::string& error) {
   Emit("failed", error);
 }
 
-void Notification::NotificationDestroyed() {}
-
 void Notification::NotificationClosed() {
   Emit("close");
 }

shell/browser/api/electron_api_notification.h

@@ -49,7 +49,7 @@ class Notification final : public gin::Wrappable<Notification>,
   void NotificationClick() override;
   void NotificationReplied(const std::string& reply) override;
   void NotificationDisplayed() override;
-  void NotificationDestroyed() override;
+  void NotificationDestroyed() override {}
   void NotificationClosed() override;
   void NotificationFailed(const std::string& error) override;
 

shell/browser/extensions/api/extension_action/extension_action_api.cc

@@ -22,13 +22,6 @@ namespace extensions {
 // ExtensionActionAPI::Observer
 //
 
-void ExtensionActionAPI::Observer::OnExtensionActionUpdated(
-    ExtensionAction* extension_action,
-    content::WebContents* web_contents,
-    content::BrowserContext* browser_context) {}
-
-void ExtensionActionAPI::Observer::OnExtensionActionAPIShuttingDown() {}
-
 ExtensionActionAPI::Observer::~Observer() {}
 
 //
@@ -57,8 +50,6 @@ ExtensionPrefs* ExtensionActionAPI::GetExtensionPrefs() {
   return nullptr;
 }
 
-void ExtensionActionAPI::Shutdown() {}
-
 //
 // ExtensionActionFunction
 //

shell/browser/extensions/api/extension_action/extension_action_api.h

@@ -28,9 +28,9 @@ class ExtensionActionAPI : public BrowserContextKeyedAPI {
     virtual void OnExtensionActionUpdated(
         ExtensionAction* extension_action,
         content::WebContents* web_contents,
-        content::BrowserContext* browser_context);
+        content::BrowserContext* browser_context) {}
 
-    virtual void OnExtensionActionAPIShuttingDown();
+    virtual void OnExtensionActionAPIShuttingDown() {}
 
    protected:
     virtual ~Observer();
@@ -73,7 +73,7 @@ class ExtensionActionAPI : public BrowserContextKeyedAPI {
   ExtensionPrefs* GetExtensionPrefs();
 
   // BrowserContextKeyedAPI implementation.
-  void Shutdown() override;
+  void Shutdown() override {}
   static const char* service_name() { return "ExtensionActionAPI"; }
   static const bool kServiceRedirectedInIncognito = true;
 

shell/browser/extensions/electron_extension_loader.cc

@@ -224,8 +224,6 @@ void ElectronExtensionLoader::ShowExtensionDisabledError(
     const Extension* extension,
     bool is_remote_install) {}
 
-void ElectronExtensionLoader::FinishDelayedInstallationsIfAny() {}
-
 bool ElectronExtensionLoader::CanAddExtension(const Extension* extension) {
   return true;
 }

shell/browser/extensions/electron_extension_loader.h

@@ -83,7 +83,7 @@ class ElectronExtensionLoader : public ExtensionRegistrar::Delegate {
       ExtensionRegistrar::LoadErrorBehavior load_error_behavior) override;
   void ShowExtensionDisabledError(const Extension* extension,
                                   bool is_remote_install) override;
-  void FinishDelayedInstallationsIfAny() override;
+  void FinishDelayedInstallationsIfAny() override {}
   bool CanAddExtension(const Extension* extension) override;
   bool CanEnableExtension(const Extension* extension) override;
   bool CanDisableExtension(const Extension* extension) override;

shell/browser/extensions/electron_extensions_browser_client.cc

@@ -280,8 +280,6 @@ bool ElectronExtensionsBrowserClient::DidVersionUpdate(
   return false;
 }
 
-void ElectronExtensionsBrowserClient::PermitExternalProtocolHandler() {}
-
 bool ElectronExtensionsBrowserClient::IsInDemoMode() {
   return false;
 }

shell/browser/extensions/electron_extensions_browser_client.h

@@ -114,7 +114,7 @@ class ElectronExtensionsBrowserClient
   std::unique_ptr<extensions::ExtensionHostDelegate>
   CreateExtensionHostDelegate() override;
   bool DidVersionUpdate(content::BrowserContext* context) override;
-  void PermitExternalProtocolHandler() override;
+  void PermitExternalProtocolHandler() override {}
   bool IsInDemoMode() override;
   bool IsScreensaverInDemoMode(const std::string& app_id) override;
   bool IsRunningInForcedAppMode() override;

shell/common/gin_helper/cleaned_up_at_exit.cc

@@ -27,8 +27,6 @@ CleanedUpAtExit::~CleanedUpAtExit() {
   std::erase(GetDoomed(), this);
 }
 
-void CleanedUpAtExit::WillBeDestroyed() {}
-
 // static
 void CleanedUpAtExit::DoCleanup() {
   auto& doomed = GetDoomed();

shell/common/gin_helper/cleaned_up_at_exit.h

@@ -19,7 +19,7 @@ class CleanedUpAtExit {
   CleanedUpAtExit();
   virtual ~CleanedUpAtExit();
 
-  virtual void WillBeDestroyed();
+  virtual void WillBeDestroyed() {}
 
   static void DoCleanup();
 };