Compare commits

...

2 Commits

Author SHA1 Message Date
Keeley Hammond
9fc0bfece2 build: disable GitHub Actions in 32-x-y (#42532)
build: disable GHActions in 32-x-y
2024-06-17 11:32:12 -07:00
trop[bot]
efe98f76d1 docs(web-embeds): replace BrowserView ref with WebContentsView (#42469)
Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Mark Lee <malept@users.noreply.github.com>
2024-06-12 15:04:23 -05:00
2 changed files with 8 additions and 7 deletions

View File

@@ -23,8 +23,8 @@ and only allow the capabilities you want to support.
[we do not recommend you to use WebViews](../api/webview-tag.md#warning), [we do not recommend you to use WebViews](../api/webview-tag.md#warning),
as this tag undergoes dramatic architectural changes that may affect stability as this tag undergoes dramatic architectural changes that may affect stability
of your application. Consider switching to alternatives, like `iframe` and of your application. Consider switching to alternatives, like `iframe` and
Electron's `BrowserView`, or an architecture that avoids embedded content Electron's [`WebContentsView`](../api/web-contents-view.md), or an architecture
by design. that avoids embedded content by design.
[WebViews](../api/webview-tag.md) are based on Chromium's WebViews and are not [WebViews](../api/webview-tag.md) are based on Chromium's WebViews and are not
explicitly supported by Electron. We do not guarantee that the WebView API will explicitly supported by Electron. We do not guarantee that the WebView API will

View File

@@ -385,6 +385,7 @@ function buildCircleCI (targetBranch, options) {
} }
} }
// eslint-disable-next-line @typescript-eslint/no-unused-vars
function buildGHActions (targetBranch, options) { function buildGHActions (targetBranch, options) {
if (options.job) { if (options.job) {
assert(ghActionsPublishWorkflows.includes(options.job), `Unknown GitHub Actions workflow name: ${options.job}. Valid values are: ${ghActionsPublishWorkflows}.`); assert(ghActionsPublishWorkflows.includes(options.job), `Unknown GitHub Actions workflow name: ${options.job}. Valid values are: ${ghActionsPublishWorkflows}.`);
@@ -405,10 +406,10 @@ function runRelease (targetBranch, options) {
buildCircleCI(targetBranch, options); buildCircleCI(targetBranch, options);
break; break;
} }
case 'GitHubActions': { // case 'GitHubActions': {
buildGHActions(targetBranch, options); // buildGHActions(targetBranch, options);
break; // break;
} // }
case 'AppVeyor': { case 'AppVeyor': {
buildAppVeyor(targetBranch, options); buildAppVeyor(targetBranch, options);
break; break;
@@ -421,7 +422,7 @@ function runRelease (targetBranch, options) {
} else { } else {
buildCircleCI(targetBranch, options); buildCircleCI(targetBranch, options);
buildAppVeyor(targetBranch, options); buildAppVeyor(targetBranch, options);
buildGHActions(targetBranch, options); // buildGHActions(targetBranch, options);
} }
console.log(`${jobRequestedCount} jobs were requested.`); console.log(`${jobRequestedCount} jobs were requested.`);
} }