mirror of
https://github.com/electron/electron.git
synced 2026-05-02 03:00:22 -04:00
* build: add oxfmt for code formatting and import sorting
Adds oxfmt as a devDependency alongside oxlint and wires it into the
lint pipeline. The .oxfmtrc.json config matches Electron's current JS
style (single quotes, semicolons, 2-space indent, trailing commas off,
printWidth 100) and configures sortImports with custom groups that
mirror the import/order pathGroups previously enforced by ESLint:
@electron/internal, @electron/*, and {electron,electron/**} each get
their own ordered group ahead of external modules.
- `yarn lint:fmt` runs `oxfmt --check` over JS/TS sources and is
chained into `yarn lint` so CI enforces it automatically.
- `yarn format` runs `oxfmt --write` for local fix-up.
- lint-staged invokes `oxfmt --write` on staged .js/.ts/.mjs/.cjs
files before oxlint, so formatting is applied at commit time.
The next commit applies the formatter to the existing codebase so the
check actually passes.
* chore: apply oxfmt formatting to JS and TS sources
Runs `yarn format` across lib/, spec/, script/, build/, default_app/,
and npm/ to bring the codebase in line with the .oxfmtrc.json settings
added in the previous commit. This is a pure formatting pass: import
statements are sorted into the groups defined by the config, method
chains longer than printWidth are broken, single-quoted strings
containing apostrophes are switched to double quotes, and a handful of
single-statement `if` bodies are re-wrapped and get braces added by
`oxlint --fix` to satisfy the `curly: multi-line` rule.
No behavior changes.
81 lines
2.0 KiB
JavaScript
81 lines
2.0 KiB
JavaScript
const inspector = require('node:inspector');
|
|
const path = require('node:path');
|
|
const { pathToFileURL } = require('node:url');
|
|
|
|
// This test case will set a breakpoint 4 lines below
|
|
function debuggedFunction() {
|
|
let i;
|
|
let accum = 0;
|
|
for (i = 0; i < 5; i++) {
|
|
accum += i;
|
|
}
|
|
return accum;
|
|
}
|
|
|
|
let scopeCallback = null;
|
|
|
|
function checkScope(session, scopeId) {
|
|
session.post(
|
|
'Runtime.getProperties',
|
|
{
|
|
objectId: scopeId,
|
|
ownProperties: false,
|
|
accessorPropertiesOnly: false,
|
|
generatePreview: true
|
|
},
|
|
scopeCallback
|
|
);
|
|
}
|
|
|
|
function debuggerPausedCallback(session, notification) {
|
|
const params = notification.params;
|
|
const callFrame = params.callFrames[0];
|
|
const scopeId = callFrame.scopeChain[0].object.objectId;
|
|
checkScope(session, scopeId);
|
|
}
|
|
|
|
function testSampleDebugSession() {
|
|
let cur = 0;
|
|
const failures = [];
|
|
const expects = {
|
|
i: [0, 1, 2, 3, 4],
|
|
accum: [0, 0, 1, 3, 6]
|
|
};
|
|
scopeCallback = function (error, result) {
|
|
if (error) failures.push(error);
|
|
const i = cur++;
|
|
let v, actual, expected;
|
|
for (v of result.result) {
|
|
actual = v.value.value;
|
|
expected = expects[v.name][i];
|
|
if (actual !== expected) {
|
|
failures.push(`Iteration ${i} variable: ${v.name} ` + `expected: ${expected} actual: ${actual}`);
|
|
}
|
|
}
|
|
};
|
|
const session = new inspector.Session();
|
|
session.connect();
|
|
session.on('Debugger.paused', (notification) => debuggerPausedCallback(session, notification));
|
|
let cbAsSecondArgCalled = false;
|
|
session.post('Debugger.enable', () => {
|
|
cbAsSecondArgCalled = true;
|
|
});
|
|
session.post('Debugger.setBreakpointByUrl', {
|
|
lineNumber: 9,
|
|
url: pathToFileURL(path.resolve(__dirname, __filename)).toString(),
|
|
columnNumber: 0,
|
|
condition: ''
|
|
});
|
|
|
|
debuggedFunction();
|
|
scopeCallback = null;
|
|
session.disconnect();
|
|
process.send({
|
|
cmd: 'assert',
|
|
debuggerEnabled: cbAsSecondArgCalled,
|
|
success: cur === 5 && failures.length === 0
|
|
});
|
|
}
|
|
|
|
testSampleDebugSession();
|