mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
01130e5c9f
https://github.com/mstange/samply is amazing to profile
Electron apps that need visualization of both JS and native
samples in an unified view. However, we cannot use the profiler
once the application is packaged due to restrictions from
entitlements and SIP that will disallow loading the preload library
from samply to exchange the task ports from the launched process.
This changes takes an alternative route inspired by crashpad architecture
where the samply profiler will be bundled as part of the application,
the browser process launches the profiler on demand and performs
mach port exchange via a simple handshake protocol implemented in
950b80e711
Every child process then launched by the browser will send their
task ports via the verified ipc connection the browser process
has created with the samply profiler process.
NB: the --samply-path is for testing purpose, we should remove it
and bundle the samply executable next to chrome_crashpad_handler
when packaging so that evil actors cannot hijack the ipc.
79 lines
2.7 KiB
Plaintext
79 lines
2.7 KiB
Plaintext
// Copyright (c) 2013 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include <utility>
|
|
|
|
#include "shell/app/electron_library_main.h"
|
|
|
|
#include "base/apple/bundle_locations.h"
|
|
#include "base/apple/foundation_util.h"
|
|
#include "base/apple/scoped_nsautorelease_pool.h"
|
|
#include "base/at_exit.h"
|
|
#include "base/command_line.h"
|
|
#include "base/i18n/icu_util.h"
|
|
#include "base/notreached.h"
|
|
#include "base/strings/sys_string_conversions.h"
|
|
#include "content/public/app/content_main.h"
|
|
#include "electron/fuses.h"
|
|
#include "shell/app/electron_main_delegate.h"
|
|
#include "shell/app/node_main.h"
|
|
#include "shell/common/electron_command_line.h"
|
|
#include "shell/common/mac/main_application_bundle.h"
|
|
#include "shell/common/mac/samply_profiler_client.h"
|
|
#include "uv.h"
|
|
|
|
int ElectronMain(int argc, char* argv[]) {
|
|
argv = uv_setup_args(argc, argv);
|
|
base::CommandLine::Init(argc, argv);
|
|
electron::ElectronCommandLine::Init(argc, argv);
|
|
|
|
electron::ElectronMainDelegate delegate;
|
|
|
|
// Ensure that Bundle Id is set before ContentMain AND before any code
|
|
// that uses MachPortRendezvousClient (like samply profiler connection).
|
|
// Refs https://chromium-review.googlesource.com/c/chromium/src/+/5581006
|
|
delegate.OverrideChildProcessPath();
|
|
delegate.OverrideFrameworkBundlePath();
|
|
delegate.SetUpBundleOverrides();
|
|
|
|
electron::MaybeConnectToSamplyProfiler();
|
|
|
|
return content::ContentMain(content::ContentMainParams{&delegate});
|
|
}
|
|
|
|
int ElectronInitializeICUandStartNode(int argc, char* argv[]) {
|
|
if (!electron::fuses::IsRunAsNodeEnabled()) {
|
|
NOTREACHED() << "run_as_node fuse is disabled";
|
|
}
|
|
|
|
argv = uv_setup_args(argc, argv);
|
|
base::CommandLine::Init(argc, argv);
|
|
electron::ElectronCommandLine::Init(argc, argv);
|
|
|
|
base::AtExitManager atexit_manager;
|
|
base::apple::ScopedNSAutoreleasePool pool;
|
|
base::apple::SetOverrideFrameworkBundlePath(
|
|
electron::MainApplicationBundlePath()
|
|
.Append("Contents")
|
|
.Append("Frameworks")
|
|
.Append(ELECTRON_PRODUCT_NAME " Framework.framework"));
|
|
|
|
// Set the bundle ID before trying to connect to samply profiler.
|
|
// This ensures MachPortRendezvousClient uses the correct service name.
|
|
@autoreleasepool {
|
|
NSBundle* bundle = electron::MainApplicationBundle();
|
|
std::string base_bundle_id =
|
|
base::SysNSStringToUTF8([bundle bundleIdentifier]);
|
|
NSString* team_id = [bundle objectForInfoDictionaryKey:@"ElectronTeamID"];
|
|
if (team_id)
|
|
base_bundle_id = base::SysNSStringToUTF8(team_id) + "." + base_bundle_id;
|
|
base::apple::SetBaseBundleIDOverride(base_bundle_id);
|
|
}
|
|
|
|
electron::MaybeConnectToSamplyProfiler();
|
|
|
|
base::i18n::InitializeICU();
|
|
return electron::NodeMain();
|
|
}
|