mirror of
https://github.com/electron/electron.git
synced 2026-05-02 03:00:22 -04:00
2c94aac330
* build: add oxfmt for code formatting and import sorting
Adds oxfmt as a devDependency alongside oxlint and wires it into the
lint pipeline. The .oxfmtrc.json config matches Electron's current JS
style (single quotes, semicolons, 2-space indent, trailing commas off,
printWidth 100) and configures sortImports with custom groups that
mirror the import/order pathGroups previously enforced by ESLint:
@electron/internal, @electron/*, and {electron,electron/**} each get
their own ordered group ahead of external modules.
- `yarn lint:fmt` runs `oxfmt --check` over JS/TS sources and is
chained into `yarn lint` so CI enforces it automatically.
- `yarn format` runs `oxfmt --write` for local fix-up.
- lint-staged invokes `oxfmt --write` on staged .js/.ts/.mjs/.cjs
files before oxlint, so formatting is applied at commit time.
The next commit applies the formatter to the existing codebase so the
check actually passes.
* chore: apply oxfmt formatting to JS and TS sources
Runs `yarn format` across lib/, spec/, script/, build/, default_app/,
and npm/ to bring the codebase in line with the .oxfmtrc.json settings
added in the previous commit. This is a pure formatting pass: import
statements are sorted into the groups defined by the config, method
chains longer than printWidth are broken, single-quoted strings
containing apostrophes are switched to double quotes, and a handful of
single-statement `if` bodies are re-wrapped and get braces added by
`oxlint --fix` to satisfy the `curly: multi-line` rule.
No behavior changes.
64 lines
2.5 KiB
TypeScript
64 lines
2.5 KiB
TypeScript
import { IPC_MESSAGES } from '@electron/internal/common/ipc-messages';
|
|
import { internalContextBridge } from '@electron/internal/renderer/api/context-bridge';
|
|
import { ipcRendererInternal } from '@electron/internal/renderer/ipc-renderer-internal';
|
|
|
|
const { contextIsolationEnabled } = internalContextBridge;
|
|
|
|
export const windowSetup = (isWebView: boolean, isHiddenPage: boolean) => {
|
|
if (!process.sandboxed && !isWebView) {
|
|
// Override default window.close.
|
|
window.close = function () {
|
|
ipcRendererInternal.send(IPC_MESSAGES.BROWSER_WINDOW_CLOSE);
|
|
};
|
|
if (contextIsolationEnabled) internalContextBridge.overrideGlobalValueFromIsolatedWorld(['close'], window.close);
|
|
}
|
|
|
|
// But we do not support prompt().
|
|
window.prompt = function () {
|
|
throw new Error('prompt() is not supported.');
|
|
};
|
|
if (contextIsolationEnabled) internalContextBridge.overrideGlobalValueFromIsolatedWorld(['prompt'], window.prompt);
|
|
|
|
if (isWebView) {
|
|
// Webview `document.visibilityState` tracks window visibility (and ignores
|
|
// the actual <webview> element visibility) for backwards compatibility.
|
|
// See discussion in #9178.
|
|
//
|
|
// Note that this results in duplicate visibilitychange events (since
|
|
// Chromium also fires them) and potentially incorrect visibility change.
|
|
// We should reconsider this decision for Electron 2.0.
|
|
let cachedVisibilityState = isHiddenPage ? 'hidden' : 'visible';
|
|
|
|
// Subscribe to visibilityState changes.
|
|
ipcRendererInternal.on(
|
|
IPC_MESSAGES.GUEST_INSTANCE_VISIBILITY_CHANGE,
|
|
function (_event, visibilityState: DocumentVisibilityState) {
|
|
if (cachedVisibilityState !== visibilityState) {
|
|
cachedVisibilityState = visibilityState;
|
|
document.dispatchEvent(new Event('visibilitychange'));
|
|
}
|
|
}
|
|
);
|
|
|
|
// Make document.hidden and document.visibilityState return the correct value.
|
|
const getDocumentHidden = () => cachedVisibilityState !== 'visible';
|
|
Object.defineProperty(document, 'hidden', {
|
|
get: getDocumentHidden
|
|
});
|
|
if (contextIsolationEnabled) {
|
|
internalContextBridge.overrideGlobalPropertyFromIsolatedWorld(['document', 'hidden'], getDocumentHidden);
|
|
}
|
|
|
|
const getDocumentVisibilityState = () => cachedVisibilityState;
|
|
Object.defineProperty(document, 'visibilityState', {
|
|
get: getDocumentVisibilityState
|
|
});
|
|
if (contextIsolationEnabled) {
|
|
internalContextBridge.overrideGlobalPropertyFromIsolatedWorld(
|
|
['document', 'visibilityState'],
|
|
getDocumentVisibilityState
|
|
);
|
|
}
|
|
}
|
|
};
|