mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
f4ee3c1b2a
* chore: bump node in DEPS to v20.11.0 * module: bootstrap module loaders in shadow realm https://github.com/nodejs/node/pull/48655 * src: add commit hash shorthand in zlib version https://github.com/nodejs/node/pull/50158 * v8,tools: expose necessary V8 defines https://github.com/nodejs/node/pull/50820 * esm: do not call getSource when format is commonjs https://github.com/nodejs/node/pull/50465 * esm: fallback to readFileSync when source is nullish https://github.com/nodejs/node/pull/50825 * vm: allow dynamic import with a referrer realm https://github.com/nodejs/node/pull/50360 * test: skip test-diagnostics-channel-memory-leak.js https://github.com/nodejs/node/pull/50327 * esm: do not call getSource when format is commonjs https://github.com/nodejs/node/pull/50465 * lib: fix assert throwing different error messages in ESM and CJS https://github.com/nodejs/node/pull/50634 * src: fix compatility with upcoming V8 12.1 APIs https://github.com/nodejs/node/pull/50709 * deps: update base64 to 0.5.1 https://github.com/nodejs/node/pull/50629 * src: avoid silent coercion to signed/unsigned int https://github.com/nodejs/node/pull/50663 * src: fix compatility with upcoming V8 12.1 APIs https://github.com/nodejs/node/pull/50709 * chore: fix patch indices * chore: update patches * test: disable TLS cipher test This can't be enabled owing to BoringSSL incompatibilities. https://github.com/nodejs/node/pull/50186 * fix: check for Buffer and global definition in shadow realm https://github.com/nodejs/node/pull/51239 * test: disable parallel/test-shadow-realm-custom-loader Incompatible with our asar logic, resulting in the following failure: > Failed to CompileAndCall electron script: electron/js2c/asar_bundle * chore: remove deleted parallel/test-crypto-modp1-error test * test: make test-node-output-v8-warning generic https://github.com/nodejs/node/pull/50421 * chore: fixup ModuleWrap patch * test: match wpt/streams/transferable/transform-stream-members.any.js to upstream * fix: sandbox is not enabled on arm * chore: disable v8 sandbox on ia32/arm --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
36 lines
1.3 KiB
Diff
36 lines
1.3 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Charles Kerr <charles@charleskerr.com>
|
|
Date: Tue, 17 Oct 2023 10:58:41 -0500
|
|
Subject: chore: remove use of deprecated kMaxLength
|
|
|
|
https://chromium-review.googlesource.com/c/v8/v8/+/4935412
|
|
|
|
This patch can be removed when upstream moves to kMaxByteLength
|
|
|
|
diff --git a/src/node_buffer.h b/src/node_buffer.h
|
|
index 606a6f5caa3b11b6d2a9068ed2fd65800530a5eb..080dcce21da05ccea398d8a856deb397b1ac8b07 100644
|
|
--- a/src/node_buffer.h
|
|
+++ b/src/node_buffer.h
|
|
@@ -29,7 +29,7 @@ namespace node {
|
|
|
|
namespace Buffer {
|
|
|
|
-static const size_t kMaxLength = v8::TypedArray::kMaxLength;
|
|
+static const size_t kMaxLength = v8::TypedArray::kMaxByteLength;
|
|
|
|
typedef void (*FreeCallback)(char* data, void* hint);
|
|
|
|
diff --git a/src/node_errors.h b/src/node_errors.h
|
|
index 8591faab8eaf6f0e6c745e2a6e9f60a468c3efcc..32efaf5148bd6620210c58a95ef3c53bc57a4ea1 100644
|
|
--- a/src/node_errors.h
|
|
+++ b/src/node_errors.h
|
|
@@ -222,7 +222,7 @@ inline v8::Local<v8::Value> ERR_BUFFER_TOO_LARGE(v8::Isolate* isolate) {
|
|
char message[128];
|
|
snprintf(message, sizeof(message),
|
|
"Cannot create a Buffer larger than 0x%zx bytes",
|
|
- v8::TypedArray::kMaxLength);
|
|
+ v8::TypedArray::kMaxByteLength);
|
|
return ERR_BUFFER_TOO_LARGE(isolate, message);
|
|
}
|
|
|