mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
b711ce7b04
* chore: remove window enlargement revert patch Chromium removed the `window_enlargement_` system from DesktopWindowTreeHostWin (1771dbae), which was a workaround for an AMD driver bug from 2013 (crbug.com/286609) where translucent HWNDs smaller than 64x64 caused graphical glitches. Chromium confirmed this is no longer needed and shipped the removal. This removes the revert patch and all Electron-side code that depended on the `kEnableTransparentHwndEnlargement` feature flag, including the `GetExpandedWindowSize` helper and max size constraint expansion in `NativeWindow::GetContentMaximumSize`. * test: remove obsolete <64x64 transparent window test The test was added in 2018 (#12904) to verify the AMD driver workaround that artificially enlarged translucent HWNDs smaller than 64x64 (crbug.com/286609). The workaround set the real HWND to 64x64 and subtracted a stored window_enlargement_ from every client/window bounds query, so getContentSize() reported the originally-requested size even though the actual HWND was larger. With both the Chromium window_enlargement_ system and Electron's GetExpandedWindowSize gone, setContentSize on a transparent thickFrame window calls SetWindowPos directly. WS_THICKFRAME windows are subject to DefWindowProc's MINMAXINFO.ptMinTrackSize clamp on programmatic resizes (Chromium's OnGetMinMaxInfo ends with SetMsgHandled(FALSE), so DefWindowProc overwrites the zeroed min-track with system defaults), which on Windows Server 2025 floors at 32x39 — hence the failing [32, 39] vs [30, 30]. The removed feature_list.cc comment explicitly flagged this test as the blocker for retiring kEnableTransparentHwndEnlargement, so delete it alongside the workaround it was validating.
117 lines
4.4 KiB
C++
117 lines
4.4 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "electron/shell/browser/feature_list.h"
|
|
|
|
#include <string>
|
|
|
|
#include "base/base_switches.h"
|
|
#include "base/command_line.h"
|
|
#include "base/feature_list.h"
|
|
#include "base/metrics/field_trial.h"
|
|
#include "components/spellcheck/common/spellcheck_features.h"
|
|
#include "content/common/features.h"
|
|
#include "content/public/common/content_features.h"
|
|
#include "electron/buildflags/buildflags.h"
|
|
#include "media/base/media_switches.h"
|
|
#include "net/base/features.h"
|
|
#include "printing/buildflags/buildflags.h"
|
|
#include "sandbox/policy/features.h"
|
|
#include "services/network/public/cpp/features.h"
|
|
#include "third_party/blink/public/common/features.h"
|
|
#include "ui/accessibility/ax_features.mojom-features.h"
|
|
|
|
#if BUILDFLAG(IS_MAC)
|
|
#include "device/base/features.h" // nogncheck
|
|
#endif
|
|
|
|
#if BUILDFLAG(ENABLE_PDF_VIEWER)
|
|
#include "pdf/pdf_features.h"
|
|
#endif
|
|
|
|
#if BUILDFLAG(IS_LINUX)
|
|
#include "printing/printing_features.h"
|
|
#endif
|
|
|
|
namespace electron {
|
|
|
|
void InitializeFeatureList() {
|
|
auto* cmd_line = base::CommandLine::ForCurrentProcess();
|
|
auto enable_features =
|
|
cmd_line->GetSwitchValueASCII(::switches::kEnableFeatures);
|
|
auto disable_features =
|
|
cmd_line->GetSwitchValueASCII(::switches::kDisableFeatures);
|
|
// Disable creation of spare renderer process with site-per-process mode,
|
|
// it interferes with our process preference tracking for non sandboxed mode.
|
|
// Can be reenabled when our site instance policy is aligned with chromium
|
|
// when node integration is enabled.
|
|
disable_features +=
|
|
std::string(",") + features::kSpareRendererForSitePerProcess.name +
|
|
// See https://chromium-review.googlesource.com/c/chromium/src/+/6487926
|
|
// this breaks PDFs locally as we don't have GLIC infra enabled.
|
|
std::string(",") + ax::mojom::features::kScreenAIOCREnabled.name +
|
|
// See https://chromium-review.googlesource.com/c/chromium/src/+/6626905
|
|
// Needed so that ElectronBrowserClient::RegisterPendingSiteInstance does
|
|
// not throw a check.
|
|
std::string(", TraceSiteInstanceGetProcessCreation") +
|
|
// See https://chromium-review.googlesource.com/c/chromium/src/+/6910012
|
|
// Needed until we rework some of our logic and checks to enable this
|
|
// properly.
|
|
std::string(",") + network::features::kLocalNetworkAccessChecks.name +
|
|
// See 4803165: Enable suppressing input event dispatch while
|
|
// paint-holding. Needed to prevent spurious input event handling
|
|
// failures.
|
|
// TODO(codebytere): Figure out how to properly wait for paint-hold.
|
|
std::string(",") +
|
|
blink::features::kDropInputEventsWhilePaintHolding.name;
|
|
|
|
#if BUILDFLAG(IS_WIN)
|
|
// See https://chromium-review.googlesource.com/c/chromium/src/+/7204292
|
|
// This feature causes the following sandbox failure on Windows:
|
|
// sandbox\policy\win\sandbox_win.cc:777 Sandbox cannot access executable
|
|
// electron.exe. Check filesystem permissions are valid.
|
|
// See https://bit.ly/31yqMJR.: Access is denied. (0x5)
|
|
disable_features +=
|
|
std::string(",") + sandbox::policy::features::kNetworkServiceSandbox.name;
|
|
#endif
|
|
|
|
#if BUILDFLAG(ENABLE_PDF_VIEWER)
|
|
// Enable window.showSaveFilePicker api for saving pdf files.
|
|
// Refs https://issues.chromium.org/issues/373852607
|
|
enable_features +=
|
|
std::string(",") + chrome_pdf::features::kPdfUseShowSaveFilePicker.name;
|
|
#endif
|
|
|
|
std::string platform_specific_enable_features =
|
|
EnablePlatformSpecificFeatures();
|
|
if (platform_specific_enable_features.size() > 0) {
|
|
enable_features += std::string(",") + platform_specific_enable_features;
|
|
}
|
|
std::string platform_specific_disable_features =
|
|
DisablePlatformSpecificFeatures();
|
|
if (platform_specific_disable_features.size() > 0) {
|
|
disable_features += std::string(",") + platform_specific_disable_features;
|
|
}
|
|
base::FeatureList::InitInstance(enable_features, disable_features);
|
|
}
|
|
|
|
void InitializeFieldTrials() {
|
|
auto* cmd_line = base::CommandLine::ForCurrentProcess();
|
|
auto force_fieldtrials =
|
|
cmd_line->GetSwitchValueASCII(::switches::kForceFieldTrials);
|
|
|
|
base::FieldTrialList::CreateTrialsFromString(force_fieldtrials);
|
|
}
|
|
|
|
#if !BUILDFLAG(IS_MAC)
|
|
std::string EnablePlatformSpecificFeatures() {
|
|
return "";
|
|
}
|
|
std::string DisablePlatformSpecificFeatures() {
|
|
return "";
|
|
}
|
|
#endif
|
|
|
|
} // namespace electron
|