trop[bot] 14c705349e fix: performance-no-automatic-move clang-tidy warnings (#44773) ...

* fix: performance-no-automatic-move in GetLogFileName()

remove `const` from log_filename.

Warning fixed by this commit:

../../electron/shell/common/logging.cc:40:12: warning: constness of 'log_filename' prevents automatic move [performance-no-automatic-move]

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* fix: performance-no-automatic-move in GetBundleResourcePath()

remove `const` from request_relative_path.

Warning fixed by this commit:

electron/shell/browser/extensions/electron_extensions_browser_client.cc:187:10: warning: constness of 'request_relative_path' prevents automatic move [performance-no-automatic-move]

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>

2024-11-21 15:29:52 +01:00

..

api

fix: utility process exit code for graceful termination (reland) (#44733)

2024-11-19 22:09:53 +01:00

badging

refactor: remove use of deprecated API BuildServiceInstanceFor() (#43690)

2024-09-12 15:44:14 -05:00

bluetooth

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

extensions

fix: performance-no-automatic-move clang-tidy warnings (#44773)

2024-11-21 15:29:52 +01:00

file_system_access

chore: bump chromium to 132.0.6779.0 (34-x-y) (#44272)

2024-10-16 21:41:53 -04:00

hid

refactor: replace base::StringPrintf() calls with absl::StrFormat() (#44552)

2024-11-04 13:12:50 -08:00

lib

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

linux

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

mac

fix: -Wunsafe-buffer-usage warning in didRegisterForRemoteNotificationsWithDeviceToken (#44382)

2024-10-23 20:44:41 -05:00

media

chore: iwyu mojom-forward header files (#43741)

2024-09-17 12:58:56 -07:00

net

refactor: replace base::StringPrintf() calls with absl::StrFormat() (#44552)

2024-11-04 13:12:50 -08:00

notifications

fix: remove use of banned std::to_string() (#44562)

2024-11-04 18:00:52 -06:00

osr

chore: bump chromium to 132.0.6807.0 (34-x-y) (#44361)

2024-11-04 14:47:15 -05:00

plugins

chore: remove unused #includes (#42971)

2024-07-22 11:31:32 +02:00

printing

fix: FTBFS when building with enable_plugins = false (#44003)

2024-09-29 17:10:34 -05:00

resources

chore: strip trailing whitespace (#35969)

2023-02-01 12:59:16 +01:00

serial

refactor: replace base::StringPrintf() calls with absl::StrFormat() (#44552)

2024-11-04 13:12:50 -08:00

ui

fix: tooltips in WCO caption buttons (#44759)

2024-11-20 15:34:58 +01:00

usb

chore: iwyu mojom-forward header files (#43741)

2024-09-17 12:58:56 -07:00

webauthn

chore: add/fix interface comments for sections of methods (#42566)

2024-06-20 10:49:07 +02:00

win

chore: remove unused #includes (#42971)

2024-07-22 11:31:32 +02:00

animation_util_mac.mm

feat: replace BrowserView with WebContentsView (#35658)

2023-12-13 13:01:03 -08:00

animation_util.h

feat: replace BrowserView with WebContentsView (#35658)

2023-12-13 13:01:03 -08:00

auto_updater_mac.mm

chore: bump chromium to 120.0.6099.0 (main) (#40316)

2023-11-01 10:02:12 -04:00

auto_updater.cc

build: make is_mas_build a generated header instead of config (#43737)

2024-09-17 01:38:56 -07:00

auto_updater.h

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

background_throttling_source.h

fix: disable background throttling also in the viz::DisplayScheduler (#38924)

2023-09-26 16:00:46 -04:00

browser_linux.cc

chore: remove unused nogncheck includes (#43964)

2024-09-26 17:09:42 -05:00

browser_mac.mm

build: make is_mas_build a generated header instead of config (#43737)

2024-09-17 01:38:56 -07:00

browser_observer.h

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

browser_process_impl.cc

chore: bump chromium to 129.0.6668.0 (main) (#43368)

2024-08-20 16:54:27 +02:00

browser_process_impl.h

chore: bump chromium to 129.0.6668.0 (main) (#43368)

2024-08-20 16:54:27 +02:00

browser_win.cc

perf: prefer GURL string_view getters (#43443)

2024-08-23 17:15:45 -05:00

browser.cc

chore: remove unused base/ includes (#43688)

2024-09-12 16:05:37 +02:00

browser.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

certificate_manager_model.cc

refactor: remove deprecated BrowserContext::ResourceContext (#41221)

2024-02-05 18:12:34 -06:00

certificate_manager_model.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

child_web_contents_tracker.cc

…

child_web_contents_tracker.h

…

cookie_change_notifier.cc

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

cookie_change_notifier.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

draggable_region_provider.h

refactor: move draggable regions to WebContents (#36230)

2022-11-07 10:15:57 -08:00

electron_api_ipc_handler_impl.cc

chore: remove deprecated ipcRenderer.sendTo() (#39087)

2023-08-28 10:29:27 -04:00

electron_api_ipc_handler_impl.h

refactor: inherit Observer classes privately, pt. 2 (#42237)

2024-05-29 13:07:02 -05:00

electron_autofill_driver_factory.cc

chore: remove unused base/ includes (#43688)

2024-09-12 16:05:37 +02:00

electron_autofill_driver_factory.h

refactor: prefer to inherit observer classes privately (#41360)

2024-05-21 14:21:31 -05:00

electron_autofill_driver.cc

feat: replace BrowserView with WebContentsView (#35658)

2023-12-13 13:01:03 -08:00

electron_autofill_driver.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

electron_browser_client.cc

chore: remove use of banned absl::optional (#44550)

2024-11-04 16:40:56 -05:00

electron_browser_client.h

chore: bump chromium to 131.0.6762.0 (main) (#44117)

2024-10-07 18:06:47 -05:00

electron_browser_context.cc

build: fix build when enable_pdf_viewer and enable_electron_extensions disabled (#43206)

2024-08-07 14:51:38 +02:00

electron_browser_context.h

chore: iwyu mojom-forward header files (#43741)

2024-09-17 12:58:56 -07:00

electron_browser_main_parts_linux.cc

refactor: move impl classes into unnamed namespaces (#42390)

2024-06-10 17:00:20 -05:00

electron_browser_main_parts_mac.mm

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

electron_browser_main_parts_posix.cc

fix: -Wunsafe-buffer-usage warnings when read()ing and write()ing integers (#44185)

2024-10-11 14:29:00 -05:00

electron_browser_main_parts.cc

chore: iwyu mojom-forward header files (#43741)

2024-09-17 12:58:56 -07:00

electron_browser_main_parts.h

chore: iwyu mojom-forward header files (#43741)

2024-09-17 12:58:56 -07:00

electron_crypto_module_delegate_nss.cc

fix: -Wunsafe-buffer-usage warning in ChunkedDataPipeReadableStream (#44211)

2024-10-14 10:46:24 +02:00

electron_crypto_module_delegate_nss.h

feat: Implement password delegate for NSS (#41205)

2024-07-17 09:48:03 -04:00

electron_download_manager_delegate.cc

chore: cleanup include groupings (#43478)

2024-08-26 10:44:20 -04:00

electron_download_manager_delegate.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

electron_gpu_client.cc

…

electron_gpu_client.h

…

electron_navigation_throttle.cc

chore: bump chromium to 127.0.6521.0 (main) (#42118)

2024-06-07 17:18:35 -04:00

electron_navigation_throttle.h

chore: add/fix interface comments for sections of methods (#42566)

2024-06-20 10:49:07 +02:00

electron_pdf_document_helper_client.cc

chore: bump chromium to 132.0.6820.0 (34-x-y) (#44585)

2024-11-06 12:00:35 -05:00

electron_pdf_document_helper_client.h

chore: bump chromium to 132.0.6820.0 (34-x-y) (#44585)

2024-11-06 12:00:35 -05:00

electron_permission_manager.cc

chore: bump chromium to 130.0.6695.0 (main) (#43454)

2024-09-17 18:12:11 -07:00

electron_permission_manager.h

chore: bump chromium to 130.0.6695.0 (main) (#43454)

2024-09-17 18:12:11 -07:00

electron_plugin_info_host_impl.cc

chore: bump chromium to 129.0.6650.0 (main) (#43266)

2024-08-12 10:28:33 +02:00

electron_plugin_info_host_impl.h

chore: bump chromium to 129.0.6650.0 (main) (#43266)

2024-08-12 10:28:33 +02:00

electron_speech_recognition_manager_delegate.cc

refactor: do not subclass ElectronSpeechRecognitionManagerDelegate from SpeechRecognitionEventListener (#42806)

2024-07-10 15:32:50 +02:00

electron_speech_recognition_manager_delegate.h

refactor: do not subclass ElectronSpeechRecognitionManagerDelegate from SpeechRecognitionEventListener (#42806)

2024-07-10 15:32:50 +02:00

electron_web_contents_utility_handler_impl.cc

chore: bump chromium to 125.0.6412.0 (main) (#41610)

2024-04-15 18:10:32 -04:00

electron_web_contents_utility_handler_impl.h

refactor: inherit Observer classes privately, pt. 2 (#42237)

2024-05-29 13:07:02 -05:00

electron_web_ui_controller_factory.cc

perf: prefer GURL string_view getters (#43443)

2024-08-23 17:15:45 -05:00

electron_web_ui_controller_factory.h

…

event_emitter_mixin.h

chore: migrate base::StringPiece to std::string_view (#40915)

2024-01-10 19:00:37 -06:00

extended_web_contents_observer.h

chore: iwyu mojom-forward header files (#43741)

2024-09-17 12:58:56 -07:00

fake_location_provider.cc

chore: remove unused base/ includes (#43688)

2024-09-12 16:05:37 +02:00

fake_location_provider.h

chore: bump chromium to 116.0.5845.0 (main) (#38827)

2023-06-22 10:51:15 +02:00

feature_list_mac.mm

feat: add support for system picker in setDisplayMediaRequestHandler (#43581)

2024-09-10 16:05:57 -07:00

feature_list.cc

feat: add support for system picker in setDisplayMediaRequestHandler (#43581)

2024-09-10 16:05:57 -07:00

feature_list.h

feat: add support for system picker in setDisplayMediaRequestHandler (#43581)

2024-09-10 16:05:57 -07:00

file_select_helper_mac.mm

refactor: replace remaining NULL with nullptr (#40053)

2023-10-03 12:26:35 -07:00

file_select_helper.cc

chore: bump chromium to 132.0.6834.0 (34-x-y) (#44666)

2024-11-14 20:56:18 -05:00

file_select_helper.h

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

font_defaults.cc

fix: -Wunsafe-buffer-usage in electron::SetFontDefaults() (#44014)

2024-09-30 15:09:36 +02:00

font_defaults.h

…

javascript_environment.cc

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

javascript_environment.h

refactor: remove unused fields, methods in gin_helper::Locker (#39803)

2023-09-12 16:53:20 -07:00

login_handler.cc

chore: bump chromium to 131.0.6762.0 (main) (#44117)

2024-10-07 18:06:47 -05:00

login_handler.h

chore: bump chromium to 131.0.6762.0 (main) (#44117)

2024-10-07 18:06:47 -05:00

microtasks_runner.cc

perf: remove isolate scope from DidProcessTask() (#44471)

2024-10-31 20:21:07 -04:00

microtasks_runner.h

chore: enable check raw ptr fields (#38167)

2023-05-11 16:07:39 -04:00

native_window_features.cc

chore: bump chromium to 127.0.6521.0 (main) (#42118)

2024-06-07 17:18:35 -04:00

native_window_features.h

…

native_window_mac.h

chore: iwyu mojom-forward header files (#43741)

2024-09-17 12:58:56 -07:00

native_window_mac.mm

chore: fix textured window conditional on macOS (#44768)

2024-11-20 14:56:38 -05:00

native_window_observer.h

feat: replace scroll-touch* with generic input-event (#35531)

2022-09-27 12:47:46 -07:00

native_window_views_win.cc

chore: bump chromium to 131.0.6744.0 (main) (#43948)

2024-09-30 14:54:44 +02:00

native_window_views.cc

fix: improve single-pixel resize handling on Windows (#44722)

2024-11-19 10:53:04 -05:00

native_window_views.h

chore: bump chromium to 131.0.6744.0 (main) (#43948)

2024-09-30 14:54:44 +02:00

native_window.cc

refactor: put empty virtual function definitions in header (#43285)

2024-08-12 09:56:51 +02:00

native_window.h

chore: iwyu mojom-forward header files (#43741)

2024-09-17 12:58:56 -07:00

network_hints_handler_impl.cc

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

network_hints_handler_impl.h

chore: enable check raw ptr fields (#38167)

2023-05-11 16:07:39 -04:00

protocol_registry.cc

perf: prefer GURL string_view getters (#43443)

2024-08-23 17:15:45 -05:00

protocol_registry.h

perf: prefer GURL string_view getters (#43443)

2024-08-23 17:15:45 -05:00

relauncher_linux.cc

chore: remove unused #includes (#42971)

2024-07-22 11:31:32 +02:00

relauncher_mac.cc

chore: remove unused #includes (#42971)

2024-07-22 11:31:32 +02:00

relauncher_win.cc

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

relauncher.cc

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

relauncher.h

…

session_preferences.cc

refactor: add SessionPreferences::CreateForBrowserContext() (#38656)

2023-06-09 11:20:43 -05:00

session_preferences.h

refactor: add SessionPreferences::CreateForBrowserContext() (#38656)

2023-06-09 11:20:43 -05:00

special_storage_policy.cc

chore: remove unused base/ includes (#43688)

2024-09-12 16:05:37 +02:00

special_storage_policy.h

chore: bump chromium to 106.0.5216.0 (main) (#34993)

2022-08-17 11:35:53 -07:00

web_contents_permission_helper.cc

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

web_contents_permission_helper.h

feat: implement File System API support (#41419)

2024-04-10 22:06:47 +02:00

web_contents_preferences.cc

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

web_contents_preferences.h

refactor: remove unused web contents preferences methods (#42947)

2024-07-19 12:26:57 -05:00

web_contents_zoom_controller.cc

perf: prefer GURL string_view getters (#43443)

2024-08-23 17:15:45 -05:00

web_contents_zoom_controller.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

web_contents_zoom_observer.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

web_view_guest_delegate.cc

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

web_view_guest_delegate.h

refactor: prefer to inherit observer classes privately (#41360)

2024-05-21 14:21:31 -05:00

web_view_manager.cc

chore: bump chromium to 121.0.6147.0 (main) (#40523)

2023-11-28 13:40:12 -08:00

web_view_manager.h

perf: use flat_set, flat_map for small, trivially-moved containers (#40817)

2024-01-05 12:18:31 +01:00

window_list_observer.h

refactor: remove WindowListObserver::OnWindowAdded() (#42979)

2024-07-22 10:44:08 +02:00

window_list.cc

chore: remove unused base/ includes (#43688)

2024-09-12 16:05:37 +02:00

window_list.h

refactor: migrate deprecated LazyInstance code to NoDestructor (#40927)

2024-01-10 14:01:49 -06:00

zoom_level_delegate.cc

chore: remove unused base/ includes (#43688)

2024-09-12 16:05:37 +02:00

zoom_level_delegate.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00