mirror of
https://github.com/electron/electron.git
synced 2026-05-02 03:00:22 -04:00
44f030f039
* fix: add inputs to node_headers target for proper invalidation The `generate_node_headers` action had no `inputs` declared, so Ninja would not rebuild when node or V8 header files changed. This caused stale headers to remain in gen/node_headers after a Node.js bump, leading to build failures with errors in files like target_agent.h. Add inputs including the install.py script (which determines which headers to copy), key Node.js headers, inspector headers, and V8 version headers. Changes to any of these will now trigger regeneration. https://claude.ai/code/session_018qZ1FBZCEkmDC1sRvPQnqp * refactor: drive node_headers inputs from filenames.auto.gni Wire the `generate_node_headers` action's inputs through the existing auto_filenames mechanism so there is a single source of truth for which files should invalidate the generated node_headers directory. `script/gen-filenames.ts` now enumerates node and v8 header files via filesystem scan and records them under `auto_filenames.node_header_sources` in filenames.auto.gni, alongside install.py (which drives which headers get copied). BUILD.gn consumes the list directly as the action's `inputs` parameter. The list will repopulate fully the next time `ts-node script/gen-filenames.ts` runs (via lint-staged on any JS/TS commit), the same way webpack bundle deps are refreshed today. https://claude.ai/code/session_018qZ1FBZCEkmDC1sRvPQnqp * chore: update filenames * fmt --------- Co-authored-by: Claude <noreply@anthropic.com>