Shelley Vohr 222c989f13 fix: bind offscreen paint callback to child WebContents (#49998) ...

fix: bind offscreen paint callback to child WebContents

Previously, MaybeOverrideCreateParamsForNewWindow bound the
OffScreenWebContentsView's paint callback to the parent WebContents
using base::Unretained(this). This was both unsafe (dangling pointer
risk if the parent is destroyed before the child) and semantically
incorrect — paint events belong to the child window, not the opener.

Replace the callback in MaybeOverrideCreateParamsForNewWindow with
base::DoNothing(), then rebind it to the child WebContents in
AddNewContents via a new SetCallback method on OffScreenWebContentsView.

2026-03-02 11:24:48 -05:00

..

views

refactor: remove gin_helper::Arguments (#48374)

2025-10-03 14:10:29 -05:00

electron_api_app_mac.mm

refactor: DRY in App::SetAppLogPath() (#48452)

2025-10-05 12:32:28 -05:00

electron_api_app_mas.mm

chore: bump chromium to 117.0.5923.0 (main) (#39304)

2023-08-04 10:47:29 +02:00

electron_api_app.cc

feat: improve Windows Toast actions support (#48132)

2026-02-12 17:25:20 -05:00

electron_api_app.h

feat: improve Windows Toast actions support (#48132)

2026-02-12 17:25:20 -05:00

electron_api_auto_updater.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_auto_updater.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_base_window_mac.mm

fix: explicitly call GetNativeNSView() on macOS (#46733)

2025-04-23 17:55:18 -05:00

electron_api_base_window.cc

refactor: simplify BaseWindow parent<->child association code (#49537)

2026-02-26 09:22:42 -06:00

electron_api_base_window.h

refactor: simplify BaseWindow parent<->child association code (#49537)

2026-02-26 09:22:42 -06:00

electron_api_browser_window.cc

refactor: simplify BaseWindow parent<->child association code (#49537)

2026-02-26 09:22:42 -06:00

electron_api_browser_window.h

fix: fixed white flash on call to BrowserWindow.show (#47151)

2025-10-14 15:58:27 +02:00

electron_api_content_tracing.cc

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_cookies.cc

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_cookies.h

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_crash_reporter.cc

refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) (#47760)

2025-07-21 16:34:38 +02:00

electron_api_crash_reporter.h

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

electron_api_data_pipe_holder.cc

refactor: use gin::Wrappable for electron::api::DataPipeHolder (#49495)

2026-01-23 20:29:01 +09:00

electron_api_data_pipe_holder.h

refactor: use gin::Wrappable for electron::api::DataPipeHolder (#49495)

2026-01-23 20:29:01 +09:00

electron_api_debugger.cc

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_debugger.h

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_desktop_capturer_mac.mm

feat: add support for system picker in setDisplayMediaRequestHandler (#43581)

2024-09-10 16:05:57 -07:00

electron_api_desktop_capturer.cc

chore: bump chromium to 147.0.7687.0 (main) (#49782)

2026-02-17 14:25:21 -05:00

electron_api_desktop_capturer.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_dialog.cc

refactor: narrow or remove gin arguments (#48300)

2025-09-13 08:19:07 +09:00

electron_api_download_item.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_download_item.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_event_emitter.cc

refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) (#47760)

2025-07-21 16:34:38 +02:00

electron_api_event_emitter.h

chore: add ELECTRON_ prefix to C++ include guards (#31925)

2021-11-22 16:34:31 +09:00

electron_api_extensions.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_extensions.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_global_shortcut.cc

fix: clang-tidy warnings, pt. 1 (#49083)

2026-01-09 22:57:38 -08:00

electron_api_global_shortcut.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_in_app_purchase.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_in_app_purchase.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_menu_mac.h

refactor: make api::Menu inherit from gin::Wrappable (#48351)

2025-09-24 19:42:22 -05:00

electron_api_menu_mac.mm

fix: menu close event missing after opening a submenu (#49783)

2026-02-26 10:40:29 -05:00

electron_api_menu_views.cc

refactor: remove base::AdaptCallbackForRepeating patch (#48774)

2025-11-05 11:00:51 -08:00

electron_api_menu_views.h

feat: add support for associating a Menu with a WebFrameMain (#45138)

2025-03-28 11:50:07 -07:00

electron_api_menu.cc

fix: update label/sublabel/icon in MenuItems on open (#49678)

2026-02-27 12:47:05 -05:00

electron_api_menu.h

fix: update label/sublabel/icon in MenuItems on open (#49678)

2026-02-27 12:47:05 -05:00

electron_api_msix_updater.cc

refactor: replace std::to_string() with base::NumberToString() (#49949)

2026-02-26 14:57:54 -05:00

electron_api_msix_updater.h

feat: msix auto-updater (#49230)

2026-01-29 16:38:26 -05:00

electron_api_native_theme_mac.mm

chore: cleanup arc migration helpers (#39606)

2023-08-23 09:54:21 -04:00

electron_api_native_theme.cc

chore: bump chromium to 143.0.7451.0 (main) (#48362)

2025-10-13 12:21:54 -04:00

electron_api_native_theme.h

chore: bump chromium to 141.0.7390.7 (main) (#48212)

2025-09-08 12:57:15 +02:00

electron_api_net_log.cc

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_net_log.h

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_notification.cc

feat: improve Windows Toast actions support (#48132)

2026-02-12 17:25:20 -05:00

electron_api_notification.h

feat: improve Windows Toast actions support (#48132)

2026-02-12 17:25:20 -05:00

electron_api_power_monitor_mac.mm

fix: remove extra 'suspend'/'resume' handling from powerMonitor (#47162)

2025-05-21 10:00:38 -05:00

electron_api_power_monitor_win.cc

fix: remove extra 'suspend'/'resume' handling from powerMonitor (#47162)

2025-05-21 10:00:38 -05:00

electron_api_power_monitor.cc

refactor: use gin::Wrappable for electron::api::PowerMonitor (#49509)

2026-01-25 22:51:31 -06:00

electron_api_power_monitor.h

refactor: use gin::Wrappable for electron::api::PowerMonitor (#49509)

2026-01-25 22:51:31 -06:00

electron_api_power_save_blocker.cc

refactor: use gin::Wrappable in electron::api::PowerSaveBlocker (#49381)

2026-01-22 17:31:38 -06:00

electron_api_power_save_blocker.h

refactor: use gin::Wrappable in electron::api::PowerSaveBlocker (#49381)

2026-01-22 17:31:38 -06:00

electron_api_printing.cc

refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) (#47760)

2025-07-21 16:34:38 +02:00

electron_api_protocol.cc

chore: bump chromium to 146.0.7645.0 (main) (#49453)

2026-01-22 17:01:09 -05:00

electron_api_protocol.h

chore: bump chromium to 142.0.7417.0 (main) (#48275)

2025-09-22 20:16:27 -07:00

electron_api_push_notifications_mac.mm

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_push_notifications.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_push_notifications.h

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_safe_storage.cc

feat: introduce os_crypt_async in safeStorage (#49054)

2026-02-15 19:54:50 +01:00

electron_api_safe_storage.h

feat: introduce os_crypt_async in safeStorage (#49054)

2026-02-15 19:54:50 +01:00

electron_api_screen.cc

fix: potential dangling pointer in api::Screen (#49536)

2026-01-27 16:27:38 -05:00

electron_api_screen.h

fix: potential dangling pointer in api::Screen (#49536)

2026-01-27 16:27:38 -05:00

electron_api_service_worker_context.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_service_worker_context.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_service_worker_main.cc

chore: bump chromium to 144.0.7512.1 (main) (#48768)

2025-11-07 10:13:45 -05:00

electron_api_service_worker_main.h

refactor: avoid unused inheritance in ServiceWorkerMain (#48279)

2025-09-10 11:16:35 -05:00

electron_api_session.cc

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_session.h

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_system_preferences_mac.mm

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_system_preferences_win.cc

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_system_preferences.cc

feat: Add getAccentColor on Linux (#48027)

2025-10-21 14:26:30 -04:00

electron_api_system_preferences.h

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_tray.cc

feat: allow macOS tray to maintain position (#47838)

2025-08-07 19:25:50 +02:00

electron_api_tray.h

feat: allow macOS tray to maintain position (#47838)

2025-08-07 19:25:50 +02:00

electron_api_utility_process.cc

fix: recover network requests after Network Service restart (#49887)

2026-02-25 12:53:06 -05:00

electron_api_utility_process.h

fix: recover network requests after Network Service restart (#49887)

2026-02-25 12:53:06 -05:00

electron_api_view.cc

feat: Allow View.setBounds to animate (#48812)

2026-01-30 15:18:56 -05:00

electron_api_view.h

feat: Allow View.setBounds to animate (#48812)

2026-01-30 15:18:56 -05:00

electron_api_web_contents_impl.cc

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

electron_api_web_contents_mac.mm

chore: remove WebContents.getNativeView() (#46734)

2025-04-23 20:33:50 -05:00

electron_api_web_contents_view.cc

fix: prevent crash on Windows when closing child windows (#49901)

2026-02-24 15:48:04 +01:00

electron_api_web_contents_view.h

fix: prevent crash on Windows when closing child windows (#49901)

2026-02-24 15:48:04 +01:00

electron_api_web_contents.cc

fix: bind offscreen paint callback to child WebContents (#49998)

2026-03-02 11:24:48 -05:00

electron_api_web_contents.h

chore: bump chromium to 147.0.7699.0 (main) (#49831)

2026-02-24 16:42:05 -05:00

electron_api_web_frame_main.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_web_frame_main.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_web_request.cc

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

electron_api_web_request.h

refactor: make api::WebRequest inherit from gin::Wrappable (#48762)

2025-11-12 12:53:00 -06:00

electron_api_web_view_manager.cc

chore: bump chromium to 143.0.7489.0 (main) (#48642)

2025-10-23 16:28:51 -04:00

frame_subscriber.cc

chore: bump chromium to 141.0.7390.7 (main) (#48212)

2025-09-08 12:57:15 +02:00

frame_subscriber.h

chore: bump chromium to 142.0.7417.0 (main) (#48275)

2025-09-22 20:16:27 -07:00

gpu_info_enumerator.cc

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

gpu_info_enumerator.h

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

gpuinfo_manager.cc

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

gpuinfo_manager.h

chore: bump chromium to 146.0.7666.0 (main) (#49528)

2026-02-12 12:37:56 -05:00

ipc_dispatcher.h

refactor: allocate gin_helper::internal::Event on cpp heap (#48161)

2025-08-27 09:30:50 +09:00

message_port.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

message_port.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

process_metric.cc

build: make is_mas_build a generated header instead of config (#43737)

2024-09-17 01:38:56 -07:00

process_metric.h

chore: bump chromium to 100.0.4857.0 (main) (#32419)

2022-02-09 18:58:52 -08:00

save_page_handler.cc

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

save_page_handler.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

ui_event.cc

chore: used nested namespaces (#34737)

2022-06-29 12:55:47 -07:00

ui_event.h

chore: used nested namespaces (#34737)

2022-06-29 12:55:47 -07:00