trop[bot] 253d49b24f fix: ensure /dev/null fd is closed on failure (#47543) ...

* fix: ensure /dev/null fd is closed on failure

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: ignore closehandle for windows

Co-authored-by: Robo <hop2deep@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: Robo <hop2deep@gmail.com>

2025-06-24 21:12:21 +02:00

..

views

chore: bump chromium to 137.0.7128.1 (main) (#46482)

2025-04-22 15:53:29 -04:00

electron_api_app_mac.mm

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

electron_api_app_mas.mm

chore: bump chromium to 117.0.5923.0 (main) (#39304)

2023-08-04 10:47:29 +02:00

electron_api_app.cc

chore: bump chromium to 138.0.7154.0 (37-x-y) (#46894)

2025-05-02 10:08:04 -04:00

electron_api_app.h

chore: bump chromium to 138.0.7154.0 (37-x-y) (#46894)

2025-05-02 10:08:04 -04:00

electron_api_auto_updater.cc

refactor: reduce & remove no-op MicrotasksScope calls (#46681)

2025-04-19 12:18:03 -05:00

electron_api_auto_updater.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_base_window_mac.mm

fix: explicitly call GetNativeNSView() on macOS (#46733)

2025-04-23 17:55:18 -05:00

electron_api_base_window.cc

fix: revert moving IsClosed() and IsClosable() into NativeWindow::Close() (#47485)

2025-06-16 21:20:53 -07:00

electron_api_base_window.h

refactor: make TrackableObject::weak_map_id() constexpr (#47115)

2025-05-15 19:38:34 -05:00

electron_api_browser_window.cc

refactor: remove public method BrowserWindow::GetWeakPtr() (#46763)

2025-04-25 15:01:52 -05:00

electron_api_browser_window.h

refactor: remove public method BrowserWindow::GetWeakPtr() (#46763)

2025-04-25 15:01:52 -05:00

electron_api_content_tracing.cc

refactor: in StopTracing(), use string literals instead of optional<string> (#45270)

2025-01-21 17:41:52 -06:00

electron_api_cookies.cc

refactor: use net::CanonicalCookie::IsDomainMatch() (#46748)

2025-04-25 16:08:16 +02:00

electron_api_cookies.h

chore: remove unused isolate argument from Cookies constructor (#44907)

2024-12-02 11:34:21 -05:00

electron_api_crash_reporter.cc

refactor: fix modernize-return-braced-init-list warnings (#44838)

2024-11-27 09:41:46 +09:00

electron_api_crash_reporter.h

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

electron_api_data_pipe_holder.cc

refactor: make node Buffers more friendly to base::span / std::span (#46724)

2025-04-25 08:00:09 -05:00

electron_api_data_pipe_holder.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_debugger.cc

fix: crash calling Fetch.continueResponse with WebContentsView (#47444)

2025-06-11 12:25:18 -05:00

electron_api_debugger.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_desktop_capturer_mac.mm

feat: add support for system picker in setDisplayMediaRequestHandler (#43581)

2024-09-10 16:05:57 -07:00

electron_api_desktop_capturer.cc

perf: don't wait for thumbnails if they were not requested on macOS (#46138)

2025-03-25 12:20:38 +01:00

electron_api_desktop_capturer.h

feat: add support for system picker in setDisplayMediaRequestHandler (#43581)

2024-09-10 16:05:57 -07:00

electron_api_dialog.cc

refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath> (#47453)

2025-06-13 10:03:03 +02:00

electron_api_download_item.cc

refactor: return-braced-init-list pt 2 of 2 (#44870)

2024-11-29 11:44:33 -06:00

electron_api_download_item.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_event_emitter.cc

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

electron_api_event_emitter.h

chore: add ELECTRON_ prefix to C++ include guards (#31925)

2021-11-22 16:34:31 +09:00

electron_api_extensions.cc

refactor: move extension APIs to session.extensions (#45597)

2025-02-21 17:36:51 -06:00

electron_api_extensions.h

refactor: remove field unused weak_factory_ (#46363)

2025-03-31 10:39:21 +02:00

electron_api_global_shortcut.cc

perf: avoid redundant map lookups in GlobalShortcut (#46229)

2025-03-25 09:46:03 -05:00

electron_api_global_shortcut.h

refactor: remove unused v8::Isolate* arg from GlobalShortcut constructor (#45773)

2025-02-24 19:38:20 -06:00

electron_api_in_app_purchase.cc

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

electron_api_in_app_purchase.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_menu_mac.h

feat: add support for associating a Menu with a WebFrameMain (#45138)

2025-03-28 11:50:07 -07:00

electron_api_menu_mac.mm

fix: fallback to old MacOS context menu behavior if no frame is present (#46595)

2025-04-11 10:15:35 -04:00

electron_api_menu_views.cc

feat: add support for associating a Menu with a WebFrameMain (#45138)

2025-03-28 11:50:07 -07:00

electron_api_menu_views.h

feat: add support for associating a Menu with a WebFrameMain (#45138)

2025-03-28 11:50:07 -07:00

electron_api_menu.cc

feat: add menu item role palette and header (#47245)

2025-06-23 19:54:53 -04:00

electron_api_menu.h

feat: add menu item role palette and header (#47245)

2025-06-23 19:54:53 -04:00

electron_api_native_theme_mac.mm

chore: cleanup arc migration helpers (#39606)

2023-08-23 09:54:21 -04:00

electron_api_native_theme.cc

feat: expose nativeTheme.shouldUseDarkColorsForSystemIntegratedUI (#46438)

2025-04-10 12:08:29 +02:00

electron_api_native_theme.h

feat: expose nativeTheme.shouldUseDarkColorsForSystemIntegratedUI (#46438)

2025-04-10 12:08:29 +02:00

electron_api_net_log.cc

refactor: fix modernize-return-braced-init-list warnings (#44838)

2024-11-27 09:41:46 +09:00

electron_api_net_log.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_notification.cc

fix: crash in gin::wrappable::secondweakcallback (#45368)

2025-01-29 10:20:37 -08:00

electron_api_notification.h

fix: crash in gin::wrappable::secondweakcallback (#45368)

2025-01-29 10:20:37 -08:00

electron_api_power_monitor_mac.mm

fix: remove extra 'suspend'/'resume' handling from powerMonitor (#47188)

2025-05-22 00:01:17 -05:00

electron_api_power_monitor_win.cc

fix: remove extra 'suspend'/'resume' handling from powerMonitor (#47188)

2025-05-22 00:01:17 -05:00

electron_api_power_monitor.cc

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

electron_api_power_monitor.h

docs: fix spelling errors in code comments (#45842)

2025-02-28 12:24:00 +01:00

electron_api_power_save_blocker.cc

refactor: use C++20's contains() method (#45742)

2025-02-21 17:33:43 -06:00

electron_api_power_save_blocker.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_printing.cc

chore: bump chromium to 135.0.7015.0 (main) (#45500)

2025-02-18 11:51:27 -05:00

electron_api_protocol.cc

refactor: reduce coupling in electron::api::Protocol (#46122)

2025-03-21 07:33:25 -05:00

electron_api_protocol.h

refactor: reduce coupling in electron::api::Protocol (#46122)

2025-03-21 07:33:25 -05:00

electron_api_push_notifications_mac.mm

fix: APNS token ids are lowercase ASCII (#46101)

2025-03-20 07:57:50 +01:00

electron_api_push_notifications.cc

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

electron_api_push_notifications.h

refactor: declare gin::Wrapper subclasses as final (#43527)

2024-09-04 18:40:02 -05:00

electron_api_safe_storage.cc

refactor: make node Buffers more friendly to base::span / std::span (#46724)

2025-04-25 08:00:09 -05:00

electron_api_screen.cc

feat: support dip <-> screen conversion on Linux X11 (#46895)

2025-05-02 19:08:50 -05:00

electron_api_screen.h

feat: support dip <-> screen conversion on Linux X11 (#46895)

2025-05-02 19:08:50 -05:00

electron_api_service_worker_context.cc

feat: ServiceWorkerMain (#45232)

2025-01-24 08:33:44 -05:00

electron_api_service_worker_context.h

feat: ServiceWorkerMain (#45232)

2025-01-24 08:33:44 -05:00

electron_api_service_worker_main.cc

perf: use absl::flat_hash_map instead of std::unordered_map (#46202)

2025-03-24 10:09:14 +01:00

electron_api_service_worker_main.h

refactor: remove unused field ServiceWorkerMain::weak_factory_ (#46171)

2025-03-23 10:14:45 +01:00

electron_api_session.cc

fix: rework lifetime mgmt of ClearDataTask/ClearDataOperation (#47412)

2025-06-08 12:56:35 +02:00

electron_api_session.h

refactor: move extension APIs to session.extensions (#45597)

2025-02-21 17:36:51 -06:00

electron_api_system_preferences_mac.mm

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

electron_api_system_preferences_win.cc

build: match upstream with unsafe buffer paths (#45853)

2025-03-06 16:04:18 -05:00

electron_api_system_preferences.cc

chore: deprecate systemPreferences.isAeroGlassEnabled() (#45434)

2025-02-10 15:17:07 -05:00

electron_api_system_preferences.h

chore: deprecate systemPreferences.isAeroGlassEnabled() (#45434)

2025-02-10 15:17:07 -05:00

electron_api_tray.cc

fix: crash in gin::wrappable::secondweakcallback (#45368)

2025-01-29 10:20:37 -08:00

electron_api_tray.h

fix: crash in gin::wrappable::secondweakcallback (#45368)

2025-01-29 10:20:37 -08:00

electron_api_utility_process.cc

fix: ensure /dev/null fd is closed on failure (#47543)

2025-06-24 21:12:21 +02:00

electron_api_utility_process.h

refactor: use private inheritance from mojo::MessageReceiver (#45973)

2025-03-12 19:06:41 +01:00

electron_api_view.cc

fix: addChildView() crashes when adding a closed WebContentsView (#47338)

2025-06-04 14:08:49 +02:00

electron_api_view.h

refactor: make api::View methods const, private (#46545)

2025-04-07 16:23:36 -05:00

electron_api_web_contents_impl.cc

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

electron_api_web_contents_mac.mm

chore: remove WebContents.getNativeView() (#46734)

2025-04-23 20:33:50 -05:00

electron_api_web_contents_view.cc

refactor: add NativeWindow::FromWidget() helper (#46928)

2025-05-05 13:02:47 -04:00

electron_api_web_contents_view.h

feat: customize border radius of Views (#42320)

2024-07-16 20:16:25 -04:00

electron_api_web_contents.cc

refactor: have ShowSaveDialogSync() return a std::optional<base::FilePath> (#47453)

2025-06-13 10:03:03 +02:00

electron_api_web_contents.h

feat: allow intercepting mouse events (#47364)

2025-06-05 15:47:42 +02:00

electron_api_web_frame_main.cc

perf: avoid double map lookup in WebFrameMain::UpdateRenderFrameHost() (#46293)

2025-03-27 14:32:01 -05:00

electron_api_web_frame_main.h

feat: add support for associating a Menu with a WebFrameMain (#45138)

2025-03-28 11:50:07 -07:00

electron_api_web_request.cc

refactor: add EmitDeprecationWarning helper (#46878)

2025-05-01 11:41:45 -05:00

electron_api_web_request.h

feat: add excludeUrls and modify urls in WebRequestFilter for better URL filtering (#44692)

2025-02-17 12:40:47 -08:00

electron_api_web_view_manager.cc

chore: rename built-in modules to bindings to match naming update in node (#37182)

2023-02-09 10:31:38 +09:00

frame_subscriber.cc

refactor: put empty virtual function definitions in header (#43285)

2024-08-12 09:56:51 +02:00

frame_subscriber.h

refactor: put empty virtual function definitions in header (#43285)

2024-08-12 09:56:51 +02:00

gpu_info_enumerator.cc

refactor: simplify code by using base::Value::EnsureList() (#41162)

2024-01-30 14:48:09 -06:00

gpu_info_enumerator.h

refactor: remove unused system header includes (#46015)

2025-03-14 10:59:15 -05:00

gpuinfo_manager.cc

fix: gin_helper::Promise in GPUInfoManager must be destroyed before destroying Node/V8 (#46434)

2025-04-03 10:12:12 -07:00

gpuinfo_manager.h

fix: gin_helper::Promise in GPUInfoManager must be destroyed before destroying Node/V8 (#46434)

2025-04-03 10:12:12 -07:00

ipc_dispatcher.h

refactor: dispatch IPC messages from Session (#45452)

2025-02-17 16:36:28 -05:00

message_port.cc

fix: postMessage crash with invalid transferrable (#46639)

2025-04-17 15:09:48 +02:00

message_port.h

refactor: use private inheritance from mojo::MessageReceiver (#45973)

2025-03-12 19:06:41 +01:00

process_metric.cc

build: make is_mas_build a generated header instead of config (#43737)

2024-09-17 01:38:56 -07:00

process_metric.h

chore: bump chromium to 100.0.4857.0 (main) (#32419)

2022-02-09 18:58:52 -08:00

save_page_handler.cc

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

save_page_handler.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

ui_event.cc

chore: used nested namespaces (#34737)

2022-06-29 12:55:47 -07:00

ui_event.h

chore: used nested namespaces (#34737)

2022-06-29 12:55:47 -07:00