mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
66fa1f4665
* chore: bump node in DEPS to v20.17.0 * module: disallow CJS <-> ESM edges in a cycle from require(esm) https://github.com/nodejs/node/pull/52264 * src: expose LookupAndCompile with parameters https://github.com/nodejs/node/pull/53886 * src: fix -Wshadow warning https://github.com/nodejs/node/pull/53885 * lib: convert WeakMaps in cjs loader with symbol properties https://github.com/nodejs/node/pull/52095 * src: reduce unnecessary serialization of CLI options in C++ https://github.com/nodejs/node/pull/52451 * build: ensure v8_pointer_compression_sandbox is enabled on 64bit https://github.com/nodejs/node/pull/53884 * lib: improve error message when index not found on cjs https://github.com/nodejs/node/pull/53859 * src,lib: expose getCategoryEnabledBuffer to use on node.http https://github.com/nodejs/node/pull/53602 * deps: update c-ares to v1.32.2 https://github.com/nodejs/node/pull/53865 * chore: update patch indices * deps: update V8 to 12.2 https://github.com/nodejs/node/pull/51362 * stream: Expose DuplexPair API https://github.com/nodejs/node/pull/34111 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
36 lines
1.3 KiB
Diff
36 lines
1.3 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Charles Kerr <charles@charleskerr.com>
|
|
Date: Tue, 17 Oct 2023 10:58:41 -0500
|
|
Subject: chore: remove use of deprecated kMaxLength
|
|
|
|
https://chromium-review.googlesource.com/c/v8/v8/+/4935412
|
|
|
|
This patch can be removed when upstream moves to kMaxByteLength
|
|
|
|
diff --git a/src/node_buffer.h b/src/node_buffer.h
|
|
index 606a6f5caa3b11b6d2a9068ed2fd65800530a5eb..080dcce21da05ccea398d8a856deb397b1ac8b07 100644
|
|
--- a/src/node_buffer.h
|
|
+++ b/src/node_buffer.h
|
|
@@ -29,7 +29,7 @@ namespace node {
|
|
|
|
namespace Buffer {
|
|
|
|
-static const size_t kMaxLength = v8::TypedArray::kMaxLength;
|
|
+static const size_t kMaxLength = v8::TypedArray::kMaxByteLength;
|
|
|
|
typedef void (*FreeCallback)(char* data, void* hint);
|
|
|
|
diff --git a/src/node_errors.h b/src/node_errors.h
|
|
index ad40141ca92c5a46ae2e4dfa96e4d6c239da8516..c462e5afcaa2328c4908fff462fc7c9fbfc1fd5f 100644
|
|
--- a/src/node_errors.h
|
|
+++ b/src/node_errors.h
|
|
@@ -232,7 +232,7 @@ inline v8::Local<v8::Value> ERR_BUFFER_TOO_LARGE(v8::Isolate* isolate) {
|
|
char message[128];
|
|
snprintf(message, sizeof(message),
|
|
"Cannot create a Buffer larger than 0x%zx bytes",
|
|
- v8::TypedArray::kMaxLength);
|
|
+ v8::TypedArray::kMaxByteLength);
|
|
return ERR_BUFFER_TOO_LARGE(isolate, message);
|
|
}
|
|
|