mirror of
https://github.com/electron/electron.git
synced 2026-01-08 23:18:06 -05:00
* chore: upgrade Node.js to v24.10.0 * chore: fixup crypto patch * chore: fixup crypto test patch * src: prepare for v8 sandboxing https://github.com/nodejs/node/pull/58376 * esm: fix module.exports export on CJS modules https://github.com/nodejs/node/pull/57366 * chore: fixup lazyload fs patch * esm: Source Phase Imports for WebAssembly https://github.com/nodejs/node/pull/56919 * module: remove --experimental-default-type https://github.com/nodejs/node/pull/56092 * lib,src: refactor assert to load error source from memory https://github.com/nodejs/node/pull/59751 * src: add source location to v8::TaskRunner https://github.com/nodejs/node/pull/54077 * src: remove dependency on wrapper-descriptor-based CppHeap https://github.com/nodejs/node/pull/54077 * src: do not use soon-to-be-deprecated V8 API https://github.com/nodejs/node/pull/53174 * src: stop using deprecated fields of v8::FastApiCallbackOptions https://github.com/nodejs/node/pull/54077 * test: update v8-stats test for V8 12.6 https://github.com/nodejs/node/pull/54077 * esm: unflag --experimental-wasm-modules https://github.com/nodejs/node/pull/57038 * test: adapt assert tests to stack trace changes https://github.com/nodejs/node/pull/58070 * src,test: unregister the isolate after disposal and before freeing https://github.com/nodejs/node/pull/58070 * src: use cppgc to manage ContextifyContext https://github.com/nodejs/node/pull/56522 * src: replace uses of FastApiTypedArray https://github.com/nodejs/node/pull/58070 * module: integrate TypeScript into compile cache https://github.com/nodejs/node/pull/56629 * deps: update ada to 3.2.7 https://github.com/nodejs/node/pull/59336 * src: make minor cleanups in encoding_binding.cc https://github.com/nodejs/node/pull/57448 * src: switch from `Get/SetPrototype` to `Get/SetPrototypeV2` https://github.com/nodejs/node/pull/55453 * src: use non-deprecated Get/SetPrototype methods https://github.com/nodejs/node/pull/59671 * src: simplify string_bytes with views https://github.com/nodejs/node/pull/54876 * src: improve utf8 string generation performance https://github.com/nodejs/node/pull/54873 * src: use non-deprecated Utf8LengthV2() method https://github.com/nodejs/node/pull/58070 * src: use non-deprecated WriteUtf8V2() method https://github.com/nodejs/node/pull/58070 * src: refactor WriteUCS2 and remove flags argument https://github.com/nodejs/node/pull/58163 * src: use String::WriteV2() in TwoByteValue https://github.com/nodejs/node/pull/58164 * node-api: use WriteV2 in napi_get_value_string_utf16 https://github.com/nodejs/node/pull/58165 * node-api: use WriteOneByteV2 in napi_get_value_string_latin1 https://github.com/nodejs/node/pull/58325 * src: migrate WriteOneByte to WriteOneByteV2 https://github.com/nodejs/node/pull/59634 * fs: introduce dirent\.parentPath https://github.com/nodejs/node/pull/50976 * src: avoid copy by using std::views::keys https://github.com/nodejs/node/pull/56080 * chore: fixup patch indices * fix: errant use of context->GetIsolate() * fix: tweak BoringSSL compat patch for new changes * fix: add back missing isolate dtor declaration * fixup! esm: fix module.exports export on CJS modules * cli: remove --no-experimental-fetch flag https://github.com/nodejs/node/pull/52611/files * esm: Source Phase Imports for WebAssembly https://github.com/nodejs/node/pull/56919 * fixup! src: prepare for v8 sandboxing * chore: bump @types/node to v24 * chore: fix const assignment in crypto test * fix: sandbox pointer patch issues * chore: rework source phase import patch * src: add percentage support to --max-old-space-size https://github.com/nodejs/node/pull/59082 * chore: fixup crypto tests * chore: HostImportModuleWithPhaseDynamically todo * fix: cjs esm failures * fix: v8::Object::Wrappable issues -b72a615754-490bac2496-4896a0dd69* chore: remove deleted specs * src: use v8::ExternalMemoryAccounter https://github.com/nodejs/node/pull/58070 * fs: port SonicBoom module to fs module as FastUtf8Stream https://github.com/nodejs/node/pull/58897 * chore: tweak sandboxed pr patch * test: disable parallel/test-os-checked-function * test: use WHATWG URL instead of url.parse * fix: OPENSSL_secure_zalloc doesn't work in BoringSSL * chore: fix accidental extra line * 7017517: [defer-import-eval] Parse import defer syntax https://chromium-review.googlesource.com/c/v8/v8/+/7017517
941 lines
45 KiB
Diff
941 lines
45 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: deepak1556 <hop2deep@gmail.com>
|
|
Date: Mon, 1 Sep 2025 03:13:53 +0900
|
|
Subject: Remove deprecated `GetIsolate`
|
|
|
|
https://chromium-review.googlesource.com/c/v8/v8/+/6905244
|
|
|
|
diff --git a/src/api/environment.cc b/src/api/environment.cc
|
|
index 072deb1fa70313e33397f6ff994e3f3548e86092..14be033113bfb13c64e5f99446afaf0cb2aa16a9 100644
|
|
--- a/src/api/environment.cc
|
|
+++ b/src/api/environment.cc
|
|
@@ -669,7 +669,7 @@ std::unique_ptr<MultiIsolatePlatform> MultiIsolatePlatform::Create(
|
|
|
|
MaybeLocal<Object> GetPerContextExports(Local<Context> context,
|
|
IsolateData* isolate_data) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
EscapableHandleScope handle_scope(isolate);
|
|
|
|
Local<Object> global = context->Global();
|
|
@@ -715,7 +715,7 @@ void ProtoThrower(const FunctionCallbackInfo<Value>& info) {
|
|
// This runs at runtime, regardless of whether the context
|
|
// is created from a snapshot.
|
|
Maybe<void> InitializeContextRuntime(Local<Context> context) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
HandleScope handle_scope(isolate);
|
|
|
|
// When `IsCodeGenerationFromStringsAllowed` is true, V8 takes the fast path
|
|
@@ -794,7 +794,7 @@ Maybe<void> InitializeContextRuntime(Local<Context> context) {
|
|
}
|
|
|
|
Maybe<void> InitializeBaseContextForSnapshot(Local<Context> context) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
HandleScope handle_scope(isolate);
|
|
|
|
// Delete `Intl.v8BreakIterator`
|
|
@@ -819,7 +819,7 @@ Maybe<void> InitializeBaseContextForSnapshot(Local<Context> context) {
|
|
}
|
|
|
|
Maybe<void> InitializeMainContextForSnapshot(Local<Context> context) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
HandleScope handle_scope(isolate);
|
|
|
|
// Initialize the default values.
|
|
@@ -837,7 +837,7 @@ Maybe<void> InitializeMainContextForSnapshot(Local<Context> context) {
|
|
MaybeLocal<Object> InitializePrivateSymbols(Local<Context> context,
|
|
IsolateData* isolate_data) {
|
|
CHECK(isolate_data);
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
EscapableHandleScope scope(isolate);
|
|
Context::Scope context_scope(context);
|
|
|
|
@@ -861,7 +861,7 @@ MaybeLocal<Object> InitializePrivateSymbols(Local<Context> context,
|
|
MaybeLocal<Object> InitializePerIsolateSymbols(Local<Context> context,
|
|
IsolateData* isolate_data) {
|
|
CHECK(isolate_data);
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
EscapableHandleScope scope(isolate);
|
|
Context::Scope context_scope(context);
|
|
|
|
@@ -887,7 +887,7 @@ MaybeLocal<Object> InitializePerIsolateSymbols(Local<Context> context,
|
|
Maybe<void> InitializePrimordials(Local<Context> context,
|
|
IsolateData* isolate_data) {
|
|
// Run per-context JS files.
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Context::Scope context_scope(context);
|
|
Local<Object> exports;
|
|
|
|
diff --git a/src/base_object-inl.h b/src/base_object-inl.h
|
|
index cc60ddddb037e0279615bbe24821eb20fd8da677..37d83e41b618a07aca98118260abe9618f11256d 100644
|
|
--- a/src/base_object-inl.h
|
|
+++ b/src/base_object-inl.h
|
|
@@ -55,7 +55,6 @@ v8::Local<v8::Object> BaseObject::object() const {
|
|
v8::Local<v8::Object> BaseObject::object(v8::Isolate* isolate) const {
|
|
v8::Local<v8::Object> handle = object();
|
|
|
|
- DCHECK_EQ(handle->GetCreationContextChecked()->GetIsolate(), isolate);
|
|
DCHECK_EQ(env()->isolate(), isolate);
|
|
|
|
return handle;
|
|
diff --git a/src/crypto/crypto_context.cc b/src/crypto/crypto_context.cc
|
|
index 20d3c1d9d17fde18fc09b6ee219137831eb08a45..8fbf4f25a91b953f3d2868889c7ee06932ee3c5f 100644
|
|
--- a/src/crypto/crypto_context.cc
|
|
+++ b/src/crypto/crypto_context.cc
|
|
@@ -1022,7 +1022,7 @@ bool ArrayOfStringsToX509s(Local<Context> context,
|
|
Local<Array> cert_array,
|
|
std::vector<X509*>* certs) {
|
|
ClearErrorOnReturn clear_error_on_return;
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Environment* env = Environment::GetCurrent(context);
|
|
uint32_t array_length = cert_array->Length();
|
|
|
|
diff --git a/src/crypto/crypto_x509.cc b/src/crypto/crypto_x509.cc
|
|
index 4c5427596d1c90d3a413cdd9ff4f1151e657073d..70135a6be65e41fcb3564ddf6d1e8083a59ef8bb 100644
|
|
--- a/src/crypto/crypto_x509.cc
|
|
+++ b/src/crypto/crypto_x509.cc
|
|
@@ -107,7 +107,7 @@ MaybeLocal<Value> ToV8Value(Local<Context> context, BIOPointer&& bio) {
|
|
return {};
|
|
BUF_MEM* mem = bio;
|
|
Local<Value> ret;
|
|
- if (!String::NewFromUtf8(context->GetIsolate(),
|
|
+ if (!String::NewFromUtf8(Isolate::GetCurrent(),
|
|
mem->data,
|
|
NewStringType::kNormal,
|
|
mem->length)
|
|
@@ -121,7 +121,7 @@ MaybeLocal<Value> ToV8Value(Local<Context> context, const BIOPointer& bio) {
|
|
return {};
|
|
BUF_MEM* mem = bio;
|
|
Local<Value> ret;
|
|
- if (!String::NewFromUtf8(context->GetIsolate(),
|
|
+ if (!String::NewFromUtf8(Isolate::GetCurrent(),
|
|
mem->data,
|
|
NewStringType::kNormal,
|
|
mem->length)
|
|
diff --git a/src/encoding_binding.cc b/src/encoding_binding.cc
|
|
index 266f640fb1c6503a424e77cc41fc15bc658bb6a5..877ae8a18f6b8f2c7e3474dfba060d99db88e6b9 100644
|
|
--- a/src/encoding_binding.cc
|
|
+++ b/src/encoding_binding.cc
|
|
@@ -76,7 +76,7 @@ void BindingData::Deserialize(Local<Context> context,
|
|
int index,
|
|
InternalFieldInfoBase* info) {
|
|
DCHECK_IS_SNAPSHOT_SLOT(index);
|
|
- HandleScope scope(context->GetIsolate());
|
|
+ HandleScope scope(Isolate::GetCurrent());
|
|
Realm* realm = Realm::GetCurrent(context);
|
|
// Recreate the buffer in the constructor.
|
|
InternalFieldInfo* casted_info = static_cast<InternalFieldInfo*>(info);
|
|
diff --git a/src/env.cc b/src/env.cc
|
|
index a78817467518245c4a190e870e0eb30658eafcdb..13dcf0e9c2c86486d1e43763033f43ac4e6b6feb 100644
|
|
--- a/src/env.cc
|
|
+++ b/src/env.cc
|
|
@@ -1753,10 +1753,10 @@ void AsyncHooks::Deserialize(Local<Context> context) {
|
|
context->GetDataFromSnapshotOnce<Array>(
|
|
info_->js_execution_async_resources).ToLocalChecked();
|
|
} else {
|
|
- js_execution_async_resources = Array::New(context->GetIsolate());
|
|
+ js_execution_async_resources = Array::New(Isolate::GetCurrent());
|
|
}
|
|
js_execution_async_resources_.Reset(
|
|
- context->GetIsolate(), js_execution_async_resources);
|
|
+ Isolate::GetCurrent(), js_execution_async_resources);
|
|
|
|
// The native_execution_async_resources_ field requires v8::Local<> instances
|
|
// for async calls whose resources were on the stack as JS objects when they
|
|
@@ -1796,7 +1796,7 @@ AsyncHooks::SerializeInfo AsyncHooks::Serialize(Local<Context> context,
|
|
info.async_id_fields = async_id_fields_.Serialize(context, creator);
|
|
if (!js_execution_async_resources_.IsEmpty()) {
|
|
info.js_execution_async_resources = creator->AddData(
|
|
- context, js_execution_async_resources_.Get(context->GetIsolate()));
|
|
+ context, js_execution_async_resources_.Get(Isolate::GetCurrent()));
|
|
CHECK_NE(info.js_execution_async_resources, 0);
|
|
} else {
|
|
info.js_execution_async_resources = 0;
|
|
diff --git a/src/inspector/network_agent.cc b/src/inspector/network_agent.cc
|
|
index d136b72e598d07f3c2fcc9c2c8ba84f5ff1aaad7..649008aafc8d68cfecb02c28ad1e26a9b749f7bd 100644
|
|
--- a/src/inspector/network_agent.cc
|
|
+++ b/src/inspector/network_agent.cc
|
|
@@ -29,31 +29,31 @@ using v8::Value;
|
|
Maybe<protocol::String> ObjectGetProtocolString(v8::Local<v8::Context> context,
|
|
Local<Object> object,
|
|
Local<v8::String> property) {
|
|
- HandleScope handle_scope(context->GetIsolate());
|
|
+ HandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
Local<Value> value;
|
|
if (!object->Get(context, property).ToLocal(&value) || !value->IsString()) {
|
|
return Nothing<protocol::String>();
|
|
}
|
|
Local<v8::String> str = value.As<v8::String>();
|
|
- return Just(ToProtocolString(context->GetIsolate(), str));
|
|
+ return Just(ToProtocolString(v8::Isolate::GetCurrent(), str));
|
|
}
|
|
|
|
// Get a protocol string property from the object.
|
|
Maybe<protocol::String> ObjectGetProtocolString(v8::Local<v8::Context> context,
|
|
Local<Object> object,
|
|
const char* property) {
|
|
- HandleScope handle_scope(context->GetIsolate());
|
|
+ HandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
return ObjectGetProtocolString(
|
|
- context, object, OneByteString(context->GetIsolate(), property));
|
|
+ context, object, OneByteString(v8::Isolate::GetCurrent(), property));
|
|
}
|
|
|
|
// Get a protocol double property from the object.
|
|
Maybe<double> ObjectGetDouble(v8::Local<v8::Context> context,
|
|
Local<Object> object,
|
|
const char* property) {
|
|
- HandleScope handle_scope(context->GetIsolate());
|
|
+ HandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
Local<Value> value;
|
|
- if (!object->Get(context, OneByteString(context->GetIsolate(), property))
|
|
+ if (!object->Get(context, OneByteString(v8::Isolate::GetCurrent(), property))
|
|
.ToLocal(&value) ||
|
|
!value->IsNumber()) {
|
|
return Nothing<double>();
|
|
@@ -65,9 +65,9 @@ Maybe<double> ObjectGetDouble(v8::Local<v8::Context> context,
|
|
Maybe<int> ObjectGetInt(v8::Local<v8::Context> context,
|
|
Local<Object> object,
|
|
const char* property) {
|
|
- HandleScope handle_scope(context->GetIsolate());
|
|
+ HandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
Local<Value> value;
|
|
- if (!object->Get(context, OneByteString(context->GetIsolate(), property))
|
|
+ if (!object->Get(context, OneByteString(v8::Isolate::GetCurrent(), property))
|
|
.ToLocal(&value) ||
|
|
!value->IsInt32()) {
|
|
return Nothing<int>();
|
|
@@ -79,9 +79,9 @@ Maybe<int> ObjectGetInt(v8::Local<v8::Context> context,
|
|
Maybe<bool> ObjectGetBool(v8::Local<v8::Context> context,
|
|
Local<Object> object,
|
|
const char* property) {
|
|
- HandleScope handle_scope(context->GetIsolate());
|
|
+ HandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
Local<Value> value;
|
|
- if (!object->Get(context, OneByteString(context->GetIsolate(), property))
|
|
+ if (!object->Get(context, OneByteString(v8::Isolate::GetCurrent(), property))
|
|
.ToLocal(&value) ||
|
|
!value->IsBoolean()) {
|
|
return Nothing<bool>();
|
|
@@ -93,9 +93,9 @@ Maybe<bool> ObjectGetBool(v8::Local<v8::Context> context,
|
|
MaybeLocal<v8::Object> ObjectGetObject(v8::Local<v8::Context> context,
|
|
Local<Object> object,
|
|
const char* property) {
|
|
- EscapableHandleScope handle_scope(context->GetIsolate());
|
|
+ EscapableHandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
Local<Value> value;
|
|
- if (!object->Get(context, OneByteString(context->GetIsolate(), property))
|
|
+ if (!object->Get(context, OneByteString(v8::Isolate::GetCurrent(), property))
|
|
.ToLocal(&value) ||
|
|
!value->IsObject()) {
|
|
return {};
|
|
@@ -106,7 +106,7 @@ MaybeLocal<v8::Object> ObjectGetObject(v8::Local<v8::Context> context,
|
|
// Create a protocol::Network::Headers from the v8 object.
|
|
std::unique_ptr<protocol::Network::Headers> createHeadersFromObject(
|
|
v8::Local<v8::Context> context, Local<Object> headers_obj) {
|
|
- HandleScope handle_scope(context->GetIsolate());
|
|
+ HandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
|
|
std::unique_ptr<protocol::DictionaryValue> dict =
|
|
protocol::DictionaryValue::create();
|
|
@@ -127,7 +127,7 @@ std::unique_ptr<protocol::Network::Headers> createHeadersFromObject(
|
|
.To(&property_value)) {
|
|
return {};
|
|
}
|
|
- dict->setString(ToProtocolString(context->GetIsolate(), property_name),
|
|
+ dict->setString(ToProtocolString(v8::Isolate::GetCurrent(), property_name),
|
|
property_value);
|
|
}
|
|
|
|
@@ -137,7 +137,7 @@ std::unique_ptr<protocol::Network::Headers> createHeadersFromObject(
|
|
// Create a protocol::Network::Request from the v8 object.
|
|
std::unique_ptr<protocol::Network::Request> createRequestFromObject(
|
|
v8::Local<v8::Context> context, Local<Object> request) {
|
|
- HandleScope handle_scope(context->GetIsolate());
|
|
+ HandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
protocol::String url;
|
|
if (!ObjectGetProtocolString(context, request, "url").To(&url)) {
|
|
return {};
|
|
@@ -169,7 +169,7 @@ std::unique_ptr<protocol::Network::Request> createRequestFromObject(
|
|
// Create a protocol::Network::Response from the v8 object.
|
|
std::unique_ptr<protocol::Network::Response> createResponseFromObject(
|
|
v8::Local<v8::Context> context, Local<Object> response) {
|
|
- HandleScope handle_scope(context->GetIsolate());
|
|
+ HandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
protocol::String url;
|
|
if (!ObjectGetProtocolString(context, response, "url").To(&url)) {
|
|
return {};
|
|
@@ -210,7 +210,7 @@ std::unique_ptr<protocol::Network::Response> createResponseFromObject(
|
|
|
|
std::unique_ptr<protocol::Network::WebSocketResponse> createWebSocketResponse(
|
|
v8::Local<v8::Context> context, Local<Object> response) {
|
|
- HandleScope handle_scope(context->GetIsolate());
|
|
+ HandleScope handle_scope(v8::Isolate::GetCurrent());
|
|
int status;
|
|
if (!ObjectGetInt(context, response, "status").To(&status)) {
|
|
return {};
|
|
diff --git a/src/js_native_api_v8.h b/src/js_native_api_v8.h
|
|
index 27aeac589b19cd681923fb848ce5f36c66fc05e2..5f2900869763f40cac54e3cb3fe2e24eda615410 100644
|
|
--- a/src/js_native_api_v8.h
|
|
+++ b/src/js_native_api_v8.h
|
|
@@ -53,7 +53,7 @@ class RefTracker {
|
|
struct napi_env__ {
|
|
explicit napi_env__(v8::Local<v8::Context> context,
|
|
int32_t module_api_version)
|
|
- : isolate(context->GetIsolate()),
|
|
+ : isolate(v8::Isolate::GetCurrent()),
|
|
context_persistent(isolate, context),
|
|
module_api_version(module_api_version) {
|
|
napi_clear_last_error(this);
|
|
diff --git a/src/module_wrap.cc b/src/module_wrap.cc
|
|
index 8fed194cbae9ce75bd0805b4df30b4de64fbbefa..a584e3a80adb69d2028dc79450349823ab973a58 100644
|
|
--- a/src/module_wrap.cc
|
|
+++ b/src/module_wrap.cc
|
|
@@ -99,7 +99,7 @@ ModuleCacheKey ModuleCacheKey::From(Local<Context> context,
|
|
Local<String> specifier,
|
|
Local<FixedArray> import_attributes) {
|
|
CHECK_EQ(import_attributes->Length() % elements_per_attribute, 0);
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
std::size_t h1 = specifier->GetIdentityHash();
|
|
size_t num_attributes = import_attributes->Length() / elements_per_attribute;
|
|
ImportAttributeVector attributes;
|
|
@@ -1022,7 +1022,7 @@ MaybeLocal<Module> ModuleWrap::ResolveModuleCallback(
|
|
return {};
|
|
}
|
|
DCHECK_NOT_NULL(resolved_module);
|
|
- return resolved_module->module_.Get(context->GetIsolate());
|
|
+ return resolved_module->module_.Get(Isolate::GetCurrent());
|
|
}
|
|
|
|
// static
|
|
@@ -1046,7 +1046,7 @@ MaybeLocal<Object> ModuleWrap::ResolveSourceCallback(
|
|
Local<String> url = resolved_module->object()
|
|
->GetInternalField(ModuleWrap::kURLSlot)
|
|
.As<String>();
|
|
- THROW_ERR_SOURCE_PHASE_NOT_DEFINED(context->GetIsolate(), url);
|
|
+ THROW_ERR_SOURCE_PHASE_NOT_DEFINED(Isolate::GetCurrent(), url);
|
|
return {};
|
|
}
|
|
CHECK(module_source_object->IsObject());
|
|
@@ -1059,7 +1059,7 @@ Maybe<ModuleWrap*> ModuleWrap::ResolveModule(
|
|
Local<String> specifier,
|
|
Local<FixedArray> import_attributes,
|
|
Local<Module> referrer) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Environment* env = Environment::GetCurrent(context);
|
|
if (env == nullptr) {
|
|
THROW_ERR_EXECUTION_ENVIRONMENT_NOT_AVAILABLE(isolate);
|
|
@@ -1104,7 +1104,7 @@ MaybeLocal<Promise> ImportModuleDynamicallyWithPhase(
|
|
Local<String> specifier,
|
|
ModuleImportPhase phase,
|
|
Local<FixedArray> import_attributes) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Environment* env = Environment::GetCurrent(context);
|
|
if (env == nullptr) {
|
|
THROW_ERR_EXECUTION_ENVIRONMENT_NOT_AVAILABLE(isolate);
|
|
@@ -1346,7 +1346,7 @@ MaybeLocal<Module> LinkRequireFacadeWithOriginal(
|
|
Local<FixedArray> import_attributes,
|
|
Local<Module> referrer) {
|
|
Environment* env = Environment::GetCurrent(context);
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
CHECK(specifier->Equals(context, env->original_string()).ToChecked());
|
|
CHECK(!env->temporary_required_module_facade_original.IsEmpty());
|
|
return env->temporary_required_module_facade_original.Get(isolate);
|
|
diff --git a/src/node.h b/src/node.h
|
|
index 7fae281a6e0f3c1a9f0eb97536883bb26c16d94d..fb37310f44c8d06d1ab2697ed64a0b539776a411 100644
|
|
--- a/src/node.h
|
|
+++ b/src/node.h
|
|
@@ -1064,7 +1064,7 @@ NODE_DEPRECATED("Use v8::Date::ValueOf() directly",
|
|
|
|
#define NODE_DEFINE_CONSTANT(target, constant) \
|
|
do { \
|
|
- v8::Isolate* isolate = target->GetIsolate(); \
|
|
+ v8::Isolate* isolate = v8::Isolate::GetCurrent(); \
|
|
v8::Local<v8::Context> context = isolate->GetCurrentContext(); \
|
|
v8::Local<v8::String> constant_name = v8::String::NewFromUtf8Literal( \
|
|
isolate, #constant, v8::NewStringType::kInternalized); \
|
|
@@ -1080,7 +1080,7 @@ NODE_DEPRECATED("Use v8::Date::ValueOf() directly",
|
|
|
|
#define NODE_DEFINE_HIDDEN_CONSTANT(target, constant) \
|
|
do { \
|
|
- v8::Isolate* isolate = target->GetIsolate(); \
|
|
+ v8::Isolate* isolate = v8::Isolate::GetCurrent(); \
|
|
v8::Local<v8::Context> context = isolate->GetCurrentContext(); \
|
|
v8::Local<v8::String> constant_name = v8::String::NewFromUtf8Literal( \
|
|
isolate, #constant, v8::NewStringType::kInternalized); \
|
|
diff --git a/src/node_blob.cc b/src/node_blob.cc
|
|
index d278a32c9934c15bc721da164efccca7bc7e7111..ab862bf93a411e6ae6da7c9f9706cee279a0ad70 100644
|
|
--- a/src/node_blob.cc
|
|
+++ b/src/node_blob.cc
|
|
@@ -554,7 +554,7 @@ void BlobBindingData::Deserialize(Local<Context> context,
|
|
int index,
|
|
InternalFieldInfoBase* info) {
|
|
DCHECK_IS_SNAPSHOT_SLOT(index);
|
|
- HandleScope scope(context->GetIsolate());
|
|
+ HandleScope scope(Isolate::GetCurrent());
|
|
Realm* realm = Realm::GetCurrent(context);
|
|
BlobBindingData* binding = realm->AddBindingData<BlobBindingData>(holder);
|
|
CHECK_NOT_NULL(binding);
|
|
diff --git a/src/node_builtins.cc b/src/node_builtins.cc
|
|
index e69eb280050cae0c0f394b2f956eef947e628904..9bb4576fcf4f07550e7d6f4ff2310cedc8093c5f 100644
|
|
--- a/src/node_builtins.cc
|
|
+++ b/src/node_builtins.cc
|
|
@@ -274,7 +274,7 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
|
|
const char* id,
|
|
LocalVector<String>* parameters,
|
|
Realm* optional_realm) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
EscapableHandleScope scope(isolate);
|
|
|
|
Local<String> source;
|
|
@@ -396,7 +396,7 @@ void BuiltinLoader::SaveCodeCache(const char* id, Local<Function> fun) {
|
|
MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context,
|
|
const char* id,
|
|
Realm* optional_realm) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
LocalVector<String> parameters(isolate);
|
|
// Detects parameters of the scripts based on module ids.
|
|
// internal/bootstrap/realm: process, getLinkedBinding,
|
|
@@ -450,7 +450,7 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context,
|
|
MaybeLocal<Value> BuiltinLoader::CompileAndCall(Local<Context> context,
|
|
const char* id,
|
|
Realm* realm) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
// Detects parameters of the scripts based on module ids.
|
|
// internal/bootstrap/realm: process, getLinkedBinding,
|
|
// getInternalBinding, primordials
|
|
@@ -506,7 +506,7 @@ MaybeLocal<Value> BuiltinLoader::CompileAndCall(Local<Context> context,
|
|
if (!maybe_fn.ToLocal(&fn)) {
|
|
return MaybeLocal<Value>();
|
|
}
|
|
- Local<Value> undefined = Undefined(context->GetIsolate());
|
|
+ Local<Value> undefined = Undefined(Isolate::GetCurrent());
|
|
return fn->Call(context, undefined, argc, argv);
|
|
}
|
|
|
|
@@ -544,14 +544,14 @@ bool BuiltinLoader::CompileAllBuiltinsAndCopyCodeCache(
|
|
to_eager_compile_.emplace(id);
|
|
}
|
|
|
|
- TryCatch bootstrapCatch(context->GetIsolate());
|
|
+ TryCatch bootstrapCatch(Isolate::GetCurrent());
|
|
auto fn = LookupAndCompile(context, id.data(), nullptr);
|
|
if (bootstrapCatch.HasCaught()) {
|
|
per_process::Debug(DebugCategory::CODE_CACHE,
|
|
"Failed to compile code cache for %s\n",
|
|
id.data());
|
|
all_succeeded = false;
|
|
- PrintCaughtException(context->GetIsolate(), context, bootstrapCatch);
|
|
+ PrintCaughtException(Isolate::GetCurrent(), context, bootstrapCatch);
|
|
} else {
|
|
// This is used by the snapshot builder, so save the code cache
|
|
// unconditionally.
|
|
diff --git a/src/node_constants.cc b/src/node_constants.cc
|
|
index fea0426496978c0003fe1481afcf93fc9c23edca..c9588880d05435ab9f4e23fcff74c93309664270 100644
|
|
--- a/src/node_constants.cc
|
|
+++ b/src/node_constants.cc
|
|
@@ -1265,7 +1265,7 @@ void CreatePerContextProperties(Local<Object> target,
|
|
Local<Value> unused,
|
|
Local<Context> context,
|
|
void* priv) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Environment* env = Environment::GetCurrent(context);
|
|
|
|
CHECK(
|
|
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
|
|
index 3c234205e89be7e976dae5c3fcc73ca67953e034..e66d4fcb0c064f96cdb819c783027d864fe88d12 100644
|
|
--- a/src/node_contextify.cc
|
|
+++ b/src/node_contextify.cc
|
|
@@ -113,7 +113,7 @@ namespace {
|
|
|
|
// Convert an int to a V8 Name (String or Symbol).
|
|
MaybeLocal<String> Uint32ToName(Local<Context> context, uint32_t index) {
|
|
- return Uint32::New(context->GetIsolate(), index)->ToString(context);
|
|
+ return Uint32::New(Isolate::GetCurrent(), index)->ToString(context);
|
|
}
|
|
|
|
} // anonymous namespace
|
|
@@ -677,7 +677,7 @@ Intercepted ContextifyContext::PropertyDefinerCallback(
|
|
}
|
|
|
|
Local<Context> context = ctx->context();
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
|
|
PropertyAttribute attributes = PropertyAttribute::None;
|
|
bool is_declared =
|
|
@@ -1666,7 +1666,7 @@ static MaybeLocal<Function> CompileFunctionForCJSLoader(
|
|
bool* cache_rejected,
|
|
bool is_cjs_scope,
|
|
ScriptCompiler::CachedData* cached_data) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
EscapableHandleScope scope(isolate);
|
|
|
|
Local<Symbol> symbol = env->vm_dynamic_import_default_internal();
|
|
diff --git a/src/node_env_var.cc b/src/node_env_var.cc
|
|
index 6aad252eb5681bb9ab9890812602b43c418e7a7f..5f7ef8cc58f589ba30a44abaaaaaf1514458c3f0 100644
|
|
--- a/src/node_env_var.cc
|
|
+++ b/src/node_env_var.cc
|
|
@@ -311,7 +311,7 @@ std::shared_ptr<KVStore> KVStore::CreateMapKVStore() {
|
|
|
|
Maybe<void> KVStore::AssignFromObject(Local<Context> context,
|
|
Local<Object> entries) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
HandleScope handle_scope(isolate);
|
|
Local<Array> keys;
|
|
if (!entries->GetOwnPropertyNames(context).ToLocal(&keys))
|
|
diff --git a/src/node_errors.cc b/src/node_errors.cc
|
|
index 4386a1bc5678e351ce084cd2c47202561619b164..8d51201ad24999ed8f54e16c7878432d41841cf2 100644
|
|
--- a/src/node_errors.cc
|
|
+++ b/src/node_errors.cc
|
|
@@ -633,7 +633,7 @@ v8::ModifyCodeGenerationFromStringsResult ModifyCodeGenerationFromStrings(
|
|
v8::Local<v8::Context> context,
|
|
v8::Local<v8::Value> source,
|
|
bool is_code_like) {
|
|
- HandleScope scope(context->GetIsolate());
|
|
+ HandleScope scope(Isolate::GetCurrent());
|
|
|
|
if (context->GetNumberOfEmbedderDataFields() <=
|
|
ContextEmbedderIndex::kAllowCodeGenerationFromStrings) {
|
|
@@ -1000,7 +1000,7 @@ const char* errno_string(int errorno) {
|
|
}
|
|
|
|
void PerIsolateMessageListener(Local<Message> message, Local<Value> error) {
|
|
- Isolate* isolate = message->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
switch (message->ErrorLevel()) {
|
|
case Isolate::MessageErrorLevel::kMessageWarning: {
|
|
Environment* env = Environment::GetCurrent(isolate);
|
|
@@ -1161,7 +1161,7 @@ void Initialize(Local<Object> target,
|
|
SetMethod(
|
|
context, target, "getErrorSourcePositions", GetErrorSourcePositions);
|
|
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Local<Object> exit_codes = Object::New(isolate);
|
|
READONLY_PROPERTY(target, "exitCodes", exit_codes);
|
|
|
|
diff --git a/src/node_file.cc b/src/node_file.cc
|
|
index d73dac2ee3f1cf1cac6845fae0f702c9fba8fcef..969e7d08086f8442bed476feaf15599b8c79db7c 100644
|
|
--- a/src/node_file.cc
|
|
+++ b/src/node_file.cc
|
|
@@ -3874,7 +3874,7 @@ void BindingData::Deserialize(Local<Context> context,
|
|
int index,
|
|
InternalFieldInfoBase* info) {
|
|
DCHECK_IS_SNAPSHOT_SLOT(index);
|
|
- HandleScope scope(context->GetIsolate());
|
|
+ HandleScope scope(Isolate::GetCurrent());
|
|
Realm* realm = Realm::GetCurrent(context);
|
|
InternalFieldInfo* casted_info = static_cast<InternalFieldInfo*>(info);
|
|
BindingData* binding =
|
|
diff --git a/src/node_messaging.cc b/src/node_messaging.cc
|
|
index 57e068ae249d618c2658638f9f3b03e1fedb6524..8c51ae4e0a435971c6d0288af87810877dd31a49 100644
|
|
--- a/src/node_messaging.cc
|
|
+++ b/src/node_messaging.cc
|
|
@@ -254,7 +254,7 @@ namespace {
|
|
|
|
MaybeLocal<Function> GetEmitMessageFunction(Local<Context> context,
|
|
IsolateData* isolate_data) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Local<Object> per_context_bindings;
|
|
Local<Value> emit_message_val;
|
|
if (!GetPerContextExports(context, isolate_data)
|
|
@@ -269,7 +269,7 @@ MaybeLocal<Function> GetEmitMessageFunction(Local<Context> context,
|
|
}
|
|
|
|
MaybeLocal<Function> GetDOMException(Local<Context> context) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Local<Object> per_context_bindings;
|
|
Local<Value> domexception_ctor_val;
|
|
if (!GetPerContextExports(context).ToLocal(&per_context_bindings) ||
|
|
@@ -284,7 +284,7 @@ MaybeLocal<Function> GetDOMException(Local<Context> context) {
|
|
}
|
|
|
|
void ThrowDataCloneException(Local<Context> context, Local<String> message) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Local<Value> argv[] = {message,
|
|
FIXED_ONE_BYTE_STRING(isolate, "DataCloneError")};
|
|
Local<Value> exception;
|
|
@@ -1477,7 +1477,7 @@ BaseObjectPtr<BaseObject> JSTransferable::Data::Deserialize(
|
|
|
|
Maybe<bool> JSTransferable::Data::FinalizeTransferWrite(
|
|
Local<Context> context, ValueSerializer* serializer) {
|
|
- HandleScope handle_scope(context->GetIsolate());
|
|
+ HandleScope handle_scope(Isolate::GetCurrent());
|
|
auto ret = serializer->WriteValue(context, PersistentToLocal::Strong(data_));
|
|
data_.Reset();
|
|
return ret;
|
|
diff --git a/src/node_modules.cc b/src/node_modules.cc
|
|
index bdbc511ef3f680bbac6770b89f47acaee95d56a2..d8477191efafba3c41c06d765f4b03bd00b8573c 100644
|
|
--- a/src/node_modules.cc
|
|
+++ b/src/node_modules.cc
|
|
@@ -69,7 +69,7 @@ void BindingData::Deserialize(v8::Local<v8::Context> context,
|
|
int index,
|
|
InternalFieldInfoBase* info) {
|
|
DCHECK_IS_SNAPSHOT_SLOT(index);
|
|
- HandleScope scope(context->GetIsolate());
|
|
+ HandleScope scope(Isolate::GetCurrent());
|
|
Realm* realm = Realm::GetCurrent(context);
|
|
BindingData* binding = realm->AddBindingData<BindingData>(holder);
|
|
CHECK_NOT_NULL(binding);
|
|
@@ -735,7 +735,7 @@ void BindingData::CreatePerContextProperties(Local<Object> target,
|
|
Realm* realm = Realm::GetCurrent(context);
|
|
realm->AddBindingData<BindingData>(target);
|
|
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
LocalVector<Value> compile_cache_status_values(isolate);
|
|
|
|
#define V(status) \
|
|
diff --git a/src/node_process_methods.cc b/src/node_process_methods.cc
|
|
index e453bacc3e5247493a3582c24174bfe6e590825d..fe4aad63bc877be105830a80aa6be10ce3f8fda4 100644
|
|
--- a/src/node_process_methods.cc
|
|
+++ b/src/node_process_methods.cc
|
|
@@ -737,7 +737,7 @@ void BindingData::Deserialize(Local<Context> context,
|
|
int index,
|
|
InternalFieldInfoBase* info) {
|
|
DCHECK_IS_SNAPSHOT_SLOT(index);
|
|
- v8::HandleScope scope(context->GetIsolate());
|
|
+ v8::HandleScope scope(Isolate::GetCurrent());
|
|
Realm* realm = Realm::GetCurrent(context);
|
|
// Recreate the buffer in the constructor.
|
|
InternalFieldInfo* casted_info = static_cast<InternalFieldInfo*>(info);
|
|
diff --git a/src/node_realm.cc b/src/node_realm.cc
|
|
index 2a5fe9fe501d1fd9356eeb7d044a872fa5a55f38..39f6f142044c42904d234da20a266315346c135a 100644
|
|
--- a/src/node_realm.cc
|
|
+++ b/src/node_realm.cc
|
|
@@ -22,7 +22,7 @@ using v8::String;
|
|
using v8::Value;
|
|
|
|
Realm::Realm(Environment* env, v8::Local<v8::Context> context, Kind kind)
|
|
- : env_(env), isolate_(context->GetIsolate()), kind_(kind) {
|
|
+ : env_(env), isolate_(v8::Isolate::GetCurrent()), kind_(kind) {
|
|
context_.Reset(isolate_, context);
|
|
env->AssignToContext(context, this, ContextInfo(""));
|
|
// The environment can also purge empty wrappers in the check callback,
|
|
diff --git a/src/node_report.cc b/src/node_report.cc
|
|
index c82c6bcc083ba60137e83b3c291130636db3162f..0d06f61d7fb2472a3d7a66854040dc493406b79e 100644
|
|
--- a/src/node_report.cc
|
|
+++ b/src/node_report.cc
|
|
@@ -400,7 +400,7 @@ static void PrintJavaScriptErrorProperties(JSONWriter* writer,
|
|
if (!error.IsEmpty() && error->IsObject()) {
|
|
TryCatch try_catch(isolate);
|
|
Local<Object> error_obj = error.As<Object>();
|
|
- Local<Context> context = error_obj->GetIsolate()->GetCurrentContext();
|
|
+ Local<Context> context = Isolate::GetCurrent()->GetCurrentContext();
|
|
Local<Array> keys;
|
|
if (!error_obj->GetOwnPropertyNames(context).ToLocal(&keys)) {
|
|
return writer->json_objectend(); // the end of 'errorProperties'
|
|
diff --git a/src/node_snapshotable.cc b/src/node_snapshotable.cc
|
|
index c2e24b4645e7903e08c80aead1c18c7bcff1bd89..e34d24d51d5c090b560d06f727043f20924e6f46 100644
|
|
--- a/src/node_snapshotable.cc
|
|
+++ b/src/node_snapshotable.cc
|
|
@@ -1614,7 +1614,7 @@ void BindingData::Deserialize(Local<Context> context,
|
|
int index,
|
|
InternalFieldInfoBase* info) {
|
|
DCHECK_IS_SNAPSHOT_SLOT(index);
|
|
- v8::HandleScope scope(context->GetIsolate());
|
|
+ v8::HandleScope scope(Isolate::GetCurrent());
|
|
Realm* realm = Realm::GetCurrent(context);
|
|
// Recreate the buffer in the constructor.
|
|
InternalFieldInfo* casted_info = static_cast<InternalFieldInfo*>(info);
|
|
diff --git a/src/node_sqlite.cc b/src/node_sqlite.cc
|
|
index 7bb4d4108c8326d69da5236c7ea7f00ddb68cea9..cf9ce6686cffca7e700a0e20cb9f776a5f0f7c4a 100644
|
|
--- a/src/node_sqlite.cc
|
|
+++ b/src/node_sqlite.cc
|
|
@@ -2020,7 +2020,7 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
|
|
|
|
if (args[0]->IsObject() && !args[0]->IsArrayBufferView()) {
|
|
Local<Object> obj = args[0].As<Object>();
|
|
- Local<Context> context = obj->GetIsolate()->GetCurrentContext();
|
|
+ Local<Context> context = Isolate::GetCurrent()->GetCurrentContext();
|
|
Local<Array> keys;
|
|
if (!obj->GetOwnPropertyNames(context).ToLocal(&keys)) {
|
|
return false;
|
|
diff --git a/src/node_task_queue.cc b/src/node_task_queue.cc
|
|
index d33ee3c26c111e53edf27e6368ca8f64ff30a349..f1c53c44f201b295888e7932c5e3e2b19cb9c319 100644
|
|
--- a/src/node_task_queue.cc
|
|
+++ b/src/node_task_queue.cc
|
|
@@ -48,7 +48,7 @@ void PromiseRejectCallback(PromiseRejectMessage message) {
|
|
static std::atomic<uint64_t> rejectionsHandledAfter{0};
|
|
|
|
Local<Promise> promise = message.GetPromise();
|
|
- Isolate* isolate = promise->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
PromiseRejectEvent event = message.GetEvent();
|
|
|
|
Environment* env = Environment::GetCurrent(isolate);
|
|
diff --git a/src/node_url.cc b/src/node_url.cc
|
|
index 9d1e8ec05161570db11f7b662395509774668d78..9b91f83d879ea02fd3d61913c8dfd35b3bf1ac31 100644
|
|
--- a/src/node_url.cc
|
|
+++ b/src/node_url.cc
|
|
@@ -70,7 +70,7 @@ void BindingData::Deserialize(Local<Context> context,
|
|
int index,
|
|
InternalFieldInfoBase* info) {
|
|
DCHECK_IS_SNAPSHOT_SLOT(index);
|
|
- HandleScope scope(context->GetIsolate());
|
|
+ HandleScope scope(Isolate::GetCurrent());
|
|
Realm* realm = Realm::GetCurrent(context);
|
|
BindingData* binding = realm->AddBindingData<BindingData>(holder);
|
|
CHECK_NOT_NULL(binding);
|
|
diff --git a/src/node_v8.cc b/src/node_v8.cc
|
|
index 98e392f6d7118bee8a3d0bce4de1ded76a293001..152b030198c6b36efd2be6c06f5c6e8bbc7cfadb 100644
|
|
--- a/src/node_v8.cc
|
|
+++ b/src/node_v8.cc
|
|
@@ -158,7 +158,7 @@ void BindingData::Deserialize(Local<Context> context,
|
|
int index,
|
|
InternalFieldInfoBase* info) {
|
|
DCHECK_IS_SNAPSHOT_SLOT(index);
|
|
- HandleScope scope(context->GetIsolate());
|
|
+ HandleScope scope(Isolate::GetCurrent());
|
|
Realm* realm = Realm::GetCurrent(context);
|
|
// Recreate the buffer in the constructor.
|
|
InternalFieldInfo* casted_info = static_cast<InternalFieldInfo*>(info);
|
|
diff --git a/src/node_wasi.cc b/src/node_wasi.cc
|
|
index 370221d3cddc201180260ecb3a222bc831c91093..f5aff2f65fe6b9f48cf970ab3e7c57cfe4885f85 100644
|
|
--- a/src/node_wasi.cc
|
|
+++ b/src/node_wasi.cc
|
|
@@ -50,7 +50,7 @@ using v8::WasmMemoryObject;
|
|
static MaybeLocal<Value> WASIException(Local<Context> context,
|
|
int errorno,
|
|
const char* syscall) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Environment* env = Environment::GetCurrent(context);
|
|
CHECK_NOT_NULL(env);
|
|
const char* err_name = uvwasi_embedder_err_code_to_string(errorno);
|
|
@@ -275,8 +275,8 @@ R WASI::WasiFunction<FT, F, R, Args...>::FastCallback(
|
|
return EinvalError<R>();
|
|
}
|
|
|
|
- Isolate* isolate = receiver->GetIsolate();
|
|
- HandleScope scope(isolate);
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
+ HandleScope handle_scope(isolate);
|
|
if (wasi->memory_.IsEmpty()) {
|
|
THROW_ERR_WASI_NOT_STARTED(isolate);
|
|
return EinvalError<R>();
|
|
diff --git a/src/node_webstorage.cc b/src/node_webstorage.cc
|
|
index cc90af827a3fbd14fb4cbfbfd39cc661f22cf6e1..5819d9bca845e0eed6d4d93564469d8f3c36200b 100644
|
|
--- a/src/node_webstorage.cc
|
|
+++ b/src/node_webstorage.cc
|
|
@@ -57,7 +57,7 @@ using v8::Value;
|
|
} while (0)
|
|
|
|
static void ThrowQuotaExceededException(Local<Context> context) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
auto dom_exception_str = FIXED_ONE_BYTE_STRING(isolate, "DOMException");
|
|
auto err_name = FIXED_ONE_BYTE_STRING(isolate, "QuotaExceededError");
|
|
auto err_message =
|
|
@@ -433,7 +433,7 @@ Maybe<void> Storage::Store(Local<Name> key, Local<Value> value) {
|
|
}
|
|
|
|
static MaybeLocal<String> Uint32ToName(Local<Context> context, uint32_t index) {
|
|
- return Uint32::New(context->GetIsolate(), index)->ToString(context);
|
|
+ return Uint32::New(Isolate::GetCurrent(), index)->ToString(context);
|
|
}
|
|
|
|
static void Clear(const FunctionCallbackInfo<Value>& info) {
|
|
diff --git a/src/node_worker.cc b/src/node_worker.cc
|
|
index 62c53368d1173edb7eb42e3337049c46fd7cdda9..7d08d8af7f6d99f7bd41cb7eb91063c630b3f87b 100644
|
|
--- a/src/node_worker.cc
|
|
+++ b/src/node_worker.cc
|
|
@@ -1466,8 +1466,6 @@ void GetEnvMessagePort(const FunctionCallbackInfo<Value>& args) {
|
|
Local<Object> port = env->message_port();
|
|
CHECK_IMPLIES(!env->is_main_thread(), !port.IsEmpty());
|
|
if (!port.IsEmpty()) {
|
|
- CHECK_EQ(port->GetCreationContextChecked()->GetIsolate(),
|
|
- args.GetIsolate());
|
|
args.GetReturnValue().Set(port);
|
|
}
|
|
}
|
|
diff --git a/src/timers.cc b/src/timers.cc
|
|
index da4206187f7c7d2becb8a101c1ff5346a10e13f4..03f0910926f3d403121e227cee32a546b2394e04 100644
|
|
--- a/src/timers.cc
|
|
+++ b/src/timers.cc
|
|
@@ -114,7 +114,7 @@ void BindingData::Deserialize(Local<Context> context,
|
|
int index,
|
|
InternalFieldInfoBase* info) {
|
|
DCHECK_IS_SNAPSHOT_SLOT(index);
|
|
- v8::HandleScope scope(context->GetIsolate());
|
|
+ v8::HandleScope scope(Isolate::GetCurrent());
|
|
Realm* realm = Realm::GetCurrent(context);
|
|
// Recreate the buffer in the constructor.
|
|
BindingData* binding = realm->AddBindingData<BindingData>(holder);
|
|
diff --git a/src/util-inl.h b/src/util-inl.h
|
|
index 9d4db311024c5f526fc3c00764fff686af044026..da9268dcf2ff432ddeec7c0f61a147b73f3130e2 100644
|
|
--- a/src/util-inl.h
|
|
+++ b/src/util-inl.h
|
|
@@ -336,14 +336,14 @@ v8::Maybe<void> FromV8Array(v8::Local<v8::Context> context,
|
|
std::vector<v8::Global<v8::Value>>* out) {
|
|
uint32_t count = js_array->Length();
|
|
out->reserve(count);
|
|
- ArrayIterationData data{out, context->GetIsolate()};
|
|
+ ArrayIterationData data{out, v8::Isolate::GetCurrent()};
|
|
return js_array->Iterate(context, PushItemToVector, &data);
|
|
}
|
|
|
|
v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context,
|
|
std::string_view str,
|
|
v8::Isolate* isolate) {
|
|
- if (isolate == nullptr) isolate = context->GetIsolate();
|
|
+ if (isolate == nullptr) isolate = v8::Isolate::GetCurrent();
|
|
if (str.size() >= static_cast<size_t>(v8::String::kMaxLength)) [[unlikely]] {
|
|
// V8 only has a TODO comment about adding an exception when the maximum
|
|
// string size is exceeded.
|
|
@@ -359,7 +359,7 @@ v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context,
|
|
v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context,
|
|
v8_inspector::StringView str,
|
|
v8::Isolate* isolate) {
|
|
- if (isolate == nullptr) isolate = context->GetIsolate();
|
|
+ if (isolate == nullptr) isolate = v8::Isolate::GetCurrent();
|
|
if (str.length() >= static_cast<size_t>(v8::String::kMaxLength))
|
|
[[unlikely]] {
|
|
// V8 only has a TODO comment about adding an exception when the maximum
|
|
@@ -386,7 +386,7 @@ template <typename T>
|
|
v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context,
|
|
const std::vector<T>& vec,
|
|
v8::Isolate* isolate) {
|
|
- if (isolate == nullptr) isolate = context->GetIsolate();
|
|
+ if (isolate == nullptr) isolate = v8::Isolate::GetCurrent();
|
|
v8::EscapableHandleScope handle_scope(isolate);
|
|
|
|
MaybeStackBuffer<v8::Local<v8::Value>, 128> arr(vec.size());
|
|
@@ -403,7 +403,7 @@ template <typename T>
|
|
v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context,
|
|
const std::set<T>& set,
|
|
v8::Isolate* isolate) {
|
|
- if (isolate == nullptr) isolate = context->GetIsolate();
|
|
+ if (isolate == nullptr) isolate = v8::Isolate::GetCurrent();
|
|
v8::Local<v8::Set> set_js = v8::Set::New(isolate);
|
|
v8::HandleScope handle_scope(isolate);
|
|
|
|
@@ -422,7 +422,7 @@ template <typename T, std::size_t U>
|
|
v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context,
|
|
const std::ranges::elements_view<T, U>& vec,
|
|
v8::Isolate* isolate) {
|
|
- if (isolate == nullptr) isolate = context->GetIsolate();
|
|
+ if (isolate == nullptr) isolate = v8::Isolate::GetCurrent();
|
|
v8::EscapableHandleScope handle_scope(isolate);
|
|
|
|
MaybeStackBuffer<v8::Local<v8::Value>, 128> arr(vec.size());
|
|
@@ -441,7 +441,7 @@ template <typename T, typename U>
|
|
v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context,
|
|
const std::unordered_map<T, U>& map,
|
|
v8::Isolate* isolate) {
|
|
- if (isolate == nullptr) isolate = context->GetIsolate();
|
|
+ if (isolate == nullptr) isolate = v8::Isolate::GetCurrent();
|
|
v8::EscapableHandleScope handle_scope(isolate);
|
|
|
|
v8::Local<v8::Map> ret = v8::Map::New(isolate);
|
|
@@ -484,7 +484,7 @@ template <typename T, typename>
|
|
v8::MaybeLocal<v8::Value> ToV8Value(v8::Local<v8::Context> context,
|
|
const T& number,
|
|
v8::Isolate* isolate) {
|
|
- if (isolate == nullptr) isolate = context->GetIsolate();
|
|
+ if (isolate == nullptr) isolate = v8::Isolate::GetCurrent();
|
|
return ConvertNumberToV8Value(isolate, number);
|
|
}
|
|
|
|
@@ -497,7 +497,7 @@ v8::Local<v8::Array> ToV8ValuePrimitiveArray(v8::Local<v8::Context> context,
|
|
std::is_floating_point_v<T>,
|
|
"Only primitive types (bool, integral, floating-point) are supported.");
|
|
|
|
- if (isolate == nullptr) isolate = context->GetIsolate();
|
|
+ if (isolate == nullptr) isolate = v8::Isolate::GetCurrent();
|
|
v8::EscapableHandleScope handle_scope(isolate);
|
|
|
|
v8::LocalVector<v8::Value> elements(isolate);
|
|
@@ -731,7 +731,7 @@ inline v8::MaybeLocal<v8::Object> NewDictionaryInstanceNullProto(
|
|
if (value.IsEmpty()) return v8::MaybeLocal<v8::Object>();
|
|
}
|
|
v8::Local<v8::Object> obj = tmpl->NewInstance(context, property_values);
|
|
- if (obj->SetPrototypeV2(context, v8::Null(context->GetIsolate()))
|
|
+ if (obj->SetPrototypeV2(context, v8::Null(v8::Isolate::GetCurrent()))
|
|
.IsNothing()) {
|
|
return v8::MaybeLocal<v8::Object>();
|
|
}
|
|
diff --git a/src/util.cc b/src/util.cc
|
|
index 660cfff6b8a0c583be843e555e7a06cd09e0d279..c4b39450c5b7f91c46f7027db367c30db34927bb 100644
|
|
--- a/src/util.cc
|
|
+++ b/src/util.cc
|
|
@@ -391,7 +391,7 @@ void SetMethod(Local<v8::Context> context,
|
|
Local<v8::Object> that,
|
|
const std::string_view name,
|
|
v8::FunctionCallback callback) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Local<v8::Function> function =
|
|
NewFunctionTemplate(isolate,
|
|
callback,
|
|
@@ -452,7 +452,7 @@ void SetFastMethod(Local<v8::Context> context,
|
|
const std::string_view name,
|
|
v8::FunctionCallback slow_callback,
|
|
const v8::CFunction* c_function) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Local<v8::Function> function =
|
|
NewFunctionTemplate(isolate,
|
|
slow_callback,
|
|
@@ -474,7 +474,7 @@ void SetFastMethodNoSideEffect(Local<v8::Context> context,
|
|
const std::string_view name,
|
|
v8::FunctionCallback slow_callback,
|
|
const v8::CFunction* c_function) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Local<v8::Function> function =
|
|
NewFunctionTemplate(isolate,
|
|
slow_callback,
|
|
@@ -562,7 +562,7 @@ void SetMethodNoSideEffect(Local<v8::Context> context,
|
|
Local<v8::Object> that,
|
|
const std::string_view name,
|
|
v8::FunctionCallback callback) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
Local<v8::Function> function =
|
|
NewFunctionTemplate(isolate,
|
|
callback,
|
|
@@ -689,7 +689,7 @@ void SetConstructorFunction(Local<v8::Context> context,
|
|
const char* name,
|
|
Local<v8::FunctionTemplate> tmpl,
|
|
SetConstructorFunctionFlag flag) {
|
|
- Isolate* isolate = context->GetIsolate();
|
|
+ Isolate* isolate = Isolate::GetCurrent();
|
|
SetConstructorFunction(
|
|
context, that, OneByteString(isolate, name), tmpl, flag);
|
|
}
|
|
diff --git a/src/util.h b/src/util.h
|
|
index 2b351235cf7f32c9fad25367cc912d187466f1e0..6da57f95165bbdedb65dab6eaae8c39b815ee4e5 100644
|
|
--- a/src/util.h
|
|
+++ b/src/util.h
|
|
@@ -739,7 +739,7 @@ inline v8::MaybeLocal<v8::Value> ToV8Value(
|
|
// Variation on NODE_DEFINE_CONSTANT that sets a String value.
|
|
#define NODE_DEFINE_STRING_CONSTANT(target, name, constant) \
|
|
do { \
|
|
- v8::Isolate* isolate = target->GetIsolate(); \
|
|
+ v8::Isolate* isolate = v8::Isolate::GetCurrent(); \
|
|
v8::Local<v8::String> constant_name = \
|
|
v8::String::NewFromUtf8(isolate, name).ToLocalChecked(); \
|
|
v8::Local<v8::String> constant_value = \
|