trop[bot] 35aea3afcc fix: reset printToPDF queue after a rejection (#51221) ...

fix: reset printToPDF queue after a rejection

The module-scoped `pendingPromise` in `webContents.printToPDF` was chained
with `.then(onFulfilled)` and never cleared. Once a call rejected (e.g.
an out-of-range `pageRanges` like `"999"`), subsequent calls chained onto
the rejected promise and short-circuited without ever invoking
`_printToPDF` — so every following call re-surfaced the original error.

Replace the shared variable with a per-`WebContents` `WeakMap` queue that
swallows prior rejections before chaining and clears its entry once the
tail drains.

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

2026-04-22 12:32:47 +02:00

..

fixtures

test: add Linux-specific test for app.getApplicationNameForProtocol() (#51215)

2026-04-21 16:42:34 -05:00

lib

build: fix code-signing for MacOS x64 tests (#50073)

2026-03-05 10:12:33 -06:00

ts-smoke

chore: bump chromium to 141.0.7361.0 (main) (#48054)

2025-08-29 12:31:47 +09:00

.eslintrc.json

build: drop eslint-plugin-unicorn (#47676)

2025-07-08 15:20:56 +02:00

.gitignore

feat: add error event for utility process (#43774)

2024-09-27 10:17:06 +09:00

ambient.d.ts

chore: bump chromium to 144.0.7527.0 (main) (#48959)

2025-11-24 12:30:57 -05:00

api-app-spec.ts

test: add Linux-specific test for app.getApplicationNameForProtocol() (#51215)

2026-04-21 16:42:34 -05:00

api-auto-updater-spec.ts

build: fix code-signing for MacOS x64 tests (#50073)

2026-03-05 10:12:33 -06:00

api-autoupdater-darwin-spec.ts

test: fixup autoupdater tests failures (#51059)

2026-04-15 11:00:07 +02:00

api-autoupdater-msix-spec.ts

feat: msix auto-updater (#49586)

2026-02-02 14:21:40 +01:00

api-browser-view-spec.ts

fix: BrowserWindow add the same BrowserView (#48053)

2025-08-28 10:31:41 +02:00

api-browser-window-spec.ts

fix: intermittent CI failure is-not-alwaysOnTop (#51135)

2026-04-20 15:25:00 -07:00

api-clipboard-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

api-content-tracing-spec.ts

fix: include missing metadata in trace files (#51021)

2026-04-13 17:09:46 -04:00

api-context-bridge-spec.ts

refactor: attach translator holder via v8::Function data slot (#51120)

2026-04-17 16:49:56 -05:00

api-corner-smoothing-spec.ts

fix: corner smoothing feature gate crash (#47759)

2025-07-16 08:39:17 -07:00

api-crash-reporter-spec.ts

fix: restore std::deque for dynamic crash key storage (#50837)

2026-04-10 10:18:48 +02:00

api-debugger-spec.ts

test: run script to help target discovery and reduce flakes (#44741)

2024-11-20 08:55:09 -06:00

api-desktop-capturer-spec.ts

test: add desktopCapturer icon validation (#50821)

2026-04-15 11:36:07 +02:00

api-dialog-spec.ts

test: add interactive macOS dialog tests (#50528)

2026-03-27 08:20:36 -04:00

api-global-shortcut-spec.ts

test: test menu rendering accelerators (#44634)

2025-05-06 14:09:35 -04:00

api-image-view-spec.ts

docs: add documentation for ImageView (#46760)

2025-05-29 10:24:16 -07:00

api-in-app-purchase-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

api-ipc-main-spec.ts

docs: Make ipcRenderer and ipcMain listener API docs consistent (#44651)

2024-11-18 14:44:30 -08:00

api-ipc-renderer-spec.ts

docs: Make ipcRenderer and ipcMain listener API docs consistent (#44651)

2024-11-18 14:44:30 -08:00

api-ipc-spec.ts

chore: upgrade Node.js to v24.10.0 (#48613)

2025-10-30 19:16:48 +01:00

api-media-handler-spec.ts

fix: crash on getUserMedia with invalid chromeMediaSourceId (#45733)

2025-02-21 10:17:52 -06:00

api-menu-item-spec.ts

fix: default accelerator for role-based menu items (#49668)

2026-02-05 10:58:19 -05:00

api-menu-spec.ts

fix: menu close event missing after opening a submenu (#49964)

2026-02-26 16:55:19 -05:00

api-native-image-spec.ts

feat: add SF Symbol support to NativeImage::CreateFromNamedImage (#48203)

2025-11-04 11:15:34 +01:00

api-native-theme-spec.ts

feat: add accessibilityDisplayShouldDifferentiateWithoutColor on macOS (#50408)

2026-03-25 15:53:31 -04:00

api-net-custom-protocols-spec.ts

fix: apply IsSafeRedirectTarget to net module redirects (#50929)

2026-04-11 19:07:02 -07:00

api-net-log-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

api-net-session-spec.ts

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

api-net-spec.ts

fix: apply IsSafeRedirectTarget to net module redirects (#50929)

2026-04-11 19:07:02 -07:00

api-notification-dbus-spec.ts

chore: bump chromium to 144.0.7527.0 (main) (#48959)

2025-11-24 12:30:57 -05:00

api-notification-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

api-power-monitor-spec.ts

chore: bump chromium to 144.0.7527.0 (main) (#48959)

2025-11-24 12:30:57 -05:00

api-power-save-blocker-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

api-process-spec.ts

refactor: eliminate duplicate code in spec/api-process-spec.ts (#45927)

2025-03-09 17:37:14 -05:00

api-protocol-spec.ts

feat: make Chrome extensions work on custom protocols (#50529)

2026-04-02 20:09:56 -07:00

api-safe-storage-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

api-screen-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

api-service-worker-main-spec.ts

feat: ServiceWorkerMain.scriptURL (#45863)

2025-03-14 21:00:13 -04:00

api-service-workers-spec.ts

feat: service worker preload scripts for improved extensions support (#44411)

2025-01-31 09:32:45 -05:00

api-session-spec.ts

fix: propagate requesting frame through sync permission checks (#50687)

2026-04-05 00:32:03 +00:00

api-shared-texture-spec.ts

chore: bump chromium to 144.0.7527.0 (main) (#48959)

2025-11-24 12:30:57 -05:00

api-shell-spec.ts

fix: second argument to shell.writeShortcutLink is optional (#49503)

2026-01-26 11:57:56 +01:00

api-subframe-spec.ts

chore: bump chromium to 140.0.7281.0 (main) (#47616)

2025-07-14 13:42:37 -07:00

api-system-preferences-spec.ts

feat: Add getAccentColor on Linux (#48027)

2025-10-21 14:26:30 -04:00

api-touch-bar-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

api-tray-spec.ts

feat: allow macOS tray to maintain position (#47838)

2025-08-07 19:25:50 +02:00

api-utility-process-spec.ts

fix: correct utility process exit code on Windows (#50386)

2026-03-19 18:48:27 -07:00

api-view-spec.ts

test: add view.getBounds|setBounds tests (#48936)

2025-11-14 14:46:21 +01:00

api-web-contents-spec.ts

fix: reset printToPDF queue after a rejection (#51221)

2026-04-22 12:32:47 +02:00

api-web-contents-view-spec.ts

fix: re-enable MacWebContentsOcclusion with embedder window fix (#50715)

2026-04-06 16:01:41 -04:00

api-web-frame-main-spec.ts

chore: bump chromium to 143.0.7497.0 (main) (#48657)

2025-10-28 11:17:29 -04:00

api-web-frame-spec.ts

chore: bump chromium to 140.0.7281.0 (main) (#47616)

2025-07-14 13:42:37 -07:00

api-web-request-spec.ts

fix: webRequest.onBeforeSendHeaders not being able to modify reserved headers (#49226)

2025-12-19 23:08:40 +13:00

api-web-utils-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

asar-integrity-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

asar-spec.ts

fix: return numeric blksize and blocks from asar fs.stat (#50876)

2026-04-10 12:15:26 +02:00

autofill-spec.ts

fix: clamp autofill popup bounds to the requesting frame viewport (#50944)

2026-04-11 19:05:11 -07:00

chromium-spec.ts

fix: nodeIntegrationInWorker not working in AudioWorklet (#51006)

2026-04-20 12:01:52 +02:00

cpp-heap-spec.ts

test: add cppgc backed menu leak regression test (#50882)

2026-04-10 10:40:40 -05:00

crash-spec.ts

fix: oob string read when parsing node_options (#46210)

2025-03-25 19:33:10 +09:00

deprecate-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

disabled-tests.json

chore: disable tests that require nut.js (#42006)

2024-04-30 21:13:38 -04:00

esm-spec.ts

feat: dynamic ESM import in preload without context isolation (#48375)

2025-10-08 10:44:09 +02:00

extensions-spec.ts

fix: scope extension tab-ID resolution to the calling BrowserContext (#50926)

2026-04-11 07:35:25 -05:00

fuses-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

get-files.ts

chore: remove walkdir dev dependency (#42591)

2024-06-21 10:31:10 -04:00

guest-window-manager-spec.ts

fix: restrict window.open features to allowlisted BrowserWindow options (#50948)

2026-04-11 19:04:40 -07:00

index.js

ci: log mocha retries in spec runner (#49878)

2026-02-19 16:10:03 -05:00

logging-spec.ts

fix: prevent log files being written to current directory on Windows (#44413)

2025-05-02 16:27:29 -05:00

mas-spec.ts

test: MAS for private API usage (#49836)

2026-02-18 14:01:18 +01:00

modules-spec.ts

fix: importing from electron/utility in ESM (#47998)

2025-08-09 09:47:47 +02:00

node-spec.ts

feat: add support for --experimental-transform-types (#49882)

2026-02-25 12:56:35 -05:00

package.json

test: add interactive macOS dialog tests (#50528)

2026-03-27 08:20:36 -04:00

parse-features-string-spec.ts

fix: restrict window.open features to allowlisted BrowserWindow options (#50948)

2026-04-11 19:04:40 -07:00

pipe-transport.ts

test: drop now-empty remote runner (#35343)

2022-08-16 15:23:13 -04:00

process-binding-spec.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

release-notes-spec.ts

build: drop dugite as a dependency (#49194)

2025-12-12 13:43:12 -05:00

security-warnings-spec.ts

feat: expose frame & move properties to console-message event object (#43617)

2024-10-18 16:07:06 -04:00

spellchecker-spec.ts

chore: bump chromium to 144.0.7527.0 (main) (#48959)

2025-11-24 12:30:57 -05:00

types-spec.ts

chore: update node types version (#36924)

2023-01-18 14:46:27 +01:00

version-bump-spec.ts

build: drop dugite as a dependency (#49194)

2025-12-12 13:43:12 -05:00

visibility-state-spec.ts

build: use github actions for windows (#44136)

2024-12-12 11:51:24 -05:00

webview-spec.ts

test: rerun failed tests individually (#48205)

2025-09-24 13:35:14 -07:00