mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
64cdfda810
* fix: let Node.js perform microtask checkpoint in the main process * fix: don't specify v8::MicrotasksScope for explicit policy * fix: remove checkpoint from some call-sites We already perform checkpoint at the end of a task, either through MicrotaskRunner or through NodeBindings. There isn't a need to add them again when calling into JS except when dealing with promises. * fix: remove checkpoint from some call-sites We already perform checkpoint at the end of a task, either through MicrotaskRunner or through NodeBindings. There isn't a need to add them again when calling into JS except when dealing with promises. * fix incorrect specs * default constructor arguments are considered for explicit mark * add regression spec Co-authored-by: deepak1556 <hop2deep@gmail.com>
40 lines
1.6 KiB
C++
40 lines
1.6 KiB
C++
|
|
// Copyright (c) 2018 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "shell/browser/microtasks_runner.h"
|
|
|
|
#include "shell/browser/electron_browser_main_parts.h"
|
|
#include "shell/browser/javascript_environment.h"
|
|
#include "shell/common/node_includes.h"
|
|
#include "v8/include/v8.h"
|
|
|
|
namespace electron {
|
|
|
|
MicrotasksRunner::MicrotasksRunner(v8::Isolate* isolate) : isolate_(isolate) {}
|
|
|
|
void MicrotasksRunner::WillProcessTask(const base::PendingTask& pending_task,
|
|
bool was_blocked_or_low_priority) {}
|
|
|
|
void MicrotasksRunner::DidProcessTask(const base::PendingTask& pending_task) {
|
|
v8::Isolate::Scope scope(isolate_);
|
|
// In the browser process we follow Node.js microtask policy of kExplicit
|
|
// and let the MicrotaskRunner which is a task observer for chromium UI thread
|
|
// scheduler run the micotask checkpoint. This worked fine because Node.js
|
|
// also runs microtasks through its task queue, but after
|
|
// https://github.com/electron/electron/issues/20013 Node.js now performs its
|
|
// own microtask checkpoint and it may happen is some situations that there is
|
|
// contention for performing checkpoint between Node.js and chromium, ending
|
|
// up Node.js dealying its callbacks. To fix this, now we always lets Node.js
|
|
// handle the checkpoint in the browser process.
|
|
{
|
|
auto* node_env = electron::ElectronBrowserMainParts::Get()->node_env();
|
|
node::InternalCallbackScope microtasks_scope(
|
|
node_env->env(), v8::Local<v8::Object>(), {0, 0},
|
|
node::InternalCallbackScope::kAllowEmptyResource);
|
|
}
|
|
}
|
|
|
|
} // namespace electron
|