github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-11 00:18:02 -05:00
Code Issues Packages Projects Releases Wiki Activity
Files
6293bbced0e2282e2a4076fd5cc422a2a90f1ed5
electron/shell/browser
History
Charles Kerr 6293bbced0 perf: avoid redundant calls to GetView() (#43216) 
* perf: avoid double-calls to GetView()

There are a lot of places where we call the virtual method GetView()
twice in succession: the first to check if the view exists, and the
second to use. This PR holds the view in a temp variable instead, e.g.:

if (auto* view = foo->GetView())
  view->DoSomething();

* perf: avoid discarded GetView() call
2024-08-06 11:25:59 -05:00
..
api
perf: avoid redundant calls to GetView() (#43216)
2024-08-06 11:25:59 -05:00
badging
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
bluetooth
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
extensions
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
file_system_access
refactor: prefer std::ranges over base::ranges (#43172)
2024-08-02 21:21:59 -05:00
hid
perf: don't build unused vectors in HidChooserContext (#43192)
2024-08-05 15:31:58 +02:00
lib
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
linux
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
mac
chore: bump chromium to 129.0.6630.0 (main) (#43087)
2024-08-02 09:02:11 -05:00
media
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
net
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
notifications
chore: bump chromium to 129.0.6630.0 (main) (#43087)
2024-08-02 09:02:11 -05:00
osr
perf: avoid redundant calls to GetView() (#43216)
2024-08-06 11:25:59 -05:00
plugins
chore: remove unused #includes (#42971)
2024-07-22 11:31:32 +02:00
printing
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
resources
chore: strip trailing whitespace (#35969)
2023-02-01 12:59:16 +01:00
serial
refactor: prefer std::ranges over base::ranges (#43172)
2024-08-02 21:21:59 -05:00
ui
perf: avoid redundant calls to GetView() (#43216)
2024-08-06 11:25:59 -05:00
usb
refactor: prefer std::ranges over base::ranges (#43172)
2024-08-02 21:21:59 -05:00
webauthn
chore: add/fix interface comments for sections of methods (#42566)
2024-06-20 10:49:07 +02:00
win
chore: remove unused #includes (#42971)
2024-07-22 11:31:32 +02:00
animation_util_mac.mm
feat: replace BrowserView with WebContentsView (#35658)
2023-12-13 13:01:03 -08:00
animation_util.h
feat: replace BrowserView with WebContentsView (#35658)
2023-12-13 13:01:03 -08:00
auto_updater_mac.mm
chore: bump chromium to 120.0.6099.0 (main) (#40316)
2023-11-01 10:02:12 -04:00
auto_updater.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
auto_updater.h
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
background_throttling_source.h
fix: disable background throttling also in the viz::DisplayScheduler (#38924)
2023-09-26 16:00:46 -04:00
browser_linux.cc
refactor: move impl classes into unnamed namespaces (#42390)
2024-06-10 17:00:20 -05:00
browser_mac.mm
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
browser_observer.h
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
browser_process_impl.cc
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
browser_process_impl.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
browser_win.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
browser.cc
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
browser.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
certificate_manager_model.cc
refactor: remove deprecated BrowserContext::ResourceContext (#41221)
2024-02-05 18:12:34 -06:00
certificate_manager_model.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
child_web_contents_tracker.cc
chore: bump chromium to 99.0.4767.0 (main) (#31986)
2022-01-10 17:31:39 -05:00
child_web_contents_tracker.h
chore: add ELECTRON_ prefix to C++ include guards (#31925)
2021-11-22 16:34:31 +09:00
cookie_change_notifier.cc
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
cookie_change_notifier.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
draggable_region_provider.h
refactor: move draggable regions to WebContents (#36230)
2022-11-07 10:15:57 -08:00
electron_api_ipc_handler_impl.cc
chore: remove deprecated ipcRenderer.sendTo() (#39087)
2023-08-28 10:29:27 -04:00
electron_api_ipc_handler_impl.h
refactor: inherit Observer classes privately, pt. 2 (#42237)
2024-05-29 13:07:02 -05:00
electron_autofill_driver_factory.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
electron_autofill_driver_factory.h
refactor: prefer to inherit observer classes privately (#41360)
2024-05-21 14:21:31 -05:00
electron_autofill_driver.cc
feat: replace BrowserView with WebContentsView (#35658)
2023-12-13 13:01:03 -08:00
electron_autofill_driver.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
electron_browser_client.cc
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
electron_browser_client.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
electron_browser_context.cc
refactor: prefer std::ranges over base::ranges (#43172)
2024-08-02 21:21:59 -05:00
electron_browser_context.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
electron_browser_main_parts_linux.cc
refactor: move impl classes into unnamed namespaces (#42390)
2024-06-10 17:00:20 -05:00
electron_browser_main_parts_mac.mm
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
electron_browser_main_parts_posix.cc
chore: remove unused #includes (#42971)
2024-07-22 11:31:32 +02:00
electron_browser_main_parts.cc
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
electron_browser_main_parts.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
electron_crypto_module_delegate_nss.cc
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
electron_crypto_module_delegate_nss.h
feat: Implement password delegate for NSS (#41205)
2024-07-17 09:48:03 -04:00
electron_download_manager_delegate.cc
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
electron_download_manager_delegate.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
electron_gpu_client.cc
chore: bump chromium to 100.0.4857.0 (main) (#32419)
2022-02-09 18:58:52 -08:00
electron_gpu_client.h
chore: add ELECTRON_ prefix to C++ include guards (#31925)
2021-11-22 16:34:31 +09:00
electron_navigation_throttle.cc
chore: bump chromium to 127.0.6521.0 (main) (#42118)
2024-06-07 17:18:35 -04:00
electron_navigation_throttle.h
chore: add/fix interface comments for sections of methods (#42566)
2024-06-20 10:49:07 +02:00
electron_pdf_document_helper_client.cc
chore: bump chromium to 125.0.6412.0 (main) (#41610)
2024-04-15 18:10:32 -04:00
electron_pdf_document_helper_client.h
chore: bump chromium to 125.0.6412.0 (main) (#41610)
2024-04-15 18:10:32 -04:00
electron_permission_manager.cc
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
electron_permission_manager.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
electron_speech_recognition_manager_delegate.cc
refactor: do not subclass ElectronSpeechRecognitionManagerDelegate from SpeechRecognitionEventListener (#42806)
2024-07-10 15:32:50 +02:00
electron_speech_recognition_manager_delegate.h
refactor: do not subclass ElectronSpeechRecognitionManagerDelegate from SpeechRecognitionEventListener (#42806)
2024-07-10 15:32:50 +02:00
electron_web_contents_utility_handler_impl.cc
chore: bump chromium to 125.0.6412.0 (main) (#41610)
2024-04-15 18:10:32 -04:00
electron_web_contents_utility_handler_impl.h
refactor: inherit Observer classes privately, pt. 2 (#42237)
2024-05-29 13:07:02 -05:00
electron_web_ui_controller_factory.cc
chore: remove unused #includes (#42971)
2024-07-22 11:31:32 +02:00
electron_web_ui_controller_factory.h
chore: add ELECTRON_ prefix to C++ include guards (#31925)
2021-11-22 16:34:31 +09:00
event_emitter_mixin.h
chore: migrate base::StringPiece to std::string_view (#40915)
2024-01-10 19:00:37 -06:00
extended_web_contents_observer.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
fake_location_provider.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
fake_location_provider.h
chore: bump chromium to 116.0.5845.0 (main) (#38827)
2023-06-22 10:51:15 +02:00
feature_list_mac.mm
fix: desktopCapturer breaks BrowserWindow resizable on macOS (#43013)
2024-07-25 11:17:37 +02:00
feature_list.cc
chore: bump chromium to 128.0.6558.0 (main) (#42413)
2024-07-02 09:51:33 +02:00
feature_list.h
fix: use ScreenCaptureKit exclusively on macOS 14.4 and higher (#41397)
2024-02-21 12:59:49 -08:00
file_select_helper_mac.mm
refactor: replace remaining NULL with nullptr (#40053)
2023-10-03 12:26:35 -07:00
file_select_helper.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
file_select_helper.h
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
font_defaults.cc
chore: remove unused #includes (#42971)
2024-07-22 11:31:32 +02:00
font_defaults.h
chore: add ELECTRON_ prefix to C++ include guards (#31925)
2021-11-22 16:34:31 +09:00
javascript_environment.cc
fix: bad js-flags shouldn't crash the app (#42414)
2024-06-11 08:32:16 -05:00
javascript_environment.h
refactor: remove unused fields, methods in gin_helper::Locker (#39803)
2023-09-12 16:53:20 -07:00
login_handler.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
login_handler.h
chore: remove unused #includes (#42971)
2024-07-22 11:31:32 +02:00
microtasks_runner.cc
chore: remove unused #includes (#42971)
2024-07-22 11:31:32 +02:00
microtasks_runner.h
chore: enable check raw ptr fields (#38167)
2023-05-11 16:07:39 -04:00
native_window_features.cc
chore: bump chromium to 127.0.6521.0 (main) (#42118)
2024-06-07 17:18:35 -04:00
native_window_features.h
fix: Add support for Wayland window decorations (#29618)
2022-01-26 13:59:09 -08:00
native_window_mac.h
fix: handle failing to enter fullscreen on macOS (#43112)
2024-08-01 12:13:13 +02:00
native_window_mac.mm
refactor: simplify window moveAbove/moveTop impl on macOS (#43157)
2024-08-05 09:57:16 +02:00
native_window_observer.h
feat: replace scroll-touch* with generic input-event (#35531)
2022-09-27 12:47:46 -07:00
native_window_views_win.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
native_window_views.cc
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
native_window_views.h
feat: enable Windows Control Overlay on Linux (#41769)
2024-06-27 14:56:36 +02:00
native_window.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
native_window.h
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
network_hints_handler_impl.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
network_hints_handler_impl.h
chore: enable check raw ptr fields (#38167)
2023-05-11 16:07:39 -04:00
protocol_registry.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
protocol_registry.h
perf: avoid protocol registry redundant lookup (#41991)
2024-05-09 09:53:09 -04:00
relauncher_linux.cc
chore: remove unused #includes (#42971)
2024-07-22 11:31:32 +02:00
relauncher_mac.cc
chore: remove unused #includes (#42971)
2024-07-22 11:31:32 +02:00
relauncher_win.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
relauncher.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
relauncher.h
chore: bump chromium to 100.0.4857.0 (main) (#32419)
2022-02-09 18:58:52 -08:00
session_preferences.cc
refactor: add SessionPreferences::CreateForBrowserContext() (#38656)
2023-06-09 11:20:43 -05:00
session_preferences.h
refactor: add SessionPreferences::CreateForBrowserContext() (#38656)
2023-06-09 11:20:43 -05:00
special_storage_policy.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
special_storage_policy.h
chore: bump chromium to 106.0.5216.0 (main) (#34993)
2022-08-17 11:35:53 -07:00
web_contents_permission_helper.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
web_contents_permission_helper.h
feat: implement File System API support (#41419)
2024-04-10 22:06:47 +02:00
web_contents_preferences.cc
chore: remove more unused #include calls (#43000)
2024-07-25 11:25:45 +02:00
web_contents_preferences.h
refactor: remove unused web contents preferences methods (#42947)
2024-07-19 12:26:57 -05:00
web_contents_zoom_controller.cc
chore: bump chromium to 128.0.6558.0 (main) (#42413)
2024-07-02 09:51:33 +02:00
web_contents_zoom_controller.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
web_contents_zoom_observer.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00
web_view_guest_delegate.cc
chore: bump chromium to 128.0.6558.0 (main) (#42413)
2024-07-02 09:51:33 +02:00
web_view_guest_delegate.h
refactor: prefer to inherit observer classes privately (#41360)
2024-05-21 14:21:31 -05:00
web_view_manager.cc
chore: bump chromium to 121.0.6147.0 (main) (#40523)
2023-11-28 13:40:12 -08:00
web_view_manager.h
perf: use flat_set, flat_map for small, trivially-moved containers (#40817)
2024-01-05 12:18:31 +01:00
window_list_observer.h
refactor: remove WindowListObserver::OnWindowAdded() (#42979)
2024-07-22 10:44:08 +02:00
window_list.cc
refactor: remove WindowListObserver::OnWindowAdded() (#42979)
2024-07-22 10:44:08 +02:00
window_list.h
refactor: migrate deprecated LazyInstance code to NoDestructor (#40927)
2024-01-10 14:01:49 -06:00
zoom_level_delegate.cc
chore: remove unused #includes (#42971)
2024-07-22 11:31:32 +02:00
zoom_level_delegate.h
chore: more iwyu (#43063)
2024-07-29 12:42:57 -05:00