mirror of
https://github.com/electron/electron.git
synced 2026-02-19 03:14:51 -05:00
* chore: bump chromium in DEPS to 146.0.7652.0 * fix(patch-conflict): update mas_avoid_private_macos_api_usage context for constrainFrameRect method The upstream CL added a new constrainFrameRect:toScreen: method override to NativeWidgetMacNSWindow as part of headless mode window zoom implementation. The MAS patch's #endif for frameViewClassForStyleMask now correctly appears after that method, since constrainFrameRect is a public API override that doesn't need to be guarded. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7487666 * fix(patch-conflict): update printing.patch for base::DictValue rename Updated printing.patch to use the new base::DictValue type name instead of base::Value::Dict following Chromium's type renaming change. This affects CompleteUpdatePrintSettings() signature and related code. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7509820 * fix(patch-conflict): update accessibility_ui patch for base::DictValue/ListValue rename Updated adjust_accessibility_ui_for_electron.patch to use the new base::DictValue and base::ListValue type names instead of base::Value::Dict and base::Value::List following Chromium's type renaming change. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7509820 * chore: update patches * 6625736: Rename DURABLE_STORAGE to PERSISTENT_STORAGE for consistency | https://chromium-review.googlesource.com/c/chromium/src/+/6625736 * chore: bump chromium in DEPS to 146.0.7653.0 * chore: update patches * 7000847: add type tag to v8::External for gin_helper function templates The upstream gin function templates now use v8::ExternalPointerTypeTag for type safety when using v8::External. Updated Electron's forked gin_helper function template to use the same kGinInternalCallbackHolderBaseTag that Chromium's gin uses. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7000847 * fix(patch-update): extend V8 Object API deprecation patch for Node.js Extended the existing patch to cover additional files that use GetAlignedPointerFromInternalField and SetAlignedPointerInInternalField: - src/stream_base-inl.h - src/udp_wrap.cc - src/js_udp_wrap.cc - src/node_process_methods.cc - src/node_snapshotable.cc - src/base_object.cc These APIs now require an EmbedderDataTypeTag parameter. Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7087956 * 7000847: add type tag to v8::External calls in shared_texture Updated v8::External::New and v8::External::Value calls to use the kExternalPointerTypeTagDefault tag as required by the V8 API change that deprecates the tagless versions. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7000847 * 7508687: use ChildProcessId for file permission APIs The ChildProcessSecurityPolicy::CanReadFile and GrantReadFile APIs now require ChildProcessId instead of int. Updated to use GetID() instead of GetDeprecatedID() for these specific calls. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7508687 * 7000847: add type tag to v8::External calls in callback and osr_converter The v8::External API now requires an EmbedderPointerTypeTag parameter for both New() and Value() methods to improve V8 sandbox type safety. Updated calls in: - callback.cc: TranslatorHolder constructor and CallTranslator - osr_converter.cc: OffscreenSharedTextureValue converter Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7000847 * fixup! 7087956: [api] Promote deprecation of v8::Context and v8::Object API methods Extended the Node.js patch to cover histogram.cc which also uses SetAlignedPointerInInternalField and GetAlignedPointerFromInternalField APIs that now require the EmbedderDataTypeTag parameter. Ref: https://chromium-review.googlesource.com/c/v8/v8/+/7087956 * chore: bump chromium in DEPS to 146.0.7655.0 * chore: update patches * 7509043: update WebSpellingMarker type for API change The upstream Chromium API changed - WebSpellingMarker was moved from a nested type within WebTextCheckClient to a standalone type in the blink namespace. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7509043 * 7498491: update process_id to use OriginatingProcess type The upstream Chromium API changed - URLLoaderFactoryParams::process_id was changed from an integer to a union type network::OriginatingProcess that distinguishes between browser and renderer processes. - For browser process requests, use OriginatingProcess::browser() - For renderer process lookups, check !is_browser() and use renderer_process().value() to get the child_id Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7498491 * 5710330: Add crash keys to debug NativeWidgetMacNSWindowBorderlessFrame exception | https://chromium-review.googlesource.com/c/chromium/src/+/5710330 5710330 added a new NSNextStepFrame interface extension and implementations for NativeWidgetMacNSWindowTitledFrame and NativeWidgetMacNSWindowBorderlessFrame. These use private macOS APIs that are not available in Mac App Store builds. * chore: update patches * chore: bump chromium in DEPS to 146.0.7661.0 * chore: bump chromium in DEPS to 146.0.7663.0 * fix(patch-conflict): update accessibility_ui for string_view API change Upstream removed redundant std::string(default_api_type) conversion as part of a string_view optimization cleanup. Updated patch context to match. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7514107 * fix(patch-conflict): update service process launch options for sandbox API refactor Upstream removed content/common/sandbox_init_win.cc and content/public/common/sandbox_init_win.h, moving the functionality directly into ChildProcessLauncherHelper. Updated patch to call sandbox::policy::SandboxWin::StartSandboxedProcess directly with the LaunchOptions pointer instead of going through the removed helper. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7528253 * fix(patch-conflict): update MAS safestorage for keychain API refactor Upstream refactored KeychainPassword::GetPassword() to use a new GetPasswordImpl() helper function with improved error tracking via base::expected<std::string, OSStatus>. Adapted patch to use the new GetPasswordImpl with the suffixed account name and handle migration from legacy accounts through the new API. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7516438 * chore: update patches * chore: bump chromium in DEPS to 146.0.7663.0 * fix: base::Value::Dict -> base::DictValue https://chromium-review.googlesource.com/c/chromium/src/+/7513889 * fix: include new cookie exclusion reason https://chromium-review.googlesource.com/c/chromium/src/+/7486527 * fix: enable libc++ ABI flag for trivially copyable std::vector<bool> Required for changes introduced in the following CL https://chromium-review.googlesource.com/c/chromium/src/+/7513653 * fixup! fix: base::Value::Dict -> base::DictValue https://chromium-review.googlesource.com/c/chromium/src/+/7513889 * fix: spellcheck not working in tests https://chromium-review.googlesource.com/c/chromium/src/+/7452579 * fix: cookie test failing due to multiple rejection reasons https://chromium-review.googlesource.com/c/chromium/src/+/7506629 * fix: macos sizing unmaximized window incorrectly https://chromium-review.googlesource.com/c/chromium/src/+/7487666 Changes to headless mode caused the unmaximized window to subtract the height of the menubar. * fix: skip tests for incompatible BoringSSL ML-DSA crypto https://boringssl-review.googlesource.com/c/boringssl/+/84929 * test: fix pseudonymization registration in utility process on Linux Ref: 7486913: Pass pseudonymization salt via shared memory at process launch | https://chromium-review.googlesource.com/c/chromium/src/+/7486913 * fix: restore MAS patch-outs Restores some `#if !IS_MAS_BUILD()` gates dropped in773054ad59* fixup! 7508687: use ChildProcessId for file permission APIs * fixup! fix(patch-conflict): update MAS safestorage for keychain API refactor * chore: add note about parallel upstream change * fixup! Merge remote-tracking branch 'origin/main' into roller/chromium/main * Revert "fixup! 7508687: use ChildProcessId for file permission APIs" This reverts commit05c43e4e5d. The _impl version has the signature, but not the public interface. :oof: * fixup! fix(patch-conflict): update MAS safestorage for keychain API refactor --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: Samuel Maddock <samuelmaddock@electronjs.org> Co-authored-by: clavin <clavin@electronjs.org>
665 lines
26 KiB
TypeScript
665 lines
26 KiB
TypeScript
import { net, session, BrowserWindow, ClientRequestConstructorOptions } from 'electron/main';
|
|
|
|
import { expect } from 'chai';
|
|
|
|
import * as dns from 'node:dns';
|
|
|
|
import { collectStreamBody, getResponse, respondNTimes, respondOnce } from './lib/net-helpers';
|
|
|
|
// See https://github.com/nodejs/node/issues/40702.
|
|
dns.setDefaultResultOrder('ipv4first');
|
|
|
|
describe('net module (session)', () => {
|
|
beforeEach(() => {
|
|
respondNTimes.routeFailure = false;
|
|
});
|
|
afterEach(async function () {
|
|
await session.defaultSession.clearCache();
|
|
if (respondNTimes.routeFailure && this.test) {
|
|
if (!this.test.isFailed()) {
|
|
throw new Error('Failing this test due an unhandled error in the respondOnce route handler, check the logs above for the actual error');
|
|
}
|
|
}
|
|
});
|
|
|
|
describe('HTTP basics', () => {
|
|
for (const extraOptions of [{}, { credentials: 'include' }, { useSessionCookies: false, credentials: 'include' }] as ClientRequestConstructorOptions[]) {
|
|
describe(`authentication when ${JSON.stringify(extraOptions)}`, () => {
|
|
it('should share credentials with WebContents', async () => {
|
|
const [user, pass] = ['user', 'pass'];
|
|
const serverUrl = await respondNTimes.toSingleURL((request, response) => {
|
|
if (!request.headers.authorization) {
|
|
return response.writeHead(401, { 'WWW-Authenticate': 'Basic realm="Foo"' }).end();
|
|
}
|
|
return response.writeHead(200).end('ok');
|
|
}, 2);
|
|
const bw = new BrowserWindow({ show: false });
|
|
bw.webContents.on('login', (event, details, authInfo, cb) => {
|
|
event.preventDefault();
|
|
cb(user, pass);
|
|
});
|
|
await bw.loadURL(serverUrl);
|
|
bw.close();
|
|
const request = net.request({ method: 'GET', url: serverUrl, ...extraOptions });
|
|
let logInCount = 0;
|
|
request.on('login', () => {
|
|
logInCount++;
|
|
});
|
|
const response = await getResponse(request);
|
|
await collectStreamBody(response);
|
|
expect(logInCount).to.equal(0, 'should not receive a login event, credentials should be cached');
|
|
});
|
|
|
|
it('should share proxy credentials with WebContents', async () => {
|
|
const [user, pass] = ['user', 'pass'];
|
|
const proxyUrl = await respondNTimes((request, response) => {
|
|
if (!request.headers['proxy-authorization']) {
|
|
return response.writeHead(407, { 'Proxy-Authenticate': 'Basic realm="Foo"' }).end();
|
|
}
|
|
return response.writeHead(200).end('ok');
|
|
}, 2);
|
|
const customSession = session.fromPartition(`net-proxy-test-${Math.random()}`);
|
|
await customSession.setProxy({ proxyRules: proxyUrl.replace('http://', ''), proxyBypassRules: '<-loopback>' });
|
|
const bw = new BrowserWindow({ show: false, webPreferences: { session: customSession } });
|
|
bw.webContents.on('login', (event, details, authInfo, cb) => {
|
|
event.preventDefault();
|
|
cb(user, pass);
|
|
});
|
|
await bw.loadURL('http://127.0.0.1:9999');
|
|
bw.close();
|
|
const request = net.request({ method: 'GET', url: 'http://127.0.0.1:9999', session: customSession, ...extraOptions });
|
|
let logInCount = 0;
|
|
request.on('login', () => {
|
|
logInCount++;
|
|
});
|
|
const response = await getResponse(request);
|
|
const body = await collectStreamBody(response);
|
|
expect(response.statusCode).to.equal(200);
|
|
expect(body).to.equal('ok');
|
|
expect(logInCount).to.equal(0, 'should not receive a login event, credentials should be cached');
|
|
});
|
|
});
|
|
}
|
|
|
|
describe('authentication when {"credentials":"omit"}', () => {
|
|
it('should not share credentials with WebContents', async () => {
|
|
const [user, pass] = ['user', 'pass'];
|
|
const serverUrl = await respondNTimes.toSingleURL((request, response) => {
|
|
if (!request.headers.authorization) {
|
|
return response.writeHead(401, { 'WWW-Authenticate': 'Basic realm="Foo"' }).end();
|
|
}
|
|
return response.writeHead(200).end('ok');
|
|
}, 2);
|
|
const bw = new BrowserWindow({ show: false });
|
|
bw.webContents.on('login', (event, details, authInfo, cb) => {
|
|
event.preventDefault();
|
|
cb(user, pass);
|
|
});
|
|
await bw.loadURL(serverUrl);
|
|
bw.close();
|
|
const request = net.request({ method: 'GET', url: serverUrl, credentials: 'omit' });
|
|
request.on('login', () => {
|
|
expect.fail();
|
|
});
|
|
const response = await getResponse(request);
|
|
expect(response.statusCode).to.equal(401);
|
|
expect(response.headers['www-authenticate']).to.equal('Basic realm="Foo"');
|
|
});
|
|
|
|
it('should share proxy credentials with WebContents', async () => {
|
|
const [user, pass] = ['user', 'pass'];
|
|
const proxyUrl = await respondNTimes((request, response) => {
|
|
if (!request.headers['proxy-authorization']) {
|
|
return response.writeHead(407, { 'Proxy-Authenticate': 'Basic realm="Foo"' }).end();
|
|
}
|
|
return response.writeHead(200).end('ok');
|
|
}, 2);
|
|
const customSession = session.fromPartition(`net-proxy-test-${Math.random()}`);
|
|
await customSession.setProxy({ proxyRules: proxyUrl.replace('http://', ''), proxyBypassRules: '<-loopback>' });
|
|
const bw = new BrowserWindow({ show: false, webPreferences: { session: customSession } });
|
|
bw.webContents.on('login', (event, details, authInfo, cb) => {
|
|
event.preventDefault();
|
|
cb(user, pass);
|
|
});
|
|
await bw.loadURL('http://127.0.0.1:9999');
|
|
bw.close();
|
|
const request = net.request({ method: 'GET', url: 'http://127.0.0.1:9999', session: customSession, credentials: 'omit' });
|
|
request.on('login', () => {
|
|
expect.fail();
|
|
});
|
|
const response = await getResponse(request);
|
|
const body = await collectStreamBody(response);
|
|
expect(response.statusCode).to.equal(200);
|
|
expect(body).to.equal('ok');
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('ClientRequest API', () => {
|
|
it('should be able to set cookie header line', async () => {
|
|
const cookieHeaderName = 'Cookie';
|
|
const cookieHeaderValue = 'test=12345';
|
|
const customSession = session.fromPartition(`test-cookie-header-${Math.random()}`);
|
|
const serverUrl = await respondOnce.toSingleURL((request, response) => {
|
|
expect(request.headers[cookieHeaderName.toLowerCase()]).to.equal(cookieHeaderValue);
|
|
response.statusCode = 200;
|
|
response.statusMessage = 'OK';
|
|
response.end();
|
|
});
|
|
await customSession.cookies.set({
|
|
url: `${serverUrl}`,
|
|
name: 'test',
|
|
value: '11111',
|
|
expirationDate: 0
|
|
});
|
|
const urlRequest = net.request({
|
|
method: 'GET',
|
|
url: serverUrl,
|
|
session: customSession
|
|
});
|
|
urlRequest.setHeader(cookieHeaderName, cookieHeaderValue);
|
|
expect(urlRequest.getHeader(cookieHeaderName)).to.equal(cookieHeaderValue);
|
|
const response = await getResponse(urlRequest);
|
|
expect(response.statusCode).to.equal(200);
|
|
await collectStreamBody(response);
|
|
});
|
|
|
|
it('should not use the sessions cookie store by default', async () => {
|
|
const serverUrl = await respondOnce.toSingleURL((request, response) => {
|
|
response.statusCode = 200;
|
|
response.statusMessage = 'OK';
|
|
response.setHeader('x-cookie', `${request.headers.cookie!}`);
|
|
response.end();
|
|
});
|
|
const sess = session.fromPartition(`cookie-tests-${Math.random()}`);
|
|
const cookieVal = `${Date.now()}`;
|
|
await sess.cookies.set({
|
|
url: serverUrl,
|
|
name: 'wild_cookie',
|
|
value: cookieVal
|
|
});
|
|
const urlRequest = net.request({
|
|
url: serverUrl,
|
|
session: sess
|
|
});
|
|
const response = await getResponse(urlRequest);
|
|
expect(response.headers['x-cookie']).to.equal('undefined');
|
|
});
|
|
|
|
for (const extraOptions of [{ useSessionCookies: true }, { credentials: 'include' }] as ClientRequestConstructorOptions[]) {
|
|
describe(`when ${JSON.stringify(extraOptions)}`, () => {
|
|
it('should be able to use the sessions cookie store', async () => {
|
|
const serverUrl = await respondOnce.toSingleURL((request, response) => {
|
|
response.statusCode = 200;
|
|
response.statusMessage = 'OK';
|
|
response.setHeader('x-cookie', request.headers.cookie!);
|
|
response.end();
|
|
});
|
|
const sess = session.fromPartition(`cookie-tests-${Math.random()}`);
|
|
const cookieVal = `${Date.now()}`;
|
|
await sess.cookies.set({
|
|
url: serverUrl,
|
|
name: 'wild_cookie',
|
|
value: cookieVal
|
|
});
|
|
const urlRequest = net.request({
|
|
url: serverUrl,
|
|
session: sess,
|
|
...extraOptions
|
|
});
|
|
const response = await getResponse(urlRequest);
|
|
expect(response.headers['x-cookie']).to.equal(`wild_cookie=${cookieVal}`);
|
|
});
|
|
|
|
it('should be able to use the sessions cookie store with set-cookie', async () => {
|
|
const serverUrl = await respondOnce.toSingleURL((request, response) => {
|
|
response.statusCode = 200;
|
|
response.statusMessage = 'OK';
|
|
response.setHeader('set-cookie', 'foo=bar');
|
|
response.end();
|
|
});
|
|
const sess = session.fromPartition(`cookie-tests-${Math.random()}`);
|
|
let cookies = await sess.cookies.get({});
|
|
expect(cookies).to.have.lengthOf(0);
|
|
const urlRequest = net.request({
|
|
url: serverUrl,
|
|
session: sess,
|
|
...extraOptions
|
|
});
|
|
await collectStreamBody(await getResponse(urlRequest));
|
|
cookies = await sess.cookies.get({});
|
|
expect(cookies).to.have.lengthOf(1);
|
|
expect(cookies[0]).to.deep.equal({
|
|
name: 'foo',
|
|
value: 'bar',
|
|
domain: '127.0.0.1',
|
|
hostOnly: true,
|
|
path: '/',
|
|
secure: false,
|
|
httpOnly: false,
|
|
session: true,
|
|
sameSite: 'unspecified'
|
|
});
|
|
});
|
|
|
|
for (const mode of ['Lax', 'Strict']) {
|
|
it(`should be able to use the sessions cookie store with same-site ${mode} cookies`, async () => {
|
|
const serverUrl = await respondNTimes.toSingleURL((request, response) => {
|
|
response.statusCode = 200;
|
|
response.statusMessage = 'OK';
|
|
response.setHeader('set-cookie', `same=site; SameSite=${mode}`);
|
|
response.setHeader('x-cookie', `${request.headers.cookie}`);
|
|
response.end();
|
|
}, 2);
|
|
const sess = session.fromPartition(`cookie-tests-${Math.random()}`);
|
|
let cookies = await sess.cookies.get({});
|
|
expect(cookies).to.have.lengthOf(0);
|
|
const urlRequest = net.request({
|
|
url: serverUrl,
|
|
session: sess,
|
|
...extraOptions
|
|
});
|
|
const response = await getResponse(urlRequest);
|
|
expect(response.headers['x-cookie']).to.equal('undefined');
|
|
await collectStreamBody(response);
|
|
cookies = await sess.cookies.get({});
|
|
expect(cookies).to.have.lengthOf(1);
|
|
expect(cookies[0]).to.deep.equal({
|
|
name: 'same',
|
|
value: 'site',
|
|
domain: '127.0.0.1',
|
|
hostOnly: true,
|
|
path: '/',
|
|
secure: false,
|
|
httpOnly: false,
|
|
session: true,
|
|
sameSite: mode.toLowerCase()
|
|
});
|
|
const urlRequest2 = net.request({
|
|
url: serverUrl,
|
|
session: sess,
|
|
...extraOptions
|
|
});
|
|
const response2 = await getResponse(urlRequest2);
|
|
expect(response2.headers['x-cookie']).to.equal('same=site');
|
|
});
|
|
}
|
|
|
|
it('should be able to use the sessions cookie store safely across redirects', async () => {
|
|
const serverUrl = await respondOnce.toSingleURL(async (request, response) => {
|
|
response.statusCode = 302;
|
|
response.statusMessage = 'Moved';
|
|
const newUrl = await respondOnce.toSingleURL((req, res) => {
|
|
res.statusCode = 200;
|
|
res.statusMessage = 'OK';
|
|
res.setHeader('x-cookie', req.headers.cookie!);
|
|
res.end();
|
|
});
|
|
response.setHeader('x-cookie', request.headers.cookie!);
|
|
response.setHeader('location', newUrl.replace('127.0.0.1', 'localhost'));
|
|
response.end();
|
|
});
|
|
const sess = session.fromPartition(`cookie-tests-${Math.random()}`);
|
|
const cookie127Val = `${Date.now()}-127`;
|
|
const cookieLocalVal = `${Date.now()}-local`;
|
|
const localhostUrl = serverUrl.replace('127.0.0.1', 'localhost');
|
|
expect(localhostUrl).to.not.equal(serverUrl);
|
|
// cookies with lax or strict same-site settings will not
|
|
// persist after redirects. no_restriction must be used
|
|
await Promise.all([
|
|
sess.cookies.set({
|
|
url: serverUrl,
|
|
name: 'wild_cookie',
|
|
sameSite: 'no_restriction',
|
|
value: cookie127Val
|
|
}), sess.cookies.set({
|
|
url: localhostUrl,
|
|
name: 'wild_cookie',
|
|
sameSite: 'no_restriction',
|
|
value: cookieLocalVal
|
|
})
|
|
]);
|
|
const urlRequest = net.request({
|
|
url: serverUrl,
|
|
session: sess,
|
|
...extraOptions
|
|
});
|
|
urlRequest.on('redirect', (status, method, url, headers) => {
|
|
// The initial redirect response should have received the 127 value here
|
|
expect(headers['x-cookie'][0]).to.equal(`wild_cookie=${cookie127Val}`);
|
|
urlRequest.followRedirect();
|
|
});
|
|
const response = await getResponse(urlRequest);
|
|
// We expect the server to have received the localhost value here
|
|
// The original request was to a 127.0.0.1 URL
|
|
// That request would have the cookie127Val cookie attached
|
|
// The request is then redirect to a localhost URL (different site)
|
|
// Because we are using the session cookie store it should do the safe / secure thing
|
|
// and attach the cookies for the new target domain
|
|
expect(response.headers['x-cookie']).to.equal(`wild_cookie=${cookieLocalVal}`);
|
|
});
|
|
});
|
|
}
|
|
|
|
it('should be able correctly filter out cookies that are secure', async () => {
|
|
const sess = session.fromPartition(`cookie-tests-${Math.random()}`);
|
|
|
|
await Promise.all([
|
|
sess.cookies.set({
|
|
url: 'https://electronjs.org',
|
|
domain: 'electronjs.org',
|
|
name: 'cookie1',
|
|
value: '1',
|
|
secure: true
|
|
}),
|
|
sess.cookies.set({
|
|
url: 'https://electronjs.org',
|
|
domain: 'electronjs.org',
|
|
name: 'cookie2',
|
|
value: '2',
|
|
secure: false
|
|
})
|
|
]);
|
|
|
|
const secureCookies = await sess.cookies.get({
|
|
secure: true
|
|
});
|
|
expect(secureCookies).to.have.lengthOf(1);
|
|
expect(secureCookies[0].name).to.equal('cookie1');
|
|
|
|
const cookies = await sess.cookies.get({
|
|
secure: false
|
|
});
|
|
expect(cookies).to.have.lengthOf(1);
|
|
expect(cookies[0].name).to.equal('cookie2');
|
|
});
|
|
|
|
it('throws when an invalid domain is passed', async () => {
|
|
const sess = session.fromPartition(`cookie-tests-${Math.random()}`);
|
|
|
|
await expect(sess.cookies.set({
|
|
url: 'https://electronjs.org',
|
|
domain: 'wssss.iamabaddomain.fun',
|
|
name: 'cookie1'
|
|
})).to.eventually.be.rejectedWith(/The cookie was set with an invalid Domain attribute/);
|
|
});
|
|
|
|
it('should be able correctly filter out cookies that are session', async () => {
|
|
const sess = session.fromPartition(`cookie-tests-${Math.random()}`);
|
|
|
|
await Promise.all([
|
|
sess.cookies.set({
|
|
url: 'https://electronjs.org',
|
|
domain: 'electronjs.org',
|
|
name: 'cookie1',
|
|
value: '1'
|
|
}),
|
|
sess.cookies.set({
|
|
url: 'https://electronjs.org',
|
|
domain: 'electronjs.org',
|
|
name: 'cookie2',
|
|
value: '2',
|
|
expirationDate: Math.round(Date.now() / 1000) + 10000
|
|
})
|
|
]);
|
|
|
|
const sessionCookies = await sess.cookies.get({
|
|
session: true
|
|
});
|
|
expect(sessionCookies).to.have.lengthOf(1);
|
|
expect(sessionCookies[0].name).to.equal('cookie1');
|
|
|
|
const cookies = await sess.cookies.get({
|
|
session: false
|
|
});
|
|
expect(cookies).to.have.lengthOf(1);
|
|
expect(cookies[0].name).to.equal('cookie2');
|
|
});
|
|
|
|
it('should be able correctly filter out cookies that are httpOnly', async () => {
|
|
const sess = session.fromPartition(`cookie-tests-${Math.random()}`);
|
|
|
|
await Promise.all([
|
|
sess.cookies.set({
|
|
url: 'https://electronjs.org',
|
|
domain: 'electronjs.org',
|
|
name: 'cookie1',
|
|
value: '1',
|
|
httpOnly: true
|
|
}),
|
|
sess.cookies.set({
|
|
url: 'https://electronjs.org',
|
|
domain: 'electronjs.org',
|
|
name: 'cookie2',
|
|
value: '2',
|
|
httpOnly: false
|
|
})
|
|
]);
|
|
|
|
const httpOnlyCookies = await sess.cookies.get({
|
|
httpOnly: true
|
|
});
|
|
expect(httpOnlyCookies).to.have.lengthOf(1);
|
|
expect(httpOnlyCookies[0].name).to.equal('cookie1');
|
|
|
|
const cookies = await sess.cookies.get({
|
|
httpOnly: false
|
|
});
|
|
expect(cookies).to.have.lengthOf(1);
|
|
expect(cookies[0].name).to.equal('cookie2');
|
|
});
|
|
|
|
describe('webRequest', () => {
|
|
afterEach(() => {
|
|
session.defaultSession.webRequest.onBeforeRequest(null);
|
|
});
|
|
|
|
it('Should throw when invalid filters are passed', () => {
|
|
expect(() => {
|
|
session.defaultSession.webRequest.onBeforeRequest(
|
|
{ urls: ['*://www.googleapis.com'] },
|
|
(details, callback) => { callback({ cancel: false }); }
|
|
);
|
|
}).to.throw('Invalid url pattern *://www.googleapis.com: Empty path.');
|
|
|
|
expect(() => {
|
|
session.defaultSession.webRequest.onBeforeRequest(
|
|
{ urls: ['*://www.googleapis.com/', '*://blahblah.dev'] },
|
|
(details, callback) => { callback({ cancel: false }); }
|
|
);
|
|
}).to.throw('Invalid url pattern *://blahblah.dev: Empty path.');
|
|
});
|
|
|
|
it('Should not throw when valid filters are passed', () => {
|
|
expect(() => {
|
|
session.defaultSession.webRequest.onBeforeRequest(
|
|
{ urls: ['*://www.googleapis.com/'] },
|
|
(details, callback) => { callback({ cancel: false }); }
|
|
);
|
|
}).to.not.throw();
|
|
});
|
|
|
|
it('Requests should be intercepted by webRequest module', async () => {
|
|
const requestUrl = '/requestUrl';
|
|
const redirectUrl = '/redirectUrl';
|
|
let requestIsRedirected = false;
|
|
const serverUrl = await respondOnce.toURL(redirectUrl, (request, response) => {
|
|
requestIsRedirected = true;
|
|
response.end();
|
|
});
|
|
let requestIsIntercepted = false;
|
|
session.defaultSession.webRequest.onBeforeRequest(
|
|
(details, callback) => {
|
|
if (details.url === `${serverUrl}${requestUrl}`) {
|
|
requestIsIntercepted = true;
|
|
callback({
|
|
redirectURL: `${serverUrl}${redirectUrl}`
|
|
});
|
|
} else {
|
|
callback({
|
|
cancel: false
|
|
});
|
|
}
|
|
});
|
|
|
|
const urlRequest = net.request(`${serverUrl}${requestUrl}`);
|
|
const response = await getResponse(urlRequest);
|
|
|
|
expect(response.statusCode).to.equal(200);
|
|
await collectStreamBody(response);
|
|
expect(requestIsRedirected).to.be.true('The server should receive a request to the forward URL');
|
|
expect(requestIsIntercepted).to.be.true('The request should be intercepted by the webRequest module');
|
|
});
|
|
|
|
it('should to able to create and intercept a request using a custom session object', async () => {
|
|
const requestUrl = '/requestUrl';
|
|
const redirectUrl = '/redirectUrl';
|
|
const customPartitionName = `custom-partition-${Math.random()}`;
|
|
let requestIsRedirected = false;
|
|
const serverUrl = await respondOnce.toURL(redirectUrl, (request, response) => {
|
|
requestIsRedirected = true;
|
|
response.end();
|
|
});
|
|
session.defaultSession.webRequest.onBeforeRequest(() => {
|
|
expect.fail('Request should not be intercepted by the default session');
|
|
});
|
|
|
|
const customSession = session.fromPartition(customPartitionName, { cache: false });
|
|
let requestIsIntercepted = false;
|
|
customSession.webRequest.onBeforeRequest((details, callback) => {
|
|
if (details.url === `${serverUrl}${requestUrl}`) {
|
|
requestIsIntercepted = true;
|
|
callback({
|
|
redirectURL: `${serverUrl}${redirectUrl}`
|
|
});
|
|
} else {
|
|
callback({
|
|
cancel: false
|
|
});
|
|
}
|
|
});
|
|
|
|
const urlRequest = net.request({
|
|
url: `${serverUrl}${requestUrl}`,
|
|
session: customSession
|
|
});
|
|
const response = await getResponse(urlRequest);
|
|
expect(response.statusCode).to.equal(200);
|
|
await collectStreamBody(response);
|
|
expect(requestIsRedirected).to.be.true('The server should receive a request to the forward URL');
|
|
expect(requestIsIntercepted).to.be.true('The request should be intercepted by the webRequest module');
|
|
});
|
|
|
|
it('should to able to create and intercept a request using a custom partition name', async () => {
|
|
const requestUrl = '/requestUrl';
|
|
const redirectUrl = '/redirectUrl';
|
|
const customPartitionName = `custom-partition-${Math.random()}`;
|
|
let requestIsRedirected = false;
|
|
const serverUrl = await respondOnce.toURL(redirectUrl, (request, response) => {
|
|
requestIsRedirected = true;
|
|
response.end();
|
|
});
|
|
session.defaultSession.webRequest.onBeforeRequest(() => {
|
|
expect.fail('Request should not be intercepted by the default session');
|
|
});
|
|
|
|
const customSession = session.fromPartition(customPartitionName, { cache: false });
|
|
let requestIsIntercepted = false;
|
|
customSession.webRequest.onBeforeRequest((details, callback) => {
|
|
if (details.url === `${serverUrl}${requestUrl}`) {
|
|
requestIsIntercepted = true;
|
|
callback({
|
|
redirectURL: `${serverUrl}${redirectUrl}`
|
|
});
|
|
} else {
|
|
callback({
|
|
cancel: false
|
|
});
|
|
}
|
|
});
|
|
|
|
const urlRequest = net.request({
|
|
url: `${serverUrl}${requestUrl}`,
|
|
partition: customPartitionName
|
|
});
|
|
const response = await getResponse(urlRequest);
|
|
expect(response.statusCode).to.equal(200);
|
|
await collectStreamBody(response);
|
|
expect(requestIsRedirected).to.be.true('The server should receive a request to the forward URL');
|
|
expect(requestIsIntercepted).to.be.true('The request should be intercepted by the webRequest module');
|
|
});
|
|
|
|
it('triggers webRequest handlers when bypassCustomProtocolHandlers', async () => {
|
|
let webRequestDetails: Electron.OnBeforeRequestListenerDetails | null = null;
|
|
const serverUrl = await respondOnce.toSingleURL((req, res) => res.end('hi'));
|
|
session.defaultSession.webRequest.onBeforeRequest((details, cb) => {
|
|
webRequestDetails = details;
|
|
cb({});
|
|
});
|
|
const body = await net.fetch(serverUrl, { bypassCustomProtocolHandlers: true }).then(r => r.text());
|
|
expect(body).to.equal('hi');
|
|
expect(webRequestDetails).to.have.property('url', serverUrl);
|
|
});
|
|
});
|
|
|
|
it('should throw if given an invalid session option', () => {
|
|
expect(() => {
|
|
net.request({
|
|
url: 'https://foo',
|
|
session: 1 as any
|
|
});
|
|
}).to.throw('`session` should be an instance of the Session class');
|
|
});
|
|
|
|
it('should throw if given an invalid partition option', () => {
|
|
expect(() => {
|
|
net.request({
|
|
url: 'https://foo',
|
|
partition: 1 as any
|
|
});
|
|
}).to.throw('`partition` should be a string');
|
|
});
|
|
|
|
it('should throw if given a header value that is empty(null/undefined)', () => {
|
|
const emptyHeaderValues = [null, undefined];
|
|
const errorMsg = '`value` required in setHeader("foo", value)';
|
|
|
|
for (const emptyValue of emptyHeaderValues) {
|
|
expect(() => {
|
|
net.request({
|
|
url: 'https://foo',
|
|
headers: { foo: emptyValue as any }
|
|
} as any);
|
|
}).to.throw(errorMsg);
|
|
|
|
const request = net.request({ url: 'https://foo' });
|
|
expect(() => {
|
|
request.setHeader('foo', emptyValue as any);
|
|
}).to.throw(errorMsg);
|
|
}
|
|
});
|
|
});
|
|
|
|
describe('net.fetch', () => {
|
|
it('should be able to use a session cookie store', async () => {
|
|
const serverUrl = await respondOnce.toSingleURL((request, response) => {
|
|
response.statusCode = 200;
|
|
response.statusMessage = 'OK';
|
|
response.setHeader('x-cookie', request.headers.cookie!);
|
|
response.end();
|
|
});
|
|
const sess = session.fromPartition(`cookie-tests-${Math.random()}`);
|
|
const cookieVal = `${Date.now()}`;
|
|
await sess.cookies.set({
|
|
url: serverUrl,
|
|
name: 'wild_cookie',
|
|
value: cookieVal
|
|
});
|
|
const response = await sess.fetch(serverUrl, {
|
|
credentials: 'include'
|
|
});
|
|
expect(response.headers.get('x-cookie')).to.equal(`wild_cookie=${cookieVal}`);
|
|
});
|
|
});
|
|
});
|