trop[bot] 1766e229eb fix: don't re-parse URL unnecessarily when handling dialogs (#50398) ...

* fix: fallback to opaque URL when needed inside dialog callback

Co-authored-by: Noah Gregory <noahmgregory@gmail.com>

* refactor: remove additional URL parsing entirely when showing dialogs

Co-authored-by: Noah Gregory <noahmgregory@gmail.com>

* test: add crash test case for URL-less dialogs

Co-authored-by: Noah Gregory <noahmgregory@gmail.com>

* refactor: exit on events instead of on timeout for dialog crash test

Co-authored-by: Robo <hop2deep@gmail.com>

Co-authored-by: Noah Gregory <noahmgregory@gmail.com>

* style: make linter happy

Co-authored-by: Noah Gregory <noahmgregory@gmail.com>

* style: make linter actually happy

Co-authored-by: Noah Gregory <noahmgregory@gmail.com>

* fix: address failing `safeDialogs` tests

Co-authored-by: Noah Gregory <noahmgregory@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Noah Gregory <noahmgregory@gmail.com>

2026-03-20 11:31:57 -04:00

..

auto-updater

feat: msix auto-updater (#49230)

2026-01-29 16:38:26 -05:00

exports

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

views

build: ensure that electron/lib/browser can only use browser or common imports (#24512)

2020-07-13 09:58:49 -07:00

app.ts

refactor: allocate api::App on cpp heap (#48118)

2025-08-20 20:35:08 +09:00

auto-updater.ts

feat: msix auto-updater (#49230)

2026-01-29 16:38:26 -05:00

base-window.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

browser-view.ts

fix: remove resize listener when BrowserWindow closed (#43972)

2024-09-27 10:34:00 -04:00

browser-window.ts

fix: BrowserWindow add the same BrowserView (#48053)

2025-08-28 10:31:41 +02:00

clipboard.ts

refactor: split clipboard module implementation for browser / renderer (#38429)

2023-05-25 20:36:12 +09:00

content-tracing.ts

refactor: prevent consistent early exception (#24191)

2020-06-22 20:32:45 -07:00

crash-reporter.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

desktop-capturer.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

dialog.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

global-shortcut.ts

refactor: prevent consistent early exception (#24191)

2020-06-22 20:32:45 -07:00

in-app-purchase.ts

feat: added username to IAP purchaseProduct method (#35902)

2022-12-12 10:11:48 -08:00

ipc-main.ts

feat: add WebContents.ipc (#34959)

2022-08-03 16:55:12 -07:00

menu-item-roles.ts

fix: default accelerator for role-based menu items (#49558)

2026-02-04 16:45:29 -05:00

menu-item.ts

fix: update label/sublabel/icon in MenuItems on open (#49678)

2026-02-27 12:47:05 -05:00

menu-utils.ts

refactor: replace .forEach() with for-of (#39691)

2023-08-31 23:36:43 +09:00

menu.ts

fix: update label/sublabel/icon in MenuItems on open (#49678)

2026-02-27 12:47:05 -05:00

message-channel.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

module-list.ts

feat: add sharedTexture module to import shared texture (#47317)

2025-11-07 09:50:28 +01:00

native-theme.ts

chore: move main process only accessible API bindings away from common (#34634)

2022-06-21 16:34:56 +09:00

net-fetch.ts

chore: upgrade Node.js to v24.10.0 (#48613)

2025-10-30 19:16:48 +01:00

net-log.ts

build: ensure that electron/lib/browser can only use browser or common imports (#24512)

2020-07-13 09:58:49 -07:00

net.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

notification.ts

feat: implements cold COM activation (#49919)

2026-03-05 17:30:04 -05:00

power-monitor.ts

fix: prevent use-after-free in PowerMonitor via dangling OS callbacks (#50045)

2026-03-05 09:00:37 -06:00

power-save-blocker.ts

refactor: prevent consistent early exception (#24191)

2020-06-22 20:32:45 -07:00

protocol.ts

chore: upgrade Node.js to v24.10.0 (#48613)

2025-10-30 19:16:48 +01:00

push-notifications.ts

feat: Enable APNS registration + notification delivery in macOS apps (#33574)

2022-07-12 08:38:49 -07:00

safe-storage.ts

feat: introduce os_crypt_async in safeStorage (#49054)

2026-02-15 19:54:50 +01:00

screen.ts

chore: move main process only accessible API bindings away from common (#34634)

2022-06-21 16:34:56 +09:00

service-worker-main.ts

feat: service worker preload scripts for improved extensions support (#44411)

2025-01-31 09:32:45 -05:00

session.ts

refactor: move extension APIs to session.extensions (#45597)

2025-02-21 17:36:51 -06:00

share-menu.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

shared-texture.ts

feat: add sharedTexture module to import shared texture (#47317)

2025-11-07 09:50:28 +01:00

system-preferences.ts

chore: remove deprecated systemPreferences.isAeroGlassEnabled() (#45563)

2025-02-18 18:59:00 -06:00

touch-bar.ts

build: update some build dependencies (#43882)

2024-09-26 00:12:11 -07:00

tray.ts

refactor: prevent consistent early exception (#24191)

2020-06-22 20:32:45 -07:00

utility-process.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

view.ts

build: add import/order eslint rule (#44085)

2024-10-02 19:10:44 -07:00

web-contents-view.ts

build: ensure that electron/lib/browser can only use browser or common imports (#24512)

2020-07-13 09:58:49 -07:00

web-contents.ts

fix: don't re-parse URL unnecessarily when handling dialogs (#50398)

2026-03-20 11:31:57 -04:00

web-frame-main.ts

feat: webFrameMain.fromFrameToken (#47850)

2025-07-31 16:41:44 -04:00