mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
build: replace npx with lockfile-pinned binaries (#50598) * build: replace npx with lockfile-pinned binaries - nan-spec-runner: reorder yarn install first, invoke nan node-gyp bin directly - publish-to-npm: use host npm with E404 try/catch (closes existing TODO) - upload-symbols: add @sentry/cli devDep, invoke from node_modules/.bin - remove script/lib/npx.py (dead since #48243) * build: bump @sentry/cli to 1.70.0 for arm support * build: bump @sentry/cli to 1.72.0, skip CDN download on test jobs @sentry/cli fetches its platform binary from Sentry CDN at postinstall. Only upload-symbols.py (release pipeline) needs the binary; set SENTRYCLI_SKIP_DOWNLOAD=1 in the two test-segment workflows that call install-dependencies. The 64k variant uses pre-built artifacts and does not install deps.
149 lines
4.5 KiB
JavaScript
149 lines
4.5 KiB
JavaScript
const minimist = require('minimist');
|
|
|
|
const cp = require('node:child_process');
|
|
const fs = require('node:fs');
|
|
const path = require('node:path');
|
|
|
|
const BASE = path.resolve(__dirname, '../..');
|
|
const NAN_DIR = path.resolve(BASE, 'third_party', 'nan');
|
|
const NODE_GYP_BIN = path.join(NAN_DIR, 'node_modules', 'node-gyp', 'bin', 'node-gyp.js');
|
|
|
|
const utils = require('./lib/utils');
|
|
const { YARN_SCRIPT_PATH } = require('./yarn');
|
|
|
|
if (!require.main) {
|
|
throw new Error('Must call the nan spec runner directly');
|
|
}
|
|
|
|
const args = minimist(process.argv.slice(2), {
|
|
string: ['only']
|
|
});
|
|
|
|
async function main () {
|
|
const outDir = utils.getOutDir({ shouldLog: true });
|
|
const nodeDir = path.resolve(BASE, 'out', outDir, 'gen', 'node_headers');
|
|
const env = {
|
|
npm_config_msvs_version: '2022',
|
|
...process.env,
|
|
npm_config_nodedir: nodeDir,
|
|
npm_config_arch: process.env.NPM_CONFIG_ARCH
|
|
};
|
|
|
|
const clangDir = path.resolve(BASE, 'third_party', 'llvm-build', 'Release+Asserts', 'bin');
|
|
const cc = path.resolve(clangDir, 'clang');
|
|
const cxx = path.resolve(clangDir, 'clang++');
|
|
const ld = path.resolve(clangDir, 'lld');
|
|
|
|
const platformFlags = [];
|
|
if (process.platform === 'darwin') {
|
|
const sdkPath = path.resolve(BASE, 'out', outDir, 'sdk', 'xcode_links');
|
|
const sdks = (await fs.promises.readdir(sdkPath)).filter(f => f.endsWith('.sdk'));
|
|
|
|
if (!sdks.length) {
|
|
console.error('Could not find an SDK to use for the NAN tests');
|
|
process.exit(1);
|
|
}
|
|
|
|
const sdkToUse = sdks.sort((a, b) => {
|
|
const getVer = s => s.match(/(\d+)\.?(\d*)/)?.[0] || '0';
|
|
return getVer(b).localeCompare(getVer(a), undefined, { numeric: true });
|
|
})[0];
|
|
|
|
if (sdks.length > 1) {
|
|
console.warn(`Multiple SDKs found - using ${sdkToUse}`);
|
|
}
|
|
|
|
platformFlags.push(`-isysroot ${path.resolve(sdkPath, sdkToUse)}`);
|
|
}
|
|
|
|
const cflags = [
|
|
'-Wno-trigraphs',
|
|
'-fPIC',
|
|
...platformFlags
|
|
].join(' ');
|
|
|
|
const cxxflags = [
|
|
'-std=c++20',
|
|
'-Wno-trigraphs',
|
|
'-fno-exceptions',
|
|
'-fno-rtti',
|
|
'-nostdinc++',
|
|
`-isystem "${path.resolve(BASE, 'buildtools', 'third_party', 'libc++')}"`,
|
|
`-isystem "${path.resolve(BASE, 'third_party', 'libc++', 'src', 'include')}"`,
|
|
`-isystem "${path.resolve(BASE, 'third_party', 'libc++abi', 'src', 'include')}"`,
|
|
' -fvisibility-inlines-hidden',
|
|
'-fPIC',
|
|
'-D_LIBCPP_ABI_NAMESPACE=Cr',
|
|
'-D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE',
|
|
...platformFlags
|
|
].join(' ');
|
|
|
|
const ldflags = [
|
|
'-stdlib=libc++',
|
|
'-fuse-ld=lld',
|
|
`-L"${path.resolve(BASE, 'out', outDir, 'obj', 'buildtools', 'third_party', 'libc++abi')}"`,
|
|
`-L"${path.resolve(BASE, 'out', outDir, 'obj', 'buildtools', 'third_party', 'libc++')}"`,
|
|
'-lc++abi',
|
|
...platformFlags
|
|
].join(' ');
|
|
|
|
if (process.platform !== 'win32') {
|
|
env.CC = cc;
|
|
env.CFLAGS = cflags;
|
|
env.CXX = cxx;
|
|
env.CXXFLAGS = cxxflags;
|
|
env.LD = ld;
|
|
env.LDFLAGS = ldflags;
|
|
}
|
|
|
|
const { status: installStatus, signal: installSignal } = cp.spawnSync(process.execPath, [YARN_SCRIPT_PATH, 'install'], {
|
|
env,
|
|
cwd: NAN_DIR,
|
|
stdio: 'inherit'
|
|
});
|
|
if (installStatus !== 0 || installSignal != null) {
|
|
console.error('Failed to install nan node_modules');
|
|
return process.exit(installStatus !== 0 ? installStatus : installSignal);
|
|
}
|
|
|
|
const { status: buildStatus, signal } = cp.spawnSync(process.execPath, [NODE_GYP_BIN, 'rebuild', '--verbose', '--directory', 'test', '-j', 'max'], {
|
|
env,
|
|
cwd: NAN_DIR,
|
|
stdio: 'inherit'
|
|
});
|
|
if (buildStatus !== 0 || signal != null) {
|
|
console.error('Failed to build nan test modules');
|
|
return process.exit(buildStatus !== 0 ? buildStatus : signal);
|
|
}
|
|
|
|
const onlyTests = args.only?.split(',');
|
|
|
|
const DISABLED_TESTS = new Set([
|
|
'nannew-test.js',
|
|
'buffer-test.js'
|
|
]);
|
|
const testsToRun = fs.readdirSync(path.resolve(NAN_DIR, 'test', 'js'))
|
|
.filter(test => !DISABLED_TESTS.has(test))
|
|
.filter(test => {
|
|
return !onlyTests || onlyTests.includes(test) || onlyTests.includes(test.replace('.js', '')) || onlyTests.includes(test.replace('-test.js', ''));
|
|
})
|
|
.map(test => `test/js/${test}`);
|
|
|
|
const testChild = cp.spawn(utils.getAbsoluteElectronExec(), ['node_modules/.bin/tap', ...testsToRun], {
|
|
env: {
|
|
...process.env,
|
|
ELECTRON_RUN_AS_NODE: 'true'
|
|
},
|
|
cwd: NAN_DIR,
|
|
stdio: 'inherit'
|
|
});
|
|
testChild.on('exit', (testCode) => {
|
|
process.exit(testCode);
|
|
});
|
|
}
|
|
|
|
main().catch((err) => {
|
|
console.error('An unhandled error occurred in the nan spec runner', err);
|
|
process.exit(1);
|
|
});
|