mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
66fa1f4665
* chore: bump node in DEPS to v20.17.0 * module: disallow CJS <-> ESM edges in a cycle from require(esm) https://github.com/nodejs/node/pull/52264 * src: expose LookupAndCompile with parameters https://github.com/nodejs/node/pull/53886 * src: fix -Wshadow warning https://github.com/nodejs/node/pull/53885 * lib: convert WeakMaps in cjs loader with symbol properties https://github.com/nodejs/node/pull/52095 * src: reduce unnecessary serialization of CLI options in C++ https://github.com/nodejs/node/pull/52451 * build: ensure v8_pointer_compression_sandbox is enabled on 64bit https://github.com/nodejs/node/pull/53884 * lib: improve error message when index not found on cjs https://github.com/nodejs/node/pull/53859 * src,lib: expose getCategoryEnabledBuffer to use on node.http https://github.com/nodejs/node/pull/53602 * deps: update c-ares to v1.32.2 https://github.com/nodejs/node/pull/53865 * chore: update patch indices * deps: update V8 to 12.2 https://github.com/nodejs/node/pull/51362 * stream: Expose DuplexPair API https://github.com/nodejs/node/pull/34111 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
26 lines
1.1 KiB
Diff
26 lines
1.1 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Shelley Vohr <shelley.vohr@gmail.com>
|
|
Date: Sun, 10 Mar 2024 16:59:30 +0100
|
|
Subject: Deprecate vector<v8::Local> in v8
|
|
|
|
Adapts for changes in https://chromium-review.googlesource.com/c/v8/v8/+/4866222.
|
|
|
|
This patch can be removed when Electron upgrades to a version of Node.js that
|
|
contains the above CL.
|
|
|
|
diff --git a/src/module_wrap.cc b/src/module_wrap.cc
|
|
index e862b51293135995c527c32aa3c3579780d7831c..ff658ec88e5161cd66536ee6e95dba675b16eccc 100644
|
|
--- a/src/module_wrap.cc
|
|
+++ b/src/module_wrap.cc
|
|
@@ -186,7 +186,9 @@ void ModuleWrap::New(const FunctionCallbackInfo<Value>& args) {
|
|
export_names[i] = export_name_val.As<String>();
|
|
}
|
|
|
|
- module = Module::CreateSyntheticModule(isolate, url, export_names,
|
|
+
|
|
+ module = Module::CreateSyntheticModule(isolate, url,
|
|
+ v8::MemorySpan<const Local<String>>(export_names.begin(), export_names.end()),
|
|
SyntheticModuleEvaluationStepsCallback);
|
|
} else {
|
|
ScriptCompiler::CachedData* cached_data = nullptr;
|