mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
9c3f76f617
fix: authenticate curl requests to googlesource in lint workflow The "Download GN Binary" and "Download clang-format Binary" steps fetch files from chromium.googlesource.com without passing authentication cookies. When googlesource rate-limits or returns a transient error (502), the HTML error page is piped into `base64 -d`, causing `base64: invalid input`. The `set-chromium-cookie` action already configures `~/.gitcookies` in a prior step. Pass `-b ~/.gitcookies` to both `curl` calls so they authenticate, matching what the cookie verification step itself does. Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
95 lines
3.6 KiB
YAML
95 lines
3.6 KiB
YAML
name: Electron Lint
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
container:
|
|
required: true
|
|
description: 'Container to run lint in'
|
|
type: string
|
|
|
|
permissions: {}
|
|
|
|
concurrency:
|
|
group: electron-lint-${{ github.ref_protected == true && github.run_id || github.ref }}
|
|
cancel-in-progress: ${{ github.ref_protected != true }}
|
|
|
|
env:
|
|
CHROMIUM_GIT_COOKIE: ${{ secrets.CHROMIUM_GIT_COOKIE }}
|
|
|
|
jobs:
|
|
lint:
|
|
name: Lint
|
|
runs-on: electron-arc-centralus-linux-amd64-4core
|
|
permissions:
|
|
contents: read
|
|
timeout-minutes: 20
|
|
container: ${{ fromJSON(inputs.container) }}
|
|
steps:
|
|
- name: Checkout Electron
|
|
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8
|
|
with:
|
|
path: src/electron
|
|
fetch-depth: 0
|
|
ref: ${{ github.event.pull_request.head.sha }}
|
|
- name: Install Dependencies
|
|
uses: ./src/electron/.github/actions/install-dependencies
|
|
- name: Set Chromium Git Cookie
|
|
uses: ./src/electron/.github/actions/set-chromium-cookie
|
|
- name: Setup third_party Depot Tools
|
|
shell: bash
|
|
run: |
|
|
# "depot_tools" has to be checkout into "//third_party/depot_tools" so pylint.py can a "pylintrc" file.
|
|
git clone --filter=tree:0 https://chromium.googlesource.com/chromium/tools/depot_tools.git src/third_party/depot_tools
|
|
echo "$(pwd)/src/third_party/depot_tools" >> $GITHUB_PATH
|
|
- name: Download GN Binary
|
|
shell: bash
|
|
run: |
|
|
chromium_revision="$(grep -A1 chromium_version src/electron/DEPS | tr -d '\n' | cut -d\' -f4)"
|
|
gn_version="$(curl -sL -b ~/.gitcookies "https://chromium.googlesource.com/chromium/src/+/${chromium_revision}/DEPS?format=TEXT" | base64 -d | grep gn_version | head -n1 | cut -d\' -f4)"
|
|
|
|
cipd ensure -ensure-file - -root . <<-CIPD
|
|
\$ServiceURL https://chrome-infra-packages.appspot.com/
|
|
@Subdir src/buildtools/linux64
|
|
gn/gn/linux-amd64 $gn_version
|
|
CIPD
|
|
|
|
buildtools_path="$(pwd)/src/buildtools"
|
|
echo "CHROMIUM_BUILDTOOLS_PATH=$buildtools_path" >> $GITHUB_ENV
|
|
- name: Download clang-format Binary
|
|
shell: bash
|
|
run: |
|
|
chromium_revision="$(grep -A1 chromium_version src/electron/DEPS | tr -d '\n' | cut -d\' -f4)"
|
|
|
|
mkdir -p src/buildtools
|
|
curl -sL -b ~/.gitcookies "https://chromium.googlesource.com/chromium/src/+/${chromium_revision}/buildtools/DEPS?format=TEXT" | base64 -d > src/buildtools/DEPS
|
|
|
|
gclient sync --spec="solutions=[{'name':'src/buildtools','url':None,'deps_file':'DEPS','custom_vars':{'process_deps':True},'managed':False}]"
|
|
- name: Add problem matchers
|
|
shell: bash
|
|
run: |
|
|
echo "::add-matcher::src/electron/.github/problem-matchers/eslint-stylish.json"
|
|
echo "::add-matcher::src/electron/.github/problem-matchers/markdownlint.json"
|
|
- name: Run Lint
|
|
shell: bash
|
|
run: |
|
|
# gn.py tries to find a gclient root folder starting from the current dir.
|
|
# When it fails and returns "None" path, the whole script fails. Let's "fix" it.
|
|
touch .gclient
|
|
# Another option would be to checkout "buildtools" inside the Electron checkout,
|
|
# but then we would lint its contents (at least gn format), and it doesn't pass it.
|
|
|
|
cd src/electron
|
|
node script/yarn.js install --immutable
|
|
node script/yarn.js lint
|
|
- name: Run Script Typechecker
|
|
shell: bash
|
|
run: |
|
|
cd src/electron
|
|
node script/yarn.js tsc -p tsconfig.script.json
|
|
- name: Check GHA Workflows
|
|
shell: bash
|
|
run: |
|
|
cd src/electron
|
|
node script/copy-pipeline-segment-publish.js --check
|