mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
a086fc7b96
refactor: improve input handling in file_path_converter Properly handle paths containing ASCII control characters in the FilePath gin converter Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <vertedinde@electronjs.org>
51 lines
1.5 KiB
C++
51 lines
1.5 KiB
C++
// Copyright (c) 2019 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef ELECTRON_SHELL_COMMON_GIN_CONVERTERS_FILE_PATH_CONVERTER_H_
|
|
#define ELECTRON_SHELL_COMMON_GIN_CONVERTERS_FILE_PATH_CONVERTER_H_
|
|
|
|
#include <algorithm>
|
|
|
|
#include "base/files/file_path.h"
|
|
#include "gin/converter.h"
|
|
#include "shell/common/gin_converters/std_converter.h"
|
|
|
|
namespace gin {
|
|
|
|
template <>
|
|
struct Converter<base::FilePath> {
|
|
static v8::Local<v8::Value> ToV8(v8::Isolate* isolate,
|
|
const base::FilePath& val) {
|
|
return Converter<base::FilePath::StringType>::ToV8(isolate, val.value());
|
|
}
|
|
static bool FromV8(v8::Isolate* isolate,
|
|
v8::Local<v8::Value> val,
|
|
base::FilePath* out) {
|
|
if (val->IsNull())
|
|
return true;
|
|
|
|
if (val->IsString() && v8::Local<v8::String>::Cast(val)->Length() == 0) {
|
|
*out = {};
|
|
return true;
|
|
}
|
|
|
|
base::FilePath::StringType path;
|
|
if (Converter<base::FilePath::StringType>::FromV8(isolate, val, &path)) {
|
|
bool has_control_chars = std::any_of(
|
|
path.begin(), path.end(),
|
|
[](base::FilePath::CharType c) { return c >= 0 && c < 0x20; });
|
|
if (has_control_chars)
|
|
return false;
|
|
*out = base::FilePath(path);
|
|
return true;
|
|
} else {
|
|
return false;
|
|
}
|
|
}
|
|
};
|
|
|
|
} // namespace gin
|
|
|
|
#endif // ELECTRON_SHELL_COMMON_GIN_CONVERTERS_FILE_PATH_CONVERTER_H_
|