mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
ad4dc5045f
* chore: bump chromium in DEPS to 148.0.7749.1
* chore: bump chromium in DEPS to 148.0.7751.1
* chore: bump chromium in DEPS to 148.0.7753.1
* chore: bump chromium in DEPS to 148.0.7755.1
* chore: bump chromium to 148.0.7751.0 (main) (#50427)
* chore: bump chromium in DEPS to 148.0.7749.0
* chore: bump chromium in DEPS to 148.0.7751.0
* chore: update patches
* 7681299: Introduce OccludedWidgetInputProtector to track always-on-top widgets
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7681299
* 7685453: chrome://accessibility: Don't AllowJavascript() in async calls
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7685453
* 7665878: Prefer browser runtime over Node.js in HostRuntime detection
Refs https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7665878
* 7674037: Rename the bookmark-related interfaces of the Clipboard class to URL.
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7674037
* 7621713: Migrate ServiceWorker framework to ChildProcessId
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7621713
* 7680500: Migrate ServiceWorkerHost to ChildProcessId
Refs https://chromium-review.googlesource.com/c/chromium/src/+/7680500
* chore: update roller commit message lint script to handle devtools CLs
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
(cherry picked from commit c44d60cfe4)
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
29 lines
1.5 KiB
Diff
29 lines
1.5 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Charles Kerr <charles@charleskerr.com>
|
|
Date: Sat, 28 Sep 2024 17:33:51 -0500
|
|
Subject: chore: partial revert of
|
|
https://chromium-review.googlesource.com/c/chromium/src/+/5894233
|
|
|
|
The `CHECK_EQ()` being removed here is failing in the Chromium roll.
|
|
I experimented with backporting the `CHECK_EQ()` to `main` and it's
|
|
failing there as well, so some pre-existing behavior in Electron is
|
|
incompatible with this assertion.
|
|
|
|
I will file an upgrades-followup-task issue in Electron and try to
|
|
track down the source of this problem & figure out if we can fix it
|
|
by changing something in Electron.
|
|
|
|
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
|
|
index 6838e858c78b1c12d352860186ee2a75bbed2ad8..e770df76c913bfb126d8e9ecd2eb8548b9bfb2f9 100644
|
|
--- a/content/browser/web_contents/web_contents_impl.cc
|
|
+++ b/content/browser/web_contents/web_contents_impl.cc
|
|
@@ -5458,7 +5458,7 @@ FrameTree* WebContentsImpl::CreateNewWindow(
|
|
: IsGuest();
|
|
// While some guest types do not have a guest SiteInstance, the ones that
|
|
// don't all override WebContents creation above.
|
|
- CHECK_EQ(source_site_instance->GetSecurityPrincipal().IsGuest(), is_guest);
|
|
+ // CHECK_EQ(source_site_instance->GetSecurityPrincipal().IsGuest(), is_guest);
|
|
|
|
// We usually create the new window in the same BrowsingInstance (group of
|
|
// script-related windows), by passing in the current SiteInstance. However,
|