mirror of
https://github.com/electron/electron.git
synced 2026-01-08 23:18:06 -05:00
39cca586f6
* refactor: avoid redundant GetIsolate() calls in NodeBindings::CreateEnvironment() Xref: https://chromium-review.googlesource.com/c/v8/v8/+/6563615 * refactor: use v8::Isolate::GetCurrent() in Initialize() methods * refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment() * fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods * refactor: add v8::Isolate* arg to RendererClientBase::DidCreateScriptContext() * fixup! refactor: add v8::Isolate* arg to NodeBindings::CreateEnvironment() * fixup! fixup! refactor: use v8::Isolate::GetCurrent() in Initialize() methods refactor: prefer JavascriptEnvironment::GetIsolate() in the browser layer
47 lines
1.4 KiB
C++
47 lines
1.4 KiB
C++
// Copyright (c) 2020 Slack Technologies, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "electron/mas.h"
|
|
#include "shell/common/gin_helper/dictionary.h"
|
|
#include "shell/common/node_includes.h"
|
|
|
|
#if !IS_MAS_BUILD()
|
|
#include "shell/common/crash_keys.h"
|
|
#endif
|
|
|
|
namespace {
|
|
|
|
v8::Local<v8::Value> GetParameters(v8::Isolate* isolate) {
|
|
std::map<std::string, std::string> keys;
|
|
#if !IS_MAS_BUILD()
|
|
electron::crash_keys::GetCrashKeys(&keys);
|
|
#endif
|
|
return gin::ConvertToV8(isolate, keys);
|
|
}
|
|
|
|
#if IS_MAS_BUILD()
|
|
void SetCrashKeyStub(const std::string& key, const std::string& value) {}
|
|
void ClearCrashKeyStub(const std::string& key) {}
|
|
#endif
|
|
|
|
void Initialize(v8::Local<v8::Object> exports,
|
|
v8::Local<v8::Value> unused,
|
|
v8::Local<v8::Context> context,
|
|
void* priv) {
|
|
v8::Isolate* const isolate = v8::Isolate::GetCurrent();
|
|
gin_helper::Dictionary dict{isolate, exports};
|
|
#if IS_MAS_BUILD()
|
|
dict.SetMethod("addExtraParameter", &SetCrashKeyStub);
|
|
dict.SetMethod("removeExtraParameter", &ClearCrashKeyStub);
|
|
#else
|
|
dict.SetMethod("addExtraParameter", &electron::crash_keys::SetCrashKey);
|
|
dict.SetMethod("removeExtraParameter", &electron::crash_keys::ClearCrashKey);
|
|
#endif
|
|
dict.SetMethod("getParameters", &GetParameters);
|
|
}
|
|
|
|
} // namespace
|
|
|
|
NODE_LINKED_BINDING_CONTEXT_AWARE(electron_renderer_crash_reporter, Initialize)
|