mirror of
https://github.com/electron/electron.git
synced 2026-01-09 15:38:08 -05:00
863faea542
* chore: bump node in DEPS to v22.11.0 * src: move evp stuff to ncrypto https://github.com/nodejs/node/pull/54911 * crypto: add Date fields for validTo and validFrom https://github.com/nodejs/node/pull/54159 * module: fix discrepancy between .ts and .js https://github.com/nodejs/node/pull/54461 * esm: do not interpret "main" as a URL https://github.com/nodejs/node/pull/55003 * src: modernize likely/unlikely hints https://github.com/nodejs/node/pull/55155 * chore: update patch indices * crypto: add validFromDate and validToDate fields to X509Certificate https://github.com/nodejs/node/pull/54159 * chore: fixup perfetto patch * fix: clang warning in simdjson * src: add receiver to fast api callback methods https://github.com/nodejs/node/pull/54408 * chore: fixup revert patch * fixup! esm: do not interpret "main" as a URL * fixup! crypto: add Date fields for validTo and validFrom * fix: move ArrayBuffer test patch * src: fixup Error.stackTraceLimit during snapshot building https://github.com/nodejs/node/pull/55121 * fix: bad rebase * chore: fixup amaro * chore: address feedback from review * src: revert filesystem::path changes https://github.com/nodejs/node/pull/55015 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
26 lines
1.0 KiB
Diff
26 lines
1.0 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Shelley Vohr <shelley.vohr@gmail.com>
|
|
Date: Fri, 18 Oct 2024 17:01:06 +0200
|
|
Subject: fix: remove harmony-import-assertions from node.cc
|
|
|
|
harmony-import-assertions has been removed from V8 as of
|
|
https://chromium-review.googlesource.com/c/v8/v8/+/5507047,
|
|
so we should remove it from node.cc as well.
|
|
|
|
This patch can be removed when we upgrade to a V8 version that
|
|
contains the above CL.
|
|
|
|
diff --git a/src/node.cc b/src/node.cc
|
|
index 1a2a43bdd37441400323a800c147fcb89f0d549a..ae0b40b40e601e86d22e223a764c20106ae29d70 100644
|
|
--- a/src/node.cc
|
|
+++ b/src/node.cc
|
|
@@ -804,7 +804,7 @@ static ExitCode ProcessGlobalArgsInternal(std::vector<std::string>* args,
|
|
}
|
|
// TODO(nicolo-ribaudo): remove this once V8 doesn't enable it by default
|
|
// anymore.
|
|
- v8_args.emplace_back("--no-harmony-import-assertions");
|
|
+ // v8_args.emplace_back("--no-harmony-import-assertions");
|
|
|
|
auto env_opts = per_process::cli_options->per_isolate->per_env;
|
|
if (std::find(v8_args.begin(), v8_args.end(),
|