mirror of
https://github.com/electron/electron.git
synced 2026-05-02 03:00:22 -04:00
* build: add oxfmt for code formatting and import sorting
Adds oxfmt as a devDependency alongside oxlint and wires it into the
lint pipeline. The .oxfmtrc.json config matches Electron's current JS
style (single quotes, semicolons, 2-space indent, trailing commas off,
printWidth 100) and configures sortImports with custom groups that
mirror the import/order pathGroups previously enforced by ESLint:
@electron/internal, @electron/*, and {electron,electron/**} each get
their own ordered group ahead of external modules.
- `yarn lint:fmt` runs `oxfmt --check` over JS/TS sources and is
chained into `yarn lint` so CI enforces it automatically.
- `yarn format` runs `oxfmt --write` for local fix-up.
- lint-staged invokes `oxfmt --write` on staged .js/.ts/.mjs/.cjs
files before oxlint, so formatting is applied at commit time.
The next commit applies the formatter to the existing codebase so the
check actually passes.
* chore: apply oxfmt formatting to JS and TS sources
Runs `yarn format` across lib/, spec/, script/, build/, default_app/,
and npm/ to bring the codebase in line with the .oxfmtrc.json settings
added in the previous commit. This is a pure formatting pass: import
statements are sorted into the groups defined by the config, method
chains longer than printWidth are broken, single-quoted strings
containing apostrophes are switched to double quotes, and a handful of
single-statement `if` bodies are re-wrapped and get braces added by
`oxlint --fix` to satisfy the `curly: multi-line` rule.
No behavior changes.
117 lines
3.5 KiB
TypeScript
117 lines
3.5 KiB
TypeScript
import { IPC_MESSAGES } from '@electron/internal//common/ipc-messages';
|
|
import { ipcMainInternal } from '@electron/internal/browser/ipc-main-internal';
|
|
import * as ipcMainUtils from '@electron/internal/browser/ipc-main-internal-utils';
|
|
|
|
import { dialog, Menu } from 'electron/main';
|
|
|
|
import * as fs from 'fs';
|
|
|
|
const convertToMenuTemplate = function (items: ContextMenuItem[], handler: (id: number) => void) {
|
|
return items.map(function (item) {
|
|
const transformed: Electron.MenuItemConstructorOptions =
|
|
item.type === 'subMenu'
|
|
? {
|
|
type: 'submenu',
|
|
label: item.label,
|
|
enabled: item.enabled,
|
|
submenu: convertToMenuTemplate(item.subItems, handler)
|
|
}
|
|
: item.type === 'separator'
|
|
? {
|
|
type: 'separator'
|
|
}
|
|
: item.type === 'checkbox'
|
|
? {
|
|
type: 'checkbox',
|
|
label: item.label,
|
|
enabled: item.enabled,
|
|
checked: item.checked
|
|
}
|
|
: {
|
|
type: 'normal',
|
|
label: item.label,
|
|
enabled: item.enabled
|
|
};
|
|
|
|
if (item.id != null) {
|
|
transformed.click = () => handler(item.id);
|
|
}
|
|
|
|
return transformed;
|
|
});
|
|
};
|
|
|
|
const getEditMenuItems = function (): Electron.MenuItemConstructorOptions[] {
|
|
return [
|
|
{ role: 'undo' },
|
|
{ role: 'redo' },
|
|
{ type: 'separator' },
|
|
{ role: 'cut' },
|
|
{ role: 'copy' },
|
|
{ role: 'paste' },
|
|
{ role: 'pasteAndMatchStyle' },
|
|
{ role: 'delete' },
|
|
{ role: 'selectAll' }
|
|
];
|
|
};
|
|
|
|
const isChromeDevTools = function (pageURL: string) {
|
|
const { protocol } = new URL(pageURL);
|
|
return protocol === 'devtools:';
|
|
};
|
|
|
|
const assertChromeDevTools = function (contents: Electron.WebContents, api: string) {
|
|
const pageURL = contents.getURL();
|
|
if (!isChromeDevTools(pageURL)) {
|
|
console.error(`Blocked ${pageURL} from calling ${api}`);
|
|
throw new Error(`Blocked ${api}`);
|
|
}
|
|
};
|
|
|
|
ipcMainInternal.handle(
|
|
IPC_MESSAGES.INSPECTOR_CONTEXT_MENU,
|
|
function (event, items: ContextMenuItem[], isEditMenu: boolean) {
|
|
return new Promise<number | void>((resolve) => {
|
|
if (event.type !== 'frame') return;
|
|
assertChromeDevTools(event.sender, 'window.InspectorFrontendHost.showContextMenuAtPoint()');
|
|
|
|
const template = isEditMenu ? getEditMenuItems() : convertToMenuTemplate(items, resolve);
|
|
const menu = Menu.buildFromTemplate(template);
|
|
const window = event.sender.getOwnerBrowserWindow()!;
|
|
|
|
menu.popup({ window, callback: () => resolve() });
|
|
});
|
|
}
|
|
);
|
|
|
|
ipcMainInternal.handle(IPC_MESSAGES.INSPECTOR_SELECT_FILE, async function (event) {
|
|
if (event.type !== 'frame') return [];
|
|
assertChromeDevTools(event.sender, 'window.UI.createFileSelectorElement()');
|
|
|
|
const result = await dialog.showOpenDialog({});
|
|
if (result.canceled) return [];
|
|
|
|
const path = result.filePaths[0];
|
|
const data = await fs.promises.readFile(path);
|
|
|
|
return [path, data];
|
|
});
|
|
|
|
ipcMainUtils.handleSync(
|
|
IPC_MESSAGES.INSPECTOR_CONFIRM,
|
|
async function (event, message: string = '', title: string = '') {
|
|
if (event.type !== 'frame') return;
|
|
assertChromeDevTools(event.sender, 'window.confirm()');
|
|
|
|
const options = {
|
|
message: String(message),
|
|
title: String(title),
|
|
buttons: ['OK', 'Cancel'],
|
|
cancelId: 1
|
|
};
|
|
const window = event.sender.getOwnerBrowserWindow()!;
|
|
const { response } = await dialog.showMessageBox(window, options);
|
|
return response === 0;
|
|
}
|
|
);
|