mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
31 lines
1.5 KiB
Diff
31 lines
1.5 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Jeremy Rose <japthorp@slack-corp.com>
|
|
Date: Mon, 20 Jun 2022 14:53:37 -0700
|
|
Subject: disable freezing flags after init in node
|
|
|
|
This was introduced in
|
|
https://chromium-review.googlesource.com/c/chromium/src/+/3687671.
|
|
|
|
When running node in the renderer, flags are updated after initialization, so
|
|
freezing the flags in Blink causes node initialization to fail.
|
|
|
|
If possible, it would be ideal to do this without a patch.
|
|
https://bugs.chromium.org/p/v8/issues/detail?id=12887 suggests that there may
|
|
at some point be an API to "unfreeze" the flags, or we may be able to refactor
|
|
node initialization to not update flags after V8 initialization.
|
|
|
|
diff --git a/content/renderer/render_process_impl.cc b/content/renderer/render_process_impl.cc
|
|
index 69f5528f0f6f3bfe6dab949b26dee9276aa115c6..81d637e84ef11681146beee74b1d27b23b16f11d 100644
|
|
--- a/content/renderer/render_process_impl.cc
|
|
+++ b/content/renderer/render_process_impl.cc
|
|
@@ -241,6 +241,9 @@ RenderProcessImpl::RenderProcessImpl()
|
|
SetV8FlagIfNotFeature(features::kWebAssemblyDynamicTiering,
|
|
"--no-wasm-dynamic-tiering");
|
|
|
|
+ // Freezing flags after init conflicts with node in the renderer.
|
|
+ v8::V8::SetFlagsFromString("--no-freeze-flags-after-init");
|
|
+
|
|
#if (BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_CHROMEOS)) && defined(ARCH_CPU_X86_64)
|
|
if (base::FeatureList::IsEnabled(features::kWebAssemblyTrapHandler)) {
|
|
if (command_line->HasSwitch(switches::kEnableCrashpad) ||
|