trop[bot] 90decd4eaf fix: add missing HandleScope in contentTracing.getTraceBufferUsage() (#50594) ...

The `OnTraceBufferUsageAvailable` callback creates V8 handles via
`Dictionary::CreateEmpty()` before `promise.Resolve()` enters its
`SettleScope` (which provides a `HandleScope`). When the callback
fires asynchronously from a Mojo response (i.e. when a trace session
is active), there is no `HandleScope` on the stack, causing a fatal
V8 error: "Cannot create a handle without a HandleScope".

Add an explicit `v8::HandleScope` at the top of the callback, matching
the pattern used by the other contentTracing APIs which resolve their
promises through `SettleScope` or the static `ResolvePromise` helper.

Made-with: Cursor

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Alexey Kozy <alexey@anysphere.co>

2026-03-31 10:15:13 +02:00

..

views

refactor: remove gin_helper::Arguments (#48374)

2025-10-03 14:10:29 -05:00

electron_api_app_mac.mm

refactor: DRY in App::SetAppLogPath() (#48452)

2025-10-05 12:32:28 -05:00

electron_api_app_mas.mm

chore: bump chromium to 117.0.5923.0 (main) (#39304)

2023-08-04 10:47:29 +02:00

electron_api_app.cc

feat: improve Windows Toast actions support (#49787)

2026-02-18 13:23:53 -05:00

electron_api_app.h

feat: improve Windows Toast actions support (#49787)

2026-02-18 13:23:53 -05:00

electron_api_auto_updater.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_auto_updater.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_base_window_mac.mm

fix: explicitly call GetNativeNSView() on macOS (#46733)

2025-04-23 17:55:18 -05:00

electron_api_base_window.cc

fix: correctly track BaseWindow::IsActive() on MacOS (#50340)

2026-03-18 17:11:46 -04:00

electron_api_base_window.h

fix: correctly track BaseWindow::IsActive() on MacOS (#50340)

2026-03-18 17:11:46 -04:00

electron_api_browser_window.cc

fix: ensure WebContents::WasShown runs when window is shown (#50343)

2026-03-18 14:53:09 -04:00

electron_api_browser_window.h

fix: ensure WebContents::WasShown runs when window is shown (#50343)

2026-03-18 14:53:09 -04:00

electron_api_content_tracing.cc

fix: add missing HandleScope in contentTracing.getTraceBufferUsage() (#50594)

2026-03-31 10:15:13 +02:00

electron_api_cookies.cc

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_cookies.h

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_crash_reporter.cc

refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) (#47760)

2025-07-21 16:34:38 +02:00

electron_api_crash_reporter.h

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

electron_api_data_pipe_holder.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_data_pipe_holder.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_debugger.cc

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_debugger.h

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_desktop_capturer_mac.mm

feat: add support for system picker in setDisplayMediaRequestHandler (#43581)

2024-09-10 16:05:57 -07:00

electron_api_desktop_capturer.cc

chore: bump chromium to 146.0.7680.16 (41-x-y) (#49838)

2026-02-20 14:30:11 -05:00

electron_api_desktop_capturer.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_dialog.cc

refactor: narrow or remove gin arguments (#48300)

2025-09-13 08:19:07 +09:00

electron_api_download_item.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_download_item.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_event_emitter.cc

refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) (#47760)

2025-07-21 16:34:38 +02:00

electron_api_event_emitter.h

chore: add ELECTRON_ prefix to C++ include guards (#31925)

2021-11-22 16:34:31 +09:00

electron_api_extensions.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_extensions.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_global_shortcut.cc

fix: better shortcut registration and app icon matching on Wayland (#50051)

2026-03-04 16:43:44 +01:00

electron_api_global_shortcut.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_in_app_purchase.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_in_app_purchase.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_menu_mac.h

refactor: make api::Menu inherit from gin::Wrappable (#48351)

2025-09-24 19:42:22 -05:00

electron_api_menu_mac.mm

fix: menu close event missing after opening a submenu (#49964)

2026-02-26 16:55:19 -05:00

electron_api_menu_views.cc

refactor: remove base::AdaptCallbackForRepeating patch (#48774)

2025-11-05 11:00:51 -08:00

electron_api_menu_views.h

feat: add support for associating a Menu with a WebFrameMain (#45138)

2025-03-28 11:50:07 -07:00

electron_api_menu.cc

fix: update label/sublabel/icon in MenuItems on open (#49972)

2026-03-02 12:50:39 +01:00

electron_api_menu.h

fix: update label/sublabel/icon in MenuItems on open (#49972)

2026-03-02 12:50:39 +01:00

electron_api_msix_updater.cc

refactor: use ComPtr pattern for MSIX to avoid exception handling (#49686)

2026-02-05 13:09:20 -08:00

electron_api_msix_updater.h

feat: msix auto-updater (#49586)

2026-02-02 14:21:40 +01:00

electron_api_native_theme_mac.mm

feat: add accessibilityDisplayShouldDifferentiateWithoutColor on macOS (#50408)

2026-03-25 15:53:31 -04:00

electron_api_native_theme.cc

feat: add accessibilityDisplayShouldDifferentiateWithoutColor on macOS (#50408)

2026-03-25 15:53:31 -04:00

electron_api_native_theme.h

feat: add accessibilityDisplayShouldDifferentiateWithoutColor on macOS (#50408)

2026-03-25 15:53:31 -04:00

electron_api_net_log.cc

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_net_log.h

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_notification.cc

feat: show toast dismissal reason on Windows (#50029)

2026-03-05 11:29:27 +01:00

electron_api_notification.h

feat: show toast dismissal reason on Windows (#50029)

2026-03-05 11:29:27 +01:00

electron_api_power_monitor_mac.mm

fix: prevent use-after-free in PowerMonitor via dangling OS callbacks (#50087)

2026-03-05 15:24:12 -05:00

electron_api_power_monitor_win.cc

fix: prevent use-after-free in PowerMonitor via dangling OS callbacks (#50087)

2026-03-05 15:24:12 -05:00

electron_api_power_monitor.cc

fix: prevent use-after-free in PowerMonitor via dangling OS callbacks (#50087)

2026-03-05 15:24:12 -05:00

electron_api_power_monitor.h

fix: prevent use-after-free in PowerMonitor via dangling OS callbacks (#50087)

2026-03-05 15:24:12 -05:00

electron_api_power_save_blocker.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_power_save_blocker.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_printing.cc

refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) (#47760)

2025-07-21 16:34:38 +02:00

electron_api_protocol.cc

chore: bump chromium to 146.0.7645.0 (41-x-y) (#49497)

2026-01-26 11:58:09 +01:00

electron_api_protocol.h

chore: bump chromium to 142.0.7417.0 (main) (#48275)

2025-09-22 20:16:27 -07:00

electron_api_push_notifications_mac.mm

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_push_notifications.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_push_notifications.h

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_safe_storage.cc

refactor: avoid deprecated v8::Context::GetIsolate() calls (pt 1) (#47760)

2025-07-21 16:34:38 +02:00

electron_api_screen.cc

fix: screen.getCursorScreenPoint() crash on Wayland (#50105)

2026-03-08 19:20:34 +01:00

electron_api_screen.h

chore: move gin::DeprecatedWrappable to gin_helper (#47958)

2025-08-04 23:28:01 +09:00

electron_api_service_worker_context.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_service_worker_context.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_service_worker_main.cc

chore: bump chromium to 144.0.7512.1 (main) (#48768)

2025-11-07 10:13:45 -05:00

electron_api_service_worker_main.h

refactor: avoid unused inheritance in ServiceWorkerMain (#48279)

2025-09-10 11:16:35 -05:00

electron_api_session.cc

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_session.h

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_system_preferences_mac.mm

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_system_preferences_win.cc

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_system_preferences.cc

feat: Add getAccentColor on Linux (#48027)

2025-10-21 14:26:30 -04:00

electron_api_system_preferences.h

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_tray.cc

feat: allow macOS tray to maintain position (#47838)

2025-08-07 19:25:50 +02:00

electron_api_tray.h

feat: allow macOS tray to maintain position (#47838)

2025-08-07 19:25:50 +02:00

electron_api_utility_process.cc

fix: correct utility process exit code on Windows (#50386)

2026-03-19 18:48:27 -07:00

electron_api_utility_process.h

fix: correct utility process exit code on Windows (#50386)

2026-03-19 18:48:27 -07:00

electron_api_view.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_view.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_web_contents_impl.cc

chore: bump chromium to 131.0.6734.0 (main) (#43769)

2024-09-25 06:19:39 -05:00

electron_api_web_contents_mac.mm

chore: remove WebContents.getNativeView() (#46734)

2025-04-23 20:33:50 -05:00

electron_api_web_contents_view.cc

fix: uaf in non-client hittest during view teardown (#50055)

2026-03-03 14:15:36 -05:00

electron_api_web_contents_view.h

fix: prevent crash on Windows when closing child windows (#49929)

2026-02-24 17:18:21 -05:00

electron_api_web_contents.cc

feat: WebContents.getOrCreateDevToolsTargetId() (#50176)

2026-03-10 12:22:32 -04:00

electron_api_web_contents.h

feat: WebContents.getOrCreateDevToolsTargetId() (#50176)

2026-03-10 12:22:32 -04:00

electron_api_web_frame_main.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_web_frame_main.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

electron_api_web_request.cc

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

electron_api_web_request.h

refactor: make api::WebRequest inherit from gin::Wrappable (#48762)

2025-11-12 12:53:00 -06:00

electron_api_web_view_manager.cc

chore: bump chromium to 143.0.7489.0 (main) (#48642)

2025-10-23 16:28:51 -04:00

frame_subscriber.cc

chore: bump chromium to 141.0.7390.7 (main) (#48212)

2025-09-08 12:57:15 +02:00

frame_subscriber.h

chore: bump chromium to 142.0.7417.0 (main) (#48275)

2025-09-22 20:16:27 -07:00

gpu_info_enumerator.cc

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

gpu_info_enumerator.h

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

gpuinfo_manager.cc

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

gpuinfo_manager.h

chore: bump chromium to 146.0.7666.0 (41-x-y) (#49543)

2026-02-17 16:19:16 -05:00

ipc_dispatcher.h

refactor: allocate gin_helper::internal::Event on cpp heap (#48161)

2025-08-27 09:30:50 +09:00

message_port.cc

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

message_port.h

chore: move gin::Handle to gin_helper (#47959)

2025-08-05 02:03:06 +09:00

process_metric.cc

build: make is_mas_build a generated header instead of config (#43737)

2024-09-17 01:38:56 -07:00

process_metric.h

chore: bump chromium to 100.0.4857.0 (main) (#32419)

2022-02-09 18:58:52 -08:00

save_page_handler.cc

chore: remove more unused #include calls (#43000)

2024-07-25 11:25:45 +02:00

save_page_handler.h

chore: more iwyu (#43063)

2024-07-29 12:42:57 -05:00

ui_event.cc

chore: used nested namespaces (#34737)

2022-06-29 12:55:47 -07:00

ui_event.h

chore: used nested namespaces (#34737)

2022-06-29 12:55:47 -07:00