mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
b15392e1c1
* Fix app.makeSingleInstance hanging on posix systems Wait for the IO thread to be a thing before attempting to listen on the socket Fixes #9880 * Move OnBrowserReady call to PreMainMessageLoopRun to account for timing issues on macOS * Woops, how did that happen ;) * Refactor as per @zcbenz comments Also fix issue where we run the single instance callback *not* on the UI thread, this apparently results in a hung process. * Appease the linting gods * Create watcher when message loop is ready * spec: Add test case for app.makeSingleInstance * Fix missing extension when saving a file without filters Previously, when triggering the save dialog through e.g. `<a download>` links (e.g. http://jsfiddle.net/koldev/cW7W5/), the extension was only saved if Finder was set to show all extensions by default. We now always display the extension to make sure that it is saved. If we want to keep the extension hidden, we could also populate the allowed file types array with the extension from the default filename, but that would have interfered with how we set the filters. * Try to make test less flaky * Try simpler test * Fix stdout detection * Try longer timeout on test
79 lines
2.2 KiB
C++
79 lines
2.2 KiB
C++
// Copyright (c) 2013 GitHub, Inc.
|
|
// Use of this source code is governed by the MIT license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef ATOM_BROWSER_BROWSER_OBSERVER_H_
|
|
#define ATOM_BROWSER_BROWSER_OBSERVER_H_
|
|
|
|
#include <string>
|
|
|
|
#include "build/build_config.h"
|
|
|
|
namespace base {
|
|
class DictionaryValue;
|
|
}
|
|
|
|
namespace atom {
|
|
|
|
class LoginHandler;
|
|
|
|
class BrowserObserver {
|
|
public:
|
|
// The browser is about to close all windows.
|
|
virtual void OnBeforeQuit(bool* prevent_default) {}
|
|
|
|
// The browser has closed all windows and will quit.
|
|
virtual void OnWillQuit(bool* prevent_default) {}
|
|
|
|
// The browser has closed all windows. If the browser is quiting, then this
|
|
// method will not be called, instead it will call OnWillQuit.
|
|
virtual void OnWindowAllClosed() {}
|
|
|
|
// The browser is quitting.
|
|
virtual void OnQuit() {}
|
|
|
|
// The browser has opened a file by double clicking in Finder or dragging the
|
|
// file to the Dock icon. (macOS only)
|
|
virtual void OnOpenFile(bool* prevent_default,
|
|
const std::string& file_path) {}
|
|
|
|
// Browser is used to open a url.
|
|
virtual void OnOpenURL(const std::string& url) {}
|
|
|
|
// The browser is activated with visible/invisible windows (usually by
|
|
// clicking on the dock icon).
|
|
virtual void OnActivate(bool has_visible_windows) {}
|
|
|
|
// The browser has finished loading.
|
|
virtual void OnWillFinishLaunching() {}
|
|
virtual void OnFinishLaunching(const base::DictionaryValue& launch_info) {}
|
|
|
|
// The browser requests HTTP login.
|
|
virtual void OnLogin(LoginHandler* login_handler,
|
|
const base::DictionaryValue& request_details) {}
|
|
|
|
// The browser's accessibility suppport has changed.
|
|
virtual void OnAccessibilitySupportChanged() {}
|
|
|
|
// The app message loop is ready
|
|
virtual void OnPreMainMessageLoopRun() {}
|
|
|
|
#if defined(OS_MACOSX)
|
|
// The browser wants to resume a user activity via handoff. (macOS only)
|
|
virtual void OnContinueUserActivity(
|
|
bool* prevent_default,
|
|
const std::string& type,
|
|
const base::DictionaryValue& user_info) {}
|
|
|
|
// User clicked the native macOS new tab button. (macOS only)
|
|
virtual void OnNewWindowForTab() {}
|
|
#endif
|
|
|
|
protected:
|
|
virtual ~BrowserObserver() {}
|
|
};
|
|
|
|
} // namespace atom
|
|
|
|
#endif // ATOM_BROWSER_BROWSER_OBSERVER_H_
|