mirror of
https://github.com/electron/electron.git
synced 2026-05-02 03:00:22 -04:00
9ecc0670fe
* chore: use emplace and use it correctly Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * chore: redundant cast to the same type [google-readability-casting] Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * chore: do not create objects with +new [google-objc-avoid-nsobject-new] Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * chore: default arguments on virtual or override methods are prohibited [google-default-arguments] Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * chore: warning: C-style casts are discouraged; use static_cast [google-readability-casting] CFLocaleGetValue already returns CFTypeRef so that redundant static_cast was removed Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * chore: refactor block to avoid use after move warning from clang-tidy Looks like clang-tidy couldn't tell these were two mutually exclusive branches so there was no actual issue, but refactoring is cleaner anyway since it makes it more DRY. Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * chore: C-style casts are discouraged; use static_cast [google-readability-casting] No cast needed here, everything is already the correct type Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * chore: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting] Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * chore: use '= default' to define a trivial destructor [modernize-use-equals-default] Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * chore: use range-based for loop instead [modernize-loop-convert] Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * chore: redundant void argument list [modernize-redundant-void-arg] Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * chore: address code review feedback Co-authored-by: David Sanders <dsanders11@ucsbalum.com> * chore: use auto Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: David Sanders <dsanders11@ucsbalum.com> --------- Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: David Sanders <dsanders11@ucsbalum.com>