mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
eb7a5c2548
* chore: bump node in DEPS to v20.18.3 * src: fix outdated js2c.cc references https://github.com/nodejs/node/pull/56133 * lib: remove startsWith/endsWith primordials for char checks https://github.com/nodejs/node/pull/55407 * test,crypto: make crypto tests work with BoringSSL https://github.com/nodejs/node/pull/55491 * fix: potential WIN32_LEAN_AND_MEAN redefinition https://github.com/c-ares/c-ares/pull/869 * chore: fixup patch indices * deps: update c-ares to v1.34.1 https://github.com/nodejs/node/pull/55369 * chore: fix bssl test --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
60 lines
2.4 KiB
Diff
60 lines
2.4 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Omer Katz <omerkatz@chromium.org>
|
|
Date: Thu, 19 Sep 2024 10:50:09 +0200
|
|
Subject: cli: remove deprecated V8 flag
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Remove the `--huge-max-old-generation-size` V8 flag from the
|
|
`NODE_OPTIONS` allowlist. That flag was recently deprecated (it
|
|
currently remains as nop, see crrev.com/c/5831467) and will soon be
|
|
completely removed.
|
|
|
|
PR-URL: https://github.com/nodejs/node/pull/54761
|
|
Reviewed-By: Richard Lau <rlau@redhat.com>
|
|
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
|
Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
|
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
|
|
|
|
diff --git a/doc/api/cli.md b/doc/api/cli.md
|
|
index df7031f65d44f9abfcf43281c0d153c654269b60..d0d78beed2b02a3703bd45fdaa4291600f98d35e 100644
|
|
--- a/doc/api/cli.md
|
|
+++ b/doc/api/cli.md
|
|
@@ -2886,7 +2886,6 @@ V8 options that are allowed are:
|
|
* `--disallow-code-generation-from-strings`
|
|
* `--enable-etw-stack-walking`
|
|
* `--expose-gc`
|
|
-* `--huge-max-old-generation-size`
|
|
* `--interpreted-frames-native-stack`
|
|
* `--jitless`
|
|
* `--max-old-space-size`
|
|
diff --git a/src/node_options.cc b/src/node_options.cc
|
|
index e19b9d88a908154dbcfd0b0e3efbc7510609f810..e056e43c36de885df57fb3d9f8d76f0bdc412537 100644
|
|
--- a/src/node_options.cc
|
|
+++ b/src/node_options.cc
|
|
@@ -870,11 +870,6 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
|
|
"disallow eval and friends",
|
|
V8Option{},
|
|
kAllowedInEnvvar);
|
|
- AddOption("--huge-max-old-generation-size",
|
|
- "increase default maximum heap size on machines with 16GB memory "
|
|
- "or more",
|
|
- V8Option{},
|
|
- kAllowedInEnvvar);
|
|
AddOption("--jitless",
|
|
"disable runtime allocation of executable memory",
|
|
V8Option{},
|
|
diff --git a/test/parallel/test-cli-node-options.js b/test/parallel/test-cli-node-options.js
|
|
index 9fb6d8af0691108868a3245518edc0f0057557ab..3b9409c3af778fcfe2be0fae2cbb04753dd5c8f1 100644
|
|
--- a/test/parallel/test-cli-node-options.js
|
|
+++ b/test/parallel/test-cli-node-options.js
|
|
@@ -72,7 +72,6 @@ if (common.hasCrypto) {
|
|
expect('--abort_on-uncaught_exception', 'B\n');
|
|
expect('--disallow-code-generation-from-strings', 'B\n');
|
|
expect('--expose-gc', 'B\n');
|
|
-expect('--huge-max-old-generation-size', 'B\n');
|
|
expect('--jitless', 'B\n');
|
|
expect('--max-old-space-size=0', 'B\n');
|
|
expect('--max-semi-space-size=0', 'B\n');
|