electron

mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00

Files

trop[bot] acf615229d build: fail gha-done check when required job fails (#51067 )

fix: fail gha-done when any required job failed

Previously, the `gha-done` gate job used an `if:` expression that
evaluated to false whenever any needed job reported a failure, which
caused the job to be *skipped* rather than *failed*. GitHub branch
protection treats skipped required checks as non-blocking, so a PR
could be marked mergeable even though one of its test jobs had failed.

Keep the job always running and move the failure check into a step
that explicitly exits 1 when any dependency failed or was cancelled,
so the "GitHub Actions Completed" required check actually blocks the
merge in that case.

Notes: none

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>

2026-04-15 18:02:13 +02:00

actions

build: update build-tools to latest (#50800 )

2026-04-11 16:52:49 -04:00

ISSUE_TEMPLATE

build: extend Chromium options in bug report template (#47829 )

2025-07-21 15:26:02 -04:00

problem-matchers

ci: capture fatal errors in clang problem matcher (#50998 )

2026-04-13 14:22:59 -05:00

workflows

build: fail gha-done check when required job fails (#51067 )