mirror of
https://github.com/electron/electron.git
synced 2026-05-02 03:00:22 -04:00
* build: add oxfmt for code formatting and import sorting
Adds oxfmt as a devDependency alongside oxlint and wires it into the
lint pipeline. The .oxfmtrc.json config matches Electron's current JS
style (single quotes, semicolons, 2-space indent, trailing commas off,
printWidth 100) and configures sortImports with custom groups that
mirror the import/order pathGroups previously enforced by ESLint:
@electron/internal, @electron/*, and {electron,electron/**} each get
their own ordered group ahead of external modules.
- `yarn lint:fmt` runs `oxfmt --check` over JS/TS sources and is
chained into `yarn lint` so CI enforces it automatically.
- `yarn format` runs `oxfmt --write` for local fix-up.
- lint-staged invokes `oxfmt --write` on staged .js/.ts/.mjs/.cjs
files before oxlint, so formatting is applied at commit time.
The next commit applies the formatter to the existing codebase so the
check actually passes.
* chore: apply oxfmt formatting to JS and TS sources
Runs `yarn format` across lib/, spec/, script/, build/, default_app/,
and npm/ to bring the codebase in line with the .oxfmtrc.json settings
added in the previous commit. This is a pure formatting pass: import
statements are sorted into the groups defined by the config, method
chains longer than printWidth are broken, single-quoted strings
containing apostrophes are switched to double quotes, and a handful of
single-statement `if` bodies are re-wrapped and get braces added by
`oxlint --fix` to satisfy the `curly: multi-line` rule.
No behavior changes.
64 lines
1.9 KiB
TypeScript
64 lines
1.9 KiB
TypeScript
import { BrowserWindow } from 'electron/main';
|
|
|
|
import { expect } from 'chai';
|
|
|
|
import * as path from 'node:path';
|
|
|
|
import { defer } from './lib/spec-helpers';
|
|
|
|
// import { once } from 'node:events';
|
|
|
|
describe('webUtils module', () => {
|
|
const fixtures = path.resolve(__dirname, 'fixtures');
|
|
|
|
describe('getPathForFile', () => {
|
|
it('returns nothing for a Blob', async () => {
|
|
const w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
contextIsolation: false,
|
|
nodeIntegration: true,
|
|
sandbox: false
|
|
}
|
|
});
|
|
defer(() => w.close());
|
|
await w.loadFile(path.resolve(fixtures, 'pages', 'file-input.html'));
|
|
const pathFromWebUtils = await w.webContents.executeJavaScript(
|
|
'require("electron").webUtils.getPathForFile(new Blob([1, 2, 3]))'
|
|
);
|
|
expect(pathFromWebUtils).to.equal('');
|
|
});
|
|
|
|
it('reports the correct path for a File object', async () => {
|
|
const w = new BrowserWindow({
|
|
show: false,
|
|
webPreferences: {
|
|
contextIsolation: false,
|
|
nodeIntegration: true,
|
|
sandbox: false
|
|
}
|
|
});
|
|
defer(() => w.close());
|
|
await w.loadFile(path.resolve(fixtures, 'pages', 'file-input.html'));
|
|
const { debugger: debug } = w.webContents;
|
|
debug.attach();
|
|
try {
|
|
const {
|
|
root: { nodeId }
|
|
} = await debug.sendCommand('DOM.getDocument');
|
|
const { nodeId: inputNodeId } = await debug.sendCommand('DOM.querySelector', { nodeId, selector: 'input' });
|
|
await debug.sendCommand('DOM.setFileInputFiles', {
|
|
files: [__filename],
|
|
nodeId: inputNodeId
|
|
});
|
|
const pathFromWebUtils = await w.webContents.executeJavaScript(
|
|
'require("electron").webUtils.getPathForFile(document.querySelector("input").files[0])'
|
|
);
|
|
expect(pathFromWebUtils).to.equal(__filename);
|
|
} finally {
|
|
debug.detach();
|
|
}
|
|
});
|
|
});
|
|
});
|