Files
electron/spec/cpp-heap-spec.ts
trop[bot] 0e66d9f774 test: add cppgc backed menu leak regression test (#50882)
* spec: add menu leak regression test

Co-authored-by: deepak1556 <hop2deep@gmail.com>

* spec: reduce menu count to remove CI flakiness

Co-authored-by: deepak1556 <hop2deep@gmail.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: deepak1556 <hop2deep@gmail.com>
2026-04-10 10:40:40 -05:00

152 lines
6.2 KiB
TypeScript

import { expect } from 'chai';
import * as path from 'node:path';
import { startRemoteControlApp } from './lib/spec-helpers';
describe('cpp heap', () => {
describe('app module', () => {
it('should not allocate on every require', async () => {
const { remotely } = await startRemoteControlApp();
const [usedBefore, usedAfter] = await remotely(async () => {
const { getCppHeapStatistics } = require('node:v8');
const heapStatsBefore = getCppHeapStatistics('brief');
{
const { app } = require('electron');
console.log(app.name);
}
{
const { app } = require('electron');
console.log(app.dock);
}
const heapStatsAfter = getCppHeapStatistics('brief');
return [heapStatsBefore.used_size_bytes, heapStatsAfter.used_size_bytes];
});
expect(usedBefore).to.be.equal(usedAfter);
});
it('should record as node in heap snapshot', async () => {
const { remotely } = await startRemoteControlApp(['--expose-internals']);
const result = await remotely(async (heap: string, snapshotHelper: string) => {
const { recordState } = require(heap);
const { containsRetainingPath } = require(snapshotHelper);
const state = recordState();
return containsRetainingPath(state.snapshot, ['C++ Persistent roots', 'Electron / App']);
}, path.join(__dirname, '../../third_party/electron_node/test/common/heap'),
path.join(__dirname, 'lib', 'heapsnapshot-helpers.js'));
expect(result).to.equal(true);
});
});
describe('session module', () => {
it('should record as node in heap snapshot', async () => {
const { remotely } = await startRemoteControlApp(['--expose-internals']);
const result = await remotely(async (heap: string, snapshotHelper: string) => {
const { session, BrowserWindow } = require('electron');
const { once } = require('node:events');
const assert = require('node:assert');
const { recordState } = require(heap);
const { containsRetainingPath } = require(snapshotHelper);
const session1 = session.defaultSession;
console.log(session1.getStoragePath());
const session2 = session.fromPartition('cppheap1');
const session3 = session.fromPartition('cppheap1');
const session4 = session.fromPartition('cppheap2');
console.log(session2.cookies);
assert.strictEqual(session2, session3);
assert.notStrictEqual(session2, session4);
const w = new BrowserWindow({
show: false,
webPreferences: {
session: session.fromPartition('cppheap1')
}
});
await w.loadURL('about:blank');
const state = recordState();
const isClosed = once(w, 'closed');
w.destroy();
await isClosed;
const numSessions = containsRetainingPath(state.snapshot, ['C++ Persistent roots', 'Electron / Session'], {
occurrences: 4
});
const canTraceJSReferences = containsRetainingPath(state.snapshot, ['C++ Persistent roots', 'Electron / Session', 'Cookies']);
return numSessions && canTraceJSReferences;
}, path.join(__dirname, '../../third_party/electron_node/test/common/heap'),
path.join(__dirname, 'lib', 'heapsnapshot-helpers.js'));
expect(result).to.equal(true);
});
});
describe('menu module', () => {
// Regression test for https://github.com/electron/electron/issues/50791
it('should not leak when rebuilding application menu', async () => {
const { remotely } = await startRemoteControlApp(['--js-flags=--expose-gc']);
const result = await remotely(async () => {
const { Menu } = require('electron');
const v8Util = (process as any)._linkedBinding('electron_common_v8_util');
const { getCppHeapStatistics } = require('node:v8');
function buildLargeMenu () {
return Menu.buildFromTemplate(
Array.from({ length: 10 }, (_, i) => ({
label: `Menu ${i}`,
submenu: Array.from({ length: 20 }, (_, j) => ({
label: `Item ${i}-${j}`,
click: () => {}
}))
}))
);
}
async function rebuildAndMeasure (n: number) {
for (let i = 0; i < n; i++) {
Menu.setApplicationMenu(buildLargeMenu());
}
for (let i = 0; i < 10; i++) {
await new Promise(resolve => setTimeout(resolve, 0));
v8Util.requestGarbageCollectionForTesting();
}
return getCppHeapStatistics('brief').used_size_bytes;
}
await rebuildAndMeasure(50);
const after1 = await rebuildAndMeasure(50);
const after2 = await rebuildAndMeasure(50);
return { after1, after2 };
});
const growth = result.after2 - result.after1;
expect(growth).to.be.at.most(
result.after1 * 0.1,
`C++ heap grew by ${growth} bytes between two identical rounds of 100 menu rebuilds — likely a leak`
);
});
});
describe('internal event', () => {
it('should record as node in heap snapshot', async () => {
const { remotely } = await startRemoteControlApp(['--expose-internals']);
const result = await remotely(async (heap: string, snapshotHelper: string) => {
const { BrowserWindow } = require('electron');
const { once } = require('node:events');
const { recordState } = require(heap);
const { containsRetainingPath } = require(snapshotHelper);
const w = new BrowserWindow({
show: false
});
await w.loadURL('about:blank');
const state = recordState();
const isClosed = once(w, 'closed');
w.destroy();
await isClosed;
const eventNativeStackReference = containsRetainingPath(state.snapshot, ['C++ native stack roots', 'Electron / Event']);
const noPersistentReference = !containsRetainingPath(state.snapshot, ['C++ Persistent roots', 'Electron / Event']);
return eventNativeStackReference && noPersistentReference;
}, path.join(__dirname, '../../third_party/electron_node/test/common/heap'),
path.join(__dirname, 'lib', 'heapsnapshot-helpers.js'));
expect(result).to.equal(true);
});
});
});