mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
227cc02aee
* chore: bump chromium in DEPS to 147.0.7702.0 * chore: update patches (trivial only) Co-Authored-By: Claude (claude-3-5-sonnet, Anthropic) * chore: bump chromium in DEPS to 147.0.7703.0 * 7582039: [Extensions] Use dependency injection for ManifestHandlerRegistry Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7582039 Co-Authored-By: Claude (claude-3-5-sonnet, Anthropic) * 7582477: spanification: migrate base::ReadUnicodeCharacter usage to string_view Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7582477 Co-Authored-By: Claude (claude-3-5-sonnet, Anthropic) * chore: update patches (trivial only) Co-Authored-By: Claude (claude-3-5-sonnet, Anthropic) * 7590029: Remove 5 unused deprecated sync methods in ui::Clipboard Migrate clipboard API calls from synchronous methods to async callback-based methods with RunLoop pattern. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7590029 * 7599553: [rust png] Chromium: Update `png` to version `0.18.1`. https://chromium-review.googlesource.com/c/chromium/src/+/7599553 Chromium updated their to Rust PNG implementation which produces different (but valid) PNG output. Update tests to compare raw bitmap data instead of encoded PNG data URLs. * test: fixup clipboard tests to properly handle urls Needed after migrating clipboard API calls from synchronous methods to async callback-based methods with RunLoop pattern. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7590029 * fixup "7599553: [rust png] Chromium: Update `png` to version `0.18.1`." https://chromium-review.googlesource.com/c/chromium/src/+/7599553 Chromium updated their Rust PNG implementation which produces different (but valid) PNG data URLs. --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com>
25 lines
1.7 KiB
Diff
25 lines
1.7 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Andy Locascio <andy@slack-corp.com>
|
|
Date: Wed, 21 Aug 2019 12:09:10 -0700
|
|
Subject: fix: disabling compositor recycling
|
|
|
|
Compositor recycling is useful for Chrome because there can be many tabs and spinning up a compositor for each one would be costly. In practice, Chrome uses the parent compositor code path of browser_compositor_view_mac.mm; the NSView of each tab is detached when it's hidden and attached when it's shown. For Electron, there is no parent compositor, so we're forced into the "own compositor" code path, which seems to be non-optimal and pretty ruthless in terms of the release of resources. Electron has no real concept of multiple tabs per window, so it should be okay to disable this ruthless recycling altogether in Electron.
|
|
|
|
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
|
|
index d0ec6830b555bcaddd882d4b626bca7762ad0317..9b25f25f035792cdb9ab0a3c99254b48a6c497ad 100644
|
|
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
|
|
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
|
|
@@ -573,7 +573,11 @@
|
|
}
|
|
|
|
host()->WasHidden();
|
|
- browser_compositor_->SetRenderWidgetHostIsHidden(true);
|
|
+ // Consider the RWHV occluded only if it is not attached to a window
|
|
+ // (e.g. unattached BrowserView). Otherwise we treat it as visible to
|
|
+ // prevent unnecessary compositor recycling.
|
|
+ const bool unattached = ![GetInProcessNSView() window];
|
|
+ browser_compositor_->SetRenderWidgetHostIsHidden(unattached);
|
|
|
|
// Headless mode forces focus change propagation inside Focus(), since there
|
|
// is no NSWindow to deliver the normal focus change notifications. As a
|