mirror of
https://github.com/electron/electron.git
synced 2026-04-10 03:01:51 -04:00
9e7ef66ecb
* chore: bump chromium in DEPS to 144.0.7527.1 * chore: bump chromium in DEPS to 144.0.7529.1 * chore: bump chromium in DEPS to 144.0.7529.3 * chore: bump chromium in DEPS to 144.0.7529.5 * chore: bump chromium in DEPS to 144.0.7531.1 * chore: bump chromium in DEPS to 144.0.7531.0 * chore: bump chromium in DEPS to 144.0.7532.1 * chore: bump chromium in DEPS to 144.0.7535.1 * chore: bump chromium in DEPS to 144.0.7537.1 * chore: bump chromium in DEPS to 144.0.7539.1 * chore: bump chromium in DEPS to 144.0.7541.1 * chore: bump chromium in DEPS to 144.0.7543.1 * chore: bump chromium in DEPS to 144.0.7545.1 * chore: bump chromium in DEPS to 144.0.7547.1 * chore: bump chromium in DEPS to 144.0.7549.1 * chore: bump chromium in DEPS to 144.0.7551.0 * chore: bump chromium in DEPS to 144.0.7553.0 * chore: bump chromium in DEPS to 144.0.7555.1 * chore: bump chromium in DEPS to 144.0.7557.1 * chore: bump chromium in DEPS to 144.0.7559.1 * chore: bump chromium in DEPS to 144.0.7559.5 * chore: bump chromium in DEPS to 144.0.7559.3 * chore: bump chromium in DEPS to 144.0.7559.12 * chore: bump chromium in DEPS to 144.0.7559.20 * fix(patch-conflict): update code cache patch for PersistentCache refactor Upstream refactored code cache to use PersistentCache with new class-based implementation (NoopCodeCacheHost, LocalCodeCacheHost, CodeCacheWithPersistentCacheHost). Updated patch to integrate custom scheme support into the new structure while preserving ProcessLockURLIsCodeCacheScheme checks for embedder-registered schemes. Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7044986 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> (cherry picked from commit2b9d256e78) * fix(patch-conflict): update dialog patch for RequestXdgDesktopPortal API Upstream changed from SetSystemdScopeUnitNameForXdgPortal to RequestXdgDesktopPortal API pattern. Updated OnServiceStarted signature and kept OnSystemdUnitStarted callback that calls Electron's file_dialog::StartPortalAvailabilityTestInBackground(). Ref: https://chromium-review.googlesource.com/c/chromium/src/+/7204285 Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> (cherry picked from commit2cd3911d92) * chore: update patches * fix(build): update VideoPixelFormat API for SharedImageFormat Upstream CL https://chromium-review.googlesource.com/c/chromium/src/+/7207153 removed VideoPixelFormatToGfxBufferFormat as part of migration to SharedImageFormat. Update to use VideoPixelFormatToSharedImageFormat which directly returns the SharedImageFormat. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com> (cherry picked from commitff9d072b4b) * fix(build): extend profile methods patch for ShouldEnableXfaForms The ShouldEnableXfaForms function uses Profile::FromBrowserContext() which is not available in Electron. Wrap the profile-dependent code in #if 0 to fall through to the feature flag default. Co-Authored-By: Claude <noreply@anthropic.com> (cherry picked from commit3edec8ee30) * fix(build): add missing include `components/dbus/xdg/systemd.h` for `void OnSystemdUnitStarted(dbus_xdg::SystemdUnitStatus)` in the same patch. (cherry picked from commit6929589c0d) * fixup! fix(build): add missing include (cherry picked from commit39cd8f15c1) * chore: update libc++ filenames (cherry picked from commit6aa1ecc71d) * fix(build): adapt to string-view-ification change in windows jump_list.cc 7186922: Fix unsafe buffer usage in base/win/win_util.cc https://chromium-review.googlesource.com/c/chromium/src/+/7186922 (cherry picked from commit85ce0d45a3) * chore: bump chromium in DEPS to 144.0.7559.31 * Fix Crash in FullscreenController::EnterFullscreenModeInternal https://chromium-review.googlesource.com/c/chromium/src/+/7260934 * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com> Co-authored-by: Claude <svc-devxp-claude@slack-corp.com> Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: clavin <clavin@electronjs.org>
29 lines
1.5 KiB
Diff
29 lines
1.5 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Charles Kerr <charles@charleskerr.com>
|
|
Date: Sat, 28 Sep 2024 17:33:51 -0500
|
|
Subject: chore: partial revert of
|
|
https://chromium-review.googlesource.com/c/chromium/src/+/5894233
|
|
|
|
The `CHECK_EQ()` being removed here is failing in the Chromium roll.
|
|
I experimented with backporting the `CHECK_EQ()` to `main` and it's
|
|
failing there as well, so some pre-existing behavior in Electron is
|
|
incompatible with this assertion.
|
|
|
|
I will file an upgrades-followup-task issue in Electron and try to
|
|
track down the source of this problem & figure out if we can fix it
|
|
by changing something in Electron.
|
|
|
|
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
|
|
index 6c83415f1022ec0b14bdabfbff9614ca620d5d4f..442df34ab1f8f80afafbe249bc0359162b90e124 100644
|
|
--- a/content/browser/web_contents/web_contents_impl.cc
|
|
+++ b/content/browser/web_contents/web_contents_impl.cc
|
|
@@ -5297,7 +5297,7 @@ FrameTree* WebContentsImpl::CreateNewWindow(
|
|
: IsGuest();
|
|
// While some guest types do not have a guest SiteInstance, the ones that
|
|
// don't all override WebContents creation above.
|
|
- CHECK_EQ(source_site_instance->IsGuest(), is_guest);
|
|
+ // CHECK_EQ(source_site_instance->IsGuest(), is_guest);
|
|
|
|
// We usually create the new window in the same BrowsingInstance (group of
|
|
// script-related windows), by passing in the current SiteInstance. However,
|